)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"fa45ed552752a9f7b12119564c2be243810e2923","unresolved":false,"context_lines":[{"line_number":7,"context_line":"WIP: Create rescue user on ironic agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create a new service, that will be launched after ironic"},{"line_number":10,"context_line":"agent has been started. This will launch an script that will"},{"line_number":11,"context_line":"take the rescue password, and create the rescue user with"},{"line_number":12,"context_line":"that credentials."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f515b1d_a38ee224","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":22},"updated":"2017-09-22 10:46:37.000000000","message":"exited, having processed the rescue sequence.","commit_id":"671a3781ca9f2c96d80549bef976d44a47916e06"}],"diskimage_builder/elements/ironic-agent/static/etc/systemd/system/ironic-agent-create-rescue-user.service":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"fa45ed552752a9f7b12119564c2be243810e2923","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"After\u003dopenstack-ironic-python-agent.service"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[Service]"},{"line_number":5,"context_line":"ExecStart\u003d/usr/local/bin/ironic-python-agent-create-rescue-user.sh"},{"line_number":6,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7f515b1d_03c25686","line":3,"updated":"2017-09-22 10:46:37.000000000","message":"probably use:\n\n  AssertPathExists\u003d/etc/ipa-rescue-config/ipa-rescue-password","commit_id":"671a3781ca9f2c96d80549bef976d44a47916e06"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"fa45ed552752a9f7b12119564c2be243810e2923","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[Service]"},{"line_number":5,"context_line":"ExecStart\u003d/usr/local/bin/ironic-python-agent-create-rescue-user.sh"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Install]"},{"line_number":8,"context_line":"WantedBy\u003dmulti-user.target"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7f515b1d_2321d24e","line":6,"updated":"2017-09-22 10:46:37.000000000","message":"I guess best fit is the oneshot service type here:\n\n   Type\u003doneshot\n   RemainAfterExit\u003dyes\n\n[1] https://www.freedesktop.org/software/systemd/man/systemd.service.html","commit_id":"671a3781ca9f2c96d80549bef976d44a47916e06"}],"diskimage_builder/elements/ironic-agent/static/etc/usr/local/bin/ironic-python-agent-create-rescue-user.sh":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"fa45ed552752a9f7b12119564c2be243810e2923","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"if [ -f /etc/ipa-rescue-config/ipa-rescue-password ]; then"},{"line_number":3,"context_line":"    echo \"Adding rescue user with root privileges...\""},{"line_number":4,"context_line":"    crypted_pass\u003d$(\u003c/etc/ipa-rescue-config/ipa-rescue-password)"},{"line_number":5,"context_line":"    sudo useradd -m rescue -G sudo -p $crypted_pass"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f515b1d_63dc6a46","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":58},"updated":"2017-09-22 10:46:37.000000000","message":"maybe better handled through the assert path exists in the systemd unit spec","commit_id":"671a3781ca9f2c96d80549bef976d44a47916e06"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"3d7b90a167d9a81001bc5ee1a859f2a4d6b2ee39","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"echo \"Adding rescue user with root privileges...\""},{"line_number":3,"context_line":"crypted_pass\u003d$(\u003c/etc/ipa-rescue-config/ipa-rescue-password)"},{"line_number":4,"context_line":"sudo useradd -m rescue -G sudo -p $crypted_pass"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7f515b1d_de0414c9","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":11},"updated":"2017-09-22 13:08:33.000000000","message":"I\u0027d add the set -e directive just in case","commit_id":"db13c5d0685f658d2134eb2f4ef2cbbd4ae74a4b"}]}