)]}'
{"diskimage_builder/lib/common-functions":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"0aa442a3b5b47795a236300c5f6b1fe21f1f4eea","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        if [ $found_mountpoint \u003d\u003d false ]; then"},{"line_number":362,"context_line":"            # unmount the directory as it is not managed by block device"},{"line_number":363,"context_line":"            echo \"Unmount $m\""},{"line_number":364,"context_line":"            sudo umount -fl $m || true"},{"line_number":365,"context_line":"        fi"},{"line_number":366,"context_line":"    done"},{"line_number":367,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3f4b6375_8fca764b","side":"PARENT","line":364,"updated":"2017-10-24 06:22:48.000000000","message":"Do you think at this point the \u0027-l\u0027 should be removed?\nWhen I understand you correctly, using \u0027umount -l\u0027 is always a bad idea.","commit_id":"a0045985f2e2ca5f37b243d88832314e604be108"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"509153f924458a926bbb803513c7ef154d7b597e","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        return 0"},{"line_number":206,"context_line":"    fi"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    for umount_option in \"\" \"-f\" \"-fl\"; do"},{"line_number":209,"context_line":"        echo \"Umount [${mount_point}] with option [${umount_option}]\""},{"line_number":210,"context_line":"        if timeout 60 bash \u003c\u003cEOF; then"},{"line_number":211,"context_line":"failed_once\u003d0"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3f4b6375_947849c4","line":208,"updated":"2017-10-24 05:29:31.000000000","message":"I don\u0027t want lazy unmount in here.  on frequent builders like nodepool it can leave the system in an increasingly bad state that ends up with tens to hundreds of bad mounts (it\u0027s been seen)\n\ni don\u0027t mind the idea of wrapping it to dump info to help us debug the real issues however","commit_id":"13b078f8ec27d32e9d772915860149b14366ed0a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e46f41e515498a72fb3e323cad5db5bbd0d507c7","unresolved":false,"context_lines":[{"line_number":196,"context_line":"# This function returns 1 if the command \u0027mountpoint\u0027 does not"},{"line_number":197,"context_line":"# reliable work and lazy umount is needed."},{"line_number":198,"context_line":"# (This is currently only one function, because Ubuntu Trusty is"},{"line_number":199,"context_line":"#  the only distribution with problems: and it fails in both cases.)"},{"line_number":200,"context_line":"function host_check_for_broken_mountpoint_umount() {"},{"line_number":201,"context_line":"    type lsb_release || return 0"},{"line_number":202,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"df87a7cf_6d92dcf8","line":199,"updated":"2017-12-18 00:20:41.000000000","message":"i agree with this sentiment ... not sure what we\u0027re really fixing though.  if you have a trusty builder on a frequent schedule, you either leave mount points behind, or you leave mount points lazy-unmounted; is that really very different to just being left behind anyway?  either way, it seems over time it\u0027s going to cause problems.","commit_id":"2026da5b5b5000a4aeed6672ac45c64f12d6dd23"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e46f41e515498a72fb3e323cad5db5bbd0d507c7","unresolved":false,"context_lines":[{"line_number":218,"context_line":"# provide some debug information and retry."},{"line_number":219,"context_line":"# You might need to install lsof and fuser (psmisc)"},{"line_number":220,"context_line":"# to get detailed information."},{"line_number":221,"context_line":"function umount_safe() {"},{"line_number":222,"context_line":"    local mount_point\u003d\"$1\""},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    # Ubuntu Trusty\u0027s \u0027mountpoint\u0027 is broken: it is not able to detect"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"df87a7cf_2d95b4e4","line":221,"updated":"2017-12-18 00:20:41.000000000","message":"looking at the output of this [1] i think this could definitely do with the tracing culling we do around some of these looping utility functions; see kill_chroot_processes for an example.  that will reduce noise \n\n[1] http://logs.openstack.org/81/514081/12/check/dib-dsvm-functests-python2-ubuntu-trusty-extras/4b4ca57/job-output.txt.gz#_2017-12-10_09_57_22_929807","commit_id":"2026da5b5b5000a4aeed6672ac45c64f12d6dd23"}]}