)]}'
{"diskimage_builder/elements/zypper/bin/install-packages":[{"author":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"change_message_id":"233ce6cedcf5d07450d47e13f13944a6cd171688","unresolved":false,"context_lines":[{"line_number":20,"context_line":"set -eu"},{"line_number":21,"context_line":"set -o pipefail"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"EXTRA_ARGS\u003d\"--no-recommends\""},{"line_number":24,"context_line":"MAP_ELEMENT\u003d"},{"line_number":25,"context_line":"ACTION\u003dinstall"},{"line_number":26,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff82abbf_902a9229","line":23,"updated":"2017-11-27 22:06:33.000000000","message":"Refactoring to remove default values would include adding a new argument for setting the action to \u0027install\u0027 instead of implicitly installing listed packages, making similar changes to all the other \u0027install-packages\u0027 scripts for compatibility, and potentially breaking any downstream elements that call install-packages directly -- which I think is far beyond the scope of my original bug fix.","commit_id":"d672e5c570da1c91e4a569beceb961ee9daceb05"},{"author":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"change_message_id":"7ed1eb24759fe6d3497d0b34191ecdc043d2bf49","unresolved":false,"context_lines":[{"line_number":20,"context_line":"set -eu"},{"line_number":21,"context_line":"set -o pipefail"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"EXTRA_ARGS\u003d\"--no-recommends\""},{"line_number":24,"context_line":"MAP_ELEMENT\u003d"},{"line_number":25,"context_line":"ACTION\u003dinstall"},{"line_number":26,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1f485f77_657f39e0","line":23,"updated":"2017-11-16 18:34:09.000000000","message":"This was intentionally added, and serves a couple purposes. It reduces the final image sizes by 10s to 100s of megabytes, and also makes downstream element developers be more explicit about which packages they want installed (a best practice).","commit_id":"d672e5c570da1c91e4a569beceb961ee9daceb05"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5d276b25c13e685dc55eb21a397bb6a49dddce95","unresolved":false,"context_lines":[{"line_number":20,"context_line":"set -eu"},{"line_number":21,"context_line":"set -o pipefail"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"EXTRA_ARGS\u003d\"--no-recommends\""},{"line_number":24,"context_line":"MAP_ELEMENT\u003d"},{"line_number":25,"context_line":"ACTION\u003dinstall"},{"line_number":26,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1f485f77_ad7353e7","line":23,"updated":"2017-11-13 06:31:04.000000000","message":"why is this even set here?  can\u0027t we clean this up and remove it?","commit_id":"d672e5c570da1c91e4a569beceb961ee9daceb05"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d14a03d7dc8364f811cabf83688eeac7ab39fe18","unresolved":false,"context_lines":[{"line_number":20,"context_line":"set -eu"},{"line_number":21,"context_line":"set -o pipefail"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"EXTRA_ARGS\u003d\"--no-recommends\""},{"line_number":24,"context_line":"MAP_ELEMENT\u003d"},{"line_number":25,"context_line":"ACTION\u003dinstall"},{"line_number":26,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff82abbf_c5c1ec30","line":23,"in_reply_to":"1f485f77_657f39e0","updated":"2017-11-20 03:46:30.000000000","message":"Sorry, not so much the argument, but my point was more like Dirk\u0027s in that the logic here is rather tortured; setting a default value that then causes problems for other arguments unless it\u0027s overwritten.\n\nSeeing as you\u0027ve gone to the effort to parse all this, maybe refactor it into something a little easier to follow?","commit_id":"d672e5c570da1c91e4a569beceb961ee9daceb05"},{"author":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"change_message_id":"233ce6cedcf5d07450d47e13f13944a6cd171688","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    case \"$1\" in"},{"line_number":50,"context_line":"        -u) run_zypper dist-upgrade --no-recommends; exit 0;;"},{"line_number":51,"context_line":"        -e) ACTION\u003d\"remove\"; EXTRA_ARGS\u003d\"--clean-deps\"; shift;;"},{"line_number":52,"context_line":"        -d) EXTRA_ARGS\u003d\"--download-only\"; shift;;"},{"line_number":53,"context_line":"        -m) MAP_ELEMENT\u003d$2; shift 2;;"},{"line_number":54,"context_line":"        -h) show_options;;"},{"line_number":55,"context_line":"        --) shift; break ;;"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff82abbf_30238658","line":52,"updated":"2017-11-27 22:06:33.000000000","message":"I think that any time we change the action, also changing the EXTRA_ARGS is reasonable. But I think that \u0027-d\u0027 should be additive rather than overwrite the value.","commit_id":"d672e5c570da1c91e4a569beceb961ee9daceb05"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"5dabc04dfa45b7bf706fabe27e5e04b6a0ef4b39","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    case \"$1\" in"},{"line_number":50,"context_line":"        -u) run_zypper dist-upgrade --no-recommends; exit 0;;"},{"line_number":51,"context_line":"        -e) ACTION\u003d\"remove\"; EXTRA_ARGS\u003d\"--clean-deps\"; shift;;"},{"line_number":52,"context_line":"        -d) EXTRA_ARGS\u003d\"--download-only\"; shift;;"},{"line_number":53,"context_line":"        -m) MAP_ELEMENT\u003d$2; shift 2;;"},{"line_number":54,"context_line":"        -h) show_options;;"},{"line_number":55,"context_line":"        --) shift; break ;;"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1f485f77_9d0cc5ec","line":52,"updated":"2017-11-16 21:27:04.000000000","message":"sort of weird to have  -e and -d overwrite EXTRA_ARGS . they\u0027re usually mutual exclusive so it hopefully isn\u0027t a real problem.","commit_id":"d672e5c570da1c91e4a569beceb961ee9daceb05"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"594a59e193559e20101625cfdff3c69e580d31d8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"set -o pipefail"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"MAP_ELEMENT\u003d"},{"line_number":24,"context_line":"ACTION\u003dinstall"},{"line_number":25,"context_line":"ACTION_ARGS\u003d\"--no-recommends\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"SCRIPTNAME\u003d$(basename $0)"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ff82abbf_1cdc58e2","line":24,"updated":"2017-11-28 04:45:51.000000000","message":"comments like \"this is the default action and arguments when no options are set; see the getopts for various overrides\" make things instantly clear, for mine","commit_id":"456510fd1d9b49fb659faba9fbd0261e296df963"}]}