)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"304fd65741bb5fd875ded1e2919663a3d0109c19","unresolved":false,"context_lines":[{"line_number":18,"context_line":"configuration-munging) configuration being used."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Because we\u0027re getting the values from the state, we need to move the"},{"line_number":21,"context_line":"exports after the \"dib-block-device create\" call.  This is OK, because"},{"line_number":22,"context_line":"the values are intended for the bootloader elements which run after"},{"line_number":23,"context_line":"this.  We move the SuSE mkinitrd into the finalise.d stage, from"},{"line_number":24,"context_line":"post-install.d (where is should actually be in the correct file-system"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f93b717_d304f84c","line":21,"updated":"2018-01-29 03:17:02.000000000","message":"mea culpa, this is just wrong wrong wrong ... although it took me Ic86177015c5c22f32e2d0c598eed28ad891dc218 to really understand the details here.  let me restore the old work","commit_id":"0e6e6e8d7c5ec400c8e77c4a16312ba4b04b8e39"}],"diskimage_builder/block_device/blockdevice.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2ed19e13f0407194c1566ef3051e6a11b70934c7","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            fs_type \u003d root_fs[\u0027type\u0027]"},{"line_number":291,"context_line":"            if fs_type \u003d\u003d \"xfs\":"},{"line_number":292,"context_line":"                if len(fs_label) \u003e 12:"},{"line_number":293,"context_line":"                    # mirror block_device/level2/mkfs.py#n63"},{"line_number":294,"context_line":"                    # FilesystemNode.__init__"},{"line_number":295,"context_line":"                    if fs_label \u003d\u003d \"cloudimg-rootfs\":"},{"line_number":296,"context_line":"                        fs_label \u003d \"img-rootfs\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_e4962095","line":293,"updated":"2018-01-23 04:02:34.000000000","message":"This feels really hacky, duplicating this here for one file-system.\n\nI think what this highlights is that \"root-label\" isn\u0027t actually available as a thing until after the block-device elements have run, because they can modify it.\n\nThus I\u0027d like to see this moved below ...","commit_id":"c872b07695bcd032512f53f1ed2f50da85152019"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2ed19e13f0407194c1566ef3051e6a11b70934c7","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        # dictionary.  They can only be accessed after the state has"},{"line_number":320,"context_line":"        # been dumped; i.e. after cmd_create() called."},{"line_number":321,"context_line":"        state \u003d BlockDeviceState(self.state_json_file_name)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        # The path to the .raw file for conversion"},{"line_number":324,"context_line":"        if symbol \u003d\u003d \u0027image-path\u0027:"},{"line_number":325,"context_line":"            print(\"%s\" % state[\u0027blockdev\u0027][\u0027image0\u0027][\u0027image\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_64e8d015","line":322,"updated":"2018-01-23 04:02:34.000000000","message":"... to in here, and pull the actual value out of the state dictionary.\n\nthis should be ok, because this value is only used after \"dib-block-device create\" is called in the code.","commit_id":"c872b07695bcd032512f53f1ed2f50da85152019"}]}