)]}'
{"diskimage_builder/block_device/level1/partition.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2e475f317a4d10ad92a9002ea30248e789c95c37","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        if self.partitioning.label \u003d\u003d \u0027gpt\u0027:"},{"line_number":38,"context_line":"            if \u0027flags\u0027 in config and \u0027primary\u0027 in config[\u0027flags\u0027]:"},{"line_number":39,"context_line":"                raise BlockDeviceSetupException("},{"line_number":40,"context_line":"                    \"Primary flag not supported for GPT partitions\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.flags \u003d set()"},{"line_number":43,"context_line":"        if \u0027flags\u0027 in config:"}],"source_content_type":"text/x-python","patch_set":13,"id":"7f96bb07_02777f3c","line":40,"updated":"2018-01-23 03:22:23.000000000","message":"Q: does the bootable flag really mean anything for GPT either?","commit_id":"da5974e776c00a3884e04fc93df99d8f59ac1dcc"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"91a9000d4844ebbd2b9b972442719bb906bf3b55","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        if self.partitioning.label \u003d\u003d \u0027gpt\u0027:"},{"line_number":38,"context_line":"            if \u0027flags\u0027 in config and \u0027primary\u0027 in config[\u0027flags\u0027]:"},{"line_number":39,"context_line":"                raise BlockDeviceSetupException("},{"line_number":40,"context_line":"                    \"Primary flag not supported for GPT partitions\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.flags \u003d set()"},{"line_number":43,"context_line":"        if \u0027flags\u0027 in config:"}],"source_content_type":"text/x-python","patch_set":13,"id":"7f96bb07_2d7dcb6d","line":40,"in_reply_to":"7f96bb07_02777f3c","updated":"2018-01-23 06:35:38.000000000","message":"In normal situation there are no flags in GPT. They is support for flags but only ChromeOS uses few own ones.\n\nBootloaders have own partition types so firmware knows where to look.","commit_id":"da5974e776c00a3884e04fc93df99d8f59ac1dcc"}],"diskimage_builder/block_device/level1/partitioning.py":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"1a758556ff6d257e7484ab01bd51309b3275c3c9","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            args[\u0027name\u0027] \u003d \u0027name %s \"%s\"\u0027 % (pnum, p.get_name())"},{"line_number":140,"context_line":"            args[\u0027boot\u0027] \u003d \u0027set %s boot on\u0027 % pnum \\"},{"line_number":141,"context_line":"                           if PartitionNode.flag_boot in p.get_flags() else \u0027\u0027"},{"line_number":142,"context_line":"            # for GPT, I think everything is just \"primary\", so we"},{"line_number":143,"context_line":"            # don\u0027t use this"},{"line_number":144,"context_line":"            args[\u0027type\u0027] \u003d p.get_type()"},{"line_number":145,"context_line":"            # convert from a relative/string size to bytes"},{"line_number":146,"context_line":"            size \u003d parse_rel_size_spec(p.get_size(), disk_free)[1]"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_03c3a239","line":143,"range":{"start_line":142,"start_character":10,"end_line":143,"end_character":28},"updated":"2018-01-17 08:26:33.000000000","message":"There is no such thing as primary/extended in GPT.","commit_id":"035f9c1de5b47180117ac0c935bfd53c25dc164c"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"0d6f8980fb7bcc37cb920109f1ffbec6cb1f14e5","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        #   ... fs-type is optional."},{"line_number":143,"context_line":"        for p in self.partitions:"},{"line_number":144,"context_line":"            args \u003d {}"},{"line_number":145,"context_line":"            args[\u0027name\u0027] \u003d \u0027\"%s\"\u0027 % p.get_name()"},{"line_number":146,"context_line":"            args[\u0027boot\u0027] \u003d \u0027set %s boot on\u0027 % pnum \\"},{"line_number":147,"context_line":"                           if PartitionNode.flag_boot in p.get_flags() else \u0027\u0027"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7f96bb07_eae14c2c","line":145,"updated":"2018-01-19 16:56:23.000000000","message":"I imagine there are some restrictions on what name can be here, I wonder if we should break this out another config option (efi-name rather than name)? If we dont, we should make sure to document that the name property will be used for this / has $restrictions.","commit_id":"1fd70497e080e5ece532cd97c7d981cbe024a20b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2e475f317a4d10ad92a9002ea30248e789c95c37","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # pad out the first 2mb before starting partitions, this seems"},{"line_number":132,"context_line":"        # standard"},{"line_number":133,"context_line":"        disk_free \u003d self.disk_size - (2048 * 1024)"},{"line_number":134,"context_line":"        pnum \u003d 1"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        for p in self.partitions:"}],"source_content_type":"text/x-python","patch_set":13,"id":"7f96bb07_e2913348","line":133,"updated":"2018-01-23 03:22:23.000000000","message":"Q: is is still necessary to pad like this with sgdisk?","commit_id":"da5974e776c00a3884e04fc93df99d8f59ac1dcc"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"91a9000d4844ebbd2b9b972442719bb906bf3b55","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # pad out the first 2mb before starting partitions, this seems"},{"line_number":132,"context_line":"        # standard"},{"line_number":133,"context_line":"        disk_free \u003d self.disk_size - (2048 * 1024)"},{"line_number":134,"context_line":"        pnum \u003d 1"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        for p in self.partitions:"}],"source_content_type":"text/x-python","patch_set":13,"id":"7f96bb07_ade55b3a","line":133,"in_reply_to":"7f96bb07_e2913348","updated":"2018-01-23 06:35:38.000000000","message":"Never seen such padding before.\n\n4MB padding is used for images which end on SD cards due to SD card controllers (those in SD card) using 4MB eraseblocks. But for VM/HDD/SSD I never saw such.","commit_id":"da5974e776c00a3884e04fc93df99d8f59ac1dcc"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"cfc1bc3e5b3d5bf93221ca87424a35bf34ce0321","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # pad out the first 2mb before starting partitions, this seems"},{"line_number":132,"context_line":"        # standard"},{"line_number":133,"context_line":"        disk_free \u003d self.disk_size - (2048 * 1024)"},{"line_number":134,"context_line":"        pnum \u003d 1"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        for p in self.partitions:"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f96bb07_45c4875f","line":133,"updated":"2018-01-24 04:48:51.000000000","message":"i say let\u0027s remove this as it doesn\u0027t seem necessary.  i think it crept in when i was testing with gparted and specifying \"0\" for a partition, and it tried to put it right at the start of the disk","commit_id":"5c9b90f45b28bb1acdaaa4a9ea5c67174288a660"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"14c545126224cbe29a4bfd1ee3b6d2f7f4b2abaf","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # pad out the first 2mb before starting partitions, this seems"},{"line_number":132,"context_line":"        # standard"},{"line_number":133,"context_line":"        disk_free \u003d self.disk_size - (2048 * 1024)"},{"line_number":134,"context_line":"        pnum \u003d 1"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        for p in self.partitions:"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f93b717_34b55332","line":133,"in_reply_to":"7f96bb07_45c4875f","updated":"2018-01-25 07:07:45.000000000","message":"after trying that it fails, i think rounding errors creep in\n\n[1] http://logs.openstack.org/90/533490/17/check/dib-dsvm-functests-python3/c945167/job-output.txt.gz#_2018-01-25_05_10_51_270500","commit_id":"5c9b90f45b28bb1acdaaa4a9ea5c67174288a660"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"3b42f7a79167e0310f6b3413958a7ac7ba076353","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    def _create_gpt(self):"},{"line_number":127,"context_line":"        \"\"\"Create partitions with GPT\"\"\""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        cmd \u003d [\u0027sgdisk\u0027, self.image_path]"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # This padding gives us a little room for rounding so we don\u0027t"},{"line_number":132,"context_line":"        # go over the end of the disk"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f93b717_5aa8c68b","line":129,"updated":"2018-01-30 20:40:00.000000000","message":"I\u0027m very happy that you found an alternative to \u0027parted\u0027.","commit_id":"49b8510ef5db454da141125edaefe45debae2498"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c94d2bef30e2b6c6b9bdf561ced2e68b215c601c","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    def _create_gpt(self):"},{"line_number":127,"context_line":"        \"\"\"Create partitions with GPT\"\"\""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        cmd \u003d [\u0027sgdisk\u0027, self.image_path]"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # This padding gives us a little room for rounding so we don\u0027t"},{"line_number":132,"context_line":"        # go over the end of the disk"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f93b717_98b3b64d","line":129,"in_reply_to":"5f93b717_5aa8c68b","updated":"2018-01-30 21:30:45.000000000","message":"Thanks. Imho \u0027parted\u0027 is old tool for MBR systems which got loosely adapted to work with GPT. While \u0027sgdisk\u0027 was written for it.","commit_id":"49b8510ef5db454da141125edaefe45debae2498"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"3b42f7a79167e0310f6b3413958a7ac7ba076353","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # This padding gives us a little room for rounding so we don\u0027t"},{"line_number":132,"context_line":"        # go over the end of the disk"},{"line_number":133,"context_line":"        disk_free \u003d self.disk_size - (2048 * 1024)"},{"line_number":134,"context_line":"        pnum \u003d 1"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        for p in self.partitions:"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f93b717_fa8192fc","line":133,"updated":"2018-01-30 20:40:00.000000000","message":"This smells like: I don\u0027t really know the correct numbers - so I hope that using this buffer let\u0027s stay me save.\n\nOr (with other words): why exactly these \u0027magical\u0027 numbers? Are these an upper limit for something? (If so a comment might be good.)","commit_id":"49b8510ef5db454da141125edaefe45debae2498"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"7158589a8b79dbff5fb7abd5875cbd52d95fcd3c","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # This padding gives us a little room for rounding so we don\u0027t"},{"line_number":132,"context_line":"        # go over the end of the disk"},{"line_number":133,"context_line":"        disk_free \u003d self.disk_size - (2048 * 1024)"},{"line_number":134,"context_line":"        pnum \u003d 1"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        for p in self.partitions:"}],"source_content_type":"text/x-python","patch_set":19,"id":"3fa0c359_ca3f98d4","line":133,"in_reply_to":"5f93b717_da492db7","updated":"2018-02-06 05:43:21.000000000","message":"Are you sure that the rounding error is always less than the given size?\n\nIf all tools do the calculation in the same way I\u0027d agree.  What I do not like is if you pass the same sizes to different tools and get different results.  This is why I\u0027d prefer doing this as an abstraction layer in DIB itself (exchanging a tool would not change the outcome).","commit_id":"49b8510ef5db454da141125edaefe45debae2498"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c5fc3c87f31c443bbe84e007b53b810cbbc2ee70","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # This padding gives us a little room for rounding so we don\u0027t"},{"line_number":132,"context_line":"        # go over the end of the disk"},{"line_number":133,"context_line":"        disk_free \u003d self.disk_size - (2048 * 1024)"},{"line_number":134,"context_line":"        pnum \u003d 1"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        for p in self.partitions:"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f93b717_da492db7","line":133,"in_reply_to":"5f93b717_fa8192fc","updated":"2018-01-31 04:10:43.000000000","message":"perhaps an element of this; but the existing functions are calculating in bytes, then we // 1024*1024 to give to sgpart in more reasonable megabytes, and with odd sizes from the image build and % calculations we seem to introduce rounding errors; as the comment says.\n\nhonestly, i\u0027d prefer to just pass through the size directions to the tool directly.  i\u0027m not sure why we have to re-implement it when sgparted knows how to calculate %\u0027s etc.","commit_id":"49b8510ef5db454da141125edaefe45debae2498"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"3b42f7a79167e0310f6b3413958a7ac7ba076353","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            # We keep track in bytes, but specify things to sgdisk in"},{"line_number":146,"context_line":"            # megabytes so it can align on sensible boundaries. And"},{"line_number":147,"context_line":"            # create partitions right after previous so no need to"},{"line_number":148,"context_line":"            # calculate start/end - just size."},{"line_number":149,"context_line":"            assert size \u003c\u003d disk_free"},{"line_number":150,"context_line":"            args[\u0027size\u0027] \u003d size // (1024 * 1024)"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5f93b717_bafb0a77","line":148,"updated":"2018-01-30 20:40:00.000000000","message":"What I learned from other tools: Never let these tools do the alignment!  They don\u0027t do it in a way you really want.  The alignment function (which is a one-liner) is already available in the mbr module.\n\nDid you check how the sgdisk tool behaves here?","commit_id":"49b8510ef5db454da141125edaefe45debae2498"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c5fc3c87f31c443bbe84e007b53b810cbbc2ee70","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            # We keep track in bytes, but specify things to sgdisk in"},{"line_number":146,"context_line":"            # megabytes so it can align on sensible boundaries. And"},{"line_number":147,"context_line":"            # create partitions right after previous so no need to"},{"line_number":148,"context_line":"            # calculate start/end - just size."},{"line_number":149,"context_line":"            assert size \u003c\u003d disk_free"},{"line_number":150,"context_line":"            args[\u0027size\u0027] \u003d size // (1024 * 1024)"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5f93b717_9acde532","line":148,"in_reply_to":"5f93b717_58a20eff","updated":"2018-01-31 04:10:43.000000000","message":"also i remain unconvinced we can do a better job than a widely used tool made for the job of partitioning","commit_id":"49b8510ef5db454da141125edaefe45debae2498"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"7158589a8b79dbff5fb7abd5875cbd52d95fcd3c","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            # We keep track in bytes, but specify things to sgdisk in"},{"line_number":146,"context_line":"            # megabytes so it can align on sensible boundaries. And"},{"line_number":147,"context_line":"            # create partitions right after previous so no need to"},{"line_number":148,"context_line":"            # calculate start/end - just size."},{"line_number":149,"context_line":"            assert size \u003c\u003d disk_free"},{"line_number":150,"context_line":"            args[\u0027size\u0027] \u003d size // (1024 * 1024)"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3fa0c359_ea193488","line":148,"in_reply_to":"5f93b717_9acde532","updated":"2018-02-06 05:43:21.000000000","message":"After a closer look into parted (which is IMHO wider used than gdisk) I\u0027d not see that as an argument.","commit_id":"49b8510ef5db454da141125edaefe45debae2498"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c94d2bef30e2b6c6b9bdf561ced2e68b215c601c","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            # We keep track in bytes, but specify things to sgdisk in"},{"line_number":146,"context_line":"            # megabytes so it can align on sensible boundaries. And"},{"line_number":147,"context_line":"            # create partitions right after previous so no need to"},{"line_number":148,"context_line":"            # calculate start/end - just size."},{"line_number":149,"context_line":"            assert size \u003c\u003d disk_free"},{"line_number":150,"context_line":"            args[\u0027size\u0027] \u003d size // (1024 * 1024)"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5f93b717_58a20eff","line":148,"in_reply_to":"5f93b717_bafb0a77","updated":"2018-01-30 21:30:45.000000000","message":"Why people are so obsessed with alignment? GPT is pure LBA - partitions start at sector X, end at Y so next partition starts at Y+1 etc.\n\nThere is no need to calculate where they start/end as long as you do not have a need for \"holes in disk\".","commit_id":"49b8510ef5db454da141125edaefe45debae2498"}],"diskimage_builder/elements/block-device-gpt/README.rst":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"0d6f8980fb7bcc37cb920109f1ffbec6cb1f14e5","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This is an override for the ``vm`` element to get a GPT partitioned"},{"line_number":6,"context_line":"disk, rather than the default MBR.  Placing it before the ``vm``"},{"line_number":7,"context_line":"element in the element will override the default block-device"},{"line_number":8,"context_line":"configuration provided there."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f96bb07_aa9ee4b5","line":7,"updated":"2018-01-19 16:56:23.000000000","message":"I dont quite grok this, did you mean to say - \u0027placing it before the vm element in the element list\u0027.","commit_id":"1fd70497e080e5ece532cd97c7d981cbe024a20b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f216a037d26e0913f9e53250fb534e0b56f26186","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This is an override for the ``vm`` element to get a GPT partitioned"},{"line_number":6,"context_line":"disk, rather than the default MBR.  Placing it before the ``vm``"},{"line_number":7,"context_line":"element in the element will override the default block-device"},{"line_number":8,"context_line":"configuration provided there."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f96bb07_a9a33a00","line":7,"in_reply_to":"7f96bb07_aa9ee4b5","updated":"2018-01-21 23:42:36.000000000","message":"It\u0027s badly worded, and not really an override for the whole element.\n\nThe way the block-device stuff works is that it walks the included elements and picks the first block-device YAML file it sees.  So this overrides the default block-device configuration provided in the vm element since it\u0027s found first.\n\nWhat I\u0027ve realised is that i\u0027m not sure we guarantee ordering at all; in fact dib-lint checks the element-deps is in alphabetical order which implies the user can\u0027t say anything other than \"these elements before me, but in any order\".  I\u0027m not sure I want to tackle all this before this patch ... but it\u0027s something to think about.\n\nI\u0027ll re-word this.","commit_id":"1fd70497e080e5ece532cd97c7d981cbe024a20b"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"c53989573ae9fc27c3c865d55f24e166a413755c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Block Device GPT"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This is an override for the ``vm`` element to get a GPT partitioned"},{"line_number":6,"context_line":"disk, rather than the default MBR.  Placing it before the ``vm``"},{"line_number":7,"context_line":"element in the element will override the default block-device"},{"line_number":8,"context_line":"configuration provided there."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f96bb07_a44dc6c5","line":8,"range":{"start_line":5,"start_character":0,"end_line":8,"end_character":29},"updated":"2018-01-19 09:28:02.000000000","message":"Why just merge gpt into \u0027vm\u0027 rather than create an new \u0027block-device-gpt\u0027 element?","commit_id":"1fd70497e080e5ece532cd97c7d981cbe024a20b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f216a037d26e0913f9e53250fb534e0b56f26186","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Block Device GPT"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This is an override for the ``vm`` element to get a GPT partitioned"},{"line_number":6,"context_line":"disk, rather than the default MBR.  Placing it before the ``vm``"},{"line_number":7,"context_line":"element in the element will override the default block-device"},{"line_number":8,"context_line":"configuration provided there."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f96bb07_49b4f635","line":8,"range":{"start_line":5,"start_character":0,"end_line":8,"end_character":29},"in_reply_to":"7f96bb07_6aa8dcda","updated":"2018-01-21 23:42:36.000000000","message":"yes, this was kind of the idea to avoid adding \"yet another flag\".  We could do \"DIB_BLOCK_DEVICE_DEFAULT_PARTITION\u003d[mbr|gpt]\" or something and put branches in, but it\u0027s hard to discover and hard to test.","commit_id":"1fd70497e080e5ece532cd97c7d981cbe024a20b"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"0d6f8980fb7bcc37cb920109f1ffbec6cb1f14e5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Block Device GPT"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This is an override for the ``vm`` element to get a GPT partitioned"},{"line_number":6,"context_line":"disk, rather than the default MBR.  Placing it before the ``vm``"},{"line_number":7,"context_line":"element in the element will override the default block-device"},{"line_number":8,"context_line":"configuration provided there."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f96bb07_6aa8dcda","line":8,"range":{"start_line":5,"start_character":0,"end_line":8,"end_character":29},"in_reply_to":"7f96bb07_a44dc6c5","updated":"2018-01-19 16:56:23.000000000","message":"I think this is much nicer broken out - if it was part of vm we\u0027d have to build machinery other than element arguments for users to select gpt or no gpt.","commit_id":"1fd70497e080e5ece532cd97c7d981cbe024a20b"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"3b42f7a79167e0310f6b3413958a7ac7ba076353","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This is an override for the default block-device configuration"},{"line_number":6,"context_line":"provided in the ``vm`` element to get a GPT based single-partition"},{"line_number":7,"context_line":"disk, rather than the default MBR."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Note this provides the extra `BIOS boot partition"},{"line_number":10,"context_line":"\u003chttps://en.wikipedia.org/wiki/BIOS_boot_partition\u003e`__ as required for"}],"source_content_type":"text/x-rst","patch_set":19,"id":"5f93b717_fa80b2c1","line":7,"updated":"2018-01-30 20:40:00.000000000","message":"I did not really understand this:\ndoes this mean, you have to specify the \u0027block-device-gpt\u0027 element before / after the vm element to overwrite this? (IMHO there is no order in the elements?)\n\nTherefore I\u0027m missing a kind of \u0027how to use this element\u0027?","commit_id":"49b8510ef5db454da141125edaefe45debae2498"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c5fc3c87f31c443bbe84e007b53b810cbbc2ee70","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This is an override for the default block-device configuration"},{"line_number":6,"context_line":"provided in the ``vm`` element to get a GPT based single-partition"},{"line_number":7,"context_line":"disk, rather than the default MBR."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Note this provides the extra `BIOS boot partition"},{"line_number":10,"context_line":"\u003chttps://en.wikipedia.org/wiki/BIOS_boot_partition\u003e`__ as required for"}],"source_content_type":"text/x-rst","patch_set":19,"id":"5f93b717_fadbc9e9","line":7,"in_reply_to":"5f93b717_fa80b2c1","updated":"2018-01-31 04:10:43.000000000","message":"i believe the direction becomes more clear with \n\nhttps://review.openstack.org/539375\n\nhowever this works as is in the functional test for this change.","commit_id":"49b8510ef5db454da141125edaefe45debae2498"}],"diskimage_builder/elements/block-device-gpt/block-device-default.yaml":[{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"c53989573ae9fc27c3c865d55f24e166a413755c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Default single partition loopback using a GPT based partition table"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- local_loop:"},{"line_number":4,"context_line":"    name: image0"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f96bb07_44ede289","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":69},"updated":"2018-01-19 09:28:02.000000000","message":"To make efi work, we need one vfat partion for contain /EFI/BOOT/","commit_id":"1fd70497e080e5ece532cd97c7d981cbe024a20b"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"0d6f8980fb7bcc37cb920109f1ffbec6cb1f14e5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Default single partition loopback using a GPT based partition table"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- local_loop:"},{"line_number":4,"context_line":"    name: image0"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f96bb07_ea170c45","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":69},"in_reply_to":"7f96bb07_44ede289","updated":"2018-01-19 16:56:23.000000000","message":"The EFI bits should probably be decoupled from GPT - its perfectly reasonable to make an mbr disk with GPT for things like large disk support. It does seem like we should have an easy way for a user to select efi though, such as an efi element...","commit_id":"1fd70497e080e5ece532cd97c7d981cbe024a20b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f216a037d26e0913f9e53250fb534e0b56f26186","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Default single partition loopback using a GPT based partition table"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- local_loop:"},{"line_number":4,"context_line":"    name: image0"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f96bb07_e982a252","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":69},"in_reply_to":"7f96bb07_ea170c45","updated":"2018-01-21 23:42:36.000000000","message":"As stated, this is definitely just supposed to be the default single partition with a GPT table rather than MBR.  EFI we can deal with as part of bootloader changes to support it.\n\nThe unit test I added, however, does add the vfat partition to ensure that side is possible","commit_id":"1fd70497e080e5ece532cd97c7d981cbe024a20b"}],"doc/source/user_guide/building_an_image.rst":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"3b42f7a79167e0310f6b3413958a7ac7ba076353","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"   For GPT the default value is \u00278300\u0027 (Linux Default partition). Any valid two"},{"line_number":339,"context_line":"   byte hexadecimal value may be specified here. Due to ``sgdisk`` leading \u00270x\u0027"},{"line_number":340,"context_line":"   should not be used."},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"Example:"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"5f93b717_dad936f3","line":340,"updated":"2018-01-30 20:40:00.000000000","message":"This looks strange to me: you expect a two byte hexadecimal value - and the default is \u00278300\u0027?","commit_id":"49b8510ef5db454da141125edaefe45debae2498"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"7158589a8b79dbff5fb7abd5875cbd52d95fcd3c","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"   For GPT the default value is \u00278300\u0027 (Linux Default partition). Any valid two"},{"line_number":339,"context_line":"   byte hexadecimal value may be specified here. Due to ``sgdisk`` leading \u00270x\u0027"},{"line_number":340,"context_line":"   should not be used."},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"Example:"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3fa0c359_4aa8681e","line":340,"in_reply_to":"5f93b717_9af64563","updated":"2018-02-06 05:43:21.000000000","message":"Huups - missed this.","commit_id":"49b8510ef5db454da141125edaefe45debae2498"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c94d2bef30e2b6c6b9bdf561ced2e68b215c601c","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"   For GPT the default value is \u00278300\u0027 (Linux Default partition). Any valid two"},{"line_number":339,"context_line":"   byte hexadecimal value may be specified here. Due to ``sgdisk`` leading \u00270x\u0027"},{"line_number":340,"context_line":"   should not be used."},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"Example:"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"5f93b717_38eb8213","line":340,"in_reply_to":"5f93b717_dad936f3","updated":"2018-01-30 21:30:45.000000000","message":"\u00278300\u0027 hex is \"Linux filesystem\" partition type. Just like \u002783\u0027 in MBR.","commit_id":"49b8510ef5db454da141125edaefe45debae2498"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c5fc3c87f31c443bbe84e007b53b810cbbc2ee70","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"   For GPT the default value is \u00278300\u0027 (Linux Default partition). Any valid two"},{"line_number":339,"context_line":"   byte hexadecimal value may be specified here. Due to ``sgdisk`` leading \u00270x\u0027"},{"line_number":340,"context_line":"   should not be used."},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"Example:"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"5f93b717_9af64563","line":340,"in_reply_to":"5f93b717_dad936f3","updated":"2018-01-31 04:10:43.000000000","message":"i don\u0027t see the issue here?  8300 \u003d\u003d 2 bytes","commit_id":"49b8510ef5db454da141125edaefe45debae2498"}],"releasenotes/notes/bootloader-gpt-d1047f81f3a0631b.yaml":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"3b42f7a79167e0310f6b3413958a7ac7ba076353","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    GPT support is added to the bootloader; see documentation for"},{"line_number":5,"context_line":"    configuration examples.  This should be considered a technology"},{"line_number":6,"context_line":"    preview; there may be minor behaviour modifications as we enable"},{"line_number":7,"context_line":"    UEFI and support across more architectures."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5f93b717_fa9c320f","line":4,"updated":"2018-01-30 20:40:00.000000000","message":"IMHO \u0027bootloader\u0027 was not touched - or do I miss something?","commit_id":"49b8510ef5db454da141125edaefe45debae2498"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c94d2bef30e2b6c6b9bdf561ced2e68b215c601c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    GPT support is added to the bootloader; see documentation for"},{"line_number":5,"context_line":"    configuration examples.  This should be considered a technology"},{"line_number":6,"context_line":"    preview; there may be minor behaviour modifications as we enable"},{"line_number":7,"context_line":"    UEFI and support across more architectures."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5f93b717_d8db7e79","line":4,"in_reply_to":"5f93b717_fa9c320f","updated":"2018-01-30 21:30:45.000000000","message":"https://review.openstack.org/#/c/536600 covers bootloader part.","commit_id":"49b8510ef5db454da141125edaefe45debae2498"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c5fc3c87f31c443bbe84e007b53b810cbbc2ee70","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    GPT support is added to the bootloader; see documentation for"},{"line_number":5,"context_line":"    configuration examples.  This should be considered a technology"},{"line_number":6,"context_line":"    preview; there may be minor behaviour modifications as we enable"},{"line_number":7,"context_line":"    UEFI and support across more architectures."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5f93b717_bae1c19d","line":4,"in_reply_to":"5f93b717_fa9c320f","updated":"2018-01-31 04:10:43.000000000","message":"this is a typo, thanks","commit_id":"49b8510ef5db454da141125edaefe45debae2498"}]}