)]}'
{"diskimage_builder/block_device/level3/mount.py":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"8ec964f84230fbac3e0d78fb9a3086203f9527b8","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        # this behaviour."},{"line_number":107,"context_line":"        # https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg02978.html"},{"line_number":108,"context_line":"        exec_sudo([\"sync\"])"},{"line_number":109,"context_line":"        if self.state[\u0027filesys\u0027][self.base][\u0027fstype\u0027] !\u003d \u0027vfat\u0027:"},{"line_number":110,"context_line":"            exec_sudo([\"fstrim\", \"--verbose\","},{"line_number":111,"context_line":"                       self.state[\u0027mount\u0027][self.mount_point][\u0027path\u0027]])"},{"line_number":112,"context_line":"        exec_sudo([\"umount\", self.state[\u0027mount\u0027][self.mount_point][\u0027path\u0027]])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_d06550b6","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":64},"updated":"2018-01-18 12:03:25.000000000","message":"That check looks like \"we should have \u0027fstype\u0027 in local class but somehow forgot to add it.\n\nWorks anyway.","commit_id":"ab3333eb2c083b778ed24365659cae535e52fe3f"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"3ad9f16233a6a61da688e219b6f7a0b0eb49c101","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        # this behaviour."},{"line_number":107,"context_line":"        # https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg02978.html"},{"line_number":108,"context_line":"        exec_sudo([\"sync\"])"},{"line_number":109,"context_line":"        if self.state[\u0027filesys\u0027][self.base][\u0027fstype\u0027] !\u003d \u0027vfat\u0027:"},{"line_number":110,"context_line":"            exec_sudo([\"fstrim\", \"--verbose\","},{"line_number":111,"context_line":"                       self.state[\u0027mount\u0027][self.mount_point][\u0027path\u0027]])"},{"line_number":112,"context_line":"        exec_sudo([\"umount\", self.state[\u0027mount\u0027][self.mount_point][\u0027path\u0027]])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_0a4e2737","line":109,"updated":"2018-01-18 10:44:11.000000000","message":"fstrim -av - just trims on all supported fs","commit_id":"ab3333eb2c083b778ed24365659cae535e52fe3f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0e8696d1954a4be216098cfd3a4d9f924dd23e22","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        # this behaviour."},{"line_number":107,"context_line":"        # https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg02978.html"},{"line_number":108,"context_line":"        exec_sudo([\"sync\"])"},{"line_number":109,"context_line":"        if self.state[\u0027filesys\u0027][self.base][\u0027fstype\u0027] !\u003d \u0027vfat\u0027:"},{"line_number":110,"context_line":"            exec_sudo([\"fstrim\", \"--verbose\","},{"line_number":111,"context_line":"                       self.state[\u0027mount\u0027][self.mount_point][\u0027path\u0027]])"},{"line_number":112,"context_line":"        exec_sudo([\"umount\", self.state[\u0027mount\u0027][self.mount_point][\u0027path\u0027]])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_cd704343","line":109,"in_reply_to":"7f96bb07_0a4e2737","updated":"2018-01-18 23:42:18.000000000","message":"I did see that in the man page and considered just running it unconditionally; i figured it was *slightly* safer to avoid adding a call to a tool doing external recursion just in case there was some unintended side-effect.","commit_id":"ab3333eb2c083b778ed24365659cae535e52fe3f"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"8ec964f84230fbac3e0d78fb9a3086203f9527b8","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        # this behaviour."},{"line_number":107,"context_line":"        # https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg02978.html"},{"line_number":108,"context_line":"        exec_sudo([\"sync\"])"},{"line_number":109,"context_line":"        if self.state[\u0027filesys\u0027][self.base][\u0027fstype\u0027] !\u003d \u0027vfat\u0027:"},{"line_number":110,"context_line":"            exec_sudo([\"fstrim\", \"--verbose\","},{"line_number":111,"context_line":"                       self.state[\u0027mount\u0027][self.mount_point][\u0027path\u0027]])"},{"line_number":112,"context_line":"        exec_sudo([\"umount\", self.state[\u0027mount\u0027][self.mount_point][\u0027path\u0027]])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_10b97813","line":109,"in_reply_to":"7f96bb07_0a4e2737","updated":"2018-01-18 12:03:25.000000000","message":"Run that on machine with several TB on mounted filesystems...","commit_id":"ab3333eb2c083b778ed24365659cae535e52fe3f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0e8696d1954a4be216098cfd3a4d9f924dd23e22","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        # this behaviour."},{"line_number":107,"context_line":"        # https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg02978.html"},{"line_number":108,"context_line":"        exec_sudo([\"sync\"])"},{"line_number":109,"context_line":"        if self.state[\u0027filesys\u0027][self.base][\u0027fstype\u0027] !\u003d \u0027vfat\u0027:"},{"line_number":110,"context_line":"            exec_sudo([\"fstrim\", \"--verbose\","},{"line_number":111,"context_line":"                       self.state[\u0027mount\u0027][self.mount_point][\u0027path\u0027]])"},{"line_number":112,"context_line":"        exec_sudo([\"umount\", self.state[\u0027mount\u0027][self.mount_point][\u0027path\u0027]])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_6d4ecf97","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":64},"in_reply_to":"7f96bb07_d06550b6","updated":"2018-01-18 23:42:18.000000000","message":"The configuration graph does reflect the way you\u0027d do things manually (first you make loopback, then add partitions, then mkfs on the parts, then mount) so it does seem wrong that you\u0027d specify the file-system type in the mount node AND in the mkfs node.\n\nwhat is lacking is a way for this node (mount) to query it\u0027s relations (or, i guess, the mkfs node to ask the mount node what fstype it would use).  i did actually play with that a while ago in Iee3b341bcf88e897af611b7ae0d60fd07cb8da8d but it\u0027s not 100% clear.\n\nas we walk through creating we build up the global self.state dictionary to reflect the overall work done... so when we\u0027re walking backwards here in the unmount phase we can pull the info out as done here safely.\n\nof course another possibility is to move this into the mfks node unmount.  although i\u0027m not sure, technically, you\u0027d be assured nothing else happens to the mount-point to invalid this trim between that and the actual unmount here.\n\n---\n\nthis is all rather theoretical and solutions looking for a problem :)  i think this is pretty much KISS","commit_id":"ab3333eb2c083b778ed24365659cae535e52fe3f"}]}