)]}'
{"diskimage_builder/elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e93b99816411c54d772aba0e16473e67d53cc33a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        extra_options\u003d"},{"line_number":132,"context_line":"        # better check for grub-efi would be nice"},{"line_number":133,"context_line":"        # fedora does not have grub-efi-modules like debian has"},{"line_number":134,"context_line":"        if [ ! -d /usr/lib/grub/*-efi ]; then"},{"line_number":135,"context_line":"            modules\u003d\"$modules biosdisk\""},{"line_number":136,"context_line":"        else"},{"line_number":137,"context_line":"            extra_options\u003d\"--removable\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7f96bb07_4227c713","line":134,"updated":"2018-01-23 03:37:35.000000000","message":"I know this is a WIP \n\n... these are files installed by grub-efi-amd64?  I\u0027m not seeing where we install that package with this?\n\nat a minimum, i think we should move the efi portion out into its own function (... and surely we can remove extlinux in here ... but for another day); even if it\u0027s a bit of duplication I still think it\u0027s easier to keep the two paths separate.\n\nif it just ends up being a (relatively) straight-forward and self-contained thing, for simplicity I guess we just keep it in here and use a flag.  otherwise we can look at more complex ideas for configuration","commit_id":"94a18685a4e6e39e239207a139e2ad5995679947"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"51a809b89896458f8f02248ab72e317da9c71e2a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        extra_options\u003d"},{"line_number":132,"context_line":"        # better check for grub-efi would be nice"},{"line_number":133,"context_line":"        # fedora does not have grub-efi-modules like debian has"},{"line_number":134,"context_line":"        if [ ! -d /usr/lib/grub/*-efi ]; then"},{"line_number":135,"context_line":"            modules\u003d\"$modules biosdisk\""},{"line_number":136,"context_line":"        else"},{"line_number":137,"context_line":"            extra_options\u003d\"--removable\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7f96bb07_4d593733","line":134,"in_reply_to":"7f96bb07_4227c713","updated":"2018-01-23 06:28:00.000000000","message":"grub-efi-amd64 is installed if you change grub-pc -\u003e grub-efi in pkg-map file.\n\nMoving it to separate function would be code duplication. Grub support in distributions is wrote in such way that there is nearly no differences between \u0027grub-pc\u0027 and \u0027grub-efi\u0027.","commit_id":"94a18685a4e6e39e239207a139e2ad5995679947"}]}