)]}'
{"diskimage_builder/elements/block-device-gpt/block-device-ppc64el.yaml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"eaba80ad2bfefdbc5baf10bdb4f90e5adaaf74db","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    label: gpt"},{"line_number":20,"context_line":"    partitions:"},{"line_number":21,"context_line":"      - name: boot"},{"line_number":22,"context_line":"        flags: [ boot ]"},{"line_number":23,"context_line":"        type: \u00270x4100\u0027"},{"line_number":24,"context_line":"        size: 8MiB"},{"line_number":25,"context_line":"      - name: root"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f93b717_dd604204","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":23},"updated":"2018-01-31 09:19:40.000000000","message":"We do not use flags on gpt","commit_id":"398228e9a7f7d6ef6abd362c49c3a531dafb43aa"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f69498492e5848d97324eac8f536aa6e18a39374","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    label: gpt"},{"line_number":20,"context_line":"    partitions:"},{"line_number":21,"context_line":"      - name: boot"},{"line_number":22,"context_line":"        flags: [ boot ]"},{"line_number":23,"context_line":"        type: \u00270x4100\u0027"},{"line_number":24,"context_line":"        size: 8MiB"},{"line_number":25,"context_line":"      - name: root"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f93b717_052e3afa","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":23},"in_reply_to":"5f93b717_dd604204","updated":"2018-01-31 23:01:01.000000000","message":"thanks, will pull that out","commit_id":"398228e9a7f7d6ef6abd362c49c3a531dafb43aa"}],"diskimage_builder/lib/common-functions":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"eaba80ad2bfefdbc5baf10bdb4f90e5adaaf74db","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    done"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    if [[ -n \"${vm_seen}\" \u0026\u0026 -z \"${blockdev_seen}\" ]]; then"},{"line_number":277,"context_line":"        elements\u003d\"$elements block-device-mbr\""},{"line_number":278,"context_line":"    fi"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    echo $elements"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5f93b717_5d1bd27f","line":277,"range":{"start_line":277,"start_character":0,"end_line":277,"end_character":45},"updated":"2018-01-31 09:19:40.000000000","message":"Can it be \"if aarch64 then gpt else mbr\"?\n\nPure EFI system can not boot mbr at all.","commit_id":"398228e9a7f7d6ef6abd362c49c3a531dafb43aa"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f69498492e5848d97324eac8f536aa6e18a39374","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    done"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    if [[ -n \"${vm_seen}\" \u0026\u0026 -z \"${blockdev_seen}\" ]]; then"},{"line_number":277,"context_line":"        elements\u003d\"$elements block-device-mbr\""},{"line_number":278,"context_line":"    fi"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    echo $elements"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5f93b717_65edbeb5","line":277,"range":{"start_line":277,"start_character":0,"end_line":277,"end_character":45},"in_reply_to":"5f93b717_5d1bd27f","updated":"2018-01-31 23:01:01.000000000","message":"My initial thought is that I\u0027d prefer we have the \"block-device-*\" element as an explicit part of the command-line ... and just keep this one hack for backwards compat; with appropriate error cases.\n\nWe could also build some sort of big defaults thing into the element dependency resolution (if element X not specified, default to Y on arch A, Z on arch B) ... i\u0027m just not sure that\u0027s time well spent.\n\nI\u0027m just working on a follow-on to incorporate this into the bootloader that probably shows this a bit better.  Let\u0027s cycle back after that","commit_id":"398228e9a7f7d6ef6abd362c49c3a531dafb43aa"}]}