)]}'
{"diskimage_builder/elements/block-device-efi/environment.d/15-block-device.bash":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"551506d8cd7c4c75e47af8f16189ad0ef5a9f686","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Arch gate"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [[ \"powerpc ppc64 ppc64le\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":6,"context_line":"    echo \"EFI is not supported on Power; use block-device-gpt or block-device-mbr\""},{"line_number":7,"context_line":"    exit 1"},{"line_number":8,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f93b717_c80ce795","line":5,"range":{"start_line":5,"start_character":21,"end_line":5,"end_character":28},"updated":"2018-02-01 00:12:52.000000000","message":"you need ppc64el here also.  I don\u0027t recall an arch for powerpc but I s\u0027pose it could be an old 32bit thing.  Having it here doesn\u0027t hurt though","commit_id":"27c7f86262a7cf44de142c1da85228fda4771583"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"550c771c045192091f46f2db00925d5b02d326bb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Arch gate"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [[ \"powerpc ppc64 ppc64le\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":6,"context_line":"    echo \"EFI is not supported on Power; use block-device-gpt or block-device-mbr\""},{"line_number":7,"context_line":"    exit 1"},{"line_number":8,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f93b717_9a8b81c1","line":5,"range":{"start_line":5,"start_character":21,"end_line":5,"end_character":28},"in_reply_to":"5f93b717_c80ce795","updated":"2018-02-01 06:40:02.000000000","message":"will do","commit_id":"27c7f86262a7cf44de142c1da85228fda4771583"}],"diskimage_builder/elements/block-device-gpt/environment.d/15-block-device.bash":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2e0482248d975d7ba87f3733eae9fe69a978c9cc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Arch gate"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [[ \"arm64 aarch64\" \u003d~ $ARCH ]]; then"},{"line_number":6,"context_line":"    echo \"GPT is not supported on AARCH64; use block-device-efi\""},{"line_number":7,"context_line":"    exit 1"},{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"export DIB_BLOCK_DEVICE\u003dgpt"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa0c359_2e942944","line":8,"range":{"start_line":5,"start_character":0,"end_line":8,"end_character":2},"updated":"2018-02-05 12:26:01.000000000","message":"Please rephrase that or drop.","commit_id":"28ccee7054733fb7aa828553ba3acdf5b21562a5"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2b9dcd31d807a619046ff4640cd6c99dd6daa6ac","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Arch gate"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [[ \"arm64 aarch64\" \u003d~ $ARCH ]]; then"},{"line_number":6,"context_line":"    echo \"GPT is not supported on AARCH64; use block-device-efi\""},{"line_number":7,"context_line":"    exit 1"},{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"export DIB_BLOCK_DEVICE\u003dgpt"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa0c359_14d3683a","line":8,"range":{"start_line":5,"start_character":0,"end_line":8,"end_character":2},"in_reply_to":"3fa0c359_2e942944","updated":"2018-02-06 00:26:43.000000000","message":"I presume you mean the \"GPT is not supported\" ... I\u0027ll rephrase that to \"the block-device-gpt\" element ...","commit_id":"28ccee7054733fb7aa828553ba3acdf5b21562a5"}],"diskimage_builder/elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2e0482248d975d7ba87f3733eae9fe69a978c9cc","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    # rigth thing based on distribution."},{"line_number":62,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":63,"context_line":"        install-packages -m bootloader grub-ppc64"},{"line_number":64,"context_line":"    elif [[ \"${DIB_BLOCK_DEVICE}\" \u003d\u003d \"mbr\" ]]; then"},{"line_number":65,"context_line":"        install-packages -m bootloader grub-pc"},{"line_number":66,"context_line":"    elif [[ \"${DIB_BLOCK_DEVICE}\" \u003d\u003d \"efi\" ]]; then"},{"line_number":67,"context_line":"        install-packages -m bootloader grub-efi"},{"line_number":68,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa0c359_6e831106","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":46},"updated":"2018-02-05 12:26:01.000000000","message":"We hope that no one will use DIB with \u003e2TB images?\n\n\u0027grub-pc\u0027 on GPT (with ef02 partition) would work too","commit_id":"28ccee7054733fb7aa828553ba3acdf5b21562a5"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2b9dcd31d807a619046ff4640cd6c99dd6daa6ac","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    # rigth thing based on distribution."},{"line_number":62,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":63,"context_line":"        install-packages -m bootloader grub-ppc64"},{"line_number":64,"context_line":"    elif [[ \"${DIB_BLOCK_DEVICE}\" \u003d\u003d \"mbr\" ]]; then"},{"line_number":65,"context_line":"        install-packages -m bootloader grub-pc"},{"line_number":66,"context_line":"    elif [[ \"${DIB_BLOCK_DEVICE}\" \u003d\u003d \"efi\" ]]; then"},{"line_number":67,"context_line":"        install-packages -m bootloader grub-efi"},{"line_number":68,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa0c359_74ff4caa","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":46},"in_reply_to":"3fa0c359_6e831106","updated":"2018-02-06 00:26:43.000000000","message":"Ahh, this is my mistake as I\u0027ve missed \"gpt\" in this branch list; the intention is it is there for this large disk case.\n\nAIUI we could just switch x86-64 to use the 3-partition layout unconditionally.  Perhaps I\u0027m too conservative but my thought is to maintain the status-quo unless people opt-in.","commit_id":"28ccee7054733fb7aa828553ba3acdf5b21562a5"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2e0482248d975d7ba87f3733eae9fe69a978c9cc","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            extra_options\u003d\"--removable\""},{"line_number":146,"context_line":"            # We need to manually set the target if it\u0027s different to"},{"line_number":147,"context_line":"            # the host.  Setup for EFI"},{"line_number":148,"context_line":"            case $ARCH in"},{"line_number":149,"context_line":"                \"x86_64\"|\"amd64\")"},{"line_number":150,"context_line":"                    GRUB_OPTS\u003d\"--target\u003dx86_64-efi\""},{"line_number":151,"context_line":"                    ;;"},{"line_number":152,"context_line":"            esac"},{"line_number":153,"context_line":"        fi"},{"line_number":154,"context_line":"        $GRUBNAME --modules\u003d\"$modules\" $extra_options $GRUB_OPTS $BOOT_DEV"},{"line_number":155,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa0c359_0ec28d34","line":152,"range":{"start_line":148,"start_character":11,"end_line":152,"end_character":16},"updated":"2018-02-05 12:26:01.000000000","message":"Look at [1] for x86, aarch64, arm targets.\n\n1. https://git.launchpad.net/cirros/tree/bin/grab-grub-efi?id\u003d371293d8e747f123f5782e27a0b80db0c4050b70#n73","commit_id":"28ccee7054733fb7aa828553ba3acdf5b21562a5"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"32416e41729d15900ae4eb982c293a90a7f9c38e","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            extra_options\u003d\"--removable\""},{"line_number":146,"context_line":"            # We need to manually set the target if it\u0027s different to"},{"line_number":147,"context_line":"            # the host.  Setup for EFI"},{"line_number":148,"context_line":"            case $ARCH in"},{"line_number":149,"context_line":"                \"x86_64\"|\"amd64\")"},{"line_number":150,"context_line":"                    GRUB_OPTS\u003d\"--target\u003dx86_64-efi\""},{"line_number":151,"context_line":"                    ;;"},{"line_number":152,"context_line":"            esac"},{"line_number":153,"context_line":"        fi"},{"line_number":154,"context_line":"        $GRUBNAME --modules\u003d\"$modules\" $extra_options $GRUB_OPTS $BOOT_DEV"},{"line_number":155,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa0c359_74f0ac91","line":152,"range":{"start_line":148,"start_character":11,"end_line":152,"end_character":16},"in_reply_to":"3fa0c359_0ec28d34","updated":"2018-02-06 00:41:23.000000000","message":"My thinking here is currently that \"grub-efi\" should be a sufficient generic package name across x86 \u0026 aarch64?\n\nI also am thinking that aarch64 doesn\u0027t require an explicit --target argument?  my understanding is that grub-install here takes a best-guess, and on non-efi x86 it probably tries to install bios based on probing inside the chroot, that\u0027s why we need the explicit target.  this doesn\u0027t seem necessary on aarch64?","commit_id":"28ccee7054733fb7aa828553ba3acdf5b21562a5"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"70575116a174ba83ac99671345d96cc9dce275a4","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            extra_options\u003d\"--removable\""},{"line_number":146,"context_line":"            # We need to manually set the target if it\u0027s different to"},{"line_number":147,"context_line":"            # the host.  Setup for EFI"},{"line_number":148,"context_line":"            case $ARCH in"},{"line_number":149,"context_line":"                \"x86_64\"|\"amd64\")"},{"line_number":150,"context_line":"                    GRUB_OPTS\u003d\"--target\u003dx86_64-efi\""},{"line_number":151,"context_line":"                    ;;"},{"line_number":152,"context_line":"            esac"},{"line_number":153,"context_line":"        fi"},{"line_number":154,"context_line":"        $GRUBNAME --modules\u003d\"$modules\" $extra_options $GRUB_OPTS $BOOT_DEV"},{"line_number":155,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa0c359_d53adae5","line":152,"range":{"start_line":148,"start_character":11,"end_line":152,"end_character":16},"in_reply_to":"3fa0c359_74f0ac91","updated":"2018-02-06 03:36:02.000000000","message":"re part 1 -- \"grub-efi\" is a valid target on amd64 it seems, but not in arm64 (at least in my testing)\n\n---\n\n(env) root@dib-test:~/diskimage-builder# apt-get install grub-efi\nReading package lists... Done\nBuilding dependency tree       \nReading state information... Done\nPackage grub-efi is not available, but is referred to by another package.\nThis may mean that the package is missing, has been obsoleted, or\nis only available from another source\nHowever the following packages replace it:\n  grub-common grub2-common\n\nE: Package \u0027grub-efi\u0027 has no installation candidate","commit_id":"28ccee7054733fb7aa828553ba3acdf5b21562a5"}]}