)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"d2a225868bc44e4b5bcf5bfcf265ae0b4f9e4733","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Hpsum utiltity of proliant-tools requires net-tools to be installed"},{"line_number":10,"context_line":"as part of base image. This commit adds support for installation of"},{"line_number":11,"context_line":"net-tools for redhat based images."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2a1e81059ed1aee975db78cfa5e61bbf1b98e06f"},{"line_number":14,"context_line":"Closes-bug: 1751777"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f9dbf25_bb188775","line":11,"range":{"start_line":11,"start_character":13,"end_line":11,"end_character":33},"updated":"2018-02-27 10:27:17.000000000","message":"Why is this only needed for Red hat?  doesn\u0027t the ssacli package need this regardless of distro?\n\nOr is net-tools just always there for ubuntu/debian?","commit_id":"06f2c5c10a91b260965e1d6e4bb2b4473e93ec44"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"840912668ca7c8705b14a854d47a23a591e6b628","unresolved":false,"context_lines":[{"line_number":7,"context_line":"proliant-tools: add net-tools package for redhat image creation."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Hpsum utiltity of proliant-tools requires net-tools to be installed"},{"line_number":10,"context_line":"as part of base image. This commit adds support for installation of"},{"line_number":11,"context_line":"net-tools for redhat based images."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2a1e81059ed1aee975db78cfa5e61bbf1b98e06f"},{"line_number":14,"context_line":"Closes-bug: 1751777"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df7087c5_31a0e9f4","line":11,"range":{"start_line":10,"start_character":23,"end_line":11,"end_character":34},"updated":"2018-03-09 05:09:01.000000000","message":"As you have to re submit this anyway can you fix this up to say you\u0027re just installing it?","commit_id":"0da5d4cbe72b95fb7d28c5ab84377f95ca494562"}],"diskimage_builder/elements/proliant-tools/package-installs.yaml":[{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"99e5288be67915834adfa81302d7c1a703bde727","unresolved":false,"context_lines":[{"line_number":2,"context_line":"gcc:"},{"line_number":3,"context_line":"python-dev:"},{"line_number":4,"context_line":"unzip:"},{"line_number":5,"context_line":"net-tools:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df7087c5_8bf8547b","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":9},"updated":"2018-03-13 08:14:20.000000000","message":"You need to add this to the pkg-map. If it changes with distros probably you may also want to specify accordingly in the same file.","commit_id":"a7135a0d8f0c06f7ef57f5124261742b290b37e8"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"0d49547f49aef219db89b0e6b92765d3c55b359d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"gcc:"},{"line_number":3,"context_line":"python-dev:"},{"line_number":4,"context_line":"unzip:"},{"line_number":5,"context_line":"net-tools:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df7087c5_a149b931","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":9},"in_reply_to":"df7087c5_8bf8547b","updated":"2018-03-13 09:06:21.000000000","message":"It\u0027s the same on all distros that have been checked.  If we add support for a distro and that is no loner true we can add it to pkg-map then.\n\nPlease try to read previous comments on a review that has several patch sets as the provide context that isn\u0027t always appropriate in the code itself.","commit_id":"a7135a0d8f0c06f7ef57f5124261742b290b37e8"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"4e2eddaa9062b6f6481082d9394476594240736a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"gcc:"},{"line_number":3,"context_line":"python-dev:"},{"line_number":4,"context_line":"unzip:"},{"line_number":5,"context_line":"net-tools:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df7087c5_5bf4e9f0","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":9},"in_reply_to":"df7087c5_a149b931","updated":"2018-03-16 08:57:17.000000000","message":"Thanks Tony for the clarification. I see other packages like \"gcc\", \"unzip\" which are common across all distro but still were mentioned. Should not we have consistency? I know for other elements we are following the approach you have explained. But not for this.","commit_id":"a7135a0d8f0c06f7ef57f5124261742b290b37e8"}],"diskimage_builder/elements/rhel-common/README.rst":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"840912668ca7c8705b14a854d47a23a591e6b628","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"df7087c5_f174b19b","updated":"2018-03-09 05:09:01.000000000","message":"I think this is part of another change ;P","commit_id":"0da5d4cbe72b95fb7d28c5ab84377f95ca494562"}],"diskimage_builder/elements/rhel-common/os-refresh-config/pre-configure.d/06-rhel-registration":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"840912668ca7c8705b14a854d47a23a591e6b628","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"df7087c5_9169b5bf","updated":"2018-03-09 05:09:01.000000000","message":"As is this","commit_id":"0da5d4cbe72b95fb7d28c5ab84377f95ca494562"}]}