)]}'
{"diskimage_builder/elements/gentoo/finalise.d/99-cleanup":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"8c2d0cb0e889ebdd76d2a0375daf5c65080688d0","unresolved":false,"context_lines":[{"line_number":57,"context_line":"unfix_shm"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# systemd id"},{"line_number":60,"context_line":"[[ ${GENTOO_PROFILE} \u003d\u003d *\u0027systemd\u0027* ]] \u0026\u0026 rm /etc/machine-id \u0026\u0026 touch /etc/machine-id"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"df7087c5_65be1600","line":60,"range":{"start_line":60,"start_character":42,"end_line":60,"end_character":85},"updated":"2018-03-15 00:25:21.000000000","message":"I probably would have avoided this compaound statement and either gone with:  \u0026\u0026 cp /dev/null /etc/machine-id or a full if statement but that\u0027s style rather than function.  This works","commit_id":"acf076ac38dbfa74c07b78d02f00bad0b433f206"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d4302b68936842b6be2d3b5f59c42951a5b16d44","unresolved":false,"context_lines":[{"line_number":57,"context_line":"unfix_shm"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# systemd id"},{"line_number":60,"context_line":"[[ \"${GENTOO_PROFILE}\" \u003d\u003d *\"systemd\"* ]] \u0026\u0026 cp /dev/null /etc/machine-id"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"df7087c5_cf722ae4","line":60,"updated":"2018-03-20 09:16:16.000000000","message":"i think your problem here is that we\u0027re running under \"-e\" and this exits 1, raising the error.\n\nI would just put it in an \"if\" to be safe","commit_id":"c88bd65919c0bbd2f6b56bfeebba10076c67b501"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"0beb1c1d533a00372c3e70c38c1af83dac24f949","unresolved":false,"context_lines":[{"line_number":57,"context_line":"unfix_shm"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# systemd id"},{"line_number":60,"context_line":"[[ \"${GENTOO_PROFILE}\" \u003d\u003d *\"systemd\"* ]] \u0026\u0026 cp /dev/null /etc/machine-id"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"df7087c5_4ad59fb6","line":60,"in_reply_to":"df7087c5_c77beaf1","updated":"2018-03-20 15:17:23.000000000","message":"thats weird. I think you can add a || : at the end to discard the errneous exit code anyway","commit_id":"c88bd65919c0bbd2f6b56bfeebba10076c67b501"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"fd63c4f66ffa239006cc9a363ed09c42bf424e48","unresolved":false,"context_lines":[{"line_number":57,"context_line":"unfix_shm"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# systemd id"},{"line_number":60,"context_line":"[[ \"${GENTOO_PROFILE}\" \u003d\u003d *\"systemd\"* ]] \u0026\u0026 cp /dev/null /etc/machine-id"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"df7087c5_c77beaf1","line":60,"in_reply_to":"df7087c5_cf722ae4","updated":"2018-03-20 14:39:18.000000000","message":"That\u0027s not it (see the pre-install.d/02-gentoo-04-install-desired-python script which makes extensive use of this.\n\nI\u0027ve also made a test script.\n\n#!/usr/bin/env bash\nset -eux\nGENTOO_PROFILE\u003dasdasd\n[[ \"${GENTOO_PROFILE}\" \u003d\u003d *\"systemd\"* ]] \u0026\u0026 echo yes\necho no\n\nOUTPUT_GOES_HERE\n+ GENTOO_PROFILE\u003dasdasd\n+ [[ asdasd \u003d\u003d *\\s\\y\\s\\t\\e\\m\\d* ]]\n+ echo no\nno","commit_id":"c88bd65919c0bbd2f6b56bfeebba10076c67b501"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c90325d2c0d70c84e746a02cc039a5d11cb0534a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"unfix_shm"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# systemd id"},{"line_number":60,"context_line":"if [[ \"${GENTOO_PROFILE}\" \u003d\u003d *\"systemd\"* ]] then"},{"line_number":61,"context_line":"    cp /dev/null /etc/machine-id"},{"line_number":62,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"df7087c5_5c2f6487","line":60,"updated":"2018-03-22 20:11:18.000000000","message":"missing a ;\n\n2018-03-22 19:37:46.531996 | primary | [gentoo/build-succeeds] 2018-03-22 19:37:46.521 | /tmp/in_target.d/finalise.d/99-cleanup: line 60: syntax error near unexpected token `then\u0027","commit_id":"cb49c72b355540e3444276daeedb63af54b6f82b"}]}
