)]}'
{"diskimage_builder/elements/dhcp-all-interfaces/install.d/60-remove-cloud-image-interfaces":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"64c63b33ecc8d27d2c6b73b2a904c5f5be2c041c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"if [ -f \"/etc/network/interfaces\" ]; then"},{"line_number":26,"context_line":"    printf \"auto lo\\niface lo inet loopback\\n\\n\" \u003e /etc/network/interfaces"},{"line_number":27,"context_line":"    if [ -d \"/etc/network/interfaces.d/\" ]; then"},{"line_number":28,"context_line":"        if [ -r /etc/lsb-release ]; then"},{"line_number":29,"context_line":"            . /etc/lsb-release"},{"line_number":30,"context_line":"        fi"},{"line_number":31,"context_line":"        if [ -n \"$DISTRIB_ID\" ] \u0026\u0026 [ \"$DISTRIB_ID\" \u003d\u003d \"Ubuntu\" ] \u0026\u0026 [ -n \"$DISTRIB_RELEASE\" ] \u0026\u0026 [[ \"$DISTRIB_RELEASE\" \u003e \"16.03\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9f6a8fd7_27be0bd5","line":28,"updated":"2018-04-21 06:15:50.000000000","message":"Why are you using lsb instead of the already defined variable \u0027DIB_RELEASE\u0027?","commit_id":"e5657d69a068f00d745d3574fc34730a459f915a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"89215e4781f5da4f0ef439f0953f7aaa032680f1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"if [ -f \"/etc/network/interfaces\" ]; then"},{"line_number":26,"context_line":"    printf \"auto lo\\niface lo inet loopback\\n\\n\" \u003e /etc/network/interfaces"},{"line_number":27,"context_line":"    if [ -d \"/etc/network/interfaces.d/\" ]; then"},{"line_number":28,"context_line":"        if [ -r /etc/lsb-release ]; then"},{"line_number":29,"context_line":"            . /etc/lsb-release"},{"line_number":30,"context_line":"        fi"},{"line_number":31,"context_line":"        if [ -n \"$DISTRIB_ID\" ] \u0026\u0026 [ \"$DISTRIB_ID\" \u003d\u003d \"Ubuntu\" ] \u0026\u0026 [ -n \"$DISTRIB_RELEASE\" ] \u0026\u0026 [[ \"$DISTRIB_RELEASE\" \u003e \"16.03\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9f6a8fd7_d141fb3a","line":28,"in_reply_to":"9f6a8fd7_16da094a","updated":"2018-04-23 10:44:17.000000000","message":"I would also not like to see this popping up everywhere.  you a probably right that we don\u0027t have a \u003e\u003d logic on releases; however in this case, can we not use \"source-directory\" on trusty and if !trusty, use \"source\"?","commit_id":"e5657d69a068f00d745d3574fc34730a459f915a"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"80313a584ee8a56e4f4f4ae3759a03258e6e2a1c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"if [ -f \"/etc/network/interfaces\" ]; then"},{"line_number":26,"context_line":"    printf \"auto lo\\niface lo inet loopback\\n\\n\" \u003e /etc/network/interfaces"},{"line_number":27,"context_line":"    if [ -d \"/etc/network/interfaces.d/\" ]; then"},{"line_number":28,"context_line":"        if [ -r /etc/lsb-release ]; then"},{"line_number":29,"context_line":"            . /etc/lsb-release"},{"line_number":30,"context_line":"        fi"},{"line_number":31,"context_line":"        if [ -n \"$DISTRIB_ID\" ] \u0026\u0026 [ \"$DISTRIB_ID\" \u003d\u003d \"Ubuntu\" ] \u0026\u0026 [ -n \"$DISTRIB_RELEASE\" ] \u0026\u0026 [[ \"$DISTRIB_RELEASE\" \u003e \"16.03\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9f6a8fd7_16da094a","line":28,"in_reply_to":"9f6a8fd7_27be0bd5","updated":"2018-04-23 10:15:49.000000000","message":"Because as I need to compare Ubuntu version number to be greater or equal than 16.04, this is the easiest way I found to do so. AFAIK this version is not available in DIB. Furthermore this makes the code distribution dependent only, not DIB dependant","commit_id":"e5657d69a068f00d745d3574fc34730a459f915a"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"abff29b1ebb8c038417ed85cb3fb276abd47e6ce","unresolved":false,"context_lines":[{"line_number":25,"context_line":"if [ -f \"/etc/network/interfaces\" ]; then"},{"line_number":26,"context_line":"    printf \"auto lo\\niface lo inet loopback\\n\\n\" \u003e /etc/network/interfaces"},{"line_number":27,"context_line":"    if [ -d \"/etc/network/interfaces.d/\" ]; then"},{"line_number":28,"context_line":"        if [ -r /etc/lsb-release ]; then"},{"line_number":29,"context_line":"            . /etc/lsb-release"},{"line_number":30,"context_line":"        fi"},{"line_number":31,"context_line":"        if [ -n \"$DISTRIB_ID\" ] \u0026\u0026 [ \"$DISTRIB_ID\" \u003d\u003d \"Ubuntu\" ] \u0026\u0026 [ -n \"$DISTRIB_RELEASE\" ] \u0026\u0026 [[ \"$DISTRIB_RELEASE\" \u003e \"16.03\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9f6a8fd7_d81a7bca","line":28,"in_reply_to":"9f6a8fd7_d141fb3a","updated":"2018-04-23 12:32:47.000000000","message":"Ian, sorry but I do not get your last point here about trusty. Could you please elaborate a bit, I am confused","commit_id":"e5657d69a068f00d745d3574fc34730a459f915a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3589e3d27ef524b62c2a5ba0b3807a87df6f9ad3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"if [ -f \"/etc/network/interfaces\" ]; then"},{"line_number":26,"context_line":"    printf \"auto lo\\niface lo inet loopback\\n\\n\" \u003e /etc/network/interfaces"},{"line_number":27,"context_line":"    if [ -d \"/etc/network/interfaces.d/\" ]; then"},{"line_number":28,"context_line":"        if [ -r /etc/lsb-release ]; then"},{"line_number":29,"context_line":"            . /etc/lsb-release"},{"line_number":30,"context_line":"        fi"},{"line_number":31,"context_line":"        if [ -n \"$DISTRIB_ID\" ] \u0026\u0026 [ \"$DISTRIB_ID\" \u003d\u003d \"Ubuntu\" ] \u0026\u0026 [ -n \"$DISTRIB_RELEASE\" ] \u0026\u0026 [[ \"$DISTRIB_RELEASE\" \u003e \"16.03\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9f6a8fd7_ef10c902","line":28,"in_reply_to":"9f6a8fd7_d81a7bca","updated":"2018-04-23 23:49:58.000000000","message":"I would do\n\nif [[ $DIB_RELEASE \u003d\u003d \u0027trusty\u0027 ]]; then\n  printf ... source-directories /etc/...\nelse\n  printf ... source /etc/...\nfi\n\nHonestly how much has this been used if we\u0027re only just noticing this now, and Xenial is about to be replaced for Bionic?","commit_id":"e5657d69a068f00d745d3574fc34730a459f915a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3589e3d27ef524b62c2a5ba0b3807a87df6f9ad3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        if [ -r /etc/lsb-release ]; then"},{"line_number":29,"context_line":"            . /etc/lsb-release"},{"line_number":30,"context_line":"        fi"},{"line_number":31,"context_line":"        if [ -n \"$DISTRIB_ID\" ] \u0026\u0026 [ \"$DISTRIB_ID\" \u003d\u003d \"Ubuntu\" ] \u0026\u0026 [ -n \"$DISTRIB_RELEASE\" ] \u0026\u0026 [[ \"$DISTRIB_RELEASE\" \u003e \"16.03\" ]]; then"},{"line_number":32,"context_line":"            printf \"source /etc/network/interfaces.d/*\\n\\n\" \u003e\u003e /etc/network/interfaces"},{"line_number":33,"context_line":"        else"},{"line_number":34,"context_line":"            printf \"source-directory interfaces.d\\n\\n\" \u003e\u003e /etc/network/interfaces"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9f6a8fd7_ef42090f","line":31,"updated":"2018-04-23 23:49:58.000000000","message":"We went through version comparison with devstack; see the final implementation in [1].  \n\nthere\u0027s two problems iirc:\n\nas i guess you\u0027ve noted by using \"16.03\" there\u0027s simple \u003e\u003d equivalent (and -ge doesn\u0027t work as it thinks it is a float).  \n\nWith the simple alphabetical sort you get into trouble with sematic versioning like \"2.10 \u003c 2.2\" when that\u0027s actually \"version two-point-ten\" which is greater than \"version two-point-two\".\n\nI don\u0027t think it applies on \"YY.MM\", and i don\u0027t think they\u0027ve gotten high enough in sub-releases, but \"16.04.10\" starts sorting before \"16.04.2\".  so you have to start splitting it up at \".\" -- it\u0027s easier to get sort to do it than re-implement it (probably badly :).\n\n[1] https://git.openstack.org/cgit/openstack-dev/devstack/tree/functions#n588","commit_id":"e5657d69a068f00d745d3574fc34730a459f915a"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"834b7c872784bb160784128f57d849fcf117db5a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        if [ -r /etc/lsb-release ]; then"},{"line_number":29,"context_line":"            . /etc/lsb-release"},{"line_number":30,"context_line":"        fi"},{"line_number":31,"context_line":"        if [ -n \"$DISTRIB_ID\" ] \u0026\u0026 [ \"$DISTRIB_ID\" \u003d\u003d \"Ubuntu\" ] \u0026\u0026 [ -n \"$DISTRIB_RELEASE\" ] \u0026\u0026 [[ \"$DISTRIB_RELEASE\" \u003e \"16.03\" ]]; then"},{"line_number":32,"context_line":"            printf \"source /etc/network/interfaces.d/*\\n\\n\" \u003e\u003e /etc/network/interfaces"},{"line_number":33,"context_line":"        else"},{"line_number":34,"context_line":"            printf \"source-directory interfaces.d\\n\\n\" \u003e\u003e /etc/network/interfaces"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_b447d51e","line":31,"in_reply_to":"9f6a8fd7_ef42090f","updated":"2018-07-03 05:14:41.000000000","message":"Done much simpler following your comments suggestions in patchset 2","commit_id":"e5657d69a068f00d745d3574fc34730a459f915a"}]}