)]}'
{"diskimage_builder/elements/pip-and-virtualenv/install.d/pip-and-virtualenv-source-install/04-install-pip":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"96dce324f634607007ff1cb43dd5cc5695d5b1be","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            # note python2-pip in epel"},{"line_number":17,"context_line":"            _extra_repo\u003d\"--enablerepo\u003depel\""},{"line_number":18,"context_line":"            packages\u003d\"python-virtualenv python2-pip\""},{"line_number":19,"context_line":"            if [ -z \"$(rpm -qa | grep ^centos-release-openstack)\" ]; then"},{"line_number":20,"context_line":"                packages+\u003d\" python-setuptools\""},{"line_number":21,"context_line":"            else"},{"line_number":22,"context_line":"                # If OpenStack release is installed, then python-setuptools is"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f6a8fd7_bb2a4f29","line":19,"updated":"2018-04-20 05:34:27.000000000","message":"sorry, i should have known it wouldn\u0027t be so easy :/\n\ncan we somehow scan this without looking for \"centos-release-openstack\" directly ... it seems very specific? \n\nwhat about\n\n $ rpm -q --qf \u0027[%{obsoletes}\\n]\u0027 python2-setuptools\n python-setuptools\n\nwhich I think means \"show me what python2-setuptools obsoletes\" ... if that returns, then we know we need python2-setuptools, otherwise python-setuptools?","commit_id":"75b0f48d19efa603181ff9f56f6b767093bbc71c"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"ec27950937ff99caaa37a9e942dffd3c8fc0b667","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            # note python2-pip in epel"},{"line_number":17,"context_line":"            _extra_repo\u003d\"--enablerepo\u003depel\""},{"line_number":18,"context_line":"            packages\u003d\"python-virtualenv python2-pip\""},{"line_number":19,"context_line":"            if [ -z \"$(rpm -qa | grep ^centos-release-openstack)\" ]; then"},{"line_number":20,"context_line":"                packages+\u003d\" python-setuptools\""},{"line_number":21,"context_line":"            else"},{"line_number":22,"context_line":"                # If OpenStack release is installed, then python-setuptools is"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f6a8fd7_36a736aa","line":19,"in_reply_to":"9f6a8fd7_7b54b753","updated":"2018-04-20 07:04:06.000000000","message":"Alright it did worked and fixed our image building.","commit_id":"75b0f48d19efa603181ff9f56f6b767093bbc71c"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"ebf7f06bfd5e78124770639a33718d9c45cbf2ad","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            # note python2-pip in epel"},{"line_number":17,"context_line":"            _extra_repo\u003d\"--enablerepo\u003depel\""},{"line_number":18,"context_line":"            packages\u003d\"python-virtualenv python2-pip\""},{"line_number":19,"context_line":"            if [ -z \"$(rpm -qa | grep ^centos-release-openstack)\" ]; then"},{"line_number":20,"context_line":"                packages+\u003d\" python-setuptools\""},{"line_number":21,"context_line":"            else"},{"line_number":22,"context_line":"                # If OpenStack release is installed, then python-setuptools is"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f6a8fd7_dbbdc3d8","line":19,"in_reply_to":"9f6a8fd7_bb2a4f29","updated":"2018-04-20 05:43:48.000000000","message":"Heh no worries :-)\n\nThe command doesn\u0027t seems to work if python2-setuptools isn\u0027t installed in the first place. Maybe we could check if python2-setuptools is available, and assume that it would have a version greater than python-setuptools.","commit_id":"75b0f48d19efa603181ff9f56f6b767093bbc71c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3e61c2be7bce562340fca2b6dbd3f0a548bb557c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            # note python2-pip in epel"},{"line_number":17,"context_line":"            _extra_repo\u003d\"--enablerepo\u003depel\""},{"line_number":18,"context_line":"            packages\u003d\"python-virtualenv python2-pip\""},{"line_number":19,"context_line":"            if [ -z \"$(rpm -qa | grep ^centos-release-openstack)\" ]; then"},{"line_number":20,"context_line":"                packages+\u003d\" python-setuptools\""},{"line_number":21,"context_line":"            else"},{"line_number":22,"context_line":"                # If OpenStack release is installed, then python-setuptools is"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f6a8fd7_7b54b753","line":19,"in_reply_to":"9f6a8fd7_dbbdc3d8","updated":"2018-04-20 06:03:51.000000000","message":"i think that would probably work ... if we see python2-setuptools put that into $packages over python-setuptools","commit_id":"75b0f48d19efa603181ff9f56f6b767093bbc71c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"9d93863b25a2eb56989208e6982c88ca6ad5afb3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            # note python2-pip in epel"},{"line_number":17,"context_line":"            _extra_repo\u003d\"--enablerepo\u003depel\""},{"line_number":18,"context_line":"            packages\u003d\"python-virtualenv python2-pip\""},{"line_number":19,"context_line":"            if [ \"$(rpm -q --qf \u0027[%{obsoletes}\\n]\u0027 python2-setuptools)\" \u003d\u003d \"python-setuptools\" ]; then"},{"line_number":20,"context_line":"                # If OpenStack release is installed, then python-setuptools is"},{"line_number":21,"context_line":"                # obsoleted by python2-setuptools"},{"line_number":22,"context_line":"                packages+\u003d\" python2-setuptools\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9f6a8fd7_9d695ffa","line":19,"updated":"2018-04-22 22:14:59.000000000","message":"nit thing; [ doesn\u0027t actually recognise \"\u003d\u003d\" but bash smooths that over, but for consistency I\u0027ll just tweak this to [[","commit_id":"fa27b746dc4a2df051bad7591206bc40b2451ba7"}]}