)]}'
{"diskimage_builder/elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1542d4762f86244cde02dd14421b05c213e8b69a","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            GRUB_MKCONFIG\u003dupdate-grub"},{"line_number":200,"context_line":"        ;;"},{"line_number":201,"context_line":"        \u0027fedora\u0027|\u0027centos7\u0027|\u0027centos\u0027)"},{"line_number":202,"context_line":"            echo \"GRUB_CMDLINE_LINUX\u003d\\\"${DIB_BOOTLOADER_DEFAULT_CMDLINE}\\\"\" \u003e\u003e/etc/default/grub"},{"line_number":203,"context_line":"        ;;"},{"line_number":204,"context_line":"        \u0027opensuse\u0027)"},{"line_number":205,"context_line":"            sed -i -e \"s/\\(^GRUB_CMDLINE_LINUX.*\\)\\\"$/\\1 ${DIB_BOOTLOADER_DEFAULT_CMDLINE}\\\"/\" /etc/default/grub"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_091b90c9","side":"PARENT","line":202,"updated":"2018-05-16 01:02:30.000000000","message":"Good golly ...\n\nIt seems like we started writing \u003e/etc/default/grub with Id553972c4fd87e78c9e6fe344331a399913d965e\n\nThe we have I96345bf8f2f13d615131557b572201b9d41b6c75 which added some stuff etc /etc/default/grub, but left the \"\u003e\" alone which meant it would just override the parts\n\nThen in Ida8e1a69df22d41ad70eb7154707c50613b536a8 this changed to \"\u003e\u003e\" ... possibly unintentionally, or maybe noticed the prior issue ... hard to tell as the code was moved around.\n\nWhich is a long-winded way of saying I have no idea why this is the way it is.","commit_id":"a8df61edbb6cec3e1e9861cfc7f6b92d80418ee9"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1542d4762f86244cde02dd14421b05c213e8b69a","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    case $DISTRO_NAME in"},{"line_number":197,"context_line":"        \u0027ubuntu\u0027|\u0027debian\u0027)"},{"line_number":198,"context_line":"            sed -i -e \"s/\\(^GRUB_CMDLINE_LINUX.*\\)\\\"$/\\1 ${DIB_BOOTLOADER_DEFAULT_CMDLINE}\\\"/\" /etc/default/grub"},{"line_number":199,"context_line":"            GRUB_MKCONFIG\u003dupdate-grub"},{"line_number":200,"context_line":"        ;;"},{"line_number":201,"context_line":"        \u0027fedora\u0027|\u0027centos7\u0027|\u0027centos\u0027)"},{"line_number":202,"context_line":"            sed -i -e \"s/\\(^GRUB_CMDLINE_LINUX.*\\)\\\"$/\\1 ${DIB_BOOTLOADER_DEFAULT_CMDLINE}\\\"/\" /etc/default/grub"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_2958cc85","line":199,"updated":"2018-05-16 01:02:30.000000000","message":"It doesn\u0027t even seem like we need this.  According to [1] this is a stub that calls \"grub2-mkconfig -o $GRUB_CFG\"; so we can just call that directly.  ergo I think we can just remove this.\n\n[1] http://manpages.ubuntu.com/manpages/bionic/man8/update-grub2.8.html","commit_id":"9287949bfcfd7ecf3379962ef4f1abbf9b14f3d8"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"9f11c457afc013999ac57901f1e618a4c49966b0","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    case $DISTRO_NAME in"},{"line_number":197,"context_line":"        \u0027ubuntu\u0027|\u0027debian\u0027)"},{"line_number":198,"context_line":"            sed -i -e \"s/\\(^GRUB_CMDLINE_LINUX.*\\)\\\"$/\\1 ${DIB_BOOTLOADER_DEFAULT_CMDLINE}\\\"/\" /etc/default/grub"},{"line_number":199,"context_line":"            GRUB_MKCONFIG\u003dupdate-grub"},{"line_number":200,"context_line":"        ;;"},{"line_number":201,"context_line":"        \u0027fedora\u0027|\u0027centos7\u0027|\u0027centos\u0027)"},{"line_number":202,"context_line":"            sed -i -e \"s/\\(^GRUB_CMDLINE_LINUX.*\\)\\\"$/\\1 ${DIB_BOOTLOADER_DEFAULT_CMDLINE}\\\"/\" /etc/default/grub"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_28ce8159","line":199,"in_reply_to":"5f7c97a3_2958cc85","updated":"2018-05-16 08:39:08.000000000","message":"Agreed, on ubuntu 16.04 the script is:\n\n#!/bin/sh\nset -e\nexec grub-mkconfig -o /boot/grub/grub.cfg \"$@\"","commit_id":"9287949bfcfd7ecf3379962ef4f1abbf9b14f3d8"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1542d4762f86244cde02dd14421b05c213e8b69a","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        \u0027opensuse\u0027)"},{"line_number":205,"context_line":"            sed -i -e \"s/\\(^GRUB_CMDLINE_LINUX.*\\)\\\"$/\\1 ${DIB_BOOTLOADER_DEFAULT_CMDLINE}\\\"/\" /etc/default/grub"},{"line_number":206,"context_line":"        ;;"},{"line_number":207,"context_line":"    esac"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    # os-prober leaks /dev/sda into config file in dual-boot host"},{"line_number":210,"context_line":"    # Disable grub-os-prober to avoid the issue  while running"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_695a4483","line":207,"updated":"2018-05-16 01:02:30.000000000","message":"So we now have the same thing three times over, with no clear rationale even after I dug through the history.\n\nI\u0027d like to see this all refactored out into a single call.","commit_id":"9287949bfcfd7ecf3379962ef4f1abbf9b14f3d8"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"9f11c457afc013999ac57901f1e618a4c49966b0","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        \u0027opensuse\u0027)"},{"line_number":205,"context_line":"            sed -i -e \"s/\\(^GRUB_CMDLINE_LINUX.*\\)\\\"$/\\1 ${DIB_BOOTLOADER_DEFAULT_CMDLINE}\\\"/\" /etc/default/grub"},{"line_number":206,"context_line":"        ;;"},{"line_number":207,"context_line":"    esac"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    # os-prober leaks /dev/sda into config file in dual-boot host"},{"line_number":210,"context_line":"    # Disable grub-os-prober to avoid the issue  while running"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_e8d3a9ff","line":207,"in_reply_to":"5f7c97a3_695a4483","updated":"2018-05-16 08:39:08.000000000","message":"Sounds good to me - I did consider it but didn\u0027t want to upset the apple cart.","commit_id":"9287949bfcfd7ecf3379962ef4f1abbf9b14f3d8"}]}