)]}'
{"diskimage_builder/elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"02f3a63647add57eb18f2398586a3cebc1377542","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    if [ -f /etc/default/grub ]; then"},{"line_number":172,"context_line":"        cp /etc/default/grub /etc/default/grub.bak"},{"line_number":173,"context_line":"        egrep -v \u0027^GRUB_(DEVICE|DISABLE_LINUX_UUID|TIMEOUT|TERMINAL|GFXPAYLOAD_LINUX|CMDLINE_LINUX_DEFAULT|SERIAL_COMMAND)\u003d\u0027 /etc/default/grub.bak \u003e/etc/default/grub"},{"line_number":174,"context_line":"    fi"},{"line_number":175,"context_line":"    echo \"GRUB_DEVICE\u003dLABEL\u003d${DIB_ROOT_LABEL}\" \u003e\u003e /etc/default/grub"},{"line_number":176,"context_line":"    echo \u0027GRUB_DISABLE_LINUX_UUID\u003dtrue\u0027 \u003e\u003e /etc/default/grub"},{"line_number":177,"context_line":"    echo \"GRUB_TIMEOUT\u003d${DIB_GRUB_TIMEOUT:-5}\" \u003e\u003e/etc/default/grub"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5f7c97a3_301451e9","line":174,"updated":"2018-06-19 05:55:37.000000000","message":"i think we should at least remove the .bak file\n\n... but, I also think it would probably be even better to do a sed in-place replacement (if existing, or append) of each line below, instead of the plain append?  that way, if there were things like comments or spacing in the original file, we\u0027d keep them?\n\nit\u0027s a bit more magic, and i think you have to use sed hold space (don\u0027t we do something similar in devstack\u0027s ini file replacement?) ... but with a function it might turnout nice?","commit_id":"248d284656aaba9e43081d81dcea8e4fb5249bb2"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"5fdccc5dc3a7757bca1d80ec568313ca0ccc3746","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    if [ -f /etc/default/grub ]; then"},{"line_number":172,"context_line":"        cp /etc/default/grub /etc/default/grub.bak"},{"line_number":173,"context_line":"        egrep -v \u0027^GRUB_(DEVICE|DISABLE_LINUX_UUID|TIMEOUT|TERMINAL|GFXPAYLOAD_LINUX|CMDLINE_LINUX_DEFAULT|SERIAL_COMMAND)\u003d\u0027 /etc/default/grub.bak \u003e/etc/default/grub"},{"line_number":174,"context_line":"    fi"},{"line_number":175,"context_line":"    echo \"GRUB_DEVICE\u003dLABEL\u003d${DIB_ROOT_LABEL}\" \u003e\u003e /etc/default/grub"},{"line_number":176,"context_line":"    echo \u0027GRUB_DISABLE_LINUX_UUID\u003dtrue\u0027 \u003e\u003e /etc/default/grub"},{"line_number":177,"context_line":"    echo \"GRUB_TIMEOUT\u003d${DIB_GRUB_TIMEOUT:-5}\" \u003e\u003e/etc/default/grub"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5f7c97a3_b0a9b88f","line":174,"in_reply_to":"5f7c97a3_301451e9","updated":"2018-06-26 04:08:30.000000000","message":"Ian, thanks for this review and I agree with you. I know the very basics of sed hold space so if you could point me to the devstack code you are referring to please.\nI found https://raw.githubusercontent.com/openstack-dev/devstack/master/inc/ini-config but not sure this is what you had in mind","commit_id":"248d284656aaba9e43081d81dcea8e4fb5249bb2"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5053788f46e2ced8559157981392547f44068652","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    if [ -f /etc/default/grub ]; then"},{"line_number":172,"context_line":"        cp /etc/default/grub /etc/default/grub.bak"},{"line_number":173,"context_line":"        egrep -v \u0027^GRUB_(DEVICE|DISABLE_LINUX_UUID|TIMEOUT|TERMINAL|GFXPAYLOAD_LINUX|CMDLINE_LINUX_DEFAULT|SERIAL_COMMAND)\u003d\u0027 /etc/default/grub.bak \u003e/etc/default/grub"},{"line_number":174,"context_line":"    fi"},{"line_number":175,"context_line":"    echo \"GRUB_DEVICE\u003dLABEL\u003d${DIB_ROOT_LABEL}\" \u003e\u003e /etc/default/grub"},{"line_number":176,"context_line":"    echo \u0027GRUB_DISABLE_LINUX_UUID\u003dtrue\u0027 \u003e\u003e /etc/default/grub"},{"line_number":177,"context_line":"    echo \"GRUB_TIMEOUT\u003d${DIB_GRUB_TIMEOUT:-5}\" \u003e\u003e/etc/default/grub"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f79a3b5_8a3e1f89","line":174,"in_reply_to":"5f7c97a3_b0a9b88f","updated":"2018-08-10 05:28:54.000000000","message":"That is what I was talking about\n\nHowever, looking at these again, I\u0027d agree with the original premise that most should just be overwritten (doesn\u0027t make sense to append to a root device, but maybe it does to the command-line).  It\u0027s probably better to be consistent and just overwrite it all.\n\nI don\u0027t think we need to keep the .bak file in the image, so like to see that removed, and a comment above this to make it clear we\u0027re quite intentionally clearing all this out.  Then I\u0027d be ok with it.","commit_id":"248d284656aaba9e43081d81dcea8e4fb5249bb2"}]}