)]}'
{"diskimage_builder/block_device/blockdevice.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"380739960fa239b78fce9f43d653682ad3e3b02f","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                        # change labels to uppercase, otherwise the contents"},{"line_number":374,"context_line":"                        # of /etc/fstab do not match the contents on lsblk"},{"line_number":375,"context_line":"                        # causing failures"},{"line_number":376,"context_line":"                        diskid \u003d diskid.upper()"},{"line_number":377,"context_line":"                else:"},{"line_number":378,"context_line":"                    diskid \u003d \"UUID\u003d%s\" % fs_val[\u0027uuid\u0027]"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_751ddb75","line":376,"updated":"2018-06-19 05:25:51.000000000","message":"i really don\u0027t feel like this is generically correct?  \n\nThis must be an artifact of \"mkfs.vfat -n mylabel\" actually labeling things \"MYLABEL\"?  where is the label (i.e. fs_val[\u0027label\u0027] even coming from?)\n\nIn that case, I\u0027d think the thing to do is set it to uppercase in diskimage_builder/block_device/level2/mkfs.py, but only for the vfat case?\n\nI notice on my systems, my /boot/efi partition actually has a UUID in fstab.  I\u0027m guessing this is based on the \"serial number\" for vfat which we don\u0027t set (set via mkfs \"-i\"?)\n\nI\u0027m thinking probably we should be setting a UUID anyway?","commit_id":"38a8e716be1146033fcf23f7f5168f422ec91118"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"9ccbb61f59a387b83aa8a53b279c12482b5735e4","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                        # change labels to uppercase, otherwise the contents"},{"line_number":374,"context_line":"                        # of /etc/fstab do not match the contents on lsblk"},{"line_number":375,"context_line":"                        # causing failures"},{"line_number":376,"context_line":"                        diskid \u003d diskid.upper()"},{"line_number":377,"context_line":"                else:"},{"line_number":378,"context_line":"                    diskid \u003d \"UUID\u003d%s\" % fs_val[\u0027uuid\u0027]"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0bc7a466","line":376,"in_reply_to":"5f7c97a3_751ddb75","updated":"2018-06-19 06:50:42.000000000","message":"For fat/vfat we need to identify the filesystem with label, as there is no way for mkfs to set the UUID (we need more tools with more dependencies). So that\u0027s why we used the label to identify it. But there is that conversion to uppercase needed.","commit_id":"38a8e716be1146033fcf23f7f5168f422ec91118"}]}