)]}'
{"diskimage_builder/elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"52196f3f93f5c7130d09e735e35894c0e9b19381","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    fi"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    # Retrieve root filesystem mount point to check if it is LVM based"},{"line_number":199,"context_line":"    ROOTFS\u003d$(mount -v | grep \u0027 on / \u0027)"},{"line_number":200,"context_line":"    # Standard filesystems are mounted as /dev/mapper/loop* within DIB"},{"line_number":201,"context_line":"    # so we need to exclude this case"},{"line_number":202,"context_line":"    if echo \"$ROOTFS\" | grep -qv \u0027/dev/mapper/loop\u0027; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_8baa6f81","line":199,"updated":"2018-06-23 16:50:21.000000000","message":"This fact is already known to the block device layer. Why don\u0027t you query there for this info? (are you really sure that you don\u0027t get this output for other scenarios like md devices?)\n\nIn addition: the output of mount is not specified. It might change at any time.  If you really want to check for mount points, please use /proc/mount.","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"4f2a04515a9c05dac088b6216a6418118d6b0002","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    fi"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    # Retrieve root filesystem mount point to check if it is LVM based"},{"line_number":199,"context_line":"    ROOTFS\u003d$(mount -v | grep \u0027 on / \u0027)"},{"line_number":200,"context_line":"    # Standard filesystems are mounted as /dev/mapper/loop* within DIB"},{"line_number":201,"context_line":"    # so we need to exclude this case"},{"line_number":202,"context_line":"    if echo \"$ROOTFS\" | grep -qv \u0027/dev/mapper/loop\u0027; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_6f983668","line":199,"in_reply_to":"5f7c97a3_8baa6f81","updated":"2018-06-25 06:02:33.000000000","message":"I think I kind of get your point about this being already known by the block device layer but could you point me to other part of the code for proper querying of this please ? However if I query this what is the point of querying /proc/mount ?\nI agree that relying on /proc/mount is a way better idea knowing that mount does not have a reliable output format. Thanks for pointing this out","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"52196f3f93f5c7130d09e735e35894c0e9b19381","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    # Retrieve root filesystem mount point to check if it is LVM based"},{"line_number":199,"context_line":"    ROOTFS\u003d$(mount -v | grep \u0027 on / \u0027)"},{"line_number":200,"context_line":"    # Standard filesystems are mounted as /dev/mapper/loop* within DIB"},{"line_number":201,"context_line":"    # so we need to exclude this case"},{"line_number":202,"context_line":"    if echo \"$ROOTFS\" | grep -qv \u0027/dev/mapper/loop\u0027; then"},{"line_number":203,"context_line":"        # LVM based filesystems are mounted as /dev/mapper/\u003cVG_name\u003e-\u003cLV-NAME\u003e within DIB"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_4b90d74e","line":200,"updated":"2018-06-23 16:50:21.000000000","message":"This comment does not really help, because it states exactly what the next code line. It would be helpful if you describe *what* you want to archive (and not how).\n(I know this kind of comment - because I often do this as well ;-) )","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"4f2a04515a9c05dac088b6216a6418118d6b0002","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    # Retrieve root filesystem mount point to check if it is LVM based"},{"line_number":199,"context_line":"    ROOTFS\u003d$(mount -v | grep \u0027 on / \u0027)"},{"line_number":200,"context_line":"    # Standard filesystems are mounted as /dev/mapper/loop* within DIB"},{"line_number":201,"context_line":"    # so we need to exclude this case"},{"line_number":202,"context_line":"    if echo \"$ROOTFS\" | grep -qv \u0027/dev/mapper/loop\u0027; then"},{"line_number":203,"context_line":"        # LVM based filesystems are mounted as /dev/mapper/\u003cVG_name\u003e-\u003cLV-NAME\u003e within DIB"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_0fa18295","line":200,"in_reply_to":"5f7c97a3_4b90d74e","updated":"2018-06-25 06:02:33.000000000","message":"Fully understand, will do","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"52196f3f93f5c7130d09e735e35894c0e9b19381","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        # LVM based filesystems are mounted as /dev/mapper/\u003cVG_name\u003e-\u003cLV-NAME\u003e within DIB"},{"line_number":204,"context_line":"        if echo \"$ROOTFS\" | grep -q \u0027/dev/mapper/\u0027; then"},{"line_number":205,"context_line":"            # Check if initramfs-tools are installed"},{"line_number":206,"context_line":"            if [ ! -d /etc/initramfs-tools ]; then"},{"line_number":207,"context_line":"                echo \"You must have initramfs-tools installed for LVM based root filesystem to work properly\""},{"line_number":208,"context_line":"                exit 1"},{"line_number":209,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_ab888b21","line":206,"updated":"2018-06-23 16:50:21.000000000","message":"Hmmm - this should IMHO part of an extra script.\nBecause not all distributions always use initramfs tools for building the initial ramfs.  Maybe this should go into the debootstrap element.","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"4f2a04515a9c05dac088b6216a6418118d6b0002","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        # LVM based filesystems are mounted as /dev/mapper/\u003cVG_name\u003e-\u003cLV-NAME\u003e within DIB"},{"line_number":204,"context_line":"        if echo \"$ROOTFS\" | grep -q \u0027/dev/mapper/\u0027; then"},{"line_number":205,"context_line":"            # Check if initramfs-tools are installed"},{"line_number":206,"context_line":"            if [ ! -d /etc/initramfs-tools ]; then"},{"line_number":207,"context_line":"                echo \"You must have initramfs-tools installed for LVM based root filesystem to work properly\""},{"line_number":208,"context_line":"                exit 1"},{"line_number":209,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_efd1a6f9","line":206,"in_reply_to":"5f7c97a3_ab888b21","updated":"2018-06-25 06:02:33.000000000","message":"agreed as I was myself using dracut package with dracut-regenerate element for this purpose on Ubuntu xenial which worked for the initial image to boot but then if you updated the image with a package which removed dracut to install initramfs-tools instead (any kernel module like overlayroot for instance) because this is the default for Ubuntu xenial then the image does not boot anymore\nHowever I do not see how this check/code could go into another DIB element, do you have other examples of DIB code which I could refer to please ?","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"52196f3f93f5c7130d09e735e35894c0e9b19381","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            fi"},{"line_number":210,"context_line":"            # Check if system supports LVM"},{"line_number":211,"context_line":"            if ! type pvs \u003e/dev/null 2\u003e\u00261; then"},{"line_number":212,"context_line":"                echo \"You must have lvm2 package installed for LVM based root filesystem to work properly\""},{"line_number":213,"context_line":"                exit 1"},{"line_number":214,"context_line":"            fi"},{"line_number":215,"context_line":"            # Check for appropriate filesystem support (for fsck)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_6b7ef31b","line":212,"updated":"2018-06-23 16:50:21.000000000","message":"I\u0027m not sure about this error message: coming to this point requires that the lvm package is installed and usable (this is the way, all the parts of the LVM are created.\n\nI could imagine that this is like an \u0027assert\u0027 but then the error message is misleading: not the user but the programmer should be informed.","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"4f2a04515a9c05dac088b6216a6418118d6b0002","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            fi"},{"line_number":210,"context_line":"            # Check if system supports LVM"},{"line_number":211,"context_line":"            if ! type pvs \u003e/dev/null 2\u003e\u00261; then"},{"line_number":212,"context_line":"                echo \"You must have lvm2 package installed for LVM based root filesystem to work properly\""},{"line_number":213,"context_line":"                exit 1"},{"line_number":214,"context_line":"            fi"},{"line_number":215,"context_line":"            # Check for appropriate filesystem support (for fsck)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_cf714a47","line":212,"in_reply_to":"5f7c97a3_6b7ef31b","updated":"2018-06-25 06:02:33.000000000","message":"Concerning the 1st part of your comment and even though I agree that the LVM partitions are created at this point all the various tests I have been carrying around demonstrated that if I do not check for this and the lvm2 package is not included in the images (which provides the pvs command) then the image will not boot\n\nAs for the second part of your comment, I do not get your point differentiating the user and programmer. Could you please elaborate ?","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"52196f3f93f5c7130d09e735e35894c0e9b19381","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                exit 1"},{"line_number":214,"context_line":"            fi"},{"line_number":215,"context_line":"            # Check for appropriate filesystem support (for fsck)"},{"line_number":216,"context_line":"            FSTYPE\u003d$(echo $ROOTFS | awk \u0027{print $5}\u0027)"},{"line_number":217,"context_line":"            if ! type fsck.$FSTYPE \u003e/dev/null 2\u003e\u00261; then"},{"line_number":218,"context_line":"                echo \"You must have utility package for $FSTYPE filesystem installed for LVM based root filesystem to work properly (fsck.$FSTYPE is missing)\""},{"line_number":219,"context_line":"                exit 1"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_2b7c7b1e","line":216,"updated":"2018-06-23 16:50:21.000000000","message":"Same applies here: it is (practical) not possible to reach this point if the appropriate file system support is not available - because it was just created some seconds ago.","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"4f2a04515a9c05dac088b6216a6418118d6b0002","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                exit 1"},{"line_number":214,"context_line":"            fi"},{"line_number":215,"context_line":"            # Check for appropriate filesystem support (for fsck)"},{"line_number":216,"context_line":"            FSTYPE\u003d$(echo $ROOTFS | awk \u0027{print $5}\u0027)"},{"line_number":217,"context_line":"            if ! type fsck.$FSTYPE \u003e/dev/null 2\u003e\u00261; then"},{"line_number":218,"context_line":"                echo \"You must have utility package for $FSTYPE filesystem installed for LVM based root filesystem to work properly (fsck.$FSTYPE is missing)\""},{"line_number":219,"context_line":"                exit 1"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_afbbaec1","line":216,"in_reply_to":"5f7c97a3_2b7c7b1e","updated":"2018-06-25 06:02:33.000000000","message":"I can assure you again that i have made a lot of tests last week and even though the filesystem are perfectly created the utilities for fsck can be missing (like when using xfs you need to have xfsprogs)","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3f9e0a40dd0805692d0f32d02fedfa72d5bc07d3","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            if ! type fsck.$FSTYPE \u003e/dev/null 2\u003e\u00261; then"},{"line_number":218,"context_line":"                echo \"You must have utility package for $FSTYPE filesystem installed for LVM based root filesystem to work properly (fsck.$FSTYPE is missing)\""},{"line_number":219,"context_line":"                exit 1"},{"line_number":220,"context_line":"            fi"},{"line_number":221,"context_line":"            # Change the current GRUB_DEVICE from LABEL\u003d(cloud)img-rootfs to /dev/mapper/..."},{"line_number":222,"context_line":"            sed -i -e \"s?^GRUB_DEVICE\u003d.*?GRUB_DEVICE\u003d$(echo $ROOTFS | awk \u0027{print $1}\u0027)?\" /etc/default/grub"},{"line_number":223,"context_line":"            # This is required for LVM2 driver to be included in the"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_0718bdd0","line":220,"updated":"2018-06-21 10:42:55.000000000","message":"my first thought is that is all this really best homed in the bootloader?  This is already a byzantine mess with old extlinux stuff etc.","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"8dd87cbc5f5060fb83c6cd5bfd1cac0ef4b33330","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            if ! type fsck.$FSTYPE \u003e/dev/null 2\u003e\u00261; then"},{"line_number":218,"context_line":"                echo \"You must have utility package for $FSTYPE filesystem installed for LVM based root filesystem to work properly (fsck.$FSTYPE is missing)\""},{"line_number":219,"context_line":"                exit 1"},{"line_number":220,"context_line":"            fi"},{"line_number":221,"context_line":"            # Change the current GRUB_DEVICE from LABEL\u003d(cloud)img-rootfs to /dev/mapper/..."},{"line_number":222,"context_line":"            sed -i -e \"s?^GRUB_DEVICE\u003d.*?GRUB_DEVICE\u003d$(echo $ROOTFS | awk \u0027{print $1}\u0027)?\" /etc/default/grub"},{"line_number":223,"context_line":"            # This is required for LVM2 driver to be included in the"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_a2c77745","line":220,"in_reply_to":"5f7c97a3_0718bdd0","updated":"2018-06-21 11:22:43.000000000","message":"From everything I have been reading on the internet lately to try to fix this I think that it is best to leave it there for now","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3f9e0a40dd0805692d0f32d02fedfa72d5bc07d3","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                exit 1"},{"line_number":220,"context_line":"            fi"},{"line_number":221,"context_line":"            # Change the current GRUB_DEVICE from LABEL\u003d(cloud)img-rootfs to /dev/mapper/..."},{"line_number":222,"context_line":"            sed -i -e \"s?^GRUB_DEVICE\u003d.*?GRUB_DEVICE\u003d$(echo $ROOTFS | awk \u0027{print $1}\u0027)?\" /etc/default/grub"},{"line_number":223,"context_line":"            # This is required for LVM2 driver to be included in the"},{"line_number":224,"context_line":"            # ramdisk of the image."},{"line_number":225,"context_line":"            echo \"lvm2\" \u003e\u003e /etc/initramfs-tools/modules"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_67541155","line":222,"updated":"2018-06-21 10:42:55.000000000","message":"would we be better off moving to GRUB_DEVICE_UUID?  we might have to export the ROOTFS uuid, but it might be overall more reliable than this?","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"52196f3f93f5c7130d09e735e35894c0e9b19381","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                exit 1"},{"line_number":220,"context_line":"            fi"},{"line_number":221,"context_line":"            # Change the current GRUB_DEVICE from LABEL\u003d(cloud)img-rootfs to /dev/mapper/..."},{"line_number":222,"context_line":"            sed -i -e \"s?^GRUB_DEVICE\u003d.*?GRUB_DEVICE\u003d$(echo $ROOTFS | awk \u0027{print $1}\u0027)?\" /etc/default/grub"},{"line_number":223,"context_line":"            # This is required for LVM2 driver to be included in the"},{"line_number":224,"context_line":"            # ramdisk of the image."},{"line_number":225,"context_line":"            echo \"lvm2\" \u003e\u003e /etc/initramfs-tools/modules"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_cb92a74b","line":222,"in_reply_to":"5f7c97a3_421c63c1","updated":"2018-06-23 16:50:21.000000000","message":"Tested this: GRUB_DEVICE\u003d/dev/mapper/... works out of the box.  Also did not manage to use UUID.","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"8dd87cbc5f5060fb83c6cd5bfd1cac0ef4b33330","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                exit 1"},{"line_number":220,"context_line":"            fi"},{"line_number":221,"context_line":"            # Change the current GRUB_DEVICE from LABEL\u003d(cloud)img-rootfs to /dev/mapper/..."},{"line_number":222,"context_line":"            sed -i -e \"s?^GRUB_DEVICE\u003d.*?GRUB_DEVICE\u003d$(echo $ROOTFS | awk \u0027{print $1}\u0027)?\" /etc/default/grub"},{"line_number":223,"context_line":"            # This is required for LVM2 driver to be included in the"},{"line_number":224,"context_line":"            # ramdisk of the image."},{"line_number":225,"context_line":"            echo \"lvm2\" \u003e\u003e /etc/initramfs-tools/modules"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_421c63c1","line":222,"in_reply_to":"5f7c97a3_67541155","updated":"2018-06-21 11:22:43.000000000","message":"I asked myself exactly the same thing. However what made me keep it the way it is is because this is the way ubuntu \"standard\" installer does it this way. What I have tested to ensure this is create a preseed file which partition the disks automatically the exact same way I have set in DIB_BLOCK_DEVICE_CONFIG and let it run to see what is produced in the end. I also tried separated /boot partition as well as /boot co-located with / partition which produced the same results.\nhttp://www.olivierbourdon.com/preseed_master-xenial_min.cfg","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"4f2a04515a9c05dac088b6216a6418118d6b0002","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                exit 1"},{"line_number":220,"context_line":"            fi"},{"line_number":221,"context_line":"            # Change the current GRUB_DEVICE from LABEL\u003d(cloud)img-rootfs to /dev/mapper/..."},{"line_number":222,"context_line":"            sed -i -e \"s?^GRUB_DEVICE\u003d.*?GRUB_DEVICE\u003d$(echo $ROOTFS | awk \u0027{print $1}\u0027)?\" /etc/default/grub"},{"line_number":223,"context_line":"            # This is required for LVM2 driver to be included in the"},{"line_number":224,"context_line":"            # ramdisk of the image."},{"line_number":225,"context_line":"            echo \"lvm2\" \u003e\u003e /etc/initramfs-tools/modules"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_6fb116e0","line":222,"in_reply_to":"5f7c97a3_cb92a74b","updated":"2018-06-25 06:02:33.000000000","message":"thanks for testing this","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"52196f3f93f5c7130d09e735e35894c0e9b19381","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            sed -i -e \"s?^GRUB_DEVICE\u003d.*?GRUB_DEVICE\u003d$(echo $ROOTFS | awk \u0027{print $1}\u0027)?\" /etc/default/grub"},{"line_number":223,"context_line":"            # This is required for LVM2 driver to be included in the"},{"line_number":224,"context_line":"            # ramdisk of the image."},{"line_number":225,"context_line":"            echo \"lvm2\" \u003e\u003e /etc/initramfs-tools/modules"},{"line_number":226,"context_line":"            # We need to regenerated the init ramdisk at this point"},{"line_number":227,"context_line":"            update-initramfs -u -v"},{"line_number":228,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_6b93534f","line":225,"updated":"2018-06-23 16:50:21.000000000","message":"Is this really needed? At least on my systems it works without.","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"4f2a04515a9c05dac088b6216a6418118d6b0002","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            sed -i -e \"s?^GRUB_DEVICE\u003d.*?GRUB_DEVICE\u003d$(echo $ROOTFS | awk \u0027{print $1}\u0027)?\" /etc/default/grub"},{"line_number":223,"context_line":"            # This is required for LVM2 driver to be included in the"},{"line_number":224,"context_line":"            # ramdisk of the image."},{"line_number":225,"context_line":"            echo \"lvm2\" \u003e\u003e /etc/initramfs-tools/modules"},{"line_number":226,"context_line":"            # We need to regenerated the init ramdisk at this point"},{"line_number":227,"context_line":"            update-initramfs -u -v"},{"line_number":228,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_2ff55e83","line":225,"in_reply_to":"5f7c97a3_6b93534f","updated":"2018-06-25 06:02:33.000000000","message":"May be newer versions of initramfs-tools are smarter now or they force bundle lvm2 but this is the way is is supposed to be done if I read the manual correctly","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"52196f3f93f5c7130d09e735e35894c0e9b19381","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            # ramdisk of the image."},{"line_number":225,"context_line":"            echo \"lvm2\" \u003e\u003e /etc/initramfs-tools/modules"},{"line_number":226,"context_line":"            # We need to regenerated the init ramdisk at this point"},{"line_number":227,"context_line":"            update-initramfs -u -v"},{"line_number":228,"context_line":"        fi"},{"line_number":229,"context_line":"    fi"},{"line_number":230,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_8b982f69","line":227,"updated":"2018-06-23 16:50:21.000000000","message":"Also in the update-initramfs domain.\n\nWant to point you to:\nhttps://review.openstack.org/#/c/562004/\nwhich mostly reverted a patch which exactly called this command.\nThe patch was reverted, because it introduced some unknown problem.","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"4f2a04515a9c05dac088b6216a6418118d6b0002","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            # ramdisk of the image."},{"line_number":225,"context_line":"            echo \"lvm2\" \u003e\u003e /etc/initramfs-tools/modules"},{"line_number":226,"context_line":"            # We need to regenerated the init ramdisk at this point"},{"line_number":227,"context_line":"            update-initramfs -u -v"},{"line_number":228,"context_line":"        fi"},{"line_number":229,"context_line":"    fi"},{"line_number":230,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_af2e4ef7","line":227,"in_reply_to":"5f7c97a3_8b982f69","updated":"2018-06-25 06:02:33.000000000","message":"Will have a look at this","commit_id":"d18ee4ea1cee940b5a3da5fd774aa9a436882a9e"}],"diskimage_builder/elements/lvm/README.rst":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"dbf65a8373b5f2187e848f798b34abacd1a71929","unresolved":false,"context_lines":[{"line_number":8,"context_line":"properly."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"On CentOS like distributions, you should use dracut-regenerate"},{"line_number":11,"context_line":"element instead of current lvm element."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_95934e4e","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":7},"updated":"2018-07-09 11:10:04.000000000","message":"So this is for debian-like OS? maybe you can specify it more exactly","commit_id":"2eeb72bcf7ace6273516f3272e6f1636c374d81a"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"829c99c6143e5f39270c646b756236ed955a2a34","unresolved":false,"context_lines":[{"line_number":8,"context_line":"properly."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"On CentOS like distributions, you should use dracut-regenerate"},{"line_number":11,"context_line":"element instead of current lvm element."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_9a6db69a","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":7},"in_reply_to":"5f7c97a3_95934e4e","updated":"2018-07-09 14:10:22.000000000","message":"This is done above at line 4 ;-)","commit_id":"2eeb72bcf7ace6273516f3272e6f1636c374d81a"}],"diskimage_builder/elements/lvm/finalise.d/60-bootloader":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"dbf65a8373b5f2187e848f798b34abacd1a71929","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        fi"},{"line_number":44,"context_line":"        # Check if system supports LVM"},{"line_number":45,"context_line":"        if ! type pvs \u003e/dev/null 2\u003e\u00261; then"},{"line_number":46,"context_line":"            echo \"You must have lvm2 package installed for LVM based root filesystem to work properly\""},{"line_number":47,"context_line":"            exit 1"},{"line_number":48,"context_line":"        fi"},{"line_number":49,"context_line":"        # Check for appropriate filesystem support (for fsck)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5f7c97a3_b5e44ae0","line":46,"range":{"start_line":46,"start_character":12,"end_line":46,"end_character":16},"updated":"2018-07-09 11:10:04.000000000","message":"You could specify initramfs-tools and lvm2 dependencies on the readme","commit_id":"2eeb72bcf7ace6273516f3272e6f1636c374d81a"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"829c99c6143e5f39270c646b756236ed955a2a34","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        fi"},{"line_number":44,"context_line":"        # Check if system supports LVM"},{"line_number":45,"context_line":"        if ! type pvs \u003e/dev/null 2\u003e\u00261; then"},{"line_number":46,"context_line":"            echo \"You must have lvm2 package installed for LVM based root filesystem to work properly\""},{"line_number":47,"context_line":"            exit 1"},{"line_number":48,"context_line":"        fi"},{"line_number":49,"context_line":"        # Check for appropriate filesystem support (for fsck)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5f7c97a3_5a639eab","line":46,"range":{"start_line":46,"start_character":12,"end_line":46,"end_character":16},"in_reply_to":"5f7c97a3_b5e44ae0","updated":"2018-07-09 14:10:22.000000000","message":"Totally agree, will do","commit_id":"2eeb72bcf7ace6273516f3272e6f1636c374d81a"}],"diskimage_builder/elements/lvm/root.d/10-lvm-check-distro":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"dbf65a8373b5f2187e848f798b34abacd1a71929","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    exit 1"},{"line_number":12,"context_line":"fi"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"if [ \u0027xenial\u0027 !\u003d $DIB_RELEASE ]; then"},{"line_number":15,"context_line":"    echo \"Only trusty is supported for LVM support. The DIB_RELEASE is set to $DIB_RELEASE\""},{"line_number":16,"context_line":"    exit 1"},{"line_number":17,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5f7c97a3_d5046680","line":14,"range":{"start_line":14,"start_character":2,"end_line":14,"end_character":3},"updated":"2018-07-09 11:10:04.000000000","message":"You say trusty but you compare to xenial here","commit_id":"2eeb72bcf7ace6273516f3272e6f1636c374d81a"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"829c99c6143e5f39270c646b756236ed955a2a34","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    exit 1"},{"line_number":12,"context_line":"fi"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"if [ \u0027xenial\u0027 !\u003d $DIB_RELEASE ]; then"},{"line_number":15,"context_line":"    echo \"Only trusty is supported for LVM support. The DIB_RELEASE is set to $DIB_RELEASE\""},{"line_number":16,"context_line":"    exit 1"},{"line_number":17,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5f7c97a3_9af296e2","line":14,"range":{"start_line":14,"start_character":2,"end_line":14,"end_character":3},"in_reply_to":"5f7c97a3_d5046680","updated":"2018-07-09 14:10:22.000000000","message":"Good catch, forgot to modify this from the stuff I derived this code from. Will fix","commit_id":"2eeb72bcf7ace6273516f3272e6f1636c374d81a"}]}