)]}'
{"id":"openstack%2Fdiskimage-builder~59621","triplet_id":"openstack%2Fdiskimage-builder~master~I88bcdba31b5afa0cb00f61f5529e2d4715644a7c","project":"openstack/diskimage-builder","branch":"master","hashtags":[],"change_id":"I88bcdba31b5afa0cb00f61f5529e2d4715644a7c","subject":"Revert \"Store DIB_* only env variables\"","status":"ABANDONED","created":"2013-12-03 05:22:24.000000000","updated":"2013-12-04 01:15:40.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7d6052182b2fb0547c8236303ffb2546118eb811","_number":59621,"virtual_id_number":59621,"owner":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2013-12-03 05:23:05.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2013-12-03 08:05:13.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},{"value":-1,"date":"2013-12-03 06:31:29.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-12-03 05:23:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2013-12-03 06:31:29.000000000","updated_by":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"reviewer":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"state":"REVIEWER"},{"updated":"2013-12-03 08:05:13.000000000","updated_by":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"reviewer":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"state":"REVIEWER"}],"messages":[{"id":"a335df4a87d0ebd9db5ac8079d53200418e11a8e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-03 05:23:05.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-diskimage-builder-pep8 http://logs.openstack.org/21/59621/1/check/gate-diskimage-builder-pep8/2d427cc : SUCCESS in 26s\n- gate-diskimage-builder-python26 http://logs.openstack.org/21/59621/1/check/gate-diskimage-builder-python26/c0e68dc : SUCCESS in 30s\n- gate-diskimage-builder-python27 http://logs.openstack.org/21/59621/1/check/gate-diskimage-builder-python27/aac2d09 : SUCCESS in 30s\n","accounts_in_message":[],"_revision_number":1},{"id":"cf13d397fbeee0e4b87fbf2cfbde245133c7b7f0","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-12-03 06:31:29.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nI think it\u0027s completely inappropriate for stuff like this:\n\n declare -x GNOME_KEYRING_CONTROL\u003d\"/run/user/markmc/keyring-UiPefJ\"\n declare -x GNOME_KEYRING_PID\u003d\"1758\"\n declare -x GPGKEY\u003d\"0x65091615C98A3808\"\n declare -x GPG_AGENT_INFO\u003d\"/run/user/markmc/keyring-UiPefJ/gpg:0:1\"\n\nto end up in an image. Sure it\u0027s not sensitive (that\u0027s why I\u0027m happy to paste it here) but it\u0027s still not the sort of stuff you\u0027d feel comfortable being put into an image you might share with others. It will certainly come as a surprise to people, and it came as a surprise to me.\n\nReproducible builds is, of course, important and capturing any env variable which has an influence over the build would be great ... but capturing all just seems very wrong.","accounts_in_message":[],"_revision_number":1},{"id":"21fed8b8d5198114de0fdce1f16baa8ae09c7619","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-12-03 08:05:13.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nI agree with Mark, it\u0027s ok to capture env variables, but there is too much garbage been stored.","accounts_in_message":[],"_revision_number":1},{"id":"15d36eac79f0a2bfc18fe06fc9fd352f9a89a1e0","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2013-12-04 01:15:40.000000000","message":"Patch Set 1: Abandoned\n\nThis is missing the change-id; https://review.openstack.org/#/c/59622/ is where we should address this.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"88bcdba31b5afa0cb00f61f5529e2d4715644a7c","revisions":{"88bcdba31b5afa0cb00f61f5529e2d4715644a7c":{"kind":"REWORK","_number":1,"created":"2013-12-03 05:22:24.000000000","uploader":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"ref":"refs/changes/21/59621/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/21/59621/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/21/59621/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/21/59621/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/21/59621/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/21/59621/1"}}},"commit":{"parents":[{"commit":"7c2d1b2295fb2f6f92896795e36f8f49e6f7d55a","subject":"Store DIB_* only env variables","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/7c2d1b2295fb2f6f92896795e36f8f49e6f7d55a"}]}],"author":{"name":"lifeless","email":"robertc@robertcollins.net","date":"2013-12-03 05:22:24.000000000","tz":0},"committer":{"name":"Gerrit Code Review","email":"review@openstack.org","date":"2013-12-03 05:22:24.000000000","tz":0},"subject":"Revert \"Store DIB_* only env variables\"","message":"Revert \"Store DIB_* only env variables\"\n\nThis reverts commit 7c2d1b2295fb2f6f92896795e36f8f49e6f7d55a\n\nWe want to capture aggressively to aid reproducability and diagnosing issues. Environment variables are not suitable storage for credentials, it\u0027s not up to us to police that.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/88bcdba31b5afa0cb00f61f5529e2d4715644a7c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/88bcdba31b5afa0cb00f61f5529e2d4715644a7c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}