)]}'
{"elements/deploy-ironic/binary-deps.d/deploy-ironic":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"18f02614909ad9abe8c36c287ef9a77e4383a04d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"busybox"},{"line_number":2,"context_line":"tgtd"},{"line_number":3,"context_line":"tgtadm"},{"line_number":4,"context_line":"curl"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F97uc%3D","line":1,"updated":"2013-12-04 15:03:54.000000000","message":"nit: please sort this alphabetically","commit_id":"a5a749bc578eda9e192c75ff2f847ac29c9b721c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b1af77a7a2cf8c8ff14778f319dea59ff61a4260","unresolved":false,"context_lines":[{"line_number":1,"context_line":"busybox"},{"line_number":2,"context_line":"tgtd"},{"line_number":3,"context_line":"tgtadm"},{"line_number":4,"context_line":"curl"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F96TU%3D","line":1,"in_reply_to":"AAAATn%2F97uc%3D","updated":"2013-12-04 16:00:34.000000000","message":"Done","commit_id":"a5a749bc578eda9e192c75ff2f847ac29c9b721c"}],"elements/deploy-ironic/init.d/80-deploy-ironic":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"18f02614909ad9abe8c36c287ef9a77e4383a04d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"fi"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"t\u003d0"},{"line_number":9,"context_line":"while ! target_disk\u003d$(find_disk \"$DISK\"); do"},{"line_number":10,"context_line":"  if [ $t -eq 10 ]; then"},{"line_number":11,"context_line":"    break"},{"line_number":12,"context_line":"  fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F96ho%3D","line":9,"updated":"2013-12-04 15:03:54.000000000","message":"(opinion) I prefer to enclose condition into [ ], but this seems to work fine","commit_id":"a5a749bc578eda9e192c75ff2f847ac29c9b721c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"18f02614909ad9abe8c36c287ef9a77e4383a04d","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"TOKEN_FILE\u003dtoken-$DEPLOYMENT_ID"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"if tftp -r /tftpboot/$TOKEN_FILE -g $BOOT_SERVER"},{"line_number":32,"context_line":"then TOKEN_HEADER\u003d\"-H \u0027X-Auth-Token: `cat $TOKEN_FILE`\u0027\""},{"line_number":33,"context_line":"else TOKEN_HEADER\u003d\"\""},{"line_number":34,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F96hg%3D","line":31,"updated":"2013-12-04 15:03:54.000000000","message":"ditto","commit_id":"a5a749bc578eda9e192c75ff2f847ac29c9b721c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"18f02614909ad9abe8c36c287ef9a77e4383a04d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"DATA\u003d\"\u0027{\\\"address\\\":\\\"$BOOT_IP_ADDRESS\\\",\\\"key\\\":\\\"$DEPLOYMENT_KEY\\\",\\\"iqn\\\":\\\"$ISCSI_TARGET_IQN\\\",\\\"error\\\":\\\"$FIRST_ERR_MSG\\\"}\u0027\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"echo \"request Ironic API to deploy image\""},{"line_number":40,"context_line":"curl $PARAMS $TOKEN_HEADER -d $DATA $IRONIC_API_URL/v1/nodes/$DEPLOYMENT_ID/vendor_passthru/pass_deploy_info"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"echo \"waiting for notice of complete\""},{"line_number":43,"context_line":"nc -l -p 10000"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F963Q%3D","line":40,"updated":"2013-12-04 15:03:54.000000000","message":"I wonder, if we should specify API version here or in ironic_api_url","commit_id":"a5a749bc578eda9e192c75ff2f847ac29c9b721c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b1af77a7a2cf8c8ff14778f319dea59ff61a4260","unresolved":false,"context_lines":[{"line_number":37,"context_line":"DATA\u003d\"\u0027{\\\"address\\\":\\\"$BOOT_IP_ADDRESS\\\",\\\"key\\\":\\\"$DEPLOYMENT_KEY\\\",\\\"iqn\\\":\\\"$ISCSI_TARGET_IQN\\\",\\\"error\\\":\\\"$FIRST_ERR_MSG\\\"}\u0027\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"echo \"request Ironic API to deploy image\""},{"line_number":40,"context_line":"curl $PARAMS $TOKEN_HEADER -d $DATA $IRONIC_API_URL/v1/nodes/$DEPLOYMENT_ID/vendor_passthru/pass_deploy_info"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"echo \"waiting for notice of complete\""},{"line_number":43,"context_line":"nc -l -p 10000"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F96Ss%3D","line":40,"in_reply_to":"AAAATn%2F963Q%3D","updated":"2013-12-04 16:00:34.000000000","message":"Now only v1 supported, but default \u003d\u003d v1 should works.","commit_id":"a5a749bc578eda9e192c75ff2f847ac29c9b721c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"18f02614909ad9abe8c36c287ef9a77e4383a04d","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"echo \"request Ironic API to deploy image\""},{"line_number":40,"context_line":"curl $PARAMS $TOKEN_HEADER -d $DATA $IRONIC_API_URL/v1/nodes/$DEPLOYMENT_ID/vendor_passthru/pass_deploy_info"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"echo \"waiting for notice of complete\""},{"line_number":43,"context_line":"nc -l -p 10000"},{"line_number":44,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F96j4%3D","line":41,"updated":"2013-12-04 15:03:54.000000000","message":"(optional, opinion) We could improve readability splitting curl call into multiple lines\n\ncurl \\\n   -X POST \\\n   -H \"Content-Type: application/json\"\n   ...","commit_id":"a5a749bc578eda9e192c75ff2f847ac29c9b721c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b1af77a7a2cf8c8ff14778f319dea59ff61a4260","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"echo \"request Ironic API to deploy image\""},{"line_number":40,"context_line":"curl $PARAMS $TOKEN_HEADER -d $DATA $IRONIC_API_URL/v1/nodes/$DEPLOYMENT_ID/vendor_passthru/pass_deploy_info"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"echo \"waiting for notice of complete\""},{"line_number":43,"context_line":"nc -l -p 10000"},{"line_number":44,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F96Sk%3D","line":41,"in_reply_to":"AAAATn%2F96j4%3D","updated":"2013-12-04 16:00:34.000000000","message":"I think that is good.","commit_id":"a5a749bc578eda9e192c75ff2f847ac29c9b721c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"18f02614909ad9abe8c36c287ef9a77e4383a04d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"curl $PARAMS $TOKEN_HEADER -d $DATA $IRONIC_API_URL/v1/nodes/$DEPLOYMENT_ID/vendor_passthru/pass_deploy_info"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"echo \"waiting for notice of complete\""},{"line_number":43,"context_line":"nc -l -p 10000"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"echo \"stop iSCSI target on $target_disk\""},{"line_number":46,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F964Q%3D","line":43,"updated":"2013-12-04 15:03:54.000000000","message":"oh, nice, busybox seems to have a different version of nc (on my ubuntu machine it is not allowed to use -p together with -l)...","commit_id":"a5a749bc578eda9e192c75ff2f847ac29c9b721c"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"a20b56578f689bd54f8ff60fb58c990e09e07046","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"TOKEN_FILE\u003dtoken-$DEPLOYMENT_ID"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"if tftp -r /tftpboot/$TOKEN_FILE -g $BOOT_SERVER"},{"line_number":32,"context_line":"then TOKEN_HEADER\u003d\"-H \u0027X-Auth-Token: `cat $TOKEN_FILE`\u0027\""},{"line_number":33,"context_line":"else TOKEN_HEADER\u003d\"\""},{"line_number":34,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATn%2F95ZI%3D","line":31,"updated":"2013-12-04 18:49:20.000000000","message":"I don\u0027t believe the -r -g options exist. At least they don\u0027t on Fedora RHEL...","commit_id":"bf222fe7bc85f25d7f8ac63b549b87db89984e1b"}]}