)]}'
{"diskimage_builder/elements/pip-and-virtualenv/install.d/pip-and-virtualenv-source-install/04-install-pip":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"50d3a4cc12b8dffb53c1f645bb5e3c381912c82d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    # assume that\u0027s the case"},{"line_number":65,"context_line":"    if [[ $DISTRO_NAME \u003d~ (fedora|rhel) ]]; then"},{"line_number":66,"context_line":"        ln -s /usr/bin/pip2 /usr/local/bin/pip"},{"line_number":67,"context_line":"        ln -s /usr/bin/virtualenv-2 /usr/local/bin/virtualenv"},{"line_number":68,"context_line":"        exit 0"},{"line_number":69,"context_line":"    fi"},{"line_number":70,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ffb9cba7_5638959e","line":67,"range":{"start_line":67,"start_character":14,"end_line":67,"end_character":36},"updated":"2019-04-30 15:45:38.000000000","message":"I like that idea! especially as it avoids bringing the operating sytems into \"unsupported\" mode.\n\nThere is only one flaw with this patch: the new systems that are python3 first may not even have python2 installed which means that we need to symlink *3 to unversioned in their cases.\n\nI know for sure that fedora28 can work perfectly without python2, and that it does not have python2 installed in the base image (at least the base container one).\n\nAlternative: add a -f test before the ln to avoid failure if these files do not exist.","commit_id":"625bf8ddca74c640fbc84c6e7f61f2ce9c91ccf4"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"11037df41759cdf499b50ba2fb92ac88068d0e1d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    # assume that\u0027s the case"},{"line_number":65,"context_line":"    if [[ $DISTRO_NAME \u003d~ (fedora|rhel) ]]; then"},{"line_number":66,"context_line":"        ln -s /usr/bin/pip2 /usr/local/bin/pip"},{"line_number":67,"context_line":"        ln -s /usr/bin/virtualenv-2 /usr/local/bin/virtualenv"},{"line_number":68,"context_line":"        exit 0"},{"line_number":69,"context_line":"    fi"},{"line_number":70,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ffb9cba7_f8040f1a","line":67,"range":{"start_line":67,"start_character":14,"end_line":67,"end_character":36},"in_reply_to":"ffb9cba7_5638959e","updated":"2019-05-01 10:03:17.000000000","message":"This will break fedora 29 where python3-virtualenv installs the virtualenv command and there is no virtualenv-3.\n\nSee https://review.opendev.org/#/c/656467/","commit_id":"625bf8ddca74c640fbc84c6e7f61f2ce9c91ccf4"}]}