)]}'
{"diskimage_builder/elements/block-device-efi/finalise.d/49-clean-bsp-partition":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6ea9769e85aea1ef42d9fbeff17f657e8f352f7b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"if [ -b ${DEVICES[BSP]} ]; then"},{"line_number":16,"context_line":"    # zero out the entire partition with 512 byte writes"},{"line_number":17,"context_line":"    # NOTE(jangutter): this command will exit with non-zero status after it has"},{"line_number":18,"context_line":"    # filled the block device."},{"line_number":19,"context_line":"    dd if\u003d/dev/zero of\u003d${DEVICES[BSP]} bs\u003d512 || :"},{"line_number":20,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_daf4465e","line":17,"range":{"start_line":17,"start_character":51,"end_line":17,"end_character":59},"updated":"2019-03-06 15:59:31.000000000","message":"Is it worth setting count\u003d$blocks to avoid the non-zero exit code? I assume we know the BSP device\u0027s size.\n\nThinking it might be nice to know when we have an actual failure with this step.","commit_id":"0e634dcddd816e057ef10982f853ca5baec517be"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b5a298d5c931a218a9e93e0e1bac111329ec0a16","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"if [ -b ${DEVICES[BSP]} ]; then"},{"line_number":16,"context_line":"    # zero out the entire partition with 512 byte writes"},{"line_number":17,"context_line":"    # NOTE(jangutter): this command will exit with non-zero status after it has"},{"line_number":18,"context_line":"    # filled the block device."},{"line_number":19,"context_line":"    dd if\u003d/dev/zero of\u003d${DEVICES[BSP]} bs\u003d512 || :"},{"line_number":20,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_9d39d842","line":17,"range":{"start_line":17,"start_character":51,"end_line":17,"end_character":59},"in_reply_to":"5fc1f717_babdba69","updated":"2019-03-06 16:30:40.000000000","message":"You don\u0027t want to hardcode 8MiB here because the block device layout can be customised.","commit_id":"0e634dcddd816e057ef10982f853ca5baec517be"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"42bd8e275975e0e28a33fad12a9950ee3dfdfc16","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"if [ -b ${DEVICES[BSP]} ]; then"},{"line_number":16,"context_line":"    # zero out the entire partition with 512 byte writes"},{"line_number":17,"context_line":"    # NOTE(jangutter): this command will exit with non-zero status after it has"},{"line_number":18,"context_line":"    # filled the block device."},{"line_number":19,"context_line":"    dd if\u003d/dev/zero of\u003d${DEVICES[BSP]} bs\u003d512 || :"},{"line_number":20,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_babdba69","line":17,"range":{"start_line":17,"start_character":51,"end_line":17,"end_character":59},"in_reply_to":"5fc1f717_daf4465e","updated":"2019-03-06 16:08:59.000000000","message":"Yes, from the partition layout it\u0027s 8MiB. (that\u0027s in diskimage_builder/elements/block-device-efi/block-device-default.yaml )\n\nDo you have a handy way to grab it programmatically, or is hard-coding sufficient?\n\nAdditionally, it\u0027s probably not necessary to zero out the entire disk, cleaning the superblock metadata is enough, but I don\u0027t have a handy, foolproof way of nuking all possible filesystems, raid and lvm.","commit_id":"0e634dcddd816e057ef10982f853ca5baec517be"}]}