)]}'
{"diskimage_builder/lib/disk-image-create":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c08f67e3d887a1a3fa75b11a4ce15d55036a44c2","unresolved":false,"context_lines":[{"line_number":366,"context_line":"if [ -e \"$TMP_HOOKS_PATH/environment.d/10-rhel-distro-name.bash\" ]; then"},{"line_number":367,"context_line":"    source \"$TMP_HOOKS_PATH/environment.d/10-rhel-distro-name.bash\""},{"line_number":368,"context_line":"    if [ \"${DISTRO_NAME}\" \u003d \"rhel\" ] \u0026\u0026 [ \"${DIB_RELEASE}\" \u003d \"8\" ]; then"},{"line_number":369,"context_line":"        DEFAULT_FS_TYPE\u003dxfs"},{"line_number":370,"context_line":"    fi"},{"line_number":371,"context_line":"fi"},{"line_number":372,"context_line":"FS_TYPE\u003d${FS_TYPE:-$DEFAULT_FS_TYPE}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9fb8cfa7_f79c675e","line":369,"updated":"2019-06-06 22:42:51.000000000","message":"Shouldn\u0027t this come in from the environment.d/10-rhel-distro-name.bash script?\n\nHow DIB should be working is it should execute the enviroment.d scripts prior to any filesystem decisions as each operating system element should be able to define it\u0027s filesystem using the exported environment variables.\n\nFor example, environment.d/10-rhel-distro-name.bash should be able to export something like \"FS_TYPE\u003dxfs\" to set the filesystem type for the rhel operating system element.\n\nWe should not be required to have distro specific conditionals in the disk-image-create code.","commit_id":"0fa9353e714c294b4d6b06eff74f707a2a833793"}]}