)]}'
{"diskimage_builder/elements/pypi/pre-install.d/04-configure-pypi-mirror":[{"author":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"change_message_id":"ad36fc26a696c26df5f171a9988a7df87cf36ac4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        output.write(\u0027[global]\\n\u0027)"},{"line_number":55,"context_line":"        output.write(\u0027log \u003d %s/pip.log\\n\u0027 % (home,))"},{"line_number":56,"context_line":"        output.write(\u0027index-url \u003d %s\\n\u0027 % (indices[0],))"},{"line_number":57,"context_line":"        output.write(\u0027trusted-host \u003d  %s\\n\u0027 % urlparse(indices[0]).hostname)"},{"line_number":58,"context_line":"        if retries is not None:"},{"line_number":59,"context_line":"            output.write(\u0027retries \u003d %s\\n\u0027 % retries)"},{"line_number":60,"context_line":"        for index in indices[1:]:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9fb8cfa7_0fd45bbc","line":57,"updated":"2019-06-10 15:52:45.000000000","message":"To keep consistency with the usage of % in the rest of the program, you could write\n  output.write(\u0027trusted-host \u003d  %s\\n\u0027 % (urlparse(indices[0]).hostname,))\nBut then this convention is already inconsistently applied... see two lines below. So feel free to ignore :-)","commit_id":"5250e5f0a6428fa3517806c4680663c102490025"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"aa430a06da039133e21c77d3686bcd134cc7b6ca","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        output.write(\u0027[global]\\n\u0027)"},{"line_number":55,"context_line":"        output.write(\u0027log \u003d %s/pip.log\\n\u0027 % (home,))"},{"line_number":56,"context_line":"        output.write(\u0027index-url \u003d %s\\n\u0027 % (indices[0],))"},{"line_number":57,"context_line":"        output.write(\u0027trusted-host \u003d  %s\\n\u0027 % urlparse(indices[0]).hostname)"},{"line_number":58,"context_line":"        if retries is not None:"},{"line_number":59,"context_line":"            output.write(\u0027retries \u003d %s\\n\u0027 % retries)"},{"line_number":60,"context_line":"        for index in indices[1:]:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9fb8cfa7_58053713","line":57,"in_reply_to":"9fb8cfa7_0fd45bbc","updated":"2019-06-10 17:44:00.000000000","message":"nitpick, but will fix this for good)","commit_id":"5250e5f0a6428fa3517806c4680663c102490025"},{"author":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"change_message_id":"ad36fc26a696c26df5f171a9988a7df87cf36ac4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    with open(home + \u0027/.pydistutils.cfg\u0027, \u0027wt\u0027) as output:"},{"line_number":63,"context_line":"        output.write(\u0027[easy_install]\\n\u0027)"},{"line_number":64,"context_line":"        output.write(\u0027index_url \u003d %s\\n\u0027 % (easy_index,))"},{"line_number":65,"context_line":"        output.write(\u0027allow_hosts \u003d %s\\n\u0027 % urlparse(easy_index).netloc)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def backup_configs(home):"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9fb8cfa7_cfd963f3","line":65,"updated":"2019-06-10 15:52:45.000000000","message":"See above","commit_id":"5250e5f0a6428fa3517806c4680663c102490025"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"aa430a06da039133e21c77d3686bcd134cc7b6ca","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    with open(home + \u0027/.pydistutils.cfg\u0027, \u0027wt\u0027) as output:"},{"line_number":63,"context_line":"        output.write(\u0027[easy_install]\\n\u0027)"},{"line_number":64,"context_line":"        output.write(\u0027index_url \u003d %s\\n\u0027 % (easy_index,))"},{"line_number":65,"context_line":"        output.write(\u0027allow_hosts \u003d %s\\n\u0027 % urlparse(easy_index).netloc)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def backup_configs(home):"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9fb8cfa7_78027b0d","line":65,"in_reply_to":"9fb8cfa7_cfd963f3","updated":"2019-06-10 17:44:00.000000000","message":"ditto","commit_id":"5250e5f0a6428fa3517806c4680663c102490025"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"734cab3f4277c5bc21ae65eef801e2b4286fac80","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/local/bin/dib-python"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9fb8cfa7_ff92be56","line":1,"updated":"2019-06-11 14:55:21.000000000","message":"you may use /usr/libexec/platform-python instead","commit_id":"ea9ab89829fe8db6f89ef002dc9223a9e1d52186"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c0f4e34f2092a4797ddd57b8a9673f3320015254","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/local/bin/dib-python"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9fb8cfa7_fa862366","line":1,"in_reply_to":"9fb8cfa7_0272c949","updated":"2019-06-13 10:19:39.000000000","message":"so feel free to CR+1 ;)","commit_id":"ea9ab89829fe8db6f89ef002dc9223a9e1d52186"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"11bd8cb3e8c9346f42d28414452d5d59a60bbfd7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/local/bin/dib-python"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9fb8cfa7_0272c949","line":1,"in_reply_to":"9fb8cfa7_657cfc1e","updated":"2019-06-12 10:21:13.000000000","message":"/usr/libexec/platform-python is mostly RHEL specific. Since  diskimage_builder supports other distros so dib-python is more preferable","commit_id":"ea9ab89829fe8db6f89ef002dc9223a9e1d52186"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2fb287b8381ef8fa91c2e54ba6187b247d3b36e4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/local/bin/dib-python"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9fb8cfa7_657cfc1e","line":1,"in_reply_to":"9fb8cfa7_a5b8b4e4","updated":"2019-06-11 20:45:18.000000000","message":"just fore sure, almost all python elements moved already:\n\nroot@aio1:/opt/diskimage-builder/diskimage_builder# grep -irn \"^#.*dib-python$\" elements/\nelements/package-installs/bin/package-installs-v2:1:#!/usr/local/bin/dib-python\nelements/svc-map/bin/svc-map:1:#!/usr/local/bin/dib-python\nelements/pkg-map/bin/pkg-map:1:#!/usr/local/bin/dib-python\nelements/redhat-common/bin/map-packages:1:#!/usr/local/bin/dib-python\nelements/dracut-regenerate/finalise.d/50-dracut-regenerate:1:#!/usr/local/bin/dib-python\nelements/pypi/pre-install.d/04-configure-pypi-mirror:1:#!/usr/local/bin/dib-python","commit_id":"ea9ab89829fe8db6f89ef002dc9223a9e1d52186"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1ae32c17af4cc29ae87933486b6acba085495357","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/local/bin/dib-python"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9fb8cfa7_a5b8b4e4","line":1,"in_reply_to":"9fb8cfa7_ff92be56","updated":"2019-06-11 20:41:46.000000000","message":"hi Sergii, what you are talking about?)\nplease read https://github.com/openstack/diskimage-builder/tree/master/diskimage_builder/elements/dib-python","commit_id":"ea9ab89829fe8db6f89ef002dc9223a9e1d52186"}]}