)]}'
{"id":"openstack%2Fdiskimage-builder~676354","triplet_id":"openstack%2Fdiskimage-builder~master~Ifa05366c2f2b95259f3312e4dde8c85347075ba1","project":"openstack/diskimage-builder","branch":"master","topic":"arm64","hashtags":[],"change_id":"Ifa05366c2f2b95259f3312e4dde8c85347075ba1","subject":"block-device-efi : expand disk size calculation","status":"MERGED","created":"2019-08-14 06:14:33.000000000","updated":"2019-08-21 02:32:22.000000000","submitted":"2019-08-21 02:30:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"676354-1566354632075-1b2da68d","meta_rev_id":"be2670c1b9779fa39bdc03928c52b74f65a8ae09","_number":676354,"virtual_id_number":676354,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-08-21 00:53:42.000000000","_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"value":0,"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},{"value":2,"date":"2019-08-21 02:30:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-08-14 09:47:54.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"recommended":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"all":[{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-16 16:23:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":1,"date":"2019-08-14 14:21:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"value":1,"date":"2019-08-14 07:02:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-20 20:23:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":1,"date":"2019-08-14 09:38:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"value":0,"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-20 20:23:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-14 07:02:19.000000000","updated_by":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"reviewer":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"state":"REVIEWER"},{"updated":"2019-08-14 09:38:54.000000000","updated_by":{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},"reviewer":{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},"state":"REVIEWER"},{"updated":"2019-08-14 09:47:54.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-14 14:21:00.000000000","updated_by":{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},"reviewer":{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},"state":"REVIEWER"},{"updated":"2019-08-16 16:23:40.000000000","updated_by":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"reviewer":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"state":"REVIEWER"},{"updated":"2019-08-21 00:53:42.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-21 02:30:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4f3e56ce91890cd0faeafc3e616fe7b3b92a2d19","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-08-14 06:14:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"649037d388f5f86502d3a51929fdbacfee12b0d5","author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"date":"2019-08-14 07:02:19.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"bb107c3576d6b96019eda73866f77416e87d49de","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 08:32:25.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b9897b6f69d84964a984acacfd34bdef : SUCCESS in 5m 08s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f3066898a5c545aab7b298c63b887d4b : SUCCESS in 4m 24s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4d6d7ca510694460b8e5303957e6f943 : SUCCESS in 4m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7701bed982c2455bac5f58f6fe349a82 : SUCCESS in 3m 44s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/00a9e61a42dc463fad60fba67c67944a : SUCCESS in 3m 40s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/545b99bd2dd546d687b1d7b2d02d2587 : SUCCESS in 4m 08s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c1a056236cde4db796c71905624a8a9e : SUCCESS in 3m 26s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/c7f0d86c25f343038ca5380df4fce4ce : SUCCESS in 24m 02s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/22430d40a2b94ead8c5401c19a963fd5 : SUCCESS in 3m 37s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/95f1fcb9b557407f815464c27bda21a8 : SUCCESS in 44m 31s\n- dib-nodepool-functional-openstack-fedora-29-src https://zuul.opendev.org/t/openstack/build/a7997208f4f64fab8b4e14631f1f52d1 : TIMED_OUT in 1h 30m 46s\n- dib-nodepool-functional-openstack-opensuse-150-src https://zuul.opendev.org/t/openstack/build/70519d2c937346048bd85662fe2c5021 : SUCCESS in 37m 18s\n- dib-nodepool-functional-openstack-opensuse-151-src https://zuul.opendev.org/t/openstack/build/09cd7a820b1a41e4a5dc8febcaab6bd1 : SUCCESS in 33m 00s\n- dib-nodepool-functional-openstack-ubuntu-trusty-src https://zuul.opendev.org/t/openstack/build/6fc594e3e1bb4f0cbed4adc9c23cac80 : SUCCESS in 33m 14s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/c16bd742622d4647b570c917d92ed9d5 : SUCCESS in 32m 18s\n- dib-nodepool-functional-openstack-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9a8bc675e31d44fbba64b950f742ebd2 : SUCCESS in 28m 48s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/7acfe8297ffb4fdabba1c1dc5f0f1a0a : SUCCESS in 30m 41s\n- dib-functests-centos7-python2 https://zuul.opendev.org/t/openstack/build/629ddf86f2784a1abd3b27f2027b2198 : SUCCESS in 39m 42s\n- dib-functests-centos7-python2-image https://zuul.opendev.org/t/openstack/build/920ac4d3b6004085ad7dcb6d57793bcc : SUCCESS in 1h 24m 42s (non-voting)\n- dib-functests-centos7-python2-extras https://zuul.opendev.org/t/openstack/build/2f906da8c5a7452383531b0ff907601e : SUCCESS in 21m 20s (non-voting)\n- dib-functests-trusty-python2 https://zuul.opendev.org/t/openstack/build/8b37a88f80134260b1a78236ff112865 : SUCCESS in 40m 18s\n- dib-functests-trusty-python2-image https://zuul.opendev.org/t/openstack/build/5b0310a2c9f541e4809e24709a7a4057 : SUCCESS in 1h 18m 01s (non-voting)\n- dib-functests-trusty-python2-extras https://zuul.opendev.org/t/openstack/build/9c7556d148f94701be5a0eeb6a3815f4 : FAILURE in 19m 48s (non-voting)\n- dib-functests-xenial-python3 https://zuul.opendev.org/t/openstack/build/99013df51d96479994bfc90d130705fd : SUCCESS in 35m 48s\n- dib-functests-xenial-python3-image https://zuul.opendev.org/t/openstack/build/603879a4c95e42aca380faf5af311b2f : FAILURE in 14m 47s (non-voting)\n- dib-functests-xenial-python3-extras https://zuul.opendev.org/t/openstack/build/a158eafc4a8e4a51a5fa362abbb4d0a4 : FAILURE in 18m 23s (non-voting)\n- dib-functests-xenial-python3-containers https://zuul.opendev.org/t/openstack/build/200eaee970c24221b2e3cc6a70ded2e4 : SUCCESS in 11m 22s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/c1d85d20cb594efc857e407e939777bb : SUCCESS in 37m 45s (non-voting)\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/98cb02ad71974d7fa9399c768d072794 : TIMED_OUT in 1h 30m 55s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/6bf7987a3a124602a8d4f286ff360438 : SUCCESS in 21m 45s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/249f0306812245d29a82285ec2b68703 : SUCCESS in 6m 15s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e4d97697717835a973ef588e7fe0dfb75ba82f1c","author":{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},"date":"2019-08-14 09:38:54.000000000","message":"Patch Set 1: Code-Review+1\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"dddc2501e5c213b019043ead5af835eadde536b3","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-08-14 09:47:54.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset001 finger://ze03.softwarefactory-project.io:7979/0644af7915d2428e95c6c59563a7d07c : POST_FAILURE in 3h 31m 51s","accounts_in_message":[],"_revision_number":1},{"id":"e441c5d37d5bf0bd2ced6e03c70d6086b31b2ba9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 10:47:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e5b3d286073546309b5a620dd7083b80 : SUCCESS in 3m 13s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/51e33e7b68bf4d08b37e7e9d1a81dac8 : SUCCESS in 4m 08s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3b3829ce50fd45b0b16ef0dcf7657128 : SUCCESS in 3m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ffb1b8ccb7554112b05b1f0b0a00b8b5 : SUCCESS in 4m 39s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/446b836f38af4859b088510e6157205a : SUCCESS in 3m 09s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/e6350552ef014683a2af21b4d7f713f1 : SUCCESS in 3m 35s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/4409bf25a17f4509970cd40dad815ab0 : SUCCESS in 3m 29s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/bb55475646f3427d9a4dbcad8ad18c9f : SUCCESS in 23m 10s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/2637e87be50d41b4806a58fda5e4084e : SUCCESS in 3m 05s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/ccff50fb2f374dee8d7c0189d461e37e : SUCCESS in 36m 31s\n- dib-nodepool-functional-openstack-fedora-29-src https://zuul.opendev.org/t/openstack/build/92b71f8e23094d34b072a9992bd12842 : SUCCESS in 56m 07s\n- dib-nodepool-functional-openstack-opensuse-150-src https://zuul.opendev.org/t/openstack/build/e96b030a52d84399b5d8f6fe21887755 : SUCCESS in 53m 45s\n- dib-nodepool-functional-openstack-opensuse-151-src https://zuul.opendev.org/t/openstack/build/119bc7bc14664eb79b8fa9779790a98b : SUCCESS in 32m 49s\n- dib-nodepool-functional-openstack-ubuntu-trusty-src https://zuul.opendev.org/t/openstack/build/f5aa64d7a9be4d58a09e63d1bf5054c8 : SUCCESS in 44m 14s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/5532ec41ce104fc0be1a539c1da8e31d : SUCCESS in 28m 55s\n- dib-nodepool-functional-openstack-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f58451283ec949a5a193d87e66863591 : SUCCESS in 29m 23s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/c0227714d19a49af86580f69fa4ef900 : SUCCESS in 44m 24s\n- dib-functests-centos7-python2 https://zuul.opendev.org/t/openstack/build/b146963c5f43428fb14051ebc7b9aff1 : SUCCESS in 39m 33s\n- dib-functests-centos7-python2-image https://zuul.opendev.org/t/openstack/build/38fd8460149248eb8d00496af55cf616 : SUCCESS in 50m 20s (non-voting)\n- dib-functests-centos7-python2-extras https://zuul.opendev.org/t/openstack/build/c3bd387c17954a36aadc816eb5231c18 : SUCCESS in 24m 51s (non-voting)\n- dib-functests-trusty-python2 https://zuul.opendev.org/t/openstack/build/712526f030464a22a8aa5864ea57773f : SUCCESS in 1h 07m 50s\n- dib-functests-trusty-python2-image https://zuul.opendev.org/t/openstack/build/00a9266d0dc245179cf2ef7a5678b253 : SUCCESS in 45m 44s (non-voting)\n- dib-functests-trusty-python2-extras https://zuul.opendev.org/t/openstack/build/5e1849df776a43af89dc71ed15697940 : FAILURE in 21m 50s (non-voting)\n- dib-functests-xenial-python3 https://zuul.opendev.org/t/openstack/build/0bb41022b1fb43148120ba690f76d739 : SUCCESS in 37m 42s\n- dib-functests-xenial-python3-image https://zuul.opendev.org/t/openstack/build/355e27ebed424d969f347c284b74e1ac : SUCCESS in 41m 17s (non-voting)\n- dib-functests-xenial-python3-extras https://zuul.opendev.org/t/openstack/build/30e338e71b6e4b6688ef3b75e3bab90b : FAILURE in 21m 09s (non-voting)\n- dib-functests-xenial-python3-containers https://zuul.opendev.org/t/openstack/build/014e987ffbe24eeb945aab1465bca41b : SUCCESS in 7m 01s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/ffd7fd8f161b4228a02b8a5dabd90682 : SUCCESS in 37m 54s (non-voting)\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/83281572f59d420f8a699413bd6598c9 : SUCCESS in 44m 25s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/2dc0826197434fdaa87ee985da59a5d6 : SUCCESS in 22m 10s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/64ec5faa13b14ff7b0de32a7e3c9db12 : SUCCESS in 6m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c88448316496478cb6eed7b97a4ed6427dd1ab88","author":{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},"date":"2019-08-14 14:21:00.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"b5734788ca5a74e2ec9facad115957163ae932d6","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2019-08-16 16:23:40.000000000","message":"Patch Set 1: Code-Review+1\n\ni agree. maybe its not ideal, but without rewriting the whole way this thing works this is the cleanest way I can see to implement it.","accounts_in_message":[],"_revision_number":1},{"id":"623bec2aed9ce80b1dcb55e5f495422a6bea90e9","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-08-20 20:23:54.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nthanks for the reviews everyone, merge for next release","accounts_in_message":[],"_revision_number":1},{"id":"339733b9e9d02eeed50ec0d91ae84568010eb06e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 20:24:07.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"cac9459709bb2e3b17e21607f72b400ac31e73bb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 21:21:25.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e5bdb40aba0449e5bce794c26b49bb8f : SUCCESS in 5m 44s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/116d12df753b45d4a9e2c1cbb711033f : SUCCESS in 5m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/36790573d3084663903f2b96004e07a1 : SUCCESS in 4m 26s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/45f9acc96510453293aa1caba63354be : SUCCESS in 4m 06s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/de5d37efa9e14586b20c35f7ef1510d7 : SUCCESS in 4m 46s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a2b71e30ec844480bdbd9ba068152f79 : SUCCESS in 3m 56s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/def38de4afb04fe29ab13e5fd208ead5 : SUCCESS in 24m 41s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/368681f7857b408aa152701d754e9e58 : SUCCESS in 3m 29s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/191d851c7f4b498895b99d488e95b675 : SUCCESS in 31m 55s\n- dib-nodepool-functional-openstack-fedora-29-src https://zuul.opendev.org/t/openstack/build/d106a16eff7b4accb843dffb99ac9ff5 : SUCCESS in 36m 50s\n- dib-nodepool-functional-openstack-opensuse-150-src https://zuul.opendev.org/t/openstack/build/6ea6dc95a7f64b35b394f73ffebe3743 : POST_FAILURE in 33m 00s\n- dib-nodepool-functional-openstack-opensuse-151-src https://zuul.opendev.org/t/openstack/build/a9fe5625dc6844beabe1ec6c6b9284f0 : SUCCESS in 36m 14s\n- dib-nodepool-functional-openstack-ubuntu-trusty-src https://zuul.opendev.org/t/openstack/build/e4fc2332dda84318b4fe00e6d58fc598 : SUCCESS in 30m 41s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/56ca2ac8d5aa449dba045b6b054b8143 : SUCCESS in 27m 05s\n- dib-nodepool-functional-openstack-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/77e15555529645bbbb88037cbfa2402e : SUCCESS in 30m 08s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/f3671bd6779a4956af26c88192d31030 : SUCCESS in 34m 34s\n- dib-functests-trusty-python2 https://zuul.opendev.org/t/openstack/build/7c301ea39151466d9f04f65a1757253b : SUCCESS in 40m 37s\n- dib-functests-xenial-python3 https://zuul.opendev.org/t/openstack/build/0d0b29ffc98f43babe1881971495b0c5 : SUCCESS in 41m 50s\n- dib-functests-centos7-python2 https://zuul.opendev.org/t/openstack/build/1d128e73507744ca8b508230f1d6f59b : SUCCESS in 46m 48s","accounts_in_message":[],"_revision_number":1},{"id":"b8de8fc5f15849da85a5660efa6d4ae0b64ace84","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-08-21 00:32:49.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"1166cc536a0541efce75c57c6c8364a4a28840a4","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-08-21 00:53:42.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-dsvm-functests-devstack-xenial-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/54/676354/1/check-dib/dib-dsvm-functests-devstack-xenial-xenial/839aff9/ : SUCCESS in 20m 36s\n- dib-dsvm-functests-devstack-xenial-trusty https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/54/676354/1/check-dib/dib-dsvm-functests-devstack-xenial-trusty/5b902b1/ : SUCCESS in 19m 49s\n- dib-dsvm-functests-devstack-xenial-centos https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/54/676354/1/check-dib/dib-dsvm-functests-devstack-xenial-centos/945fdc7/ : SUCCESS in 6m 31s (non-voting)\n- dib-dsvm-functests-devstack-xenial-fedora https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/54/676354/1/check-dib/dib-dsvm-functests-devstack-xenial-fedora/53887f8/ : SUCCESS in 19m 18s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"800d17ea7a3ccddb63315d245dd95f12ab89b5fe","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-21 01:39:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b3fcce8192b64300aa9054c4fb823427 : SUCCESS in 6m 11s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6cf9f4cf84364ee8b891597207ad7f4a : SUCCESS in 4m 58s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4f41b9d745d643ccb253d740d612a916 : SUCCESS in 6m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/122ed77e2d024af7bca231f1aed322c9 : SUCCESS in 5m 27s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/901722b837bb49879a1077d253b1c30a : SUCCESS in 3m 16s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/755aaac2b3594ed9a33f976b7cf79b5e : SUCCESS in 5m 42s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/7e9afd01ed664c98a92d766694220972 : SUCCESS in 3m 38s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/851ecb40550c421cb3a8a212649d73de : SUCCESS in 23m 24s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/044df1b14aec4245b028ce43e41623e4 : SUCCESS in 3m 28s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/faf9b9bf0e6d4f7191afa74d1cd7b2d6 : SUCCESS in 34m 07s\n- dib-nodepool-functional-openstack-fedora-29-src https://zuul.opendev.org/t/openstack/build/1fb74c805cae470ea15f1039f7e2f341 : SUCCESS in 44m 24s\n- dib-nodepool-functional-openstack-opensuse-150-src https://zuul.opendev.org/t/openstack/build/f936f5dbc2bd4166a35e741f46804def : SUCCESS in 34m 40s\n- dib-nodepool-functional-openstack-opensuse-151-src https://zuul.opendev.org/t/openstack/build/b4f6a9fa5bdd43ad904dbbbfb416e953 : SUCCESS in 51m 20s\n- dib-nodepool-functional-openstack-ubuntu-trusty-src https://zuul.opendev.org/t/openstack/build/5967800b25a4400db86cd8868018dd72 : SUCCESS in 43m 43s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/ab803ae6964f4684b19324c8fbc8d58f : SUCCESS in 42m 21s\n- dib-nodepool-functional-openstack-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/5eeac68adf3d4bb0a53eaba27bdfb4ff : SUCCESS in 28m 54s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/386de7b3fb5a47599abe2a6348149e34 : SUCCESS in 37m 34s\n- dib-functests-centos7-python2 https://zuul.opendev.org/t/openstack/build/bf80eae94af64e798a4e73d8d4842afe : SUCCESS in 40m 57s\n- dib-functests-centos7-python2-image https://zuul.opendev.org/t/openstack/build/fa9985a7b2b94b6ba0ca565be92c2ba2 : SUCCESS in 33m 27s (non-voting)\n- dib-functests-centos7-python2-extras https://zuul.opendev.org/t/openstack/build/74cd07044b9244229c3ab96ab3896074 : SUCCESS in 24m 31s (non-voting)\n- dib-functests-trusty-python2 https://zuul.opendev.org/t/openstack/build/b1336bb1c0ce4efd8b5e4f541d0cf976 : SUCCESS in 45m 08s\n- dib-functests-trusty-python2-image https://zuul.opendev.org/t/openstack/build/22e05fee4e454521a5143e1b2c98eb5f : SUCCESS in 32m 57s (non-voting)\n- dib-functests-trusty-python2-extras https://zuul.opendev.org/t/openstack/build/9d2878ca56ae4b249999e15729782fde : FAILURE in 23m 09s (non-voting)\n- dib-functests-xenial-python3 https://zuul.opendev.org/t/openstack/build/b33878048b22486c9100ee2ec116e045 : SUCCESS in 40m 55s\n- dib-functests-xenial-python3-image https://zuul.opendev.org/t/openstack/build/237f04c06d834b28a14f4d0c2581fc75 : SUCCESS in 33m 28s (non-voting)\n- dib-functests-xenial-python3-extras https://zuul.opendev.org/t/openstack/build/49a171d4e10a45bab00ede03e6bc7b29 : FAILURE in 21m 24s (non-voting)\n- dib-functests-xenial-python3-containers https://zuul.opendev.org/t/openstack/build/ba64a69bb2b042a3b500885e6e162f43 : SUCCESS in 10m 59s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/becad541b51d406aa96ddb0812115177 : SUCCESS in 44m 10s (non-voting)\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/f20a30f1680e4adba402860b8705a96c : SUCCESS in 33m 14s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/fce17e40e4df43d38a3976ff79315c8a : SUCCESS in 21m 05s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/cc9f1e76e309463ea654f7c1d984527a : SUCCESS in 10m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e7666646dde551e3b0022e48a66b3c6ca5d14287","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-21 01:39:38.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"81338803a18523c81a95ea7cbcfa280477b88f90","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-21 02:30:31.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/491a98c1131b439692575316cca33acb : SUCCESS in 6m 51s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ae413b64765a4f92ad92cd8f43fdfd24 : SUCCESS in 5m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d800af4d787f44cfa177db7cd06e93ff : SUCCESS in 4m 08s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/c771454e123e42628fedae5492f95cf1 : SUCCESS in 3m 39s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/a6ed9f3655164a34babcaea67da770b9 : SUCCESS in 4m 03s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/8b46d08f9c3140d0a445d736dbfdd263 : SUCCESS in 3m 32s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/8a4a5d56b7834adaa4315d8404de82bb : SUCCESS in 23m 54s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/1085fe2d665245d39bc45d19ad24a6fa : SUCCESS in 4m 12s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/b844effec43d4243b55b25cd96f26098 : SUCCESS in 35m 15s\n- dib-nodepool-functional-openstack-fedora-29-src https://zuul.opendev.org/t/openstack/build/65b8e2aa2efc4a33be3f715570c89d2a : SUCCESS in 40m 12s\n- dib-nodepool-functional-openstack-opensuse-150-src https://zuul.opendev.org/t/openstack/build/45b681b85f4d4c35a704497371d1be24 : SUCCESS in 44m 52s\n- dib-nodepool-functional-openstack-opensuse-151-src https://zuul.opendev.org/t/openstack/build/569b8384d5444969a971367b9717906f : SUCCESS in 34m 41s\n- dib-nodepool-functional-openstack-ubuntu-trusty-src https://zuul.opendev.org/t/openstack/build/b385fca9f7d64aea8a078c86ac02da0a : SUCCESS in 30m 12s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/f1fd81651bf44ba59b107726c57a7f1f : SUCCESS in 29m 39s\n- dib-nodepool-functional-openstack-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c9c72c92f5a24bb29cc7801ad2183a76 : SUCCESS in 28m 52s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/e53e5642e4fe4b99a551ca88e5bf7e91 : SUCCESS in 29m 05s\n- dib-functests-trusty-python2 https://zuul.opendev.org/t/openstack/build/74030b58fbc440c6929d24d13cab666f : SUCCESS in 38m 45s\n- dib-functests-xenial-python3 https://zuul.opendev.org/t/openstack/build/3733cdf2d6104e088915f437e83a8aa4 : SUCCESS in 34m 05s\n- dib-functests-centos7-python2 https://zuul.opendev.org/t/openstack/build/513bc1bbff1349a59c3b0ece27665d24 : SUCCESS in 44m 14s","accounts_in_message":[],"_revision_number":1},{"id":"d4e160d9bdba376534547a2a545f8e8573d8ac78","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-21 02:30:32.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"f3230a635723ce4332aa01c2348f4115b0351b56","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-21 02:32:22.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/70e264f489844a0c988d45fb10e48f3b : SUCCESS in 1m 32s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5492843aa8f06554d9a1eba452922ef4724cd43b","revisions":{"5492843aa8f06554d9a1eba452922ef4724cd43b":{"kind":"REWORK","_number":1,"created":"2019-08-14 06:14:33.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/54/676354/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/54/676354/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/54/676354/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/54/676354/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/54/676354/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/54/676354/1"}}},"commit":{"parents":[{"commit":"0c6a4dbd927c46e29077a8bca16ba3742886a210","subject":"Merge \"Fixes packages for arm64 bootloader\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/0c6a4dbd927c46e29077a8bca16ba3742886a210"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2019-08-14 05:24:03.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2019-08-14 05:49:38.000000000","tz":600},"subject":"block-device-efi : expand disk size calculation","message":"block-device-efi : expand disk size calculation\n\nAs noted in the change, 7fd52ba84180b4e749ccf4c9db8c49eafff46ea8\nincreased the size of the EFI partition considerably.  This has meant\nthat our padding upwards of the disk size is insufficient and EFI\nbuilds (arm64 in particular) is failing due to out-of-disk errors\nduring final image operations like installing kernels.\n\nSimilar to the discussion we had in\nI65fa13a088eecdfe61636678578577ea2cfb3c0c, this feels a bit ugly\nbecause we\u0027re mixing logic here with sizes specified in block-device\nconfig files.  But it boils down to the same problem; we are\ncalculating the disk size here and passing it to the block-layer, so\nunless we want to make large changes to the status quo about where\nthese sizes are calculated, small adjustments here are the most KISS\nsolution.\n\nThus we check if we have selected the EFI bootloader element, and thus\nassume there will be a large system EFI partition and expand the disk\nsize accordingly.\n\nChange-Id: Ifa05366c2f2b95259f3312e4dde8c85347075ba1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/5492843aa8f06554d9a1eba452922ef4724cd43b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/5492843aa8f06554d9a1eba452922ef4724cd43b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}