)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"090a9dfcff98cc5768e8c9099e35368c7b999e04","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Ignoring non-executable files: 10-do-not-run-me"},{"line_number":20,"context_line":"Ignoring non-conforming filenames: 10-I-can-run.sh"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"I am not enabling these by default as they can create extra noise"},{"line_number":23,"context_line":"and require additional filesystem IO to produce."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ic804efca3015c199440b4b10da951d71a815c64f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5faad753_2c9cc05b","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":48},"updated":"2019-09-13 06:41:57.000000000","message":"fair sentiment, but running dib without \"-x\" is also almost pretty useless, i tell people to just run with it because it\u0027s not too much.\n\ni think this is probably OK to turn on by default?  we\u0027re not relying on dib-run-parts not picking things up are we (i.e. getting this message on spurious files that shouldn\u0027t be there)","commit_id":"90addc30c7c141c4bb06306881d3f39bfcb243fe"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"810a900f7f247b003e164e9cf5941ddbb8afab3d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Ignoring non-executable files: 10-do-not-run-me"},{"line_number":20,"context_line":"Ignoring non-conforming filenames: 10-I-can-run.sh"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"I am not enabling these by default as they can create extra noise"},{"line_number":23,"context_line":"and require additional filesystem IO to produce."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ic804efca3015c199440b4b10da951d71a815c64f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5faad753_edbf79a7","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":48},"in_reply_to":"5faad753_2c9cc05b","updated":"2019-09-13 16:31:54.000000000","message":"If you are ok with the extra IO from the finds I am more than happy to make it on by default. That will simplify the code as well.","commit_id":"90addc30c7c141c4bb06306881d3f39bfcb243fe"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"45716216d97edfbf2bd2df4568dcc7892afa31a2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Ignoring non-executable files: 10-do-not-run-me"},{"line_number":20,"context_line":"Ignoring non-conforming filenames: 10-I-can-run.sh"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"I am not enabling these by default as they can create extra noise"},{"line_number":23,"context_line":"and require additional filesystem IO to produce."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ic804efca3015c199440b4b10da951d71a815c64f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_011219b2","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":48},"in_reply_to":"5faad753_edbf79a7","updated":"2019-09-23 01:08:35.000000000","message":"Now I think about it, DIB_DEBUG_TRACE should be exported and available to this, and is the standard flag for setting debug output.  I\u0027d suggest basically replace --verbose by that\n\nAs mentioned, I really consider \"-x\" basically the defacto default ... but if it\u0027s too much we can put it behind \"-x -x\" (i.e. DIB_DEBUG_TRACE \u003e\u003d2)","commit_id":"90addc30c7c141c4bb06306881d3f39bfcb243fe"}],"diskimage_builder/lib/dib-run-parts":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"090a9dfcff98cc5768e8c9099e35368c7b999e04","unresolved":false,"context_lines":[{"line_number":85,"context_line":"if [ \"$1\" \u003d\u003d \"--list\" ] ; then"},{"line_number":86,"context_line":"    show_list\u003d\"1\""},{"line_number":87,"context_line":"    shift"},{"line_number":88,"context_line":"fi"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"if [ \"$1\" \u003d\u003d \"--verbose\" ] ; then"},{"line_number":91,"context_line":"    verbose_output\u003d\"1\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"5faad753_4c8c9c35","line":88,"updated":"2019-09-13 06:41:57.000000000","message":"hrm, what if you do \"--verbose --list\"?","commit_id":"90addc30c7c141c4bb06306881d3f39bfcb243fe"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"810a900f7f247b003e164e9cf5941ddbb8afab3d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"if [ \"$1\" \u003d\u003d \"--list\" ] ; then"},{"line_number":86,"context_line":"    show_list\u003d\"1\""},{"line_number":87,"context_line":"    shift"},{"line_number":88,"context_line":"fi"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"if [ \"$1\" \u003d\u003d \"--verbose\" ] ; then"},{"line_number":91,"context_line":"    verbose_output\u003d\"1\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"5faad753_8d07e582","line":88,"in_reply_to":"5faad753_4c8c9c35","updated":"2019-09-13 16:31:54.000000000","message":"Well, for the sake of not adding full arg parsing to this patch and the fact that if you use --list, --verbose will do nothing I decided to shortcut this.\nHowever, if we agree to make the checks on by default this can go away anyway.","commit_id":"90addc30c7c141c4bb06306881d3f39bfcb243fe"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"45716216d97edfbf2bd2df4568dcc7892afa31a2","unresolved":false,"context_lines":[{"line_number":85,"context_line":"if [ \"$1\" \u003d\u003d \"--list\" ] ; then"},{"line_number":86,"context_line":"    show_list\u003d\"1\""},{"line_number":87,"context_line":"    shift"},{"line_number":88,"context_line":"fi"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"if [ \"$1\" \u003d\u003d \"--verbose\" ] ; then"},{"line_number":91,"context_line":"    verbose_output\u003d\"1\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3fa7e38b_61498dce","line":88,"in_reply_to":"5faad753_8d07e582","updated":"2019-09-23 01:08:35.000000000","message":"originally, dib-run-parts was part of \"dib-utils\" and split out because it was considered a generically useful runner.  but for years the only thing in dib-utils was this script, which was only used in \"instack\".  it became an increasing pain having dib depend on this and increasingly clear the idea that \"dib-utils\" would grow into something wasn\u0027t happening.  so we moved it back into here as a private tool\n\nthus, long story short, i think we\u0027re ok with slightly odd semantics as it\u0027s not intended to be an external tool.  but if we don\u0027t, so much the better.","commit_id":"90addc30c7c141c4bb06306881d3f39bfcb243fe"}]}