)]}'
{"id":"openstack%2Fdiskimage-builder~683272","triplet_id":"openstack%2Fdiskimage-builder~master~Ibb28b6e90d966a845de38a2cd5a1e8babd2604bc","project":"openstack/diskimage-builder","branch":"master","topic":"machine-id","hashtags":[],"change_id":"Ibb28b6e90d966a845de38a2cd5a1e8babd2604bc","subject":"Ensure machine-id is not included in images","status":"MERGED","created":"2019-09-20 03:15:36.000000000","updated":"2019-10-25 04:29:48.000000000","submitted":"2019-10-25 04:28:28.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"683272-1571977708773-f546210b","meta_rev_id":"a88067816128730b6bdb1be5e7a70a4feb846a5b","_number":683272,"virtual_id_number":683272,"owner":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-09-20 03:41:07.000000000","_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"date":"2019-09-20 03:40:24.000000000","_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-25 04:28:28.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-09-20 06:12:58.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2019-09-20 07:34:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2019-10-25 03:43:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-20 03:41:07.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-09-20 06:12:58.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-10-25 03:43:50.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2019-10-25 04:28:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"df766146444d852008ac9c00047a897d9f1bd213","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2019-09-20 03:15:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4f8082d42f27cd7e606859a05fdd10d1a17a2215","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2019-09-20 03:17:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c1ea5f47c1aa6319a5b19e33d31beb90401ff2c8","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2019-09-20 03:17:52.000000000","message":"Patch Set 3: Published edit on patch set 2.","accounts_in_message":[],"_revision_number":3},{"id":"60d6d463a57e82c4f831d107661aafdefd6c181f","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2019-09-20 03:40:24.000000000","message":"Patch Set 3:\n\nAccording to systemd:\n\n\u003e This ID uniquely identifies the host. It should be considered \"confidential\", and must not be exposed in untrusted environments, in particular on the network. If a stable unique identifier that is tied to the machine is needed for some application, the machine ID or any part of it must not be used directly. Instead the machine ID should be hashed with a cryptographic, keyed hash function, using a fixed, application-specific key. That way the ID will be properly unique, and derived in a constant way from the machine ID but there will be no way to retrieve the original machine ID from the application-specific one. The sd_id128_get_machine_app_specific(3) API provides an implementation of such an algorithm.\n\n(from https://www.freedesktop.org/software/systemd/man/machine-id.html#Description)\n\nSo I guess this seems somewhat serious? I don\u0027t see any justification for it being \"considered confidential\" but I guess the intent is that applications can use it as a machine-unique seed?","accounts_in_message":[],"_revision_number":3},{"id":"20e6e6634745c947267e6841809b36e3b8c7ba9f","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-09-20 03:41:07.000000000","message":"Patch Set 3:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-dsvm-functests-devstack-xenial-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/72/683272/3/check-dib/dib-dsvm-functests-devstack-xenial-xenial/e9a5d87/ : SUCCESS in 22m 30s\n- dib-dsvm-functests-devstack-xenial-trusty https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/72/683272/3/check-dib/dib-dsvm-functests-devstack-xenial-trusty/bf7e3c0/ : SUCCESS in 11m 28s\n- dib-dsvm-functests-devstack-xenial-centos https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/72/683272/3/check-dib/dib-dsvm-functests-devstack-xenial-centos/1bd6946/ : SUCCESS in 7m 52s (non-voting)\n- dib-dsvm-functests-devstack-xenial-fedora https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/72/683272/3/check-dib/dib-dsvm-functests-devstack-xenial-fedora/92790f2/ : SUCCESS in 19m 15s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"81ffd0174cfaa2956bdf015457e0c60092ffdd18","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-20 04:38:59.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ac3277e38a1a4899ba8a0a403ed04a0f : SUCCESS in 4m 42s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/13419bc0fd8a44bfbdd1b02aa978b3e5 : SUCCESS in 4m 28s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b64ea025606f48a89d40998dcb80e78f : SUCCESS in 3m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cf0d9b6234404a21a0f62f410c65eccf : SUCCESS in 5m 14s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/0d846a5d794a4bce9142b97481629732 : SUCCESS in 4m 13s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/12c7ffe7b800434bb30a243f08ec664c : SUCCESS in 4m 15s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5e1e78b865914bc995273336e3fe2bdb : SUCCESS in 3m 12s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/26137eeaf9f24bf289e00ee68969ae76 : SUCCESS in 24m 42s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/2f6951ed5d844b1895c4d9f7a1748882 : SUCCESS in 3m 58s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/84284973741c44d39b0a1c41762b1b5a : SUCCESS in 39m 00s\n- dib-nodepool-functional-openstack-fedora-29-src https://zuul.opendev.org/t/openstack/build/fb18e39d60354e71868eac7cd362cd66 : SUCCESS in 40m 08s\n- dib-nodepool-functional-openstack-fedora-30-src https://zuul.opendev.org/t/openstack/build/fe79e40d8add4bebac9b393a3f31734a : SUCCESS in 53m 21s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/b89aabbc0a0a4fbeb91c64402eed294e : SUCCESS in 44m 19s\n- dib-nodepool-functional-openstack-ubuntu-trusty-src https://zuul.opendev.org/t/openstack/build/da94f3e009b143e9b7bc330dfdf22a88 : SUCCESS in 30m 48s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/00a825864cf042d5a2bf253b1e165908 : SUCCESS in 32m 36s\n- dib-nodepool-functional-openstack-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/13f46ca811c844e2843ab42100201ce3 : SUCCESS in 30m 27s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/33d371777e8945e3a564c673569843d7 : SUCCESS in 28m 11s\n- dib-functests-centos7-python2 https://zuul.opendev.org/t/openstack/build/f7fbaa5ebb14499dadab714d0cd542a0 : SUCCESS in 43m 46s\n- dib-functests-centos7-python2-image https://zuul.opendev.org/t/openstack/build/67bd1eccdd28484ca5f5d9f4b31c6056 : SUCCESS in 31m 47s (non-voting)\n- dib-functests-centos7-python2-extras https://zuul.opendev.org/t/openstack/build/8f9426ea2b84481eb500e0a69714655b : SUCCESS in 25m 12s (non-voting)\n- dib-functests-trusty-python2 https://zuul.opendev.org/t/openstack/build/f05dd51b9f1e472ea59e96bc69b735d2 : SUCCESS in 57m 49s\n- dib-functests-trusty-python2-image https://zuul.opendev.org/t/openstack/build/1e182bbe7aad4b188b743de63f29a46f : SUCCESS in 34m 01s (non-voting)\n- dib-functests-trusty-python2-extras https://zuul.opendev.org/t/openstack/build/68d63f9c6855406da6669f2290d3915b : FAILURE in 21m 58s (non-voting)\n- dib-functests-xenial-python3 https://zuul.opendev.org/t/openstack/build/4c4fbe8645ca4dea8792594c052a84fc : SUCCESS in 49m 56s\n- dib-functests-xenial-python3-image https://zuul.opendev.org/t/openstack/build/6c81aeb130ad4454958e98abc088b644 : SUCCESS in 41m 39s (non-voting)\n- dib-functests-xenial-python3-extras https://zuul.opendev.org/t/openstack/build/756550121aa344b69791a5f6b33a9d52 : FAILURE in 23m 32s (non-voting)\n- dib-functests-xenial-python3-containers https://zuul.opendev.org/t/openstack/build/0ea99f4dfdd94829a77db26ead331746 : SUCCESS in 7m 46s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/7790b4d8aa794627a0ba540d16dbf154 : SUCCESS in 38m 15s (non-voting)\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/a03c6476788243a68896ad6d0c7c8721 : SUCCESS in 33m 05s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/50bf6fd7050541e298eb827695f7676c : SUCCESS in 19m 51s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/00099f905fca4d9fad061641de2313e5 : SUCCESS in 8m 02s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"f3e38f87aa9df7d22c84eb868d2ac063edb51964","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-09-20 06:12:58.000000000","message":"Patch Set 3:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset001 http://logs.rdoproject.org/72/683272/3/openstack-check/tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset001/da0127b/ : SUCCESS in 2h 54m 06s","accounts_in_message":[],"_revision_number":3},{"id":"6060c80860b094f482fe14f00d357e67e3d2ed33","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-09-20 07:34:44.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"982f266fa17ffb4511bbcfa90aa33737c5cba2bd","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-10-25 03:43:50.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"f61a297f01c99bd1ac3369b4c396b15cde187a42","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-25 03:44:56.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"9b9a82080ef1708349f7052222e6b21d77d08605","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-25 04:28:28.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2e9b1d22e7a3474f9ff1c1fe160dc7bf : SUCCESS in 3m 40s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/917fc2f2236a4ad796530ae76ddce55f : SUCCESS in 3m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7d7f60bdcd954c85b2c31b969a45810c : SUCCESS in 3m 31s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/7080a75c388a470ab50ed2b5d65f5892 : SUCCESS in 3m 11s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/106b3a28ef5f4e29a7a3c4199a75e8da : SUCCESS in 3m 58s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6ba71c72533f45f1a2328d862d7de531 : SUCCESS in 3m 03s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/39b44be809984bd4b5fffa61d367d54f : SUCCESS in 28m 05s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/c1caba36d62b47feb6d5e857d6ad16e9 : SUCCESS in 3m 01s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/6aa270414e5f46ad9bae198c97b95f2a : SUCCESS in 30m 51s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/dea8909c44554399b3073ab4695fb641 : SUCCESS in 30m 51s\n- dib-nodepool-functional-openstack-fedora-29-src https://zuul.opendev.org/t/openstack/build/e8cdf89ce77d4d3287f9ada6065852be : SUCCESS in 36m 14s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/32a326cd47184c4c9397b64109beaf41 : SUCCESS in 35m 31s\n- dib-nodepool-functional-openstack-ubuntu-trusty-src https://zuul.opendev.org/t/openstack/build/2c2aab9dea6f46b980edcf32a168cbf9 : SUCCESS in 30m 45s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/7a7a24b90ace4747bd52d6a70a372c5b : SUCCESS in 29m 11s\n- dib-nodepool-functional-openstack-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/bff987e86ac040af9b572138400d44be : SUCCESS in 29m 42s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/dfa3ee4ad83e45f3b763bc66f8bd7fe2 : SUCCESS in 31m 28s\n- dib-functests-trusty-python2 https://zuul.opendev.org/t/openstack/build/f630181d8b2b4c06b4c14eed882fe885 : SUCCESS in 23m 52s\n- dib-functests-xenial-python3 https://zuul.opendev.org/t/openstack/build/c85b832a67a04b31986d1b02e52df8c6 : SUCCESS in 23m 36s\n- dib-functests-centos7-python2 https://zuul.opendev.org/t/openstack/build/00292a7d6e124ef0a28b12b79e890822 : SUCCESS in 27m 24s","accounts_in_message":[],"_revision_number":3},{"id":"390f2248f3b8405c3bcffeca226263b21f5b4fc0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-25 04:28:28.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"abc7d3b66697815022468a6cc406e9860890130a","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-25 04:29:48.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4f1af73a0c9e4b9089ebe4c54e733295 : SUCCESS in 1m 02s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/0891b8f4729044c58a0ab794f6f776ae : SUCCESS in 49s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"c7e907794c4b4bfd19ec02cf19194a8901443828","revisions":{"6f509227c6db25bf6bdb69db4bde931ec8d3d475":{"kind":"REWORK","_number":1,"created":"2019-09-20 03:15:36.000000000","uploader":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"ref":"refs/changes/72/683272/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/72/683272/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/72/683272/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/72/683272/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/72/683272/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/72/683272/1"}}},"commit":{"parents":[{"commit":"b907ecf15c052df8757a8315a2605ddbf2fe730f","subject":"Merge \"Revert \"Fixed use of flake8\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/b907ecf15c052df8757a8315a2605ddbf2fe730f"}]}],"author":{"name":"Logan V","email":"logan2211@gmail.com","date":"2019-09-20 03:10:55.000000000","tz":-300},"committer":{"name":"Logan V","email":"logan2211@gmail.com","date":"2019-09-20 03:10:55.000000000","tz":-300},"subject":"Ensure machine-id is not included in images","message":"Ensure machine-id is not included in images\n\nTwo bugs are addressed.\n\n1) The sysprep element was broken in that it only truncates\n   /etc/machine-id, but not /var/lib/dbus/machine-id. systemd will\n   not generate a new machine-id if /var/lib/dbus/machine-id is\n   present[1], it will simply copy it to /etc/machine-id.\n\n   We observed machine-ids being packaged in /var/lib/dbus/machine-id\n   on several distros: Ubuntu Bionic, Fedora 29, Debian Stretch.\n\n   CentOS 7 and Ubuntu Xenial do not contain packaged machine-id as\n   far as I can tell.\n\n   All test builds were performed using -minimal elements.\n\n2) A second bug existed where debian-minimal did not run the sysprep\n   element at all, so a stretch image I tested contained a populated\n   /etc/machine-id AND a populated /var/lib/dbus/machine-id.\n\n[1] https://www.freedesktop.org/software/systemd/man/machine-id.html#Initialization\n\nChange-Id: Ibb28b6e90d966a845de38a2cd5a1e8babd2604bc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/6f509227c6db25bf6bdb69db4bde931ec8d3d475"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/6f509227c6db25bf6bdb69db4bde931ec8d3d475"}]},"branch":"refs/heads/master"},"e3aeee2517446168643e24ba63c4a5d308ed6cb5":{"kind":"REWORK","_number":2,"created":"2019-09-20 03:17:09.000000000","uploader":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"ref":"refs/changes/72/683272/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/72/683272/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/72/683272/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/72/683272/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/72/683272/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/72/683272/2"}}},"commit":{"parents":[{"commit":"b907ecf15c052df8757a8315a2605ddbf2fe730f","subject":"Merge \"Revert \"Fixed use of flake8\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/b907ecf15c052df8757a8315a2605ddbf2fe730f"}]}],"author":{"name":"Logan V","email":"logan2211@gmail.com","date":"2019-09-20 03:10:55.000000000","tz":-300},"committer":{"name":"Logan V","email":"logan2211@gmail.com","date":"2019-09-20 03:17:07.000000000","tz":-300},"subject":"Ensure machine-id is not included in images","message":"Ensure machine-id is not included in images\n\nTwo bugs are addressed.\n\n1) The sysprep element was broken in that it only truncates\n   /etc/machine-id, but not /var/lib/dbus/machine-id. systemd will\n   not generate a new machine-id if /var/lib/dbus/machine-id is\n   present[1], it will simply copy it to /etc/machine-id.\n\n   We observed machine-ids being packaged in /var/lib/dbus/machine-id\n   on several distros: Ubuntu Bionic, Fedora 29, Debian Stretch.\n\n   CentOS 7 and Ubuntu Xenial do not contain packaged machine-id as\n   far as I can tell.\n\n   All test builds were performed using -minimal elements.\n\n2) A second bug existed where debian-minimal did not run the sysprep\n   element at all, so a stretch image I tested contained a populated\n   /etc/machine-id AND a populated /var/lib/dbus/machine-id.\n\n[1] https://www.freedesktop.org/software/systemd/man/machine-id.html#Initialization\n\nChange-Id: Ibb28b6e90d966a845de38a2cd5a1e8babd2604bc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/e3aeee2517446168643e24ba63c4a5d308ed6cb5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/e3aeee2517446168643e24ba63c4a5d308ed6cb5"}]},"branch":"refs/heads/master"},"c7e907794c4b4bfd19ec02cf19194a8901443828":{"kind":"REWORK","_number":3,"created":"2019-09-20 03:17:52.000000000","uploader":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"ref":"refs/changes/72/683272/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/72/683272/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/72/683272/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/72/683272/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/72/683272/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/72/683272/3"}}},"commit":{"parents":[{"commit":"b907ecf15c052df8757a8315a2605ddbf2fe730f","subject":"Merge \"Revert \"Fixed use of flake8\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/b907ecf15c052df8757a8315a2605ddbf2fe730f"}]}],"author":{"name":"Logan V","email":"logan2211@gmail.com","date":"2019-09-20 03:10:55.000000000","tz":-300},"committer":{"name":"Logan V","email":"logan2211@gmail.com","date":"2019-09-20 03:17:50.000000000","tz":0},"subject":"Ensure machine-id is not included in images","message":"Ensure machine-id is not included in images\n\nTwo bugs are addressed.\n\n1) The sysprep element was broken in that it only truncates\n   /etc/machine-id, but not /var/lib/dbus/machine-id. systemd will\n   not generate a new machine-id if /var/lib/dbus/machine-id is\n   present[1], it will simply copy it to /etc/machine-id.\n\n   We observed machine-ids being packaged in /var/lib/dbus/machine-id\n   on several distros: Ubuntu Bionic, Fedora 29, Debian Stretch.\n\n   CentOS 7 and Ubuntu Xenial do not contain packaged machine-id as\n   far as I can tell.\n\n   All test builds were performed using -minimal elements.\n\n2) A second bug existed where debian-minimal did not run the sysprep\n   element at all, so a stretch image I tested contained a populated\n   /etc/machine-id AND a populated /var/lib/dbus/machine-id.\n\n[1] https://www.freedesktop.org/software/systemd/man/machine-id.html#Initialization\n\nChange-Id: Ibb28b6e90d966a845de38a2cd5a1e8babd2604bc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/c7e907794c4b4bfd19ec02cf19194a8901443828"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/c7e907794c4b4bfd19ec02cf19194a8901443828"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}