)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"cce3a88b10cfcaa204986b6a569f4af21c888daa","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Another option is to basically drop source support and just install"},{"line_number":17,"context_line":"from packages, and jobs migrating to centos8 should be python3 only"},{"line_number":18,"context_line":"and in a standard upstream environment.  This is certainly appealing"},{"line_number":19,"context_line":"if others feel this way..."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ia267a60eecfa8f4071dd477d86daebe07e9a7e38"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_843810ee","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":26},"updated":"2019-09-26 06:58:59.000000000","message":"I feel ya! ;)","commit_id":"850b397da07c3f1af126cf6a3741987988fd3391"}],"diskimage_builder/elements/pip-and-virtualenv/environment.d/51-pip-and-virutalenv-default.bash":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b8688c2d530afc04b8418031b2ea4832bc9cccf5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# upgrading packaged system pip/setuptools/virtualenv binaries with"},{"line_number":3,"context_line":"# upstream non-packaged versions, we wish to avoid this completely on"},{"line_number":4,"context_line":"# modern distros."},{"line_number":5,"context_line":"if [[ $DISTRO_NAME \u003d~ (centos|rhel) \u0026\u0026 $DIB_RELEASE -ge 8 ]]; then"},{"line_number":6,"context_line":"    export DIB_INSTALLTYPE_pip_and_virtualenv\u003d${DIB_INSTALLTYPE_pip_and_virtualenv:-package}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    if [[ ${DIB_INSTALLTYPE_pip_and_virtualenv} \u003d\u003d \"source\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3fa7e38b_05989772","line":5,"updated":"2019-10-13 12:36:46.000000000","message":"This broke CentOS 7 (at least without explicit DIB_RELEASE): https://storage.bhs1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_788/685662/2/check/ironic-python-agent-check-image-dib-centos7/7883c94/job-output.txt","commit_id":"18215274d895b4b6104c5d977c00b623568646b2"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8c1caa6f0a3c5cd207d7a0c4d01cba62b1e98fd7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# upgrading packaged system pip/setuptools/virtualenv binaries with"},{"line_number":3,"context_line":"# upstream non-packaged versions, we wish to avoid this completely on"},{"line_number":4,"context_line":"# modern distros."},{"line_number":5,"context_line":"if [[ $DISTRO_NAME \u003d~ (centos|rhel) \u0026\u0026 $DIB_RELEASE -ge 8 ]]; then"},{"line_number":6,"context_line":"    export DIB_INSTALLTYPE_pip_and_virtualenv\u003d${DIB_INSTALLTYPE_pip_and_virtualenv:-package}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    if [[ ${DIB_INSTALLTYPE_pip_and_virtualenv} \u003d\u003d \"source\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3fa7e38b_5ba18ef6","line":5,"in_reply_to":"3fa7e38b_05989772","updated":"2019-10-13 22:47:45.000000000","message":"hrrm, yes I had not considered that weird release, sorry.  have to think about that ...","commit_id":"18215274d895b4b6104c5d977c00b623568646b2"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a16b31b50831ec4fd9e6dac28719fe80c132b9df","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# upgrading packaged system pip/setuptools/virtualenv binaries with"},{"line_number":3,"context_line":"# upstream non-packaged versions, we wish to avoid this completely on"},{"line_number":4,"context_line":"# modern distros."},{"line_number":5,"context_line":"if [[ $DISTRO_NAME \u003d~ (centos|rhel) \u0026\u0026 $DIB_RELEASE -ge 8 ]]; then"},{"line_number":6,"context_line":"    export DIB_INSTALLTYPE_pip_and_virtualenv\u003d${DIB_INSTALLTYPE_pip_and_virtualenv:-package}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    if [[ ${DIB_INSTALLTYPE_pip_and_virtualenv} \u003d\u003d \"source\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3fa7e38b_dc57b5c9","line":5,"in_reply_to":"3fa7e38b_5ba18ef6","updated":"2019-10-14 06:43:20.000000000","message":"Sorry about that, Dmitry.\n\nI think https://review.opendev.org/#/c/684308/ fixes this issue.\n\nhttps://review.opendev.org/#/c/684308/16/diskimage_builder/elements/centos7/environment.d/09-centos7-distro-name.bash","commit_id":"18215274d895b4b6104c5d977c00b623568646b2"}],"diskimage_builder/elements/pip-and-virtualenv/install.d/pip-and-virtualenv-source-install/04-install-pip":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"cce3a88b10cfcaa204986b6a569f4af21c888daa","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    # see notes below on this var..."},{"line_number":15,"context_line":"    _clear_old_files\u003d0"},{"line_number":16,"context_line":"    case \"$DISTRO_NAME\" in"},{"line_number":17,"context_line":"        centos*|rhel7)"},{"line_number":18,"context_line":"            case \"$DIB_RELEASE\" in"},{"line_number":19,"context_line":"                8)"},{"line_number":20,"context_line":"                    _do_py3\u003d1"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3fa7e38b_e420e4ae","line":17,"range":{"start_line":17,"start_character":8,"end_line":17,"end_character":15},"updated":"2019-09-26 06:58:59.000000000","message":"DISTRO_NAME for CentOS is being uniformized to be \"centos\" across centos, centos-minimal and centos7 elements.","commit_id":"850b397da07c3f1af126cf6a3741987988fd3391"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"cce3a88b10cfcaa204986b6a569f4af21c888daa","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    # see notes below on this var..."},{"line_number":15,"context_line":"    _clear_old_files\u003d0"},{"line_number":16,"context_line":"    case \"$DISTRO_NAME\" in"},{"line_number":17,"context_line":"        centos*|rhel7)"},{"line_number":18,"context_line":"            case \"$DIB_RELEASE\" in"},{"line_number":19,"context_line":"                8)"},{"line_number":20,"context_line":"                    _do_py3\u003d1"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3fa7e38b_442698d0","line":17,"range":{"start_line":17,"start_character":16,"end_line":17,"end_character":21},"updated":"2019-09-26 06:58:59.000000000","message":"this can be dropped. DISTRO_NAME for RHEL is just \"rhel\".","commit_id":"850b397da07c3f1af126cf6a3741987988fd3391"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"cce3a88b10cfcaa204986b6a569f4af21c888daa","unresolved":false,"context_lines":[{"line_number":20,"context_line":"                    _do_py3\u003d1"},{"line_number":21,"context_line":"                    _clear_old_files\u003d0"},{"line_number":22,"context_line":"                    # All in AppStream for Centos 8"},{"line_number":23,"context_line":"                    # NOTE(ianw): this tool is explicitly setting up python2 \u0026 python3, hence bringing in"},{"line_number":24,"context_line":"                    # python2 that otherwise might not be required."},{"line_number":25,"context_line":"                    packages\u003d\" python2 python2-pip python2-virtualenv \""},{"line_number":26,"context_line":"                    packages+\u003d\" python3-virtualenv python3-pip python3-setuptools\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3fa7e38b_640cf440","line":23,"updated":"2019-09-26 06:58:59.000000000","message":"Python 2 is not a runtime from Ussuri onwards. Let\u0027s kill the beast once and for all. We could, and should, keep support for EL7 with Python 2, though.\n\nIf we agree to that, see https://review.opendev.org/#/c/684308/3/diskimage_builder/elements/pip-and-virtualenv/install.d/pip-and-virtualenv-source-install/04-install-pip for a suggestion on how to simplify much of this code. It also aligns with Fedora, so triple-win!","commit_id":"850b397da07c3f1af126cf6a3741987988fd3391"}]}