)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"d91c25443e9c8083d9b85d2f0b5f3567c9e62c98","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[wip] don\u0027t create interfaces on centos-8"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default network-scripts isn\u0027t installed, so the directories for"},{"line_number":10,"context_line":"these files don\u0027t exist either.  Worth investigating what the default"},{"line_number":11,"context_line":"situation is, not currenctly clear.  With infra we use glean."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I194ec3735e17f27e586386541dc51f775b01e510"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_9f3db9de","line":10,"updated":"2019-09-26 07:58:59.000000000","message":"NetworkManager is the successor to network-scripts. I think centos-minimal should use it as default.","commit_id":"2d1ff7037fad47ac8f36d25aba310d1a5daf4769"}],"diskimage_builder/elements/centos-minimal/README.rst":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"423a6aa67de7319f8faf20b32a015d751dedc84b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"centos-minimal"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Create a minimal image based on CentOS 7."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Use of this element will require \u0027yum\u0027 and \u0027yum-utils\u0027 to be installed on"},{"line_number":7,"context_line":"Ubuntu and Debian. Nothing additional is needed on Fedora or CentOS."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_5cb6138d","line":4,"range":{"start_line":4,"start_character":39,"end_line":4,"end_character":40},"updated":"2019-10-02 11:23:46.000000000","message":"Or 8. Better just remove mention of version.","commit_id":"008b63317bf1c4a670239bd39ef3bb4f134f6f80"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"db043bb5a0acc956797d3228490fef1c733e3988","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"centos-minimal"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Create a minimal image based on CentOS 7."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Use of this element will require \u0027yum\u0027 and \u0027yum-utils\u0027 to be installed on"},{"line_number":7,"context_line":"Ubuntu and Debian. Nothing additional is needed on Fedora or CentOS."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_2e1bcf73","line":4,"range":{"start_line":4,"start_character":39,"end_line":4,"end_character":40},"in_reply_to":"3fa7e38b_5cb6138d","updated":"2019-10-03 08:10:00.000000000","message":"Done","commit_id":"008b63317bf1c4a670239bd39ef3bb4f134f6f80"}],"diskimage_builder/elements/centos-minimal/environment.d/10-centos-distro-name.bash":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"423a6aa67de7319f8faf20b32a015d751dedc84b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3fa7e38b_3f3c69be","line":10,"updated":"2019-10-02 11:23:46.000000000","message":"From the README:\n\n  For CentOS 8, this is set to ``0`` by default as the\n  system uses NetworkManager by default.\n\nSo I think DIB_YUM_MINIMAL_CREATE_INTERFACES should still be exported for CentOS 8 but default to 0. CentOS 8 amphora images will continue to require network-scripts -- NetworkManager isn\u0027t supported yet.","commit_id":"008b63317bf1c4a670239bd39ef3bb4f134f6f80"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"db043bb5a0acc956797d3228490fef1c733e3988","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3fa7e38b_0e03730f","line":10,"in_reply_to":"3fa7e38b_3f3c69be","updated":"2019-10-03 08:10:00.000000000","message":"done, now exports 0 in the other case","commit_id":"008b63317bf1c4a670239bd39ef3bb4f134f6f80"}],"diskimage_builder/elements/simple-init/post-install.d/80-simple-init":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"423a6aa67de7319f8faf20b32a015d751dedc84b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        exit 0"},{"line_number":13,"context_line":"        ;;"},{"line_number":14,"context_line":"    systemd)"},{"line_number":15,"context_line":"        if [[ ${DISTRO_NAME} \u003d~ (centos|rhel7|fedora) ]]; then"},{"line_number":16,"context_line":"            if [[ ${DIB_SIMPLE_INIT_NETWORKMANAGER} !\u003d 1 ]]; then"},{"line_number":17,"context_line":"                # NOTE(pabelanger): Glean requires network.service for"},{"line_number":18,"context_line":"                # these platforms when not using networkmanager"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"3fa7e38b_1fdbad7d","line":15,"range":{"start_line":15,"start_character":40,"end_line":15,"end_character":45},"updated":"2019-10-02 11:23:46.000000000","message":"Hmm, this needs to be fixed (s/rhel7/rhel/) or removed if RHEL isn\u0027t supported in this element at all.","commit_id":"008b63317bf1c4a670239bd39ef3bb4f134f6f80"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"db043bb5a0acc956797d3228490fef1c733e3988","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        exit 0"},{"line_number":13,"context_line":"        ;;"},{"line_number":14,"context_line":"    systemd)"},{"line_number":15,"context_line":"        if [[ ${DISTRO_NAME} \u003d~ (centos|rhel7|fedora) ]]; then"},{"line_number":16,"context_line":"            if [[ ${DIB_SIMPLE_INIT_NETWORKMANAGER} !\u003d 1 ]]; then"},{"line_number":17,"context_line":"                # NOTE(pabelanger): Glean requires network.service for"},{"line_number":18,"context_line":"                # these platforms when not using networkmanager"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"3fa7e38b_2b7501fb","line":15,"range":{"start_line":15,"start_character":40,"end_line":15,"end_character":45},"in_reply_to":"3fa7e38b_1fdbad7d","updated":"2019-10-03 08:10:00.000000000","message":"hrrm, i imagine this is untested.  i think best to remove it, but i\u0027ll put in an error fall-through just in case","commit_id":"008b63317bf1c4a670239bd39ef3bb4f134f6f80"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"423a6aa67de7319f8faf20b32a015d751dedc84b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        ;;"},{"line_number":14,"context_line":"    systemd)"},{"line_number":15,"context_line":"        if [[ ${DISTRO_NAME} \u003d~ (centos|rhel7|fedora) ]]; then"},{"line_number":16,"context_line":"            if [[ ${DIB_SIMPLE_INIT_NETWORKMANAGER} !\u003d 1 ]]; then"},{"line_number":17,"context_line":"                # NOTE(pabelanger): Glean requires network.service for"},{"line_number":18,"context_line":"                # these platforms when not using networkmanager"},{"line_number":19,"context_line":"                if [[ ${DIB_RELEASE} -lt 8 ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"3fa7e38b_9fb6bddc","line":16,"range":{"start_line":16,"start_character":52,"end_line":16,"end_character":56},"updated":"2019-10-02 11:23:46.000000000","message":"From README file:\n  To use  NetworkManager instead, set\n  ``DIB_SIMPLE_INIT_NETWORKMANAGER`` to non-zero.\n\nShould this condition be \u003d\u003d 0 instead?","commit_id":"008b63317bf1c4a670239bd39ef3bb4f134f6f80"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"db043bb5a0acc956797d3228490fef1c733e3988","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        ;;"},{"line_number":14,"context_line":"    systemd)"},{"line_number":15,"context_line":"        if [[ ${DISTRO_NAME} \u003d~ (centos|rhel7|fedora) ]]; then"},{"line_number":16,"context_line":"            if [[ ${DIB_SIMPLE_INIT_NETWORKMANAGER} !\u003d 1 ]]; then"},{"line_number":17,"context_line":"                # NOTE(pabelanger): Glean requires network.service for"},{"line_number":18,"context_line":"                # these platforms when not using networkmanager"},{"line_number":19,"context_line":"                if [[ ${DIB_RELEASE} -lt 8 ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"3fa7e38b_8e0e8330","line":16,"range":{"start_line":16,"start_character":52,"end_line":16,"end_character":56},"in_reply_to":"3fa7e38b_9fb6bddc","updated":"2019-10-03 08:10:00.000000000","message":"i think this is correct as is, but it brings up a good point ... why do we want this on centos 8?  I think we can make simple-init only support networkmanager there.\n\ni\u0027ll change it so it defaults to that","commit_id":"008b63317bf1c4a670239bd39ef3bb4f134f6f80"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"09c68ce3a8869438a05e1d212ed32604bd550acd","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                # NOTE(pabelanger): Glean requires network.service for"},{"line_number":22,"context_line":"                # these platforms when not using networkmanager"},{"line_number":23,"context_line":"                if [[ ${DIB_RELEASE} -lt 8 ]]; then"},{"line_number":24,"context_line":"                    # Not available on Centos 8"},{"line_number":25,"context_line":"                    # NOTE(ianw) we should evaluate if Fedora needs this"},{"line_number":26,"context_line":"                    systemctl enable network.service"},{"line_number":27,"context_line":"                fi"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"3fa7e38b_77f8b67b","line":24,"updated":"2019-10-03 08:33:32.000000000","message":"It is available but deprecated and doesn\u0027t come installed out of the box IIRC.","commit_id":"a85966c56923c4b23caa1e7561d93d358d60e665"}]}