)]}'
{"diskimage_builder/elements/debian-minimal/environment.d/10-debian-minimal.bash":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"cf731716896629f94f88bd2c547d38651aaa0bb2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"if [ -n \"${DIB_DEBIAN_DISTRIBUTION_SECURITY_MIRROR:-}\" ]; then"},{"line_number":15,"context_line":"    DIB_DISTRIBUTION_SECURITY_MIRROR\u003d$DIB_DEBIAN_DISTRIBUTION_SECURITY_MIRROR"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":"export DIB_DISTRIBUTION_SECURITY_MIRROR\u003d${DIB_DISTRIBUTION_MIRROR:-http://security.debian.org/}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"export DIB_DEBIAN_COMPONENTS\u003d${DIB_DEBIAN_COMPONENTS:-main}"},{"line_number":20,"context_line":"export DIB_DEBIAN_COMPONENTS_WS\u003d${DIB_DEBIAN_COMPONENTS//,/ }"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_40db817c","line":17,"updated":"2019-10-02 16:19:08.000000000","message":"Ahh, whoops, thanks!\n\nI don\u0027t know the reason why $DIB_DEBIAN_DISTRIBUTION_MIRROR is provided as an interface separate from $DIB_DISTRIBUTION_MIRROR, but was doing my best to provide an analog of that behavior. Hopefully DIB reviewers can shed light on it, since there was no code comment explaining (and codesearch.o.o turned up no users of that more specific variable in any of the repos hosted in OpenDev at least).","commit_id":"e79a24c8dedeb6b2a67f6bcc62de9d0c017e164c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"4c9b0a345d287c7fa2284cc0d9b14f59c9d639d7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"if [ -n \"${DIB_DEBIAN_DISTRIBUTION_SECURITY_MIRROR:-}\" ]; then"},{"line_number":15,"context_line":"    DIB_DISTRIBUTION_SECURITY_MIRROR\u003d$DIB_DEBIAN_DISTRIBUTION_SECURITY_MIRROR"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":"export DIB_DISTRIBUTION_SECURITY_MIRROR\u003d${DIB_DISTRIBUTION_MIRROR:-http://security.debian.org/}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"export DIB_DEBIAN_COMPONENTS\u003d${DIB_DEBIAN_COMPONENTS:-main}"},{"line_number":20,"context_line":"export DIB_DEBIAN_COMPONENTS_WS\u003d${DIB_DEBIAN_COMPONENTS//,/ }"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_c074519f","line":17,"range":{"start_line":17,"start_character":42,"end_line":17,"end_character":65},"updated":"2019-10-02 16:14:15.000000000","message":"This should be DIB_DISTRIBUTION_SECURITY_MIRROR\n\nOut of curiosity do you know why the if check above is necessary when we can get the same effect with the var setting on this line?","commit_id":"e79a24c8dedeb6b2a67f6bcc62de9d0c017e164c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"54e1dbaf5dc655e58e2c14c85f5457ba10073aab","unresolved":false,"context_lines":[{"line_number":14,"context_line":"if [ -n \"${DIB_DEBIAN_DISTRIBUTION_SECURITY_MIRROR:-}\" ]; then"},{"line_number":15,"context_line":"    DIB_DISTRIBUTION_SECURITY_MIRROR\u003d$DIB_DEBIAN_DISTRIBUTION_SECURITY_MIRROR"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":"export DIB_DISTRIBUTION_SECURITY_MIRROR\u003d${DIB_DISTRIBUTION_MIRROR:-http://security.debian.org/}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"export DIB_DEBIAN_COMPONENTS\u003d${DIB_DEBIAN_COMPONENTS:-main}"},{"line_number":20,"context_line":"export DIB_DEBIAN_COMPONENTS_WS\u003d${DIB_DEBIAN_COMPONENTS//,/ }"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_d12bba2d","line":17,"in_reply_to":"3fa7e38b_40db817c","updated":"2019-10-03 03:21:16.000000000","message":"I think DIB_$DISTRO_DISTRIBUTION_MIRROR was introduced with I92964b17ec3e47cf97e3a3091f054b2a205ac768 because every element was supposed to obey DIB_DISTRIBUTION_MIRROR but that caused a problem if you wanted to source one config file that set all the mirror paths.  this way you can have\n\n DIB_UBUNTU_DISTRIBUTION_MIRROR\u003dhttp://mirror/ubuntu\n DIB_DEBIAN_DISTRIBUTION_MIRROR\u003dhttp://mirror/foo/debian\n\nall in the one file and just source that globally.","commit_id":"e79a24c8dedeb6b2a67f6bcc62de9d0c017e164c"}]}