)]}'
{"diskimage_builder/elements/dhcp-all-interfaces/install.d/dhcp-all-interfaces.sh":[{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"53c392d2b6ca81c5831c53108f78f8ab1350818d","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            local ipv6_AdvOtherConfigFlag\u003dNo"},{"line_number":149,"context_line":"            if type rdisc6 \u0026\u003e/dev/null; then"},{"line_number":150,"context_line":"                # We have rdisc6, let\u0027s try to configure IPv6 autoconfig/dhcpv6"},{"line_number":151,"context_line":"                tries \u003d 3"},{"line_number":152,"context_line":"                for ((; tries \u003e 0; tries--)); do"},{"line_number":153,"context_line":"                    # Need to retry this, link-local-address required for"},{"line_number":154,"context_line":"                    # Neighbor Discovery, DHCPv6 etc."}],"source_content_type":"text/x-sh","patch_set":10,"id":"3fa7e38b_118cf9d5","line":151,"updated":"2019-11-07 11:00:13.000000000","message":"extra spaces here \n\nNov 07 10:53:01 localhost.localdomain dhcp-all-interfaces.sh[852]: /usr/local/sbin/dhcp-all-interfaces.sh: line 151: tries: command not found","commit_id":"78d638fa4e8e762d0cbc9efa2cf3f00211899513"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"96c961df995aa5a0e2ec14ab010286a1e84db1eb","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                for ((; tries \u003e 0; tries--)); do"},{"line_number":153,"context_line":"                    # Need to retry this, link-local-address required for"},{"line_number":154,"context_line":"                    # Neighbor Discovery, DHCPv6 etc."},{"line_number":155,"context_line":"                    if RA\u003d$(rdisc6 --single \"$interface\" 2\u003e/dev/null); then"},{"line_number":156,"context_line":"                        ipv6_init\u003dTrue"},{"line_number":157,"context_line":"                        ipv6_AdvManagedFlag\u003d$(echo \"$RA\" |  grep \"Stateful address conf.\" | awk -F: \u0027{ print $2 }\u0027)"},{"line_number":158,"context_line":"                        ipv6_AdvOtherConfigFlag\u003d$(echo \"$RA\" |  grep \"Stateful other conf.\" | awk -F: \u0027{ print $2 }\u0027)"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3fa7e38b_5d6daa97","line":155,"updated":"2019-11-07 02:40:36.000000000","message":"IMHO you mix build-time and run-time.\n\nImages might typically build in one environment and build in another one.  Therefore the resulting image should not have any information of the build environment.","commit_id":"78d638fa4e8e762d0cbc9efa2cf3f00211899513"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"8ec89ca54bc9c892902ed777a2486f4481de638b","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                for ((; tries \u003e 0; tries--)); do"},{"line_number":153,"context_line":"                    # Need to retry this, link-local-address required for"},{"line_number":154,"context_line":"                    # Neighbor Discovery, DHCPv6 etc."},{"line_number":155,"context_line":"                    if RA\u003d$(rdisc6 --single \"$interface\" 2\u003e/dev/null); then"},{"line_number":156,"context_line":"                        ipv6_init\u003dTrue"},{"line_number":157,"context_line":"                        ipv6_AdvManagedFlag\u003d$(echo \"$RA\" |  grep \"Stateful address conf.\" | awk -F: \u0027{ print $2 }\u0027)"},{"line_number":158,"context_line":"                        ipv6_AdvOtherConfigFlag\u003d$(echo \"$RA\" |  grep \"Stateful other conf.\" | awk -F: \u0027{ print $2 }\u0027)"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3fa7e38b_5138313a","line":155,"in_reply_to":"3fa7e38b_5d6daa97","updated":"2019-11-07 10:38:42.000000000","message":"This script does not run in the build environment. It\u0027s run in the built image by the init system during boot.","commit_id":"78d638fa4e8e762d0cbc9efa2cf3f00211899513"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"fe5c666bafa07c6879025cccbf8cdeaf29ce1f90","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                for ((; tries \u003e 0; tries--)); do"},{"line_number":153,"context_line":"                    # Need to retry this, link-local-address required for"},{"line_number":154,"context_line":"                    # Neighbor Discovery, DHCPv6 etc."},{"line_number":155,"context_line":"                    if RA\u003d$(rdisc6 --single \"$interface\" 2\u003e/dev/null); then"},{"line_number":156,"context_line":"                        ipv6_init\u003dTrue"},{"line_number":157,"context_line":"                        ipv6_AdvManagedFlag\u003d$(echo \"$RA\" |  grep \"Stateful address conf.\" | awk -F: \u0027{ print $2 }\u0027)"},{"line_number":158,"context_line":"                        ipv6_AdvOtherConfigFlag\u003d$(echo \"$RA\" |  grep \"Stateful other conf.\" | awk -F: \u0027{ print $2 }\u0027)"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_22f68592","line":155,"range":{"start_line":155,"start_character":28,"end_line":155,"end_character":68},"updated":"2019-11-07 15:13:14.000000000","message":"I think we may want to use the error codes of rdisc6 here.\nIf we get a timeout we should probably just move on, if we get an error we should do seme retries to wait for the local-link-addr? to be available.\n\nFrom RDISC6(8) manual page:\nIf  rdisc6  does  not  receive any response after the specified number of attempts waiting for wait_ms milliseconds each time, it will exit with code 2. On error, it exits with code 1.  Otherwise it exits with code 0.","commit_id":"17d2d75b5d8bac2b6c30faf99503fc574d12121d"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"e1c55ffaa704c07fb917507f85600263ee5eb7f0","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                for ((; tries \u003e 0; tries--)); do"},{"line_number":153,"context_line":"                    # Need to retry this, link-local-address required for"},{"line_number":154,"context_line":"                    # Neighbor Discovery, DHCPv6 etc."},{"line_number":155,"context_line":"                    if RA\u003d$(rdisc6 --single \"$interface\" 2\u003e/dev/null); then"},{"line_number":156,"context_line":"                        ipv6_init\u003dTrue"},{"line_number":157,"context_line":"                        ipv6_AdvManagedFlag\u003d$(echo \"$RA\" |  grep \"Stateful address conf.\" | awk -F: \u0027{ print $2 }\u0027)"},{"line_number":158,"context_line":"                        ipv6_AdvOtherConfigFlag\u003d$(echo \"$RA\" |  grep \"Stateful other conf.\" | awk -F: \u0027{ print $2 }\u0027)"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_d4663656","line":155,"range":{"start_line":155,"start_character":28,"end_line":155,"end_character":68},"in_reply_to":"3fa7e38b_22f68592","updated":"2019-11-10 21:25:07.000000000","message":"Looking at the error codes wouldn\u0027t be a bad idea I can\u0027t say what the error code was in my example, I guess it was exit 1 as it didn\u0027t wait for a response.","commit_id":"17d2d75b5d8bac2b6c30faf99503fc574d12121d"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"5a23463790ab981c12d14c6cec54e8f1a6ac57cd","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                        ipv6_AdvManagedFlag\u003d$(echo \"$RA\" |  grep \"Stateful address conf.\" | awk -F: \u0027{ print $2 }\u0027)"},{"line_number":158,"context_line":"                        ipv6_AdvOtherConfigFlag\u003d$(echo \"$RA\" |  grep \"Stateful other conf.\" | awk -F: \u0027{ print $2 }\u0027)"},{"line_number":159,"context_line":"                    fi"},{"line_number":160,"context_line":"                    [ \"$ipv6_init\" \u003d\u003d \"True\" ] \u0026\u0026 break"},{"line_number":161,"context_line":"                done"},{"line_number":162,"context_line":"            else"},{"line_number":163,"context_line":"                echo \"rdisc6 not available, skipping IPv6 configuration.\""}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_acba6e6e","line":160,"updated":"2019-11-07 14:45:43.000000000","message":"I think we should insert a short sleep here, I seen this loop complete 3 times without getting anything from rdisc6 (it doesn\u0027t seem to be waiting), when I add a sleep it worked.\n\n\u003e Nov 07 12:32:51 localhost.localdomain dhcp-all-interfaces.sh[860]: ++ rdisc6 --single eth0\n\u003e Nov 07 12:32:51 localhost.localdomain dhcp-all-interfaces.sh[860]: + RA\u003d\u0027Soliciting ff02::2 (ff02::2) on eth0...\u0027\n\u003e Nov 07 12:32:51 localhost.localdomain dhcp-all-interfaces.sh[860]: + \u0027[\u0027 False \u003d\u003d True \u0027]\u0027","commit_id":"17d2d75b5d8bac2b6c30faf99503fc574d12121d"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"83cd7db7c89e1a2278bba1bc8a1bd0596b46acbf","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                    # Need to retry this, link-local-address required for"},{"line_number":156,"context_line":"                    # Neighbor Discovery, DHCPv6 etc."},{"line_number":157,"context_line":"                    set +e # Do not exit on error, capture rdisc6 error codes."},{"line_number":158,"context_line":"                    RA\u003d$(rdisc6 --retry 3 --single \"$interface\" 2\u003e/dev/null)"},{"line_number":159,"context_line":"                    local return_code\u003d$?"},{"line_number":160,"context_line":"                    set -e # Re-enable exit on error."},{"line_number":161,"context_line":"                    if [ $return_code -eq 0 ]; then"}],"source_content_type":"text/x-sh","patch_set":13,"id":"ff570b3c_139178f2","line":158,"range":{"start_line":158,"start_character":25,"end_line":158,"end_character":31},"updated":"2020-06-11 16:01:35.000000000","message":"It seems I am having an egg/chick issue here, for the dnsmasq, if enable-ra is not configured, the rdisc6 will get nothing from it, but if configured, dnsmasq would refuse to offer an address (maybe is because of the iaid changed) on the second run, unless the previous lease is expired.","commit_id":"f94508d537432817619932074a5f98ea08d93055"}],"diskimage_builder/elements/dhcp-all-interfaces/pkg-map":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cbabadc9b4515c542df6037c99aa6f2796090629","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  \"family\": {"},{"line_number":3,"context_line":"    \"redhat\": {"},{"line_number":4,"context_line":"      \"dhcp-client\": \"dhclient\","},{"line_number":5,"context_line":"      \"ndisc6\": \"ndisc6\""},{"line_number":6,"context_line":"    },"},{"line_number":7,"context_line":"    \"gentoo\": {"},{"line_number":8,"context_line":"      \"dhcp-client\": \"net-misc/dhcpcd\","}],"source_content_type":"application/octet-stream","patch_set":13,"id":"3fa7e38b_8299796e","line":5,"updated":"2019-11-27 19:59:09.000000000","message":"This breaks building IPA with CentOS 8: https://e6e79a4a5a78bf536503-240d4aa44573f96d2050363ab0d496a6.ssl.cf1.rackcdn.com/696383/1/check/ironic-python-agent-check-image-dib-centos8/d9075f3/job-output.txt\n\nThis package doesn\u0027t seem to exist.","commit_id":"f94508d537432817619932074a5f98ea08d93055"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a5feec5ae2ec5d5741881be7aedeb520c65553de","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  \"family\": {"},{"line_number":3,"context_line":"    \"redhat\": {"},{"line_number":4,"context_line":"      \"dhcp-client\": \"dhclient\","},{"line_number":5,"context_line":"      \"ndisc6\": \"ndisc6\""},{"line_number":6,"context_line":"    },"},{"line_number":7,"context_line":"    \"gentoo\": {"},{"line_number":8,"context_line":"      \"dhcp-client\": \"net-misc/dhcpcd\","}],"source_content_type":"application/octet-stream","patch_set":13,"id":"3fa7e38b_d73baae7","line":5,"in_reply_to":"3fa7e38b_8299796e","updated":"2019-11-28 09:23:06.000000000","message":"Right it was added to RDO (https://review.rdoproject.org/r/#/q/topic:ndisc6+(status:open+OR+status:merged), and downstream RHEL8 have it ndisc6-1.0.3-9.el8ost. \n\nThe actual script is designed to test for the existance of the ndicsc utilities before trying to use them. The package is installed with:\n\n2019-11-27 18:36:58.873651 | ubuntu-bionic | 2019-11-27 18:36:58.868 | \u003e + dnf -v -y install policycoreutils-python-utils dmidecode git lshw util-linux tcpdump ca-certificates curl dracut-config-generic psmisc python3-pip qemu-img which traceroute audit parted dosfstools selinux-policy mdadm genisoimage hdparm python3-virtualenv python3-libselinux initscripts redhat-lsb-core selinux-policy-targeted ipmitool dhcp-client dhclient python3-policycoreutils redhat-rpm-config kernel kmod lsof iscsi-initiator-utils rsync dracut python3-devel NetworkManager grubby openssh ndisc6 man-pages gcc iptables targetcli gdisk\n\ndnf and yum behaves different for missing packages, I believe yum would exit OK but print a message that the missing package was not installed by default. dnf will exit with an error if packages are missing.\n\nWe can get the same behaviour with dnf if we add `--setopt\u003dstrict\u003d0` - See: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1197456","commit_id":"f94508d537432817619932074a5f98ea08d93055"}]}