)]}'
{"diskimage_builder/elements/dhcp-all-interfaces/install.d/50-dhcp-all-interfaces":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"afa99e918a97ec71b71501d9558e9598b987cdcb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    else"},{"line_number":17,"context_line":"        yum -v -y install ndisc6 || true"},{"line_number":18,"context_line":"    fi"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# this script is not needed on Gentoo."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3fa7e38b_644c469d","line":19,"updated":"2019-12-03 21:25:49.000000000","message":"for all RH platforms ${YUM} should be defined to the right thing.  Since this intended to be temporary we can just go with this for simplicity as others have reviewed","commit_id":"7948fee7e25707904f81ccc8854a1f98265c8f0b"}],"diskimage_builder/elements/yum/bin/install-packages":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f2c7412afd002cc5339309e1516f26baf99db4eb","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# dnf should\u0027nt error on missing packages. (i.e behave like yum)"},{"line_number":31,"context_line":"if [ \"$YUM\" \u003d\u003d \"dnf\" ]; then"},{"line_number":32,"context_line":"    EXTRA_ARGS+\u003d\" --setopt\u003dstrict\u003d0\""},{"line_number":33,"context_line":"fi"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# save global xtrace state"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa7e38b_a3dfc664","line":32,"updated":"2019-11-29 08:34:38.000000000","message":"is this temporary? i mean do we want to add a note here to remove it? \n\nthanks dtantsur for the note (was not clear just by looking at the bug) ... will ndisc6 become available and so we can remove this at some point?","commit_id":"23e3fcc4bc42a0eb8c7a83b96cfde38073bd63a7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b8c7a42c6ec1aa4e71335ccf723f9efc59c47c59","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# dnf should\u0027nt error on missing packages. (i.e behave like yum)"},{"line_number":31,"context_line":"if [ \"$YUM\" \u003d\u003d \"dnf\" ]; then"},{"line_number":32,"context_line":"    EXTRA_ARGS+\u003d\" --setopt\u003dstrict\u003d0\""},{"line_number":33,"context_line":"fi"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# save global xtrace state"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa7e38b_b2bdc068","line":32,"in_reply_to":"3fa7e38b_12d7f4c2","updated":"2019-12-02 07:57:42.000000000","message":"ack, I will update the comment in code with more details.","commit_id":"23e3fcc4bc42a0eb8c7a83b96cfde38073bd63a7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"58821ccf0115f293980d03c1eb9432586bc4f023","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# dnf should\u0027nt error on missing packages. (i.e behave like yum)"},{"line_number":31,"context_line":"if [ \"$YUM\" \u003d\u003d \"dnf\" ]; then"},{"line_number":32,"context_line":"    EXTRA_ARGS+\u003d\" --setopt\u003dstrict\u003d0\""},{"line_number":33,"context_line":"fi"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# save global xtrace state"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa7e38b_ee304558","line":32,"in_reply_to":"3fa7e38b_a3dfc664","updated":"2019-11-29 10:24:36.000000000","message":"ndisc6 should become available as RDO get\u0027s CentOS 8 support.\n\nIf we want diskimage-builder to fail the image build when packages are missing; it did\u0027nt on CentOS 7; we may want to revert this at some point.\n\nI believe we can also resolve the CentOS 8 issue by extending the pkg-map[1] to also take into account the Release number. Something like below, but we\u0027d then have to change that once ndisc6 is available in RDO for CentOS 8.\n\n{\n  \"relese\": {\n    \"centos\":\n       \"7\": {\n          \"ndisc6\": \"ndisc6\"\n       }\n       \"8\": {\n          \"ndisc6\": \"\"\n       }\n    }\n  },\n  \"family\": {\n    \"redhat\": {\n      \"dhcp-client\": \"dhclient\",\n      \"ndisc6\": \"ndisc6\"\n    },\n    \"gentoo\": {\n      \"dhcp-client\": \"net-misc/dhcpcd\",\n      \"ndisc6\": \"net-misc/ndisc6\"\n    },\n    \"suse\": {\n      \"dhcp-client\": \"dhcp-client\"\n    },\n    \"debian\": {\n      \"ifupdown\": \"ifupdown\",\n      \"ndisc6\": \"ndisc6\"\n    }\n  },\n  \"default\": {\n    \"dhcp-client\": \"isc-dhcp-client\",\n    \"ifupdown\": \"\",\n    \"ndisc6\": \"\"\n  }\n}\n\n\n\n[1] https://review.opendev.org/#/c/692110/13/diskimage_builder/elements/dhcp-all-interfaces/pkg-map","commit_id":"23e3fcc4bc42a0eb8c7a83b96cfde38073bd63a7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b8c7a42c6ec1aa4e71335ccf723f9efc59c47c59","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# dnf should\u0027nt error on missing packages. (i.e behave like yum)"},{"line_number":31,"context_line":"if [ \"$YUM\" \u003d\u003d \"dnf\" ]; then"},{"line_number":32,"context_line":"    EXTRA_ARGS+\u003d\" --setopt\u003dstrict\u003d0\""},{"line_number":33,"context_line":"fi"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# save global xtrace state"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa7e38b_ba060021","line":32,"in_reply_to":"3fa7e38b_d7307558","updated":"2019-12-02 07:57:42.000000000","message":"The package[1] is in EPEL 7. But not in EPEL 8. I can look into getting it added in EPEL 8.\n\n[1] http://mirrors.glesys.net/fedora/epel/7/x86_64/Packages/n/ndisc6-1.0.3-1.el7.x86_64.rpm","commit_id":"23e3fcc4bc42a0eb8c7a83b96cfde38073bd63a7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"980164112632700b6d8ec75b0d7e706bf3b56c12","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# dnf should\u0027nt error on missing packages. (i.e behave like yum)"},{"line_number":31,"context_line":"if [ \"$YUM\" \u003d\u003d \"dnf\" ]; then"},{"line_number":32,"context_line":"    EXTRA_ARGS+\u003d\" --setopt\u003dstrict\u003d0\""},{"line_number":33,"context_line":"fi"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# save global xtrace state"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa7e38b_12d7f4c2","line":32,"in_reply_to":"3fa7e38b_d7307558","updated":"2019-12-02 07:40:45.000000000","message":"ack thanks for answers\n\non one hand i think we want to \u0027keep same behaviour\u0027 and so don\u0027t error here.\n\nhowever on the other hand i wonder if we didn\u0027t error as an oversight i.e. really we should be erroring when some package we need isn\u0027t there?\n\nthanks for the comment in the code, but since you\u0027ve gone to the trouble of including that you may as well include \"see https://bugs.launchpad.net/diskimage-builder/+bug/1754219\" it will make it easier and more likely (though still not guaranteed ;)) that someone might revisit that in the future and remove some unneeded exception here (e.g. once ndisc6 is available and beyond)","commit_id":"23e3fcc4bc42a0eb8c7a83b96cfde38073bd63a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9183c074898cd94dac6643a81a34e83a4627ec09","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# dnf should\u0027nt error on missing packages. (i.e behave like yum)"},{"line_number":31,"context_line":"if [ \"$YUM\" \u003d\u003d \"dnf\" ]; then"},{"line_number":32,"context_line":"    EXTRA_ARGS+\u003d\" --setopt\u003dstrict\u003d0\""},{"line_number":33,"context_line":"fi"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# save global xtrace state"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa7e38b_d7307558","line":32,"in_reply_to":"3fa7e38b_ee304558","updated":"2019-11-29 18:11:10.000000000","message":"Note that we don\u0027t expect RDO to always be available. Anything unconditionally installed here must be available from either CentOS or EPEL.","commit_id":"23e3fcc4bc42a0eb8c7a83b96cfde38073bd63a7"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7126257b5099815cebcbcd69488ba60444a9c8ef","unresolved":false,"context_lines":[{"line_number":33,"context_line":"# TODO(hjensas): We may want to remove this once ndisc6 is available in EPEL 8."},{"line_number":34,"context_line":"if [ \"$YUM\" \u003d\u003d \"dnf\" ]; then"},{"line_number":35,"context_line":"    EXTRA_ARGS+\u003d\" --setopt\u003dstrict\u003d0\""},{"line_number":36,"context_line":"fi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# save global xtrace state"},{"line_number":39,"context_line":"_xtrace\u003d$(set +o | grep xtrace)"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_32b1bee1","line":36,"updated":"2019-12-03 05:52:05.000000000","message":"i\u0027m worried that this turns if off for everything just to work around one package.\n\nIn devstack, we ended up wrapping yum with a awk/sed matcher to find missing packages and stop, it was such a mis-\"feature\".  we\u0027d always have things missing and the script wouldn\u0027t stop.\n\nso i\u0027m hesitant to introduce that same behaviour into dib; it\u0027s better to be strict.\n\ncan this be worked around by moving the install into an element script (where you can do \"|| true\" or whatever on a one-off basis)","commit_id":"a9898348c6da1d58b910c838c155ddeff8e24c6f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"08a90c0dbcbf5fac914f5494073eda8f128a3208","unresolved":false,"context_lines":[{"line_number":33,"context_line":"# TODO(hjensas): We may want to remove this once ndisc6 is available in EPEL 8."},{"line_number":34,"context_line":"if [ \"$YUM\" \u003d\u003d \"dnf\" ]; then"},{"line_number":35,"context_line":"    EXTRA_ARGS+\u003d\" --setopt\u003dstrict\u003d0\""},{"line_number":36,"context_line":"fi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# save global xtrace state"},{"line_number":39,"context_line":"_xtrace\u003d$(set +o | grep xtrace)"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_2575f733","line":36,"in_reply_to":"3fa7e38b_32b1bee1","updated":"2019-12-03 11:14:57.000000000","message":"ok, I will take a look at moving this to an element script.","commit_id":"a9898348c6da1d58b910c838c155ddeff8e24c6f"}]}