)]}'
{"diskimage_builder/disk_image_create.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"12e4415627050db83e5697db0d82a4c2f78be0d8","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    script \u003d \"%s/%s\" % (diskimage_builder.paths.get_path(\u0027lib\u0027),"},{"line_number":83,"context_line":"                        os.path.basename(sys.argv[0]))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    subprocess.call([\u0027/bin/bash\u0027, script] + sys.argv[1:], env\u003denviron)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    # Cleanup python symlink"},{"line_number":88,"context_line":"    os.remove(python_path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f7169458","line":85,"updated":"2019-12-04 20:07:16.000000000","message":"hrm, this is fairly different to exec-ing ourself which makes me a bit worried; as we\u0027ve had issues with file-descriptors hanging around etc before.\n\nbut as a first thing, i think we need to capture the exit code and make sure we return that (i think that\u0027s why the test is failing, because it expects an error).\n\nanother thought (that i\u0027d probably prefer, because it isolates us from changing this too much) is that we could clean this up in the exit handler of the extant script to avoid wrapping another subprocess layer and any problems that might incur.  could either set a private variable with the temp path, or pull it out of the path, or just clean everything with a given prefix...","commit_id":"6d66b25a7460a760a3cadeca1ad0b52fcd4a73bb"}],"diskimage_builder/lib/disk-image-create":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0c7e7be8c0f8dafe058424aac8809209641b9707","unresolved":false,"context_lines":[{"line_number":600,"context_line":"# Remove the leftovers, i.e. the temporary image directory."},{"line_number":601,"context_line":"cleanup_image_dir"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"# Cleanup temporary python exec path"},{"line_number":604,"context_line":"export PATH\u003d$ORIGINAL_PATH"},{"line_number":605,"context_line":"rm \"$PYTHON_EXEC_TMP/python\""},{"line_number":606,"context_line":"rmdir \"$PYTHON_EXEC_TMP\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa7e38b_f3bd4167","line":603,"updated":"2019-12-05 07:53:31.000000000","message":"i hate to be a pain on this, but can we hook it into the clean-up functions so it always goes away?\n\ntrap_cleanup is what i\u0027m thinking of","commit_id":"d70bb33b659b97d200f446a2ee44d1fdc23ff90e"}]}