)]}'
{"diskimage_builder/elements/containerfile/root.d/08-containerfile":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f40d9c024009bed33c91440bc80dc58ced19526a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2015 Hewlett-Packard Development Company, L.P."},{"line_number":4,"context_line":"# Copyright 2019 Red Hat, INC."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1fa4df85_8a64d8e6","line":3,"updated":"2020-03-18 20:49:58.000000000","message":"This is copied from a file with that header, so it is correct to leave it.","commit_id":"cb890aba5b9647a51f77402379108e2ba44343c0"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5bd5a1e9eef30e08838d80e1a5aa9bde13a1f22c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2015 Hewlett-Packard Development Company, L.P."},{"line_number":4,"context_line":"# Copyright 2019 Red Hat, INC."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_33fef26a","line":3,"updated":"2020-01-13 03:59:22.000000000","message":"probably no (C) HP now :)","commit_id":"cb890aba5b9647a51f77402379108e2ba44343c0"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f40d9c024009bed33c91440bc80dc58ced19526a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"set -eu"},{"line_number":22,"context_line":"set -o pipefail"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"if [ -f ${TARGET_ROOT}/.extra_settings ] ; then"},{"line_number":25,"context_line":"    . ${TARGET_ROOT}/.extra_settings"},{"line_number":26,"context_line":"fi"},{"line_number":27,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1fa4df85_2a6364de","line":24,"updated":"2020-03-18 20:49:58.000000000","message":"No, this is something that\u0027s present in the docker element I based this on.  It\u0027s also in the debian-system, debian-upstart, debootstrap, docker, and yum-minimal elements.","commit_id":"cb890aba5b9647a51f77402379108e2ba44343c0"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5bd5a1e9eef30e08838d80e1a5aa9bde13a1f22c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"set -eu"},{"line_number":22,"context_line":"set -o pipefail"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"if [ -f ${TARGET_ROOT}/.extra_settings ] ; then"},{"line_number":25,"context_line":"    . ${TARGET_ROOT}/.extra_settings"},{"line_number":26,"context_line":"fi"},{"line_number":27,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_f3effaaf","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":39},"updated":"2020-01-13 03:59:22.000000000","message":"is this some sort of standard docker flag file i\u0027ve missed, or something else?","commit_id":"cb890aba5b9647a51f77402379108e2ba44343c0"}],"diskimage_builder/elements/containerfile/test-elements/bionic-build-succeeds/environment.d/10-set-file.bash":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f40d9c024009bed33c91440bc80dc58ced19526a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"path\u003d\"$( cd \"$( dirname \"${BASH_SOURCE[0]}\" )\" \u003e/dev/null 2\u003e\u00261 \u0026\u0026 pwd )\""},{"line_number":2,"context_line":"path\u003d\"$( dirname $path)\""},{"line_number":3,"context_line":"export DIB_CONTAINER_FILE\u003d\"$path/files/Dockerfile\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_4a5ee012","line":1,"updated":"2020-03-18 20:49:58.000000000","message":"How would you use that in a shell script like this?","commit_id":"cb890aba5b9647a51f77402379108e2ba44343c0"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"cfa3d35dd16b2f3efeb436e8f8bdc51d47a64d7e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"path\u003d\"$( cd \"$( dirname \"${BASH_SOURCE[0]}\" )\" \u003e/dev/null 2\u003e\u00261 \u0026\u0026 pwd )\""},{"line_number":2,"context_line":"path\u003d\"$( dirname $path)\""},{"line_number":3,"context_line":"export DIB_CONTAINER_FILE\u003d\"$path/files/Dockerfile\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_2d637ede","line":1,"updated":"2020-03-18 21:49:41.000000000","message":"That seems both longer and more complicated to follow than the bash-ism; and since we\u0027re in bash anyway, why not keep it all in bash?","commit_id":"cb890aba5b9647a51f77402379108e2ba44343c0"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5bd5a1e9eef30e08838d80e1a5aa9bde13a1f22c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"path\u003d\"$( cd \"$( dirname \"${BASH_SOURCE[0]}\" )\" \u003e/dev/null 2\u003e\u00261 \u0026\u0026 pwd )\""},{"line_number":2,"context_line":"path\u003d\"$( dirname $path)\""},{"line_number":3,"context_line":"export DIB_CONTAINER_FILE\u003d\"$path/files/Dockerfile\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_b317429e","line":1,"updated":"2020-01-13 03:59:22.000000000","message":"we did create diskimage_builder.paths.get_path(\u0027elements\u0027) to make something like this you can consistently offset against too","commit_id":"cb890aba5b9647a51f77402379108e2ba44343c0"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"41f80fdfe8ca346775715506922ade0309dd5894","unresolved":false,"context_lines":[{"line_number":1,"context_line":"path\u003d\"$( cd \"$( dirname \"${BASH_SOURCE[0]}\" )\" \u003e/dev/null 2\u003e\u00261 \u0026\u0026 pwd )\""},{"line_number":2,"context_line":"path\u003d\"$( dirname $path)\""},{"line_number":3,"context_line":"export DIB_CONTAINER_FILE\u003d\"$path/files/Dockerfile\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_4a8ca07e","line":1,"in_reply_to":"1fa4df85_4a5ee012","updated":"2020-03-18 20:54:24.000000000","message":"something like what we do in disk-image-create\n\n _BASE_ELEMENT_DIR\u003d$(${DIB_PYTHON_EXEC:-python} -c \u0027\n import diskimage_builder.paths\n diskimage_builder.paths.show_path(\"elements\")\u0027)","commit_id":"cb890aba5b9647a51f77402379108e2ba44343c0"}],"diskimage_builder/elements/containerfile/test-elements/focal-build-succeeds/environment.d/10-set-distro.bash":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"07d5520bb48700b06115910ddc46fc87d6be456e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# For the openstack-ci-mirrors element"},{"line_number":2,"context_line":"export DISTRO_NAME\u003dubuntu"}],"source_content_type":"text/x-sh","patch_set":7,"id":"9f560f44_3f9fddb3","line":2,"updated":"2020-10-08 03:48:59.000000000","message":"The DISTRO_NAME is used in several places and basically required to be set.  Currently all the base elements set this, because obviously things like \"ubuntu-minimal\" and \"centos-minimal\" know what distro they\u0027re building.  It\u0027s not DIB_ prefixed because it was considered to be internal and automatically set by the build elements.\n\nDIB_RELEASE will be similar; although most build environments (such as here in CI) will be setting that already to choose between releases.\n\nProbably we could guess this from the incoming container name, and if we can\u0027t match that, then error out and tell the user they need to set DISTRO_NAME/DIB_RELEASE","commit_id":"04aaed6ae21b0670d9f8f19539e4665d7f145f7b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f2fc51d70deea9d6cad8bfc653ea6d8d96f9942b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# For the openstack-ci-mirrors element"},{"line_number":2,"context_line":"export DISTRO_NAME\u003dubuntu"}],"source_content_type":"text/x-sh","patch_set":7,"id":"9f560f44_0288c21f","line":2,"in_reply_to":"9f560f44_3f9fddb3","updated":"2020-10-08 05:07:32.000000000","message":"... or ... we have ubuntu-containerfile elements, that set all this for you and choose the right dockerfile/image ...","commit_id":"04aaed6ae21b0670d9f8f19539e4665d7f145f7b"}]}