)]}'
{".zuul.d/jobs.yaml":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"54391f71fd5e1597d03f0dc0e155236799da33c7","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        base_element: opensuse-minimal"},{"line_number":416,"context_line":"        release: \u0027tumbleweed\u0027"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"- job:"},{"line_number":419,"context_line":"    name: dib-ironic-partition-bios-ipmi-iscsi"},{"line_number":420,"context_line":"    description: |"},{"line_number":421,"context_line":"      Test ironic with ramdisk built by diskimage-builder."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_80716048","line":418,"updated":"2020-01-15 09:21:22.000000000","message":"Why do you need these two new jobs instead of just adding their parents to the check queue? Is it because their parents do not include DIB in their required-projects list? Would it be better to include DIB in those jobs instead? Otherwise, the these two ironic jobs could pass in DIB gate but not in Ironic gate.","commit_id":"30aa0a5a6b7e65c7eedb45a8316ea07338d88295"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dc0f2497b72f3e8612c247ff1b4ee59fbb97f8fc","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        base_element: opensuse-minimal"},{"line_number":416,"context_line":"        release: \u0027tumbleweed\u0027"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"- job:"},{"line_number":419,"context_line":"    name: dib-ironic-partition-bios-ipmi-iscsi"},{"line_number":420,"context_line":"    description: |"},{"line_number":421,"context_line":"      Test ironic with ramdisk built by diskimage-builder."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_ae632dde","line":418,"in_reply_to":"3fa7e38b_80716048","updated":"2020-01-15 10:36:15.000000000","message":"Yes, because of this. DIB is usually consumed from releases, similar to libraries, so I assumed it\u0027s better to get ironic against released DIB (so that we don\u0027t start relying on unreleased features).","commit_id":"30aa0a5a6b7e65c7eedb45a8316ea07338d88295"}],".zuul.d/project.yaml":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e246b09481497e64298c81de22be60fe1e9de311","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        - dib-functests-bionic-python3-containers"},{"line_number":31,"context_line":"        # IPA jobs that build an image without further validations."},{"line_number":32,"context_line":"        - ironic-python-agent-check-image-dib-centos8"},{"line_number":33,"context_line":"        - ironic-python-agent-check-image-dib-centos7:"},{"line_number":34,"context_line":"            voting: false"},{"line_number":35,"context_line":"        # IPA jobs that build AND validate an image via deployment."},{"line_number":36,"context_line":"        - ipa-tempest-wholedisk-bios-ipmi-direct-dib-src:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_6872bbe6","line":33,"range":{"start_line":33,"start_character":10,"end_line":33,"end_character":53},"updated":"2020-01-21 11:40:29.000000000","message":"Note that continued CentOS 7 support is no longer a requirement starting from Ussuri. DIB may at some point drop it. Please consider this and evaluate how to best handle it in Ironic stable branches CI jobs prior to Ussuri (i.e. consume DIB from upper-constraints.txt from given branch instead of master).","commit_id":"7035326412a4697cb3bb9dc9f89cb173fbfd34a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e67878adc368b2b15054c37d196d473da50ef82","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        - dib-functests-bionic-python3-containers"},{"line_number":31,"context_line":"        # IPA jobs that build an image without further validations."},{"line_number":32,"context_line":"        - ironic-python-agent-check-image-dib-centos8"},{"line_number":33,"context_line":"        - ironic-python-agent-check-image-dib-centos7:"},{"line_number":34,"context_line":"            voting: false"},{"line_number":35,"context_line":"        # IPA jobs that build AND validate an image via deployment."},{"line_number":36,"context_line":"        - ipa-tempest-wholedisk-bios-ipmi-direct-dib-src:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_83a7d809","line":33,"range":{"start_line":33,"start_character":10,"end_line":33,"end_character":53},"in_reply_to":"3fa7e38b_282603ce","updated":"2020-01-21 11:51:58.000000000","message":"I\u0027ve realized that we do use DIB from upper-constraints in stable/train. Note that this, however, contradicts your previous recommendation of adding DIB to required-projects :)","commit_id":"7035326412a4697cb3bb9dc9f89cb173fbfd34a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b606a23190612c2361f4fa7c4daf574ff58de706","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        - dib-functests-bionic-python3-containers"},{"line_number":31,"context_line":"        # IPA jobs that build an image without further validations."},{"line_number":32,"context_line":"        - ironic-python-agent-check-image-dib-centos8"},{"line_number":33,"context_line":"        - ironic-python-agent-check-image-dib-centos7:"},{"line_number":34,"context_line":"            voting: false"},{"line_number":35,"context_line":"        # IPA jobs that build AND validate an image via deployment."},{"line_number":36,"context_line":"        - ipa-tempest-wholedisk-bios-ipmi-direct-dib-src:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_282603ce","line":33,"range":{"start_line":33,"start_character":10,"end_line":33,"end_character":53},"in_reply_to":"3fa7e38b_6872bbe6","updated":"2020-01-21 11:44:59.000000000","message":"Unless you want to start having stable branches, there are no way we can avoid this situation. Consuming DIB from upper-constraints.txt means that bugs can never be fixed (e.g. if an update to CentOS 7 breaks something in DIB).","commit_id":"7035326412a4697cb3bb9dc9f89cb173fbfd34a7"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"5dd9cafe6c9d11b799718ff86581666eb9a83d8b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        - dib-functests-bionic-python3-containers"},{"line_number":31,"context_line":"        # IPA jobs that build an image without further validations."},{"line_number":32,"context_line":"        - ironic-python-agent-check-image-dib-centos8"},{"line_number":33,"context_line":"        - ironic-python-agent-check-image-dib-centos7:"},{"line_number":34,"context_line":"            voting: false"},{"line_number":35,"context_line":"        # IPA jobs that build AND validate an image via deployment."},{"line_number":36,"context_line":"        - ipa-tempest-wholedisk-bios-ipmi-direct-dib-src:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_c3ef101a","line":33,"range":{"start_line":33,"start_character":10,"end_line":33,"end_character":53},"in_reply_to":"3fa7e38b_83a7d809","updated":"2020-01-21 11:56:28.000000000","message":"My comment was about the change proposed in the depends-on patch [1] that you\u0027re adding DIB to the required-project list of a base job. However, I did not consider that that is on a branched project (unlike tempest plugin projects that are branchless) so the base job will not impact stable branch jobs because they are kept defined in separate branches from master.\n\n[1] https://review.opendev.org/#/c/703585/1/zuul.d/ironic-python-agent-jobs.yaml@165","commit_id":"7035326412a4697cb3bb9dc9f89cb173fbfd34a7"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e246b09481497e64298c81de22be60fe1e9de311","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        - dib-nodepool-functional-openstack-ubuntu-bionic-src"},{"line_number":53,"context_line":"        - dib-functests-xenial-python3"},{"line_number":54,"context_line":"        - dib-functests-centos7-python2"},{"line_number":55,"context_line":"        - ironic-python-agent-check-image-dib-centos8"},{"line_number":56,"context_line":"    experimental:"},{"line_number":57,"context_line":"      jobs:"},{"line_number":58,"context_line":"        - dib-nodepool-functional-openstack-gentoo-src"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_e85eab4f","line":55,"updated":"2020-01-21 11:40:29.000000000","message":"I\u0027d rather see this job consistently passing for some time before adding it to the gate.","commit_id":"7035326412a4697cb3bb9dc9f89cb173fbfd34a7"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"b022501bfe8c1e5adf170906f2c4e02465fe77c6","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        - dib-nodepool-functional-openstack-ubuntu-bionic-src"},{"line_number":53,"context_line":"        - dib-functests-xenial-python3"},{"line_number":54,"context_line":"        - dib-functests-centos7-python2"},{"line_number":55,"context_line":"        - ironic-python-agent-check-image-dib-centos8"},{"line_number":56,"context_line":"    experimental:"},{"line_number":57,"context_line":"      jobs:"},{"line_number":58,"context_line":"        - dib-nodepool-functional-openstack-gentoo-src"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_e396cca0","line":55,"in_reply_to":"3fa7e38b_68095b30","updated":"2020-01-21 11:52:06.000000000","message":"DIB has tests for CentOS 8 so we should be able to catch issues related to CentOS 8 with the existing jobs. You may, however, be referring to the recent breakage with the update to 8.1. That has been fixed and the CI jobs caught that too.\n\nWhat I meant is that personally I believe no job should be added immediately to the gate regardless of the project.","commit_id":"7035326412a4697cb3bb9dc9f89cb173fbfd34a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e67878adc368b2b15054c37d196d473da50ef82","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        - dib-nodepool-functional-openstack-ubuntu-bionic-src"},{"line_number":53,"context_line":"        - dib-functests-xenial-python3"},{"line_number":54,"context_line":"        - dib-functests-centos7-python2"},{"line_number":55,"context_line":"        - ironic-python-agent-check-image-dib-centos8"},{"line_number":56,"context_line":"    experimental:"},{"line_number":57,"context_line":"      jobs:"},{"line_number":58,"context_line":"        - dib-nodepool-functional-openstack-gentoo-src"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_a3753488","line":55,"in_reply_to":"3fa7e38b_68095b30","updated":"2020-01-21 11:51:58.000000000","message":"Made non-voting for now. I do hope we can make it voting ASAP since it represents a very popular use case for DIB.","commit_id":"7035326412a4697cb3bb9dc9f89cb173fbfd34a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b606a23190612c2361f4fa7c4daf574ff58de706","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        - dib-nodepool-functional-openstack-ubuntu-bionic-src"},{"line_number":53,"context_line":"        - dib-functests-xenial-python3"},{"line_number":54,"context_line":"        - dib-functests-centos7-python2"},{"line_number":55,"context_line":"        - ironic-python-agent-check-image-dib-centos8"},{"line_number":56,"context_line":"    experimental:"},{"line_number":57,"context_line":"      jobs:"},{"line_number":58,"context_line":"        - dib-nodepool-functional-openstack-gentoo-src"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_68095b30","line":55,"in_reply_to":"3fa7e38b_e85eab4f","updated":"2020-01-21 11:44:59.000000000","message":"The reason it has been failing is the breakage of DIB with CentOS 8. I think it\u0027s useful for you to know it.","commit_id":"7035326412a4697cb3bb9dc9f89cb173fbfd34a7"}]}
