)]}'
{"diskimage_builder/elements/yum-minimal/root.d/08-yum-chroot":[{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"fec117993fe0bcbc7ce4e2ee4799c8f0f6d9f733","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # CentOS 8.1 split repositories and GPG keys out into subpackages"},{"line_number":93,"context_line":"    if [[ ${DISTRO_NAME} \u003d centos \u0026\u0026 ${DIB_RELEASE} -ge 8 ]]; then"},{"line_number":94,"context_line":"        packages+\u003d\"centos-repos centos-gpg-keys \""},{"line_number":95,"context_line":"    fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # By default, parent elements (fedora-minimal, centos-minimal)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_704bc727","line":94,"updated":"2020-01-15 18:47:26.000000000","message":"do these exist in 8.0 too?","commit_id":"ae2be0b464392256df7009f7030281963c06aa81"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"553d6063f9f3968743ffc8c07317654aadf9bce0","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # CentOS 8.1 split repositories and GPG keys out into subpackages"},{"line_number":93,"context_line":"    if [[ ${DISTRO_NAME} \u003d centos \u0026\u0026 ${DIB_RELEASE} -ge 8 ]]; then"},{"line_number":94,"context_line":"        packages+\u003d\"centos-repos centos-gpg-keys \""},{"line_number":95,"context_line":"    fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # By default, parent elements (fedora-minimal, centos-minimal)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_706e6765","line":94,"in_reply_to":"3fa7e38b_10cdb391","updated":"2020-01-15 19:00:05.000000000","message":"The centos-minimal element\u0027s README explicitly says the valid DIB_RELEASE values are \"7\" and \"8\". This means that you cannot explicitly ask for an older minor release currently. Due to this, I think we are ok to merge this change as is.\n\nIf people want to be able to build an 8.0 image they will need to make changes to these elements.","commit_id":"ae2be0b464392256df7009f7030281963c06aa81"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"2656ccad8fa25f227f64c495aeca8574f14f1556","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # CentOS 8.1 split repositories and GPG keys out into subpackages"},{"line_number":93,"context_line":"    if [[ ${DISTRO_NAME} \u003d centos \u0026\u0026 ${DIB_RELEASE} -ge 8 ]]; then"},{"line_number":94,"context_line":"        packages+\u003d\"centos-repos centos-gpg-keys \""},{"line_number":95,"context_line":"    fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # By default, parent elements (fedora-minimal, centos-minimal)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_f026d767","line":94,"in_reply_to":"3fa7e38b_704bc727","updated":"2020-01-15 18:51:04.000000000","message":"No.","commit_id":"ae2be0b464392256df7009f7030281963c06aa81"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a8887313957141209485e72b7cd470f3941e6565","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # CentOS 8.1 split repositories and GPG keys out into subpackages"},{"line_number":93,"context_line":"    if [[ ${DISTRO_NAME} \u003d centos \u0026\u0026 ${DIB_RELEASE} -ge 8 ]]; then"},{"line_number":94,"context_line":"        packages+\u003d\"centos-repos centos-gpg-keys \""},{"line_number":95,"context_line":"    fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # By default, parent elements (fedora-minimal, centos-minimal)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_10cdb391","line":94,"in_reply_to":"3fa7e38b_704bc727","updated":"2020-01-15 18:51:34.000000000","message":"http://mirror.centos.org/centos/8.0.1905/BaseOS/x86_64/os/Packages/ does not look like it. I guess we need to add them only if version i 8 or 8.1? not 8.0?","commit_id":"ae2be0b464392256df7009f7030281963c06aa81"}]}