)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"c37fc636f1ca091a612986b02e7d5e11dc44562a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sorin Sbarnea \u003cssbarnea@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-11 13:06:34 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Validate virtualenv and pip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This should be a fail-safe mechanism for protecting us from installing broken virtualenv or pip commands."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_706b5285","line":7,"updated":"2020-02-11 14:23:39.000000000","message":"Remove the WIP - this is decent enough to land.","commit_id":"27069df9da012314ab51ed8b125179e06d2a13c3"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"c37fc636f1ca091a612986b02e7d5e11dc44562a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This should be a fail-safe mechanism for protecting us from installing broken virtualenv or pip commands."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I5f2df8ff2f148af6e80b0a8c38e4fe89a29e8d58"},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/#/c/707112/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_b0554ac3","line":12,"updated":"2020-02-11 14:23:39.000000000","message":"This doesn\u0027t actually depend on that change - let\u0027s remove this.","commit_id":"27069df9da012314ab51ed8b125179e06d2a13c3"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"0dc11c75fb796f0a9f359daae935905034ecf261","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This should be a fail-safe mechanism for protecting us from installing broken virtualenv or pip commands."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I5f2df8ff2f148af6e80b0a8c38e4fe89a29e8d58"},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/#/c/707112/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_b0d8ea50","line":12,"in_reply_to":"3fa7e38b_b0554ac3","updated":"2020-02-11 14:26:23.000000000","message":"Maybe make it depends-on https://review.opendev.org/#/c/705380/\n\nAlso - we should update these jobs to use python3.6 instead of 3.5 - but that\u0027s maybe a smidge out of scope","commit_id":"27069df9da012314ab51ed8b125179e06d2a13c3"}],"diskimage_builder/elements/pip-and-virtualenv/install.d/pip-and-virtualenv-source-install/04-install-pip":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"c37fc636f1ca091a612986b02e7d5e11dc44562a","unresolved":false,"context_lines":[{"line_number":240,"context_line":"fi"},{"line_number":241,"context_line":"# validation of virtualenv"},{"line_number":242,"context_line":"# https://github.com/pypa/virtualenv/issues/1551"},{"line_number":243,"context_line":"PYTHON\u003d%(type python3 python python2 | awk \u0027NF\u003e1{print $NF}\u0027 | head -n1)"},{"line_number":244,"context_line":"$PYTHON -m virtualenv --help"},{"line_number":245,"context_line":"# validation of pip, conflict reported is sign of something will break"},{"line_number":246,"context_line":"$PYTHON -m pip check"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa7e38b_10f9bec4","line":243,"updated":"2020-02-11 14:23:39.000000000","message":"Rather than looking only for one python, why don\u0027t we check it explicitly on both python2 and python3 since we do an install for both versions above.","commit_id":"27069df9da012314ab51ed8b125179e06d2a13c3"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c3a893ad3b5a525ff7de23a5896b4e5feaa28694","unresolved":false,"context_lines":[{"line_number":240,"context_line":"fi"},{"line_number":241,"context_line":"# validation of virtualenv"},{"line_number":242,"context_line":"# https://github.com/pypa/virtualenv/issues/1551"},{"line_number":243,"context_line":"PYTHON\u003d%(type python3 python python2 | awk \u0027NF\u003e1{print $NF}\u0027 | head -n1)"},{"line_number":244,"context_line":"$PYTHON -m virtualenv --help"},{"line_number":245,"context_line":"# validation of pip, conflict reported is sign of something will break"},{"line_number":246,"context_line":"$PYTHON -m pip check"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"df33271e_8154bf54","line":243,"updated":"2020-03-30 21:20:09.000000000","message":"I guess this wants to be a $ ... \n\nIt\u0027s not a priroi evident why this is correct, why wouldn\u0027t it check python2 \u0026 python3 on platforms that have both?","commit_id":"9a444104cb384d58f51800369f1d6d7b5d777582"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"b7bfb9634bc4a2f0202a0936881581ca733ab13c","unresolved":false,"context_lines":[{"line_number":240,"context_line":"fi"},{"line_number":241,"context_line":"# validation of virtualenv"},{"line_number":242,"context_line":"# https://github.com/pypa/virtualenv/issues/1551"},{"line_number":243,"context_line":"PYTHON\u003d%(type python3 python python2 | awk \u0027NF\u003e1{print $NF}\u0027 | head -n1)"},{"line_number":244,"context_line":"$PYTHON -m virtualenv --help"},{"line_number":245,"context_line":"# validation of pip, conflict reported is sign of something will break"},{"line_number":246,"context_line":"$PYTHON -m pip check"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"df33271e_e7c6729a","line":243,"in_reply_to":"df33271e_8154bf54","updated":"2020-03-31 09:23:58.000000000","message":"Indeed, better to loop over them.","commit_id":"9a444104cb384d58f51800369f1d6d7b5d777582"}]}