)]}'
{"id":"openstack%2Fdiskimage-builder~734331","triplet_id":"openstack%2Fdiskimage-builder~master~Ibd72ce6104d42c348e2e1340cb8b4f4f5c724af4","project":"openstack/diskimage-builder","branch":"master","topic":"drop_mock","hashtags":[],"change_id":"Ibd72ce6104d42c348e2e1340cb8b4f4f5c724af4","subject":"Use unittest.mock instead of mock","status":"NEW","created":"2020-06-08 22:08:16.000000000","updated":"2020-06-09 10:01:51.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"caaaa00ae5d7da4db5cc4a414d3c72580042ff13","_number":734331,"virtual_id_number":734331,"owner":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-06-08 23:39:54.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-06-09 00:35:46.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-06-09 04:44:06.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"all":[{"value":-1,"date":"2020-06-09 10:01:51.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-08 23:39:54.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-06-09 00:35:46.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-06-09 04:44:06.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"}],"messages":[{"id":"aea20078adbaf7022c4637420aa2a474c1c044e5","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-06-08 22:08:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"40b728f3eb7da1c5e92fcf810ff628e94aaaaded","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-08 22:28:45.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/fa04a6ac4dbc409aa43aa41a6112a746 : SUCCESS in 19m 48s","accounts_in_message":[],"_revision_number":1},{"id":"9997b8cc23f203783d37ef9d660809ce46a205c8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-08 23:39:54.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/45042858faa94016b3ded1e64b4c25d1 : SUCCESS in 9m 57s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f67bbd6b5d8f404bbdf232814447f355 : SUCCESS in 7m 03s\n- requirements-check https://zuul.opendev.org/t/openstack/build/577aecfd3e9d46e287949536d93af061 : FAILURE in 4m 44s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/31078f287a14412495c85c2cf15f361f : SUCCESS in 7m 51s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5c24af7e579947c3be2ee8897e3330a7 : SUCCESS in 7m 45s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/8290c64fd2a046758f0828e9dd6f3605 : SUCCESS in 30m 17s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/f47941b9a00a45ee8d79fcdfabeeec50 : SUCCESS in 28m 52s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/a25cbd45c79d407a841fc68e37037cb8 : FAILURE in 7m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ddc11abab66643a4bfdd927672c2c209 : SUCCESS in 7m 22s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3932694e7fd2427d8b97e487359c099b : SUCCESS in 9m 39s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/aae2eec749db4b43be056df3c8895034 : SUCCESS in 5m 18s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/21c600d26cef4682ac12aeb134432980 : SUCCESS in 1h 22m 55s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/3130a626ccbd4b9080296994f39c0618 : SUCCESS in 15m 57s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/8c82aed1cc6144228ca284a4a33dd86e : SUCCESS in 37m 22s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/38eeb0dbf8d144148733d74d8973b175 : SUCCESS in 33m 43s\n- dib-nodepool-functional-openstack-fedora-31-src https://zuul.opendev.org/t/openstack/build/dcd3958b15c34c6996068c4c0fbcc2ca : SUCCESS in 39m 54s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/f5800c2424a7488f965b9ae3df41686c : SUCCESS in 32m 05s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/8af802dc92604efc8922690c713718dc : SUCCESS in 32m 19s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/2369c55dd08b4dd0b2cf27f190f05672 : SUCCESS in 35m 32s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/615e92badfbc4f8ea3bc1991f35efd86 : SUCCESS in 49m 13s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/1adf3621791244ffa09c48ce2a5f81fb : FAILURE in 44m 13s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/4b93aa2cfbff4dc6b88c55f3ec47a47c : SUCCESS in 31m 06s\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/d1f50de3c0024a5784e282bd39e1ad92 : SUCCESS in 35m 01s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/82125a17ecc64a14846df46e8cf5370e : SUCCESS in 35m 39s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/aac4ba4b446c4ea996f025a1d83ddb4f : SUCCESS in 10m 17s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/9abc4d427387470eb73134673fb22c09 : SUCCESS in 12m 28s\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/93a36ae4802a480d97bca1430702804d : SUCCESS in 1h 10m 30s (non-voting)\n- ipa-tempest-partition-bios-ipmi-iscsi-dib-src https://zuul.opendev.org/t/openstack/build/63a1f9ff0140448faeca550ae9e20ed7 : SUCCESS in 1h 06m 55s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e17edfc92adb5836b657a8d3f4b842d57dcba46f","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-06-09 00:35:46.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/4d8de364630446dcb97ad9ac0ed54227 : SUCCESS in 2h 25m 39s","accounts_in_message":[],"_revision_number":1},{"id":"6596d595b3d910e9bb710ee636d01594befa2e30","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-06-09 04:44:06.000000000","message":"Patch Set 1: Code-Review-1\n\nunfortunately (as the failure shows) we still support python 3.5 to be inline with what nodepool is supporting (openstacksdk is simliar, in fact monty suggested it).  when we drop that (zuul v4 I think will drop it) we can do this","accounts_in_message":[],"_revision_number":1},{"id":"0241df9b4b10bf91e5990c09d0c052ae499df069","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-06-09 10:01:51.000000000","message":"Patch Set 1: Workflow-1\n\n\u003e unfortunately (as the failure shows) we still support python 3.5 to\n \u003e be inline with what nodepool is supporting (openstacksdk is\n \u003e simliar, in fact monty suggested it).  when we drop that (zuul v4 I\n \u003e think will drop it) we can do this\n\nThanks for the heads up, I -W these changes, feel free to update them when py35 will be moved away.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1015dd8d92b72a1b3c8e6e5215ff53b62e8dabde","revisions":{"1015dd8d92b72a1b3c8e6e5215ff53b62e8dabde":{"kind":"REWORK","_number":1,"created":"2020-06-08 22:08:16.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/31/734331/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/31/734331/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/31/734331/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/31/734331/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/31/734331/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/31/734331/1"}}},"commit":{"parents":[{"commit":"3477dfad00ed4e93fe2c0ea2680c63a704ea618a","subject":"Drop support for python2","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/3477dfad00ed4e93fe2c0ea2680c63a704ea618a"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-06-08 22:08:08.000000000","tz":120},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-06-08 22:08:08.000000000","tz":120},"subject":"Use unittest.mock instead of mock","message":"Use unittest.mock instead of mock\n\nThe mock third party library was needed for mock support in py2\nruntimes. Since we now only support py36 and later, we can use the\nstandard lib unittest.mock module instead.\n\nChange-Id: Ibd72ce6104d42c348e2e1340cb8b4f4f5c724af4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/1015dd8d92b72a1b3c8e6e5215ff53b62e8dabde"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/1015dd8d92b72a1b3c8e6e5215ff53b62e8dabde"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":["label:Workflow\u003dMIN"],"failing_atoms":["label:Workflow\u003dMAX"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}