)]}'
{"id":"openstack%2Fdiskimage-builder~734414","triplet_id":"openstack%2Fdiskimage-builder~master~Iede929ea2d278008220aac8b1d678ba41eba0d8a","project":"openstack/diskimage-builder","branch":"master","topic":"venv","hashtags":[],"change_id":"Iede929ea2d278008220aac8b1d678ba41eba0d8a","subject":"Remove virtualenv activation","status":"MERGED","created":"2020-06-09 03:13:19.000000000","updated":"2020-06-12 01:18:40.000000000","submitted":"2020-06-12 01:17:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"734414-1591924637024-45de1d5f","meta_rev_id":"a4c6e53eb51bff99573d311d37638275cb44fc86","_number":734414,"virtual_id_number":734414,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-06-12 01:17:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-06-12 01:14:20.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"date":"2020-06-11 22:43:59.000000000","_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"all":[{"value":2,"date":"2020-06-11 08:28:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":1,"date":"2020-06-11 08:25:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"all":[{"value":1,"date":"2020-06-11 08:28:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-09 09:11:03.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-06-11 08:25:11.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2020-06-11 08:28:09.000000000","updated_by":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"reviewer":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"state":"REVIEWER"},{"updated":"2020-06-12 01:14:20.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-06-12 01:17:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"784db49ae092f412c73cd5e3da09f6f8e6953e37","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-06-09 03:13:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e40af01fa9af79e8b0a81cad070308fdb3373cb3","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-09 03:15:34.000000000","message":"Patch Set 1:\n\nBuild failed (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/2014cd2bae5344bf8db7be1ff5622bc6 : FAILURE in 1m 49s","accounts_in_message":[],"_revision_number":1},{"id":"d42f180eda7163587d47053dc489502f5093ed30","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-06-09 03:27:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7f22edbb903c38c80b6834cbf425110456cc2f22","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-09 03:31:03.000000000","message":"Patch Set 2:\n\nBuild failed (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/0724b07753c44e54b3293d3697ecfff8 : FAILURE in 2m 47s","accounts_in_message":[],"_revision_number":2},{"id":"80aa4d1ed602a7cc7d74fefafa23f406cec6cc70","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-06-09 03:36:16.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"e687b531794cdfb1f2d83cf6d6d3847458c3947c","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-09 03:39:33.000000000","message":"Patch Set 3:\n\nBuild failed (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/12341c46829149629eed80f9d81126ea : FAILURE in 2m 51s","accounts_in_message":[],"_revision_number":3},{"id":"4d100bda897086b0a977c7753483c7494e63bf3e","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-06-09 03:42:46.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"0e0a7e2fc112e9f257cfb206e6e7a4154ef7633a","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-09 04:01:15.000000000","message":"Patch Set 4:\n\nBuild succeeded (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/4552838910de44e68a43854b93a466e3 : SUCCESS in 18m 08s","accounts_in_message":[],"_revision_number":4},{"id":"52f1b9057c18e3a001e63d371cb7269f1fdc77c3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-09 05:11:28.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/db790d75c1c14c0c95d8aed1a27fb07d : SUCCESS in 4m 06s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1bb9e93d4a4f4732aaee7bb46dfcfcb2 : SUCCESS in 3m 35s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e1f827018cad4245b5d2fd2e19dea6c8 : SUCCESS in 3m 59s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2eb2c18b8633402799484a53687cb3b5 : SUCCESS in 3m 31s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/e59807a120a54a52a932683acd0bdd4b : SUCCESS in 30m 29s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/2aa71bad5cf2438c9ca370f167a47544 : SUCCESS in 24m 12s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/65cc98abf60141569b4e32d6e13a5295 : SUCCESS in 3m 51s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/741026941e9f43c6a4969a94fe54739d : SUCCESS in 3m 48s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4559a8d75a484a64920494534be13000 : SUCCESS in 3m 46s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/c059a5c59bae4f7a9a2a15a3fdbc1928 : SUCCESS in 3m 39s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/b1c7f94807d84cfdadb2d1b5a781eed9 : SUCCESS in 1h 23m 27s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/d4ea2e74692b4807823aec6fa48bc8c0 : SUCCESS in 15m 34s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/a3f7d21b5be547b9b13f1df6657e8520 : SUCCESS in 29m 54s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/951b4c8fa65d4b2591a48c11da57598a : SUCCESS in 34m 02s\n- dib-nodepool-functional-openstack-fedora-31-src https://zuul.opendev.org/t/openstack/build/73d31dfc77cf4c7b85d162d1b8d6e6c8 : SUCCESS in 37m 16s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/d1c2cc8add1347b98ad768453ad7028f : SUCCESS in 28m 46s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/fe5ec89597df42499b04f5db5e5120d7 : SUCCESS in 30m 23s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/3565802288844445ac626af06938501d : SUCCESS in 37m 05s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/b08621adb18f4b59b308c9e7546f304c : SUCCESS in 52m 24s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/52578f364c3e49578aeb00b079b088dc : FAILURE in 54m 08s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/84177355ec964e5bb379bd6962ef9c53 : SUCCESS in 28m 59s\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/757d0d6852aa4ab78b502da211c488f5 : SUCCESS in 36m 45s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/4bedc637b3444ed7827da3781185848a : SUCCESS in 37m 03s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/d85a8571c7b74ef0b548a262fbcdc96d : SUCCESS in 7m 24s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/b2de4e9f6a184bd6af11880de108a4ab : SUCCESS in 9m 30s\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/71d5be53606045728184b33255695fcd : SUCCESS in 1h 06m 35s (non-voting)\n- ipa-tempest-partition-bios-ipmi-iscsi-dib-src https://zuul.opendev.org/t/openstack/build/04eedf1bdfff40089dbf43ee365478c5 : SUCCESS in 1h 03m 24s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"7935ab17165826b9192dae1aef872abccfa4e343","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-06-09 06:06:56.000000000","message":"Patch Set 4:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/c16a59020cdc4fb69f06e9fc3b157364 : SUCCESS in 2h 22m 44s","accounts_in_message":[],"_revision_number":4},{"id":"4972e5814c8668896962ba343fa1f6d8871ac332","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2020-06-09 09:01:32.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"1d3fde55ede4ffe5ea55a78f1fcb7430a7d8da80","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-06-09 09:11:03.000000000","message":"Patch Set 4: Code-Review+1\n\nTested, works for us.","accounts_in_message":[],"_revision_number":4},{"id":"bbd66e24aa8bd708f1749ada9feb59c39a879a0b","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-06-10 09:33:53.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"d374b0793c237b3a577187ed6e827f9c398b4564","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2020-06-10 09:37:03.000000000","message":"Patch Set 4: Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"af6eaedcfc246891857038f3f14ce557cc7d117b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-10 09:37:14.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"9f254fbfbd2a5b69e01f1b859c154ca68054dd43","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-10 10:44:39.000000000","message":"Patch Set 4: Verified-2\n\n(1 comment)\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7ad9fa333cdc465dbe77eb7c94fb6064 : SUCCESS in 6m 49s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c274ced015654496af955076866dc427 : SUCCESS in 6m 08s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6970c52fc90a4f639655850871efb653 : SUCCESS in 4m 25s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/307429ce3fc241e7b79f0c83017d7702 : SUCCESS in 53m 13s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/531f091f27ad414a862f6eac095e987e : SUCCESS in 25m 45s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/764a2dd919804c6183cfdc4f7c3630c2 : SUCCESS in 4m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9b95837ebe7c4cda85a24f44b49a5717 : FAILURE in 6m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3e15f90c1956442c95832baaf485d8c4 : SUCCESS in 6m 11s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6484ec9ca9bb4c08be942ba26f274fd5 : SUCCESS in 7m 54s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/7618c83f9ad5456da976d8146ac3059b : SUCCESS in 7m 13s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/661f0871fd1a4db9b50d7fd51a9984a7 : SUCCESS in 1h 05m 35s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/3f94826d719444078cafc480165e64f8 : SUCCESS in 19m 38s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/f46d4a72738c476aba32d9ba721d8390 : SUCCESS in 35m 54s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/eb6bebe0b39d4466a59a3fe5cecf4dea : SUCCESS in 37m 30s\n- dib-nodepool-functional-openstack-fedora-31-src https://zuul.opendev.org/t/openstack/build/127548fd1a554d15beb32aad028eecd0 : SUCCESS in 39m 42s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/646ce62d92144cf78de4362f897cc11b : SUCCESS in 32m 57s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/1798c33c25b44957b550512766d475ca : SUCCESS in 35m 38s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/41d206c565f64aaba89b53be2486efec : SUCCESS in 37m 04s\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/5291edb83da04fe9937d0276b681eee4 : SUCCESS in 32m 31s\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/c58aa49cb4ae46c09d22f86142c466cc : SUCCESS in 11m 11s","accounts_in_message":[],"_revision_number":4},{"id":"abbc85758dacca7c342fb338605156c04ce71062","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-06-11 06:49:28.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"32e58bc183452712d504ada38a33b1a1fac3e2b2","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-06-11 08:25:11.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"478e4f26482acbaa84c5a00a02ed3ba87e744b86","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2020-06-11 08:28:09.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"8b68e6829a3b9bb29388708d142843e5ed4966be","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-11 08:33:16.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/361b675c560943ceb8864be848ad6828 : SUCCESS in 8m 18s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f7a36ed0bfa34b96880658c0354bc29b : SUCCESS in 7m 17s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/68611c4345a7401688742b44fe1d9674 : SUCCESS in 7m 27s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f0ecb732c9d54c5ebf6d89c21814cd9f : SUCCESS in 5m 41s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/7607c2cc2c234218858d86fd0cffd9d0 : SUCCESS in 56m 53s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/f296ae553d6447028d19ae3ae5f6f56f : SUCCESS in 24m 10s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/5cc5b92101ce4040aca04fc478475387 : SUCCESS in 7m 18s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8ece864b78e141b1b63456dfbd5a35e9 : SUCCESS in 6m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/09dc69724bee469eb5c60b0a6e60eec1 : SUCCESS in 6m 51s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4e026d95a7fd4a9295f138a71da592a0 : SUCCESS in 6m 16s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/c0ccc6566be4478b992701f7c9144606 : SUCCESS in 7m 45s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/49ddfb57d1374ce69f538cd082eb3436 : SUCCESS in 1h 38m 58s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/79f5bc4a8c5349deba34e11cbabf0702 : SUCCESS in 19m 34s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/5a535ecd644e402dbba8dba5b1e6681b : FAILURE in 21m 43s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/2db5fdeac9f747fca5c8b2e9102e3a78 : FAILURE in 17m 23s\n- dib-nodepool-functional-openstack-fedora-31-src https://zuul.opendev.org/t/openstack/build/c677fef8f8a94de7be3ef4d86b8b4812 : FAILURE in 19m 38s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/cb8b4c7c17b947a0a72c5aec710c1331 : FAILURE in 22m 06s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/a5840e67d8e04261bb1a7f27f1760c84 : FAILURE in 21m 04s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/2bc0c7f319cc4eb397775f2eb1dbdceb : FAILURE in 35m 47s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/cfaae6274d4648cebcf67ba298e985ee : FAILURE in 18m 39s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/7dfc4365fcff4ecd93c2e98ebbac74b9 : FAILURE in 23m 04s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/67f55223ec604c6f83a85f9c055dabcc : SUCCESS in 35m 30s\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/e8468ab136194418822a428912d7b9dc : SUCCESS in 48m 31s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/454ceab1854c4d7094408d1e1aa7ca96 : TIMED_OUT in 1h 32m 13s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/d43188a5fe8a4aa0aa88de9d478ab094 : SUCCESS in 12m 44s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/99605485152d475b9c2d4c46cff789c3 : SUCCESS in 12m 19s\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/315aaf955077499a98dc25089bd23159 : SUCCESS in 1h 09m 52s (non-voting)\n- ipa-tempest-partition-bios-ipmi-iscsi-dib-src https://zuul.opendev.org/t/openstack/build/610b80478f244874a63d8018d5c60a55 : SUCCESS in 1h 07m 29s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"a1c806cc622bc4b0ab4b0658411553746abaea42","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-11 08:41:56.000000000","message":"Patch Set 5:\n\nBuild failed (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/e010539c564042d98cf4c62a439d68f2 : FAILURE in 59m 06s","accounts_in_message":[],"_revision_number":5},{"id":"b6237025f37168f3da6c230403ba75b7deff4fba","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-06-11 09:18:52.000000000","message":"Patch Set 5:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/caf8133dfb1d4096bb8c8e6fc88d9ab3 : SUCCESS in 2h 25m 59s","accounts_in_message":[],"_revision_number":5},{"id":"a7f5cad8d3a79e36273193bb1854bbdd6551ddc9","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-06-11 22:43:59.000000000","message":"Patch Set 5:\n\nrecheck","accounts_in_message":[],"_revision_number":5},{"id":"d881d970e1280c760b14d1cda4c7d359d7d5c9fb","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-11 23:15:08.000000000","message":"Patch Set 5:\n\nBuild succeeded (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/3c8ecf1ef4b447ebb2820678e3a22066 : SUCCESS in 29m 56s","accounts_in_message":[],"_revision_number":5},{"id":"35fac16b45e2892710bf398d057c689394d044e4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-12 00:10:38.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0c3d6dd6dd884591b6c74d167b1dfc74 : SUCCESS in 4m 31s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/097097f9fb6549e39514f891e891cea4 : SUCCESS in 4m 02s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/bdd42c2c44644e8784c13a7a662f92f2 : SUCCESS in 4m 20s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/cb97b037aa8e4af08d570ce8f6481caa : SUCCESS in 4m 17s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/69135b529988485981112cc90bd1f59a : SUCCESS in 53m 38s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/79eb942c8f084b578614e927ae490dbe : SUCCESS in 23m 56s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/5d17bafd334b47639b90f8782abd3ca6 : SUCCESS in 3m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f6f1dd5e5bdb4f8db8aad47a30472f47 : SUCCESS in 4m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b5c5680b03c34aac858799920395d91f : SUCCESS in 3m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4dc748715c2342a49d230c794064621a : SUCCESS in 4m 12s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/f619442b77d04fd08512fffdb3d79d8f : SUCCESS in 3m 22s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/6eb6cff4ecb1499397ddd74189be9bf3 : SUCCESS in 1h 14m 30s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/730492f0999749e594ac6a34e8798918 : SUCCESS in 16m 04s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/b397ccb6d0c641709323867c5ef618b4 : SUCCESS in 35m 41s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/70944e98006b45d881e3f6ce0c853710 : SUCCESS in 33m 25s\n- dib-nodepool-functional-openstack-fedora-31-src https://zuul.opendev.org/t/openstack/build/d9072eaceee841288bc874b9d38a3c41 : SUCCESS in 41m 38s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/0b0179b0bb154c059d026a0c2d19806d : SUCCESS in 31m 00s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/ce29335e295346268a52e9a464a4a52c : SUCCESS in 33m 47s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/f310b20b80b1425ab4a7a98efaad1ee3 : SUCCESS in 35m 21s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/ae3d8ade70b647168fe7ea11de46ff04 : SUCCESS in 49m 28s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/4a3eb52832cf47f4ba011305030f5319 : FAILURE in 40m 12s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/d9a52cdc5d7441819341e58aef956cbf : SUCCESS in 28m 28s\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/0aa7c18220c741478c61d0bcdfce6287 : FAILURE in 24m 41s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/d77a2c42a0334d059c98077ad90555c2 : SUCCESS in 33m 35s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/37681871a7564e34adc1e6ddfec7dea1 : SUCCESS in 7m 20s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/4a037c6d7b9146de9fe453ede75765bc : SUCCESS in 9m 49s\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/41306720edbe4c498428e4e0b08c69ca : SUCCESS in 1h 20m 22s (non-voting)\n- ipa-tempest-partition-bios-ipmi-iscsi-dib-src https://zuul.opendev.org/t/openstack/build/354ef01b7a154521acbb4b61ee2b16a1 : SUCCESS in 1h 09m 00s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"08e1451d4d41fe6773c4dcc64ceda61fd7d1727a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-12 00:10:49.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"c1a647edd9f9a534008055c576743e54168d7e65","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-06-12 01:14:20.000000000","message":"Patch Set 5:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/017c9a56ea3742e38863d8677583382d : SUCCESS in 2h 28m 31s","accounts_in_message":[],"_revision_number":5},{"id":"e7565c1a6e2bf7076f5072975f2173b7ff62ef87","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-12 01:17:16.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cdabc08279c340658c53ecbb637ccf41 : SUCCESS in 5m 11s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/76ba4eaf245644d49a4df128f19eae9e : SUCCESS in 3m 52s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ddc0b6d1dc014076a931460bddb92add : SUCCESS in 3m 07s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/1fec820cc5254326885d149e2162178f : SUCCESS in 55m 53s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/55cd320764044ac28982a17a56b560fb : SUCCESS in 25m 29s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/afeddb727262480497702379b34f1b09 : SUCCESS in 4m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/27d485d1cffc4832a6e1bb7d1032cb6d : SUCCESS in 3m 49s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a173fec091314a9aa972007a67f6f834 : SUCCESS in 3m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/51494ce799e24845a6adc9aa80fe725e : SUCCESS in 3m 39s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/eb7038e2fdd94bb79364d1cce926f4b4 : SUCCESS in 3m 18s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/7efd4ab7811840f5bc9a5e9cad1b073f : SUCCESS in 1h 01m 51s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/fb03decbaa0048e2873eafe6704d9341 : SUCCESS in 15m 22s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/3b2dd710580d471baae2a36450ad4f26 : SUCCESS in 31m 00s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/f3f41ab0a70742cb9fa520b200d639df : SUCCESS in 32m 36s\n- dib-nodepool-functional-openstack-fedora-31-src https://zuul.opendev.org/t/openstack/build/365b492ac15143be99c3bb37d2d37cbe : SUCCESS in 37m 53s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/6a53b8bbc4a7496dbbf20ae7732dccb5 : SUCCESS in 30m 56s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/fd6630dbdf7540c997ae8bffea5627d0 : SUCCESS in 30m 27s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/137e1d2d33c0438d9804ca78f0694eb3 : SUCCESS in 32m 58s\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/912408183d314ad1af2c8d59ced4bf19 : SUCCESS in 27m 12s\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/4a12d0d442bf4d799b380a353c006d38 : SUCCESS in 9m 45s","accounts_in_message":[],"_revision_number":5},{"id":"b80ee22b9a54e3d6fb02fdf4cb59e6f73ec1a76d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-12 01:17:17.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5},{"id":"83281d56cd34d08116a1d3c2e17236147fe7ee2e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-12 01:18:40.000000000","message":"Patch Set 5:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/243672d26b6549409319e9c102b91f6a : SUCCESS in 1m 07s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/30ddff83ce174cc1b7d6df100072a8c4 : SUCCESS in 1m 02s","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"e793cc4038c6b131b801e854b233fd07ab766bcf","revisions":{"860023aa6eab3fceb409a06b275a8f0529ad9c47":{"kind":"REWORK","_number":1,"created":"2020-06-09 03:13:19.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/14/734414/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/14/734414/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/1"}}},"commit":{"parents":[{"commit":"1e1e36df6402276e7766fe88a341c236fb01d9b4","subject":"Do not fail in a venv when activate_this.py is not found","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/1e1e36df6402276e7766fe88a341c236fb01d9b4"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-05-29 10:22:01.000000000","tz":120},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2020-06-09 03:13:00.000000000","tz":600},"subject":"Remove virtualenv activation","message":"Remove virtualenv activation\n\nSince the original merge of this code\n(04208e7c79e52e2db905b973ab018deec6782260) several things have\nchanged; particularly now we ship dib-run-parts as part of dib, not as\na separate package.\n\nWe setup $_LIB to point to the shipped library diretory via\npkg_resources lookups.  We now call dib-run-parts (as mentioned,\nshipped as a dib library now), source scripts, etc. via $_LIB and thus\ndo not rely on $PATH.  Consequently we don\u0027t need this activation\npart.\n\nWhich is helpful, because \"venv\" (as opposed to virtualenv) doesn\u0027t\nhave activate_this.py.  So this fixes installation under that for\nPython 3.\n\nWe update the functional tests to use the virtualenv_command exported\nby the ensure-pip role, which will test the venv path.\n\nChange-Id: Iede929ea2d278008220aac8b1d678ba41eba0d8a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/860023aa6eab3fceb409a06b275a8f0529ad9c47"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/860023aa6eab3fceb409a06b275a8f0529ad9c47"}]},"branch":"refs/heads/master"},"5ff30626a97b344f125692c24cdbf9c48ac53c68":{"kind":"REWORK","_number":2,"created":"2020-06-09 03:27:54.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/14/734414/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/14/734414/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/2"}}},"commit":{"parents":[{"commit":"1e1e36df6402276e7766fe88a341c236fb01d9b4","subject":"Do not fail in a venv when activate_this.py is not found","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/1e1e36df6402276e7766fe88a341c236fb01d9b4"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-05-29 10:22:01.000000000","tz":120},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2020-06-09 03:24:16.000000000","tz":600},"subject":"Remove virtualenv activation","message":"Remove virtualenv activation\n\nSince the original merge of this code\n(04208e7c79e52e2db905b973ab018deec6782260) several things have\nchanged; particularly now we ship dib-run-parts as part of dib, not as\na separate package.\n\nWe setup $_LIB to point to the shipped library diretory via\npkg_resources lookups.  We now call dib-run-parts (as mentioned,\nshipped as a dib library now), source scripts, etc. via $_LIB and thus\ndo not rely on $PATH.  Consequently we don\u0027t need this activation\npart.\n\nWhich is helpful, because \"venv\" (as opposed to virtualenv) doesn\u0027t\nhave activate_this.py.  So this fixes installation under that for\nPython 3.\n\nWe update the functional tests to use the virtualenv_command exported\nby the ensure-pip role, which will test the venv path.\n\nChange-Id: Iede929ea2d278008220aac8b1d678ba41eba0d8a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/5ff30626a97b344f125692c24cdbf9c48ac53c68"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/5ff30626a97b344f125692c24cdbf9c48ac53c68"}]},"branch":"refs/heads/master"},"41368811ebe53d774b93ea9cb1b05e3fa75b335d":{"kind":"REWORK","_number":3,"created":"2020-06-09 03:36:16.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/14/734414/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/14/734414/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/3"}}},"commit":{"parents":[{"commit":"1e1e36df6402276e7766fe88a341c236fb01d9b4","subject":"Do not fail in a venv when activate_this.py is not found","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/1e1e36df6402276e7766fe88a341c236fb01d9b4"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-05-29 10:22:01.000000000","tz":120},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2020-06-09 03:34:21.000000000","tz":600},"subject":"Remove virtualenv activation","message":"Remove virtualenv activation\n\nSince the original merge of this code\n(04208e7c79e52e2db905b973ab018deec6782260) several things have\nchanged; particularly now we ship dib-run-parts as part of dib, not as\na separate package.\n\nWe setup $_LIB to point to the shipped library diretory via\npkg_resources lookups.  We now call dib-run-parts (as mentioned,\nshipped as a dib library now), source scripts, etc. via $_LIB and thus\ndo not rely on $PATH.  Consequently we don\u0027t need this activation\npart.\n\nWhich is helpful, because \"venv\" (as opposed to virtualenv) doesn\u0027t\nhave activate_this.py.  So this fixes installation under that for\nPython 3.\n\nWe update the functional tests to use the virtualenv_command exported\nby the ensure-pip role, which will test the venv path.\n\nChange-Id: Iede929ea2d278008220aac8b1d678ba41eba0d8a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/41368811ebe53d774b93ea9cb1b05e3fa75b335d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/41368811ebe53d774b93ea9cb1b05e3fa75b335d"}]},"branch":"refs/heads/master"},"d27ba81c0ee6b6de20df324259b50a0f2a422f48":{"kind":"REWORK","_number":4,"created":"2020-06-09 03:42:46.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/14/734414/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/14/734414/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/4"}}},"commit":{"parents":[{"commit":"1e1e36df6402276e7766fe88a341c236fb01d9b4","subject":"Do not fail in a venv when activate_this.py is not found","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/1e1e36df6402276e7766fe88a341c236fb01d9b4"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-05-29 10:22:01.000000000","tz":120},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2020-06-09 03:42:16.000000000","tz":600},"subject":"Remove virtualenv activation","message":"Remove virtualenv activation\n\nSince the original merge of this code\n(04208e7c79e52e2db905b973ab018deec6782260) several things have\nchanged; particularly now we ship dib-run-parts as part of dib, not as\na separate package.\n\nWe setup $_LIB to point to the shipped library diretory via\npkg_resources lookups.  We now call dib-run-parts (as mentioned,\nshipped as a dib library now), source scripts, etc. via $_LIB and thus\ndo not rely on $PATH.  Consequently we don\u0027t need this activation\npart.\n\nWhich is helpful, because \"venv\" (as opposed to virtualenv) doesn\u0027t\nhave activate_this.py.  So this fixes installation under that for\nPython 3.\n\nWe update the functional tests to use the virtualenv_command exported\nby the ensure-pip role, which will test the venv path.  There is no\nneed for dib_python as we are Python 3 only now.\n\nChange-Id: Iede929ea2d278008220aac8b1d678ba41eba0d8a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/d27ba81c0ee6b6de20df324259b50a0f2a422f48"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/d27ba81c0ee6b6de20df324259b50a0f2a422f48"}]},"branch":"refs/heads/master"},"e793cc4038c6b131b801e854b233fd07ab766bcf":{"kind":"REWORK","_number":5,"created":"2020-06-11 06:49:28.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/14/734414/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/14/734414/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/14/734414/5"}}},"commit":{"parents":[{"commit":"1e1e36df6402276e7766fe88a341c236fb01d9b4","subject":"Do not fail in a venv when activate_this.py is not found","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/1e1e36df6402276e7766fe88a341c236fb01d9b4"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-05-29 10:22:01.000000000","tz":120},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2020-06-11 06:49:15.000000000","tz":600},"subject":"Remove virtualenv activation","message":"Remove virtualenv activation\n\nSince the original merge of this code\n(04208e7c79e52e2db905b973ab018deec6782260) several things have\nchanged; particularly now we ship dib-run-parts as part of dib, not as\na separate package.\n\nWe setup $_LIB to point to the shipped library diretory via\npkg_resources lookups.  We now call dib-run-parts (as mentioned,\nshipped as a dib library now), source scripts, etc. via $_LIB and thus\ndo not rely on $PATH.  Consequently we don\u0027t need this activation\npart.\n\nWhich is helpful, because \"venv\" (as opposed to virtualenv) doesn\u0027t\nhave activate_this.py.  So this fixes installation under that for\nPython 3.\n\nWe update the functional tests to use the virtualenv_command exported\nby the ensure-pip role, which will test the venv path.  There is no\nneed for dib_python as we are Python 3 only now.\n\nChange-Id: Iede929ea2d278008220aac8b1d678ba41eba0d8a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/e793cc4038c6b131b801e854b233fd07ab766bcf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/e793cc4038c6b131b801e854b233fd07ab766bcf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}