)]}'
{"diskimage_builder/elements/dib-python/environment.d/50-dib-python-version":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5a4a2348562fc6b0399b613df5101529bbdbf972","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    rhel|centos)"},{"line_number":25,"context_line":"        if [ \"$DIB_RELEASE\" \u003d\u003d \"7\" ]; then"},{"line_number":26,"context_line":"            DIB_PYTHON_VERSION\u003d2"},{"line_number":27,"context_line":"        elif [ \"$DIB_RELEASE\" \u003d\u003d \"8\" ]; then"},{"line_number":28,"context_line":"            DIB_PYTHON_VERSION\u003d3"},{"line_number":29,"context_line":"        fi"},{"line_number":30,"context_line":"    ;;"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"bf51134e_fb130065","line":27,"updated":"2020-07-06 10:03:03.000000000","message":"I\u0027d keep just the \u0027else\u0027 here","commit_id":"e2f47a296410ab54c843c537a575278908e113af"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"052b0e780db4e8a4f3a4d5b9f104131098b1de3e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    rhel|centos)"},{"line_number":25,"context_line":"        if [ \"$DIB_RELEASE\" \u003d\u003d \"7\" ]; then"},{"line_number":26,"context_line":"            DIB_PYTHON_VERSION\u003d2"},{"line_number":27,"context_line":"        elif [ \"$DIB_RELEASE\" \u003d\u003d \"8\" ]; then"},{"line_number":28,"context_line":"            DIB_PYTHON_VERSION\u003d3"},{"line_number":29,"context_line":"        fi"},{"line_number":30,"context_line":"    ;;"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"bf51134e_7f0d0734","line":27,"in_reply_to":"bf51134e_fb130065","updated":"2020-07-07 08:31:08.000000000","message":"done","commit_id":"e2f47a296410ab54c843c537a575278908e113af"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0ec427e4f11593cd130188f2e5dc2bd51b18a58e","unresolved":true,"context_lines":[{"line_number":21,"context_line":"        # TODO(nmagnezi): Remove this when the \u0027rhel7\u0027 element gets replaced by \u0027rhel\u0027"},{"line_number":22,"context_line":"        DIB_PYTHON_VERSION\u003d2"},{"line_number":23,"context_line":"    ;;"},{"line_number":24,"context_line":"    rhel|centos)"},{"line_number":25,"context_line":"        if [ \"$DIB_RELEASE\" \u003d\u003d \"7\" ]; then"},{"line_number":26,"context_line":"            DIB_PYTHON_VERSION\u003d2"},{"line_number":27,"context_line":"        else"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"17a61458_014307da","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":16},"updated":"2021-04-20 04:25:28.000000000","message":"This isn\u0027t quite the same as \"\u003d~ (rhel|centos)\" because that is a regex, so will match \"rhel7\" while this won\u0027t.  \n\nNow we have replicated the rhel7 element (for rhel) and probably nobody is using it ...\n\nBut to keep it consistent I guess we should at least do rhel|rhel7|centos","commit_id":"256c798bc433bcf7077f773c50b8aefe0833ca68"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2177ee3e184f8d15002e052f964ded300e1d31bc","unresolved":true,"context_lines":[{"line_number":21,"context_line":"        # TODO(nmagnezi): Remove this when the \u0027rhel7\u0027 element gets replaced by \u0027rhel\u0027"},{"line_number":22,"context_line":"        DIB_PYTHON_VERSION\u003d2"},{"line_number":23,"context_line":"    ;;"},{"line_number":24,"context_line":"    rhel|centos)"},{"line_number":25,"context_line":"        if [ \"$DIB_RELEASE\" \u003d\u003d \"7\" ]; then"},{"line_number":26,"context_line":"            DIB_PYTHON_VERSION\u003d2"},{"line_number":27,"context_line":"        else"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"71b29b11_9903a8e1","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":16},"in_reply_to":"02083f52_b215b302","updated":"2021-04-20 08:55:10.000000000","message":"I don\u0027t think this is necessary.\nIf DISTRO_NAME is \"rhel7\" it will be correctly assigned DIB_PYTHON_VERSION\u003d2 by the precedent case entry and won\u0027t arrive to this one.\nIf we add \"rhel7\" here we\u0027ll just have a repeated value that will never be taken into consideration as the precedent case entry takes priority.\nSame consideration for \"centos7\".","commit_id":"256c798bc433bcf7077f773c50b8aefe0833ca68"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"23175198c6f1cab7a2425f295dc6b58a304e613e","unresolved":true,"context_lines":[{"line_number":21,"context_line":"        # TODO(nmagnezi): Remove this when the \u0027rhel7\u0027 element gets replaced by \u0027rhel\u0027"},{"line_number":22,"context_line":"        DIB_PYTHON_VERSION\u003d2"},{"line_number":23,"context_line":"    ;;"},{"line_number":24,"context_line":"    rhel|centos)"},{"line_number":25,"context_line":"        if [ \"$DIB_RELEASE\" \u003d\u003d \"7\" ]; then"},{"line_number":26,"context_line":"            DIB_PYTHON_VERSION\u003d2"},{"line_number":27,"context_line":"        else"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"02083f52_b215b302","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":16},"in_reply_to":"17a61458_014307da","updated":"2021-04-20 04:26:06.000000000","message":"s/replicated/deprecated/ i mean","commit_id":"256c798bc433bcf7077f773c50b8aefe0833ca68"}]}
