)]}'
{"diskimage_builder/elements/centos/pre-install.d/01-set-centos-mirror":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"48f1f311e10f7e07e74f7052faa49ab7d66b359f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    else"},{"line_number":19,"context_line":"        BASE_PREFIX\u003daltarch"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"    sed -e \"s|^#baseurl\u003dhttp[s]*://mirror.centos.org/$BASE_PREFIX|baseurl\u003d$DIB_DISTRIBUTION_MIRROR|;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":22,"context_line":"elif [[ ${DIB_RELEASE} \u003d\u003d \u00278\u0027 ]]; then"},{"line_number":23,"context_line":"    sed -e \"s|^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/|baseurl\u003d$DIB_DISTRIBUTION_MIRROR/|;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":24,"context_line":"    sed -e \"s|^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/|baseurl\u003d$DIB_DISTRIBUTION_MIRROR/|;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-AppStream.repo"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bf51134e_7fa015f5","line":21,"updated":"2020-07-13 01:40:51.000000000","message":"i\u0027m not against this, but i think it would be clearer to just handle this in the regex and make it an extended match?.  we\u0027re replacing the line that starts with \"#baseurl\u003d...\" so can\u0027t we just add\n\nsed -re \"|^#baseurl\u003dhttp[s]*://mirror.centos.org/(centos|altarch)| ...\"\n\nor possibly it\u0027s safe to just drop this bit all together?","commit_id":"25c5cdb574a11da6e96a6342ec9fec68d250db1b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"56c2a979c7f5144fe0a2aacd4216de647b9673ae","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    else"},{"line_number":19,"context_line":"        BASE_PREFIX\u003daltarch"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"    sed -e \"s|^#baseurl\u003dhttp[s]*://mirror.centos.org/$BASE_PREFIX|baseurl\u003d$DIB_DISTRIBUTION_MIRROR|;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":22,"context_line":"elif [[ ${DIB_RELEASE} \u003d\u003d \u00278\u0027 ]]; then"},{"line_number":23,"context_line":"    sed -e \"s|^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/|baseurl\u003d$DIB_DISTRIBUTION_MIRROR/|;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":24,"context_line":"    sed -e \"s|^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/|baseurl\u003d$DIB_DISTRIBUTION_MIRROR/|;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-AppStream.repo"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bf51134e_65e246d7","line":21,"in_reply_to":"bf51134e_7fa015f5","updated":"2020-07-13 06:42:47.000000000","message":"Could just replace up to the next slash and reinclude it like done with CentOS 8 below.","commit_id":"25c5cdb574a11da6e96a6342ec9fec68d250db1b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3e77c38354b5f8be5f7f0c84e6f4c89e4669b6e8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# Only set the mirror for the Base, Extras and Updates repositories"},{"line_number":14,"context_line":"# The others aren\u0027t enabled and do not exist on all mirrors"},{"line_number":15,"context_line":"if [[ ${DIB_RELEASE} \u003d\u003d \u00277\u0027 ]]; then"},{"line_number":16,"context_line":"    sed -e \"s|^#baseurl\u003dhttp[s]*://mirror.centos.org/(centos|altarch)/|baseurl\u003d$DIB_DISTRIBUTION_MIRROR/|;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":17,"context_line":"elif [[ ${DIB_RELEASE} \u003d\u003d \u00278\u0027 ]]; then"},{"line_number":18,"context_line":"    sed -e \"s|^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/|baseurl\u003d$DIB_DISTRIBUTION_MIRROR/|;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":19,"context_line":"    sed -e \"s|^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/|baseurl\u003d$DIB_DISTRIBUTION_MIRROR/|;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-AppStream.repo"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_45c4fb5f","line":16,"updated":"2020-07-20 00:19:07.000000000","message":"wow, a one liner sent me down a half-hour rabbit hole :)\n\ndid you know\n\n $ echo \"foo\" | sed \u0027s|\\(foo\\|bar\\)|moo|\u0027\n foo\n\ndoesn\u0027t work?!\n\nIf you read posix on it \n\n\u003e Within the BRE and the replacement, the BRE delimiter itself can be used as a literal character if it is preceded by a backslash.\"\n\nso by using \"|\" as the delimiter \"\\|\" becomes a literal | in the expression and it doesn\u0027t match.  TIL\n\nergo this match doesn\u0027t work because both because it needs to quote the \\( and \\| (or switch to -E for) but there\u0027s the more subtle problem of the | match","commit_id":"1c51a1d4667d8102ed1f822a192efaf9f285efdf"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fee67ee0fe1394319cc30eee490b3b384244bd41","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# Only set the mirror for the Base, Extras and Updates repositories"},{"line_number":14,"context_line":"# The others aren\u0027t enabled and do not exist on all mirrors"},{"line_number":15,"context_line":"if [[ ${DIB_RELEASE} \u003d\u003d \u00277\u0027 ]]; then"},{"line_number":16,"context_line":"    sed -e \"s|^#baseurl\u003dhttp[s]*://mirror.centos.org/(centos|altarch)/|baseurl\u003d$DIB_DISTRIBUTION_MIRROR/|;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":17,"context_line":"elif [[ ${DIB_RELEASE} \u003d\u003d \u00278\u0027 ]]; then"},{"line_number":18,"context_line":"    sed -e \"s|^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/|baseurl\u003d$DIB_DISTRIBUTION_MIRROR/|;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":19,"context_line":"    sed -e \"s|^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/|baseurl\u003d$DIB_DISTRIBUTION_MIRROR/|;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-AppStream.repo"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_76d5731b","line":16,"in_reply_to":"bf51134e_45c4fb5f","updated":"2020-07-20 09:24:28.000000000","message":"Can\u0027t we just then replace *any* [a-z]+ string between the / and avoid comma drama?","commit_id":"1c51a1d4667d8102ed1f822a192efaf9f285efdf"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"be935aabc7c554bcc0b05133c09722f13f4462a7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# Only set the mirror for the Base, Extras and Updates repositories"},{"line_number":14,"context_line":"# The others aren\u0027t enabled and do not exist on all mirrors"},{"line_number":15,"context_line":"if [[ ${DIB_RELEASE} \u003d\u003d \u00277\u0027 ]]; then"},{"line_number":16,"context_line":"    sed -e \"s|^#baseurl\u003dhttp[s]*://mirror.centos.org/(centos|altarch)/|baseurl\u003d$DIB_DISTRIBUTION_MIRROR/|;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":17,"context_line":"elif [[ ${DIB_RELEASE} \u003d\u003d \u00278\u0027 ]]; then"},{"line_number":18,"context_line":"    sed -e \"s|^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/|baseurl\u003d$DIB_DISTRIBUTION_MIRROR/|;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":19,"context_line":"    sed -e \"s|^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/|baseurl\u003d$DIB_DISTRIBUTION_MIRROR/|;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-AppStream.repo"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_1c2df945","line":16,"in_reply_to":"bf51134e_76d5731b","updated":"2020-07-23 03:56:01.000000000","message":"probably; i think it works fine now and reads pretty clearly though","commit_id":"1c51a1d4667d8102ed1f822a192efaf9f285efdf"}]}