)]}'
{"id":"openstack%2Fdiskimage-builder~74171","triplet_id":"openstack%2Fdiskimage-builder~master~I8e088e1ca7759150ab9851be47ed2144294f0f2e","project":"openstack/diskimage-builder","branch":"master","topic":"map_users","hashtags":[],"change_id":"I8e088e1ca7759150ab9851be47ed2144294f0f2e","subject":"Add helper to map service users","status":"ABANDONED","created":"2014-02-17 21:41:13.000000000","updated":"2014-02-25 06:03:07.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"97157fa535242ce1505dd53aaea4cc2105cf1855","_number":74171,"virtual_id_number":74171,"owner":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":1,"date":"2014-02-18 01:03:17.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"all":[{"value":-1,"date":"2014-02-17 22:26:36.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2014-02-17 22:26:36.000000000","_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-02-17 22:26:36.000000000","updated_by":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"reviewer":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"state":"REVIEWER"},{"updated":"2014-02-18 01:03:17.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5ca35068c1d2fc1559212fcb110c8c95d3fb36b5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-17 21:41:13.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"576875aea82b535e1b078407220cc28da9dc5f80","author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"date":"2014-02-17 22:26:36.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nI\u0027d like to see the users differences handled by an environment.d hook in the distro specific elements. The script would define $KEYSTONE_USER, $NOVA_USER, etc. \n\nThen, we update our install and os-refresh-config scripts to use $*_USER everywhere. I\u0027d prefer to see it done that way instead of calls to map-user everywhere.\n\nSee my suggestion in the following review:\nhttps://review.openstack.org/#/c/70721/\n\nChris Jones also suggested something similar on openstack-dev at http://lists.openstack.org/pipermail/openstack-dev/2014-February/027233.html\n\nI like the environment variables b/c it makes the scripts a bit cleaner, and I think is easier documented than a map-users.\n\nIt\u0027s probably worth getting some other folks to weigh in though before deciding on a path forward.\n\nIt could be worth getting more opinions before starting on this implementation though.","accounts_in_message":[],"_revision_number":1},{"id":"95d27ffba4d1224474697e193e5f8a342c84f1ff","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-18 00:25:25.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"0cf25785d0580c5f207af1c86582b4739af24ae2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-18 00:52:24.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"ddd7d105e400a4164685e2dae0c5b867b0a77c74","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-18 01:03:17.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-diskimage-builder-pep8 http://logs.openstack.org/71/74171/1/check/gate-diskimage-builder-pep8/4f7346b : SUCCESS in 26s\n- gate-diskimage-builder-python26 http://logs.openstack.org/71/74171/1/check/gate-diskimage-builder-python26/9ae7a27 : SUCCESS in 56s\n- gate-diskimage-builder-python27 http://logs.openstack.org/71/74171/1/check/gate-diskimage-builder-python27/e3436f3 : SUCCESS in 27s\n","accounts_in_message":[],"_revision_number":1},{"id":"a3a556d51d3ff708afa971b1b0d14a8267b48e94","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-02-25 06:03:07.000000000","message":"Patch Set 1:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"3ec8beca1d6ee25843cd90515b43427ba95b153c","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-02-25 06:03:07.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"78daa4a06704a766ed951f1d85c6eca1c1f55799","revisions":{"78daa4a06704a766ed951f1d85c6eca1c1f55799":{"kind":"REWORK","_number":1,"created":"2014-02-17 21:41:13.000000000","uploader":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"ref":"refs/changes/71/74171/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/71/74171/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/71/74171/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/71/74171/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/71/74171/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/71/74171/1"}}},"commit":{"parents":[{"commit":"621376db44fa34927880da37ef284896c05d5233","subject":"Merge \"Remove tox locale overrides\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/621376db44fa34927880da37ef284896c05d5233"}]}],"author":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2014-02-17 21:38:49.000000000","tz":60},"committer":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2014-02-17 21:38:49.000000000","tz":60},"subject":"Add helper to map service users","message":"Add helper to map service users\n\nAdd wrapper for mapping the service users on openSUSE.\n\nChange-Id: I8e088e1ca7759150ab9851be47ed2144294f0f2e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/78daa4a06704a766ed951f1d85c6eca1c1f55799"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/78daa4a06704a766ed951f1d85c6eca1c1f55799"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"621376db44fa34927880da37ef284896c05d5233","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}