)]}'
{"id":"openstack%2Fdiskimage-builder~743243","triplet_id":"openstack%2Fdiskimage-builder~master~Iee6c8b3b97b3cfff4562bcb30a50800f5ade894a","project":"openstack/diskimage-builder","branch":"master","topic":"bug/1889089","hashtags":[],"change_id":"Iee6c8b3b97b3cfff4562bcb30a50800f5ade894a","subject":"Makes EFI images bootable by bios","status":"MERGED","created":"2020-07-27 14:27:29.000000000","updated":"2020-08-18 08:01:41.000000000","submitted":"2020-08-18 07:59:01.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"743243-1597737541343-e059b733","meta_rev_id":"207e90c1492fa61ef2257dba7332d2f807536b71","_number":743243,"virtual_id_number":743243,"owner":{"_account_id":23518,"name":"Pierre Crégut","email":"pierre.cregut@orange.com","username":"pcregut"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"value":0,"date":"2020-08-18 04:50:53.000000000","_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-18 07:59:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-08-18 06:45:22.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":23518,"name":"Pierre Crégut","email":"pierre.cregut@orange.com","username":"pcregut"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2020-08-18 06:30:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":23518,"name":"Pierre Crégut","email":"pierre.cregut@orange.com","username":"pcregut"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2020-08-18 06:30:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":23518,"name":"Pierre Crégut","email":"pierre.cregut@orange.com","username":"pcregut"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":23518,"name":"Pierre Crégut","email":"pierre.cregut@orange.com","username":"pcregut"},{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-29 17:29:51.000000000","updated_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"REVIEWER"},{"updated":"2020-07-30 05:55:27.000000000","updated_by":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"reviewer":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"state":"REVIEWER"},{"updated":"2020-08-07 07:21:16.000000000","updated_by":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"reviewer":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"state":"REVIEWER"},{"updated":"2020-08-18 04:50:53.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-08-18 06:30:27.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2020-08-18 06:45:22.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-08-18 07:59:01.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"11023a96c7688f6cba0c2e655d15e59855fa4889","author":{"_account_id":23518,"name":"Pierre Crégut","email":"pierre.cregut@orange.com","username":"pcregut"},"date":"2020-07-27 14:27:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2b559d088653e19e4811feb7bf3900c391d846b2","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-07-27 15:00:09.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3-p9 dib-functests-bionic-python3-p9 : NODE_FAILURE in 0s","accounts_in_message":[],"_revision_number":1},{"id":"bd044352537c439e571deb95e031eb0e48295ed9","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-27 15:42:28.000000000","message":"Patch Set 1:\n\nBuild failed (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/None : NODE_FAILURE in 0s","accounts_in_message":[],"_revision_number":1},{"id":"6d3f9ac34c91c5795539581ea76c2a579abc381d","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-07-27 16:30:24.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/a7c7308c20e949bca836cdc136f8ab88 : SUCCESS in 2h 02m 06s","accounts_in_message":[],"_revision_number":1},{"id":"f8b24a2ca2ea9793997ca11b704d137df9fbdd94","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-27 17:00:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/92fccfc51d3249c99cb0c354d36457e9 : SUCCESS in 5m 19s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2f29c6cd660f4e30b51db9320c1b3c3c : SUCCESS in 7m 05s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0a2c4f612e004c898503c82befc93774 : SUCCESS in 5m 25s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/1c8b86539521437e92607fd96fd54245 : SUCCESS in 58m 37s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/778d2269d81c4d4386a238b4a98015a3 : SUCCESS in 25m 01s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/1c4bc41b61394d68a3161b2fc3e661be : SUCCESS in 4m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/93ee63748ae3469a9e72b8623219d0c9 : SUCCESS in 5m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e6fe7691634f4d829d22186a1463ec8b : SUCCESS in 5m 16s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/bd33aa75a83f4a4bbc5c530652e16ff8 : SUCCESS in 4m 50s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/0d23c17343da4031b9471e78f65e6366 : SUCCESS in 3m 57s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/56d2d5fbe58b422eb3063c79172462ca : SUCCESS in 1h 04m 48s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/ff83d626cfe94c35b52f6aa6e14b58a2 : SUCCESS in 15m 52s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/1db14b565e5e440e84d0f33cf0d542f5 : SUCCESS in 26m 00s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/edd9acdbeedb466da7ea96b410b1b75e : SUCCESS in 27m 09s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/e5eddd1d3eff4d7c823f732a157efe5f : SUCCESS in 26m 05s\n- dib-nodepool-functional-openstack-fedora-31-src https://zuul.opendev.org/t/openstack/build/111e0a07e1b34089b78c61b85825e9e9 : SUCCESS in 28m 55s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/39b8897d5a9742e99a4f6b5f6f540e9f : SUCCESS in 24m 37s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/aa5829cc59dc4392b67565cd90ca6518 : SUCCESS in 27m 18s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/fb9d166fdadc490187c4767fbbaa63fa : SUCCESS in 26m 58s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/732e3e366e3d4cb68582e48f5d6e3442 : SUCCESS in 29m 31s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/d0ff3943ee9c462698ae7a8e8f8bfea9 : SUCCESS in 30m 04s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/3b2ae456ae11477098902d04554e07b6 : SUCCESS in 34m 11s\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/b401d2ac25404f68af22b736cc81ea1d : SUCCESS in 32m 33s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/379b528c8fe247998cd69724e142cf9f : SUCCESS in 1h 02m 16s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/f5aa7116078b420c9c111ec653d5fd6d : SUCCESS in 8m 48s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/b3151816209b469fad8d9c0d5fbc1abf : SUCCESS in 14m 38s\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/b2b72fec485c4ae18c9050c3531b0b52 : SUCCESS in 1h 28m 36s (non-voting)\n- ipa-tempest-partition-bios-ipmi-iscsi-dib-src https://zuul.opendev.org/t/openstack/build/81ae9e31864e475098f5cbd88c0bb3a9 : SUCCESS in 1h 20m 24s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3fc968f09f8548a9c7ba1ca6fb650d4f09a2af25","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-07-29 17:29:51.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nDoes it mean EFI-only images are now EFI+BIOS? Is it worth it considering folks are moving towards EFI-only and often try minimizing the images?","accounts_in_message":[],"_revision_number":1},{"id":"8be3565297c3234f25e9f1ebe46e6d672b1b5798","author":{"_account_id":23518,"name":"Pierre Crégut","email":"pierre.cregut@orange.com","username":"pcregut"},"date":"2020-07-29 17:38:05.000000000","message":"Patch Set 1:\n\nIn that case it may be worth adding an option. But currently EFI images are built with a partition for BIOS (see Block Device EFI element) and it does not make sense if it cannot be BIOS booted.","accounts_in_message":[],"_revision_number":1},{"id":"222eb219314e21ce61a648db207b82db42a30296","author":{"_account_id":23518,"name":"Pierre Crégut","email":"pierre.cregut@orange.com","username":"pcregut"},"date":"2020-07-29 17:45:16.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"a2ca6b1c88f45014e53837d52ccde329e591fa71","author":{"_account_id":23518,"name":"Pierre Crégut","email":"pierre.cregut@orange.com","username":"pcregut"},"date":"2020-07-29 17:46:48.000000000","message":"Patch Set 2:\n\nA very clean approach would be to check (whatever the OS is) if there is a partition for BIOS compatibility before calling grub. Someone wanting to squeeze the last bits would use a custom partitioning.\nBut I am not sure I know how to do it...","accounts_in_message":[],"_revision_number":2},{"id":"4254aa97e25eee3615947ad4ff04a98a876b7452","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-29 17:54:20.000000000","message":"Patch Set 2:\n\nBuild failed (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/None : NODE_FAILURE in 0s","accounts_in_message":[],"_revision_number":2},{"id":"fae64c090012bdf2d5f8a95f5ffe4c4e2574f008","author":{"_account_id":23518,"name":"Pierre Crégut","email":"pierre.cregut@orange.com","username":"pcregut"},"date":"2020-07-29 18:50:22.000000000","message":"Patch Set 2:\n\nIf you think it is worth it, the correct approach would be:\n* introduce block-device-efi-bios an exact copy of current block-device-efi with the addition in environment.d of \"export DIB_BIOS_EFI_COMPAT\u003d1\", \n* remove the ESP partition from block-device-efi and the claim in the documentation it supports bios\n* modify my patch to check on DIB_BIOS_EFI_COMPAT in bootloader and install grub only if it is 1.\n* probably the section on package installation should be altered a bit to install only grub-pc if needed.\n\nI think it offers minimal disruption. There was no use for this partition if you cannot boot through bios. We only add a new variable so the other elements will work without change. We even reduce the size of images as long as the user does not want compatibility.\n\nIf you agree on the approach, I amend my patch.","accounts_in_message":[],"_revision_number":2},{"id":"a688d00e1d1aa926f80a573a550aa6b9b20dc06e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-29 19:40:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4c972d0d4fd046e6925f17e0e1a4fed2 : SUCCESS in 5m 01s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5ccb67584a944320ae590504d84548c1 : SUCCESS in 4m 17s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d4b4a9a6039f47deb60c5beadce6c7cd : SUCCESS in 3m 52s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/467a95f6a1504945b4248a971f80486c : SUCCESS in 1h 11m 25s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/3da0757ff62246209df8e767c114da87 : SUCCESS in 29m 08s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/c6a9cada5120463ab57d48480a7fcdb7 : SUCCESS in 4m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d22f7f7eb28b4926b483da38e9159e32 : SUCCESS in 3m 43s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/910ea5f2fff34f1aacbf316436dc8c4e : SUCCESS in 3m 46s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/663cbbf4601649cf9e42e2d2640c0da2 : SUCCESS in 4m 50s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/a897e887f7b647e59713344f6b360a4e : SUCCESS in 3m 55s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/06d9db7fa1274addaf9d066f475693c6 : SUCCESS in 1h 48m 53s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/429b0992aa9446a6a7b40897443acbd0 : SUCCESS in 18m 59s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/5b122d709aff4f43bb7f1418e4406fe3 : SUCCESS in 59m 01s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/abf841a3f1184a8c92944d327b355d1d : SUCCESS in 48m 05s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/36d4448642114415bf541e9c24165ab5 : SUCCESS in 46m 36s\n- dib-nodepool-functional-openstack-fedora-31-src https://zuul.opendev.org/t/openstack/build/cdebc7101a3c49cdaa64e2e56e7d8288 : SUCCESS in 1h 20m 05s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/442f5b17b90e4808abf015c416dfd622 : SUCCESS in 1h 06m 57s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/c90f14560fe54853b1ecb6f14cca6218 : SUCCESS in 48m 39s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/da6a2e3d38434f6aa70ac4f32bb67925 : SUCCESS in 51m 30s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/a4832405606e4500a45369e98bd939f8 : SUCCESS in 1h 00m 36s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/94a353f2e11d40408153028b66a7b894 : FAILURE in 1h 06m 21s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/2861f2ac0ae44a4ab34e4ccd31007ddd : SUCCESS in 49m 27s\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/03b0010d1569408e9c23e240b033b2f5 : SUCCESS in 24m 30s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/62ad4efecd1046a2baa2acba96404686 : SUCCESS in 53m 07s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/e9f749af31b74dc59a2523b16ac36e61 : SUCCESS in 7m 55s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/c0b83542bfd04ac7ac858fdcf0b1187c : SUCCESS in 7m 02s\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/effc9d282fc240488bde7cafc968590b : SUCCESS in 1h 34m 52s (non-voting)\n- ipa-tempest-partition-bios-ipmi-iscsi-dib-src https://zuul.opendev.org/t/openstack/build/56a75e7bacd149659bd9f0a551fab5f8 : SUCCESS in 1h 20m 17s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"faa4b93070ca3a33cb37b6a5892ab548807e41e9","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-07-29 19:48:55.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/bf94d691a3e64058a483823af8a65714 : SUCCESS in 2h 02m 55s","accounts_in_message":[],"_revision_number":2},{"id":"88464fd5223260801704b68de40a4a081d851d7b","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-07-29 19:58:27.000000000","message":"Patch Set 2:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3-p9 dib-functests-bionic-python3-p9 : NODE_FAILURE in 0s","accounts_in_message":[],"_revision_number":2},{"id":"4494e1a957c7a7eb7661ae63d653f48851d92afd","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-08-07 01:07:14.000000000","message":"Patch Set 2:\n\nI\u0027m trying to remember the history here.  AFAIK we\u0027ve never discussed having single EFI and BIOS bootable elements.  \n\nIt seems we got that layout in https://review.opendev.org/#/c/533490/ where we have the comment from\n\n \u003e So, AFAICT, that LVM error is because there\u0027s no bios boot partition [1];\n \u003e some discussion in [2].  I think it\u0027s generically correct to add this\n \u003e although it works without it in the simple case.\n\nSo I don\u0027t think we\u0027ve ever seriously considered the case of having dual-bootable images and putting this partition in was in response to LVM or other assumptions.  \n\nThus if all it takes to make bios and EFI dual-compatible images is this one call, I would say I\u0027m for it.\n\nI don\u0027t know about refactoring to a full block-device-efi-bios element.  This is going to be x86 only and I\u0027m wondering if anyone really needs a x86 image that *only* boots from EFI (v one that is more broadly compatible) such that we should have the overhead of having yet another bootloader path.\n\nIt would be great if hrw had any thoughts ...","accounts_in_message":[],"_revision_number":2},{"id":"f367775f843fb0e80b7b6c8c42b6c7fd4f620aaa","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-08-07 01:10:45.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7e42fecf0194c9e0bef4a8123a2f3a5e0f6652a1","author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"date":"2020-08-07 07:21:16.000000000","message":"Patch Set 2: Code-Review+1\n\n\u003e It would be great if hrw had any thoughts ...\n\nWe added GPT partitioning because AArch64 is UEFI only machine. And UEFI requires GPT.\n\nBIOS boot partition was added for use like this patch is doing - to have place for non-efi grub. We just did not installed such.\n\nAnd UEFI+BIOS bootable image may allow to even drop MBR based image one day to simplify code.","accounts_in_message":[],"_revision_number":2},{"id":"a9a44b292e12bc596c06bddb6b5560e61aad06b7","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-08-18 04:41:36.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c5901e8b70fc18c4a39b0906dc10bf8d572d5134","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-08-18 04:50:53.000000000","message":"Patch Set 3:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3-p9 dib-functests-bionic-python3-p9 : NODE_FAILURE in 0s","accounts_in_message":[],"_revision_number":3},{"id":"b7bd7e549c906621976f200a441ee49f0dffa630","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 05:00:32.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/db19d42491654fb58b70653081488e7d : SUCCESS in 18m 16s","accounts_in_message":[],"_revision_number":3},{"id":"1e8c1f92b72c30b32d26220a2c4e78403038d5ab","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 06:16:34.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f81c43dd4459429e8d3b9b2752ce9aad : SUCCESS in 4m 05s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/25cc23bf09cf42e2b49176b3e91d661a : SUCCESS in 2m 54s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/31efee1b615c4caead4756266c11d2f6 : SUCCESS in 3m 53s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/62b5dfd6e7354c0a88804cb8a3eb41b6 : SUCCESS in 19m 17s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/70671721565b4a268a8459e1fb73576b : SUCCESS in 59m 14s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/f31146893c234f06b1095264e9b03329 : SUCCESS in 24m 18s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/5f5b98cc6b4f419b8a090f73229a56b6 : SUCCESS in 4m 13s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e03cf50ab6de456c9e07310d4afbf478 : SUCCESS in 4m 12s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a6bf9f7211fb4b1db0725dc3c46935d5 : SUCCESS in 2m 59s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ce51fe05636944489abbbc3b4d08b7d2 : SUCCESS in 3m 29s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/732edb8e86e4442c806f31c5c56dc117 : SUCCESS in 2m 51s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/a35dde17545441e4bcf369bb0cc1166f : SUCCESS in 1h 11m 49s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/f7e9b0be264842429bcbd0690eafc70c : SUCCESS in 17m 41s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/1ab23e3095af42acb34b70426ea20cc3 : SUCCESS in 34m 51s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/224dfd733c4c4852a4ec1a7d3f1f1e10 : SUCCESS in 34m 14s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/be7e88edb3a5411fa82d24f9fc376c5e : SUCCESS in 37m 42s\n- dib-nodepool-functional-openstack-fedora-31-src https://zuul.opendev.org/t/openstack/build/81092e957bf443b489cf8275d92f40bc : SUCCESS in 38m 30s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/6568537aaa5c48aebc336ed74a3ba1e5 : SUCCESS in 31m 41s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/265270a89df34f2d9da2e0850de51978 : SUCCESS in 32m 21s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/0963c0d4effa4d9f8e64c1c4c6cfb042 : SUCCESS in 35m 02s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/31a3b0601ca64794babb73ec76c83c48 : SUCCESS in 49m 19s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/e5996f6cf7074b899056273a86b091fb : SUCCESS in 38m 38s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/3d729e7f5fcc49418a01a9d82b249e33 : SUCCESS in 27m 18s\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/3982aeadd7374f82b25a91d367965b3f : SUCCESS in 34m 29s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/13d25988e38741e588713fe235dfb572 : SUCCESS in 42m 03s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/1e864654e656442aa0209a178f5c3d14 : SUCCESS in 6m 47s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/21b588c78fed4de78d4767d19a975af6 : SUCCESS in 9m 54s\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/109b32161dfd497eae4ba1c909a959f6 : SUCCESS in 1h 29m 04s (non-voting)\n- ipa-tempest-partition-bios-ipmi-iscsi-dib-src https://zuul.opendev.org/t/openstack/build/d1367cf32caf43679da6e731f32324aa : SUCCESS in 1h 26m 52s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"885e280a75c3564c4d1d01b32a9845c585898602","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-08-18 06:30:27.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nI just added some comments here.  I\u0027m happy to go with hrw\u0027s review here that this looks about right","accounts_in_message":[],"_revision_number":3},{"id":"953b94cbab5c41f32dc7ca7ae5ce7eddaafbb54e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 06:30:41.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"58923537e8a0c70fa98e9385a9e51f7036f8496f","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-08-18 06:45:22.000000000","message":"Patch Set 3:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/505fd0e0a04240a0a1b72351c738bd12 : SUCCESS in 2h 02m 46s","accounts_in_message":[],"_revision_number":3},{"id":"53f6b91c2099d1f0e7998bdea2e4b74fb0106653","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 07:59:01.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"cc32b8f2bdb80fdb72ef9569fd2de63c5cec8cab","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 07:59:01.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2c779324f88349b881dbfdabb208acf0 : SUCCESS in 6m 31s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e18516a75dd84e0985155220d8f14678 : SUCCESS in 4m 32s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2e15f1fe56e64689b675159481c64235 : SUCCESS in 5m 11s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/7fb52e1f52aa456e9cbef55efe48b22e : SUCCESS in 56m 37s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/25d7db3255e64498ad4a874068a29ba8 : SUCCESS in 27m 02s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/ab76b7e9446e4d399a427aea376e0c54 : SUCCESS in 5m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2de65ca34c6c4883a1553c5d8ededb4f : SUCCESS in 4m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/779b4a32dd1c449387adce5b7a6e67cc : SUCCESS in 5m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/97e63489eeed4e248e8209e09098a51a : SUCCESS in 6m 27s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/ec7a5c48a8a6478ca1d379defce190a8 : SUCCESS in 5m 45s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/5e2e808264714674b395939532c74dc7 : SUCCESS in 1h 26m 19s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/2956022f4cd14ff59bf36a698471da2f : SUCCESS in 20m 11s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/c5ea1860b7974abc901e37914d673cc0 : SUCCESS in 40m 03s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/269f011e003f4bb982c0bfae67aae33e : SUCCESS in 47m 24s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/896e703ad9db49d7b60ea60fe3e92d0e : SUCCESS in 57m 19s\n- dib-nodepool-functional-openstack-fedora-31-src https://zuul.opendev.org/t/openstack/build/94f06716deaf4cf5a874c57760389b4e : SUCCESS in 43m 59s\n- dib-nodepool-functional-openstack-fedora-32-src https://zuul.opendev.org/t/openstack/build/2a0ee92370c04781a03e431f5d987169 : SUCCESS in 41m 44s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/ed8f56b631d64f87ab337c924685d64d : SUCCESS in 52m 34s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/ce451f4764574aafbe3f0e7beb118829 : SUCCESS in 34m 53s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/f786bd4cfbe849f581ac049d56af6d70 : SUCCESS in 43m 42s\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/d6f6b8b1d44b4cbeaca5552aecff1c30 : SUCCESS in 22m 29s\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/9f0616b7f0974aee8c73fde43384ec1a : SUCCESS in 12m 35s","accounts_in_message":[],"_revision_number":3},{"id":"36c42d02dda6c5af24494c4a8b0050b78b2c4637","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 08:01:41.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0374069fb7ed444da04bf94674d38f7a : SUCCESS in 1m 50s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b1216f412d564113a623c0f0d76a64d5 : SUCCESS in 1m 32s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"6e71bd423937ba510ee85c123d1f42b174d53cef","revisions":{"f9abfe5c342569fbd90bba8dc9f2fd5f38142854":{"kind":"REWORK","_number":1,"created":"2020-07-27 14:27:29.000000000","uploader":{"_account_id":23518,"name":"Pierre Crégut","email":"pierre.cregut@orange.com","username":"pcregut"},"ref":"refs/changes/43/743243/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/43/743243/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/43/743243/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/43/743243/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/43/743243/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/43/743243/1"}}},"commit":{"parents":[{"commit":"a7fba927ca265a8547f29286a863e586760269a6","subject":"Merge \"Support non-x86_64 DIB_DISTRIBUTION_MIRROR variable for CentOS 7\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/a7fba927ca265a8547f29286a863e586760269a6"}]}],"author":{"name":"Pierre Crégut","email":"pierre.cregut@orange.com","date":"2020-07-26 16:51:35.000000000","tz":120},"committer":{"name":"Pierre Crégut","email":"pierre.cregut@orange.com","date":"2020-07-27 14:25:49.000000000","tz":120},"subject":"Makes EFI images, bootable by bios","message":"Makes EFI images, bootable by bios\n\nFor Bios and EFI compatibility, grub must be installed twice.\nThis patch adds the bios version when EFI is selected. The GPT EFI  block partitioning already\nadds the bios partition, but the bootloader only called grub once.\n\nChange-Id: Iee6c8b3b97b3cfff4562bcb30a50800f5ade894a\nCloses-Bug: #1889089\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/f9abfe5c342569fbd90bba8dc9f2fd5f38142854"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/f9abfe5c342569fbd90bba8dc9f2fd5f38142854"}]},"branch":"refs/heads/master"},"a11da77554850d8618024ae7482a51ba6e451edc":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-07-29 17:45:16.000000000","uploader":{"_account_id":23518,"name":"Pierre Crégut","email":"pierre.cregut@orange.com","username":"pcregut"},"ref":"refs/changes/43/743243/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/43/743243/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/43/743243/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/43/743243/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/43/743243/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/43/743243/2"}}},"commit":{"parents":[{"commit":"a7fba927ca265a8547f29286a863e586760269a6","subject":"Merge \"Support non-x86_64 DIB_DISTRIBUTION_MIRROR variable for CentOS 7\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/a7fba927ca265a8547f29286a863e586760269a6"}]}],"author":{"name":"Pierre Crégut","email":"pierre.cregut@orange.com","date":"2020-07-26 16:51:35.000000000","tz":120},"committer":{"name":"Pierre Crégut","email":"pierre.cregut@orange.com","date":"2020-07-27 14:37:57.000000000","tz":120},"subject":"Makes EFI images bootable by bios","message":"Makes EFI images bootable by bios\n\nFor Bios and EFI compatibility, grub must be installed twice.\nThis patch adds the bios version when EFI is selected. The GPT EFI  block partitioning\nalready adds the bios partition, but the bootloader only called grub once.\n\nChange-Id: Iee6c8b3b97b3cfff4562bcb30a50800f5ade894a\nCloses-Bug: #1889089\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/a11da77554850d8618024ae7482a51ba6e451edc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/a11da77554850d8618024ae7482a51ba6e451edc"}]},"branch":"refs/heads/master"},"6e71bd423937ba510ee85c123d1f42b174d53cef":{"kind":"REWORK","_number":3,"created":"2020-08-18 04:41:36.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/43/743243/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/43/743243/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/43/743243/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/43/743243/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/43/743243/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/43/743243/3"}}},"commit":{"parents":[{"commit":"a7fba927ca265a8547f29286a863e586760269a6","subject":"Merge \"Support non-x86_64 DIB_DISTRIBUTION_MIRROR variable for CentOS 7\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/a7fba927ca265a8547f29286a863e586760269a6"}]}],"author":{"name":"Pierre Crégut","email":"pierre.cregut@orange.com","date":"2020-07-26 16:51:35.000000000","tz":120},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2020-08-18 04:41:21.000000000","tz":600},"subject":"Makes EFI images bootable by bios","message":"Makes EFI images bootable by bios\n\nFor Bios and EFI compatibility, grub must be installed twice.\nThis patch adds the bios version when EFI is selected. The GPT EFI  block partitioning\nalready adds the bios partition, but the bootloader only called grub once.\n\nChange-Id: Iee6c8b3b97b3cfff4562bcb30a50800f5ade894a\nCloses-Bug: #1889089\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/6e71bd423937ba510ee85c123d1f42b174d53cef"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/6e71bd423937ba510ee85c123d1f42b174d53cef"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}