)]}'
{"id":"openstack%2Fdiskimage-builder~745698","triplet_id":"openstack%2Fdiskimage-builder~master~I0e0cfbdbf7ef2b2861b934ccd7dab9d83a35c8f0","project":"openstack/diskimage-builder","branch":"master","hashtags":[],"change_id":"I0e0cfbdbf7ef2b2861b934ccd7dab9d83a35c8f0","subject":"Handle NetworkManager for dhcp-all-interfaces","status":"MERGED","created":"2020-08-11 15:12:31.000000000","updated":"2020-08-18 05:37:06.000000000","submitted":"2020-08-18 05:35:45.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"745698-1597728945712-9a8a0da4","meta_rev_id":"80bfc672a095744f3d67cadb5a026a95c626ab34","_number":745698,"virtual_id_number":745698,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},{"value":0,"date":"2020-08-11 15:21:16.000000000","_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"date":"2020-08-12 13:56:59.000000000","_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-18 05:35:45.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-08-11 17:37:14.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"recommended":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"all":[{"value":1,"date":"2020-08-12 09:15:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":1,"date":"2020-08-12 10:15:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":1,"date":"2020-08-13 07:35:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":1,"date":"2020-08-14 05:56:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2020-08-18 04:28:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":1,"date":"2020-08-17 14:23:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2020-08-18 04:28:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-11 15:21:16.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-08-11 17:37:14.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-08-12 09:15:19.000000000","updated_by":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"reviewer":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"state":"REVIEWER"},{"updated":"2020-08-12 10:15:47.000000000","updated_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"REVIEWER"},{"updated":"2020-08-13 07:35:25.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2020-08-14 05:56:34.000000000","updated_by":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"reviewer":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"state":"REVIEWER"},{"updated":"2020-08-17 14:23:06.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-08-18 04:28:44.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2020-08-18 05:35:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e611b39a9a62f7f8acc5133893bbc6eef98824ea","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-08-11 15:12:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ac3b2a1371ab7f4f0e903aeb0ed5c2b330ebecc2","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-08-11 15:21:16.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3-p9 dib-functests-bionic-python3-p9 : NODE_FAILURE in 0s","accounts_in_message":[],"_revision_number":1},{"id":"ee63962aeff3e4a86d9a85978668c7429b86ceb9","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-11 15:47:50.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/87f3cd519d564313b760ab9d25314d3a : SUCCESS in 34m 00s","accounts_in_message":[],"_revision_number":1},{"id":"66bd15a0708f175b5e41c9361d4702ffa355d97e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-11 16:59:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5879c338d742495b99494921838e0434 : SUCCESS in 4m 30s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c996cf1daa7c4b3d96a066fa4237d327 : SUCCESS in 3m 45s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/bae03e5ad6ca4f1a8b3187bb118b2c83 : SUCCESS in 4m 43s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b7cdcb64ded943cfab0fa613769abf70 : SUCCESS in 4m 06s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/66e6cdbcfd664ede9cfb4bad049c3853 : SUCCESS in 1h 03m 30s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/9bf80a7d36634e618da5a5dbe56b3ad2 : SUCCESS in 27m 56s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/859d733f2a1d42d6ad343658968c60de : SUCCESS in 4m 52s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/77c750b617c640789f5ba211b050525d : SUCCESS in 5m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2533a7cc5ccc41cd8d52c740a78b1e90 : SUCCESS in 4m 42s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2d4fbe2556ef467f8008b37fbb502964 : SUCCESS in 4m 38s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/c829b2a9b2f84b9d84458ac273e1f46e : SUCCESS in 7m 55s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/39f6e6ccc46f4f0ba671ce95036cef74 : SUCCESS in 1h 25m 10s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/171a518c04c442e18022c019a8b54683 : SUCCESS in 18m 10s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/c32bd01ab66a49dcb53de2f496b8f780 : SUCCESS in 29m 58s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/98e33a3f26ba45039a02f7c2142306b4 : SUCCESS in 33m 12s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/90ba03551944418b9ab01ecb9bbbc39f : SUCCESS in 34m 57s\n- dib-nodepool-functional-openstack-fedora-31-src https://zuul.opendev.org/t/openstack/build/647a44c2ece44ed189b38b1b7677395f : SUCCESS in 35m 33s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/7f4e9f169a70490a88e44ca65c97c0de : SUCCESS in 32m 14s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/b9dd17241b9944c6ab4de2ebb14a9129 : SUCCESS in 29m 22s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/3aa44abecff5412ca3d56fe90dabba09 : SUCCESS in 29m 41s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/107132a8f83e4774b1879fecbd7e86f6 : SUCCESS in 44m 07s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/0d81315fe39a45d8b9ca19c1c641c6b2 : SUCCESS in 35m 52s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/9b0843726c944ae6bb998b0deb83f046 : SUCCESS in 31m 57s\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/50f12884d0954b6ebd19ddebe5c043ff : SUCCESS in 35m 07s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/c9a6c4d1fe6d4cabb580eb4f54e08fb1 : SUCCESS in 1h 08m 05s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/4561fafc24b24e8988dd11892a8b8542 : SUCCESS in 9m 01s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/91704839dc5c444f8f8bd6c1f17d6e5a : SUCCESS in 12m 40s\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/9463fa1f90014e9c9f40c4c0c73bc7b9 : SUCCESS in 1h 38m 54s (non-voting)\n- ipa-tempest-partition-bios-ipmi-iscsi-dib-src https://zuul.opendev.org/t/openstack/build/288279abe6ef47d382c1d197bcd79331 : SUCCESS in 1h 27m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"144061b64826bd1ab3e9434b9e3496ec1b3ce710","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-08-11 17:37:14.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/5ad65b20bc0848ecbea6574992833743 : SUCCESS in 2h 23m 55s","accounts_in_message":[],"_revision_number":1},{"id":"ac9c07f69a4ec365f9728e840c481b6268496e9e","author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"date":"2020-08-12 09:15:19.000000000","message":"Patch Set 1: Code-Review+1\n\nThis looks good to me.\n\n\nAs a side note, what I think we may want to follow up with is a completely new element that uses nmcli to configure interfaces instead of writing config files in /etc/sysconfig/network-scripts or other location for different distros.\n\nI think possibly with network manager we can replace pretty much all of diskimage_builder/elements/dhcp-all-interfaces/install.d/dhcp-all-interfaces.sh etc something like this for all distros:\n\nfor iface in $(nmcli device | grep ethernet | awk { print $0}); do\n  nmcli device modify $iface ipv4.method auto\n  nmcli device modify $iface ipv6.method auto\ndone","accounts_in_message":[],"_revision_number":1},{"id":"47965aa395ac733b174d17284c765cd4f03115d1","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-08-12 10:15:47.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"50eaef92178089cfeaadc776fd718217a77fa293","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-08-12 13:56:59.000000000","message":"Patch Set 1:\n\n\u003e This looks good to me.\n \u003e \n \u003e \n \u003e As a side note, what I think we may want to follow up with is a\n \u003e completely new element that uses nmcli to configure interfaces\n \u003e instead of writing config files in /etc/sysconfig/network-scripts\n \u003e or other location for different distros.\n \u003e \n \u003e I think possibly with network manager we can replace pretty much\n \u003e all of diskimage_builder/elements/dhcp-all-interfaces/install.d/dhcp-all-interfaces.sh\n \u003e etc something like this for all distros:\n \u003e \n \u003e for iface in $(nmcli device | grep ethernet | awk { print $0}); do\n \u003e nmcli device modify $iface ipv4.method auto\n \u003e nmcli device modify $iface ipv6.method auto\n \u003e done\n\nwe could also just completely bypass the network scripts write out in the existing element and do the same commands per interface identified by systemd early on in the boot sequence kind of like what is done now.","accounts_in_message":[],"_revision_number":1},{"id":"97c4e8c9ef9922d8b5d40f8b2579ade162e8ad99","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-08-13 07:35:25.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"80999dff8ca409038bd4b9b2b45c99f2a373cad8","author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"date":"2020-08-14 05:56:34.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"3a0baa46fc5c4480748d5d701734a7bd9ffecc46","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-08-17 14:23:06.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5de121963e905322a95db6eef50dca0e4efdc68f","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-08-18 04:28:44.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nthanks, lots of review here so LGTM","accounts_in_message":[],"_revision_number":1},{"id":"efd0957139840047014aac45270a9b84965621bc","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 04:28:56.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"cafc61839806ea186c7a0b43f72cc6d273837730","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 05:35:45.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"4134843cb0b5af1cd0a43e4ffd65a6cd647fc867","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 05:35:45.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3a966711cbcd4eecbe46473b105d7b4a : SUCCESS in 4m 04s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/30394334d91f4452a750291d449bb764 : SUCCESS in 3m 25s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/001fcc7cde824985a809ba1b0ca969b8 : SUCCESS in 2m 59s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/32f839126348459599338611f856e2be : SUCCESS in 1h 01m 32s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/1036b0008f7f46e481d832d2a3989f2f : SUCCESS in 25m 48s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/4ecd1ffa4d58418a87d89426c811fc42 : SUCCESS in 3m 45s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4de09e1f66d7439b851d4229949a8e94 : SUCCESS in 3m 22s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/32233b08c1a34a0f8e6d4bb78150ead1 : SUCCESS in 3m 18s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/69ffa3436efc4028af92fec0ba337125 : SUCCESS in 3m 12s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/3100b92ecdef42a3b1c4a0f42a70d416 : SUCCESS in 3m 16s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/9add1b929add407e8a52a850272e5dfd : SUCCESS in 59m 54s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/a2dc830a0a9c4d8fb840bf09966ba882 : SUCCESS in 15m 25s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/c6ad1179c08946e1a9ff6a95b2e287f0 : SUCCESS in 30m 04s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/1b9cc016a74d499eb35d6126e7d988af : SUCCESS in 31m 35s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/f8e5395be7734b2abae78beb0933fa29 : SUCCESS in 36m 25s\n- dib-nodepool-functional-openstack-fedora-31-src https://zuul.opendev.org/t/openstack/build/a5a099393e0b4f74b2c766e3c1080a19 : SUCCESS in 34m 55s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/0a057fcf32ba4facae85a5c4ab42fb5a : SUCCESS in 29m 09s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/652c7aebaad848139e022091708c749e : SUCCESS in 31m 37s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/469c48450de249058bf8dc7ff284a51f : SUCCESS in 30m 38s\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/14ae6f8d25234c2a999439a583b90cde : SUCCESS in 21m 17s\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/c92cd5e568394e7f88ac365396186d83 : SUCCESS in 9m 41s","accounts_in_message":[],"_revision_number":1},{"id":"80bfc672a095744f3d67cadb5a026a95c626ab34","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 05:37:06.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7665b37ce6f642de9b00c8794fcbeca2 : SUCCESS in 1m 00s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/81fec080caf54ef3a6aa5587bdd25262 : SUCCESS in 52s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"46d12ae7d396a1e74df6a47376a4bdada5d42e10","revisions":{"46d12ae7d396a1e74df6a47376a4bdada5d42e10":{"kind":"REWORK","_number":1,"created":"2020-08-11 15:12:31.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/98/745698/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/98/745698/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/98/745698/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/98/745698/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/98/745698/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/98/745698/1"}}},"commit":{"parents":[{"commit":"1291dcba516a95fce9d3a51da7e5c73d9da5f584","subject":"Merge \"Deprecate dib-python; remove from in-tree elements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/1291dcba516a95fce9d3a51da7e5c73d9da5f584"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2020-08-11 14:57:40.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2020-08-11 15:12:31.000000000","tz":-420},"subject":"Handle NetworkManager for dhcp-all-interfaces","message":"Handle NetworkManager for dhcp-all-interfaces\n\nNetworkManager takes a distinctly differnet network management\napproach and the bulk of the dhcp-all-interfaces code is largely\ntargetted at distribution specific configuration. Some which may\nor may not override settings, or only partially assert desirable\nsettings.\n\nAs such, we need to set appropriate configuration, such as the\ncorrect client to be used, and timeouts based upon user supplied\nsettings.\n\nBy default this change sets the client to be dhclient on redhat\nstyled machines, as the packaging default, while it works for\nramdisk usage, it does not reset the interface between retries,\nwhich can be critical if the infrastucture operator is attempting\nto configure LACP trunks to the end node.\n\nChange-Id: I0e0cfbdbf7ef2b2861b934ccd7dab9d83a35c8f0\nStory: 2008001\nTask: 40648\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/46d12ae7d396a1e74df6a47376a4bdada5d42e10"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/46d12ae7d396a1e74df6a47376a4bdada5d42e10"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}