)]}'
{"id":"openstack%2Fdiskimage-builder~748402","triplet_id":"openstack%2Fdiskimage-builder~master~I69984a9141fa8abb12dc5d51bd334f9280deca67","project":"openstack/diskimage-builder","branch":"master","topic":"add_cloud_init_disable_growpart","hashtags":[],"change_id":"I69984a9141fa8abb12dc5d51bd334f9280deca67","subject":"Disable growpart in cloud-init-disable-resizefs","status":"MERGED","created":"2020-08-27 10:20:02.000000000","updated":"2020-10-07 08:42:32.000000000","submitted":"2020-10-07 08:41:03.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"748402-1602060063324-7963eb8c","meta_rev_id":"50cbab11c26e82191ce1bcf9c7c3ee9265745644","_number":748402,"virtual_id_number":748402,"owner":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"value":0,"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"date":"2020-10-06 12:55:27.000000000","_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-10-07 08:41:03.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-10-06 14:07:33.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"all":[{"value":0,"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"value":0,"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"value":2,"date":"2020-10-07 06:45:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2020-10-07 02:42:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"all":[{"value":0,"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"value":0,"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"value":1,"date":"2020-10-07 06:45:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-27 12:11:09.000000000","updated_by":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"reviewer":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"state":"REVIEWER"},{"updated":"2020-08-28 06:59:26.000000000","updated_by":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"reviewer":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"state":"REVIEWER"},{"updated":"2020-08-28 07:04:31.000000000","updated_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"REVIEWER"},{"updated":"2020-10-06 12:55:27.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-10-06 14:07:33.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-10-07 02:42:29.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2020-10-07 06:45:47.000000000","updated_by":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"reviewer":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"state":"REVIEWER"},{"updated":"2020-10-07 08:41:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"79aa53e3e71e33e264a795344ce56ab44e86948d","author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"date":"2020-08-27 10:20:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b1445248df7fd66ae6c146d7a58dac4ae726f961","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-27 10:39:57.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/9e85c567537e46b4b728e6393cb6c123 : SUCCESS in 18m 52s","accounts_in_message":[],"_revision_number":1},{"id":"98f8e96686dcb0105d1a252a2912f84752ab9c01","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-08-27 11:06:55.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/7ec05d6d14c14ef0a287ef2d7dbce36e : FAILURE in 46m 08s","accounts_in_message":[],"_revision_number":1},{"id":"93face852148cdb82a86b22ed648f7da29f2c3ca","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-27 12:26:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/48f44911b95a4299bac4428ac894f8b3 : SUCCESS in 5m 41s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2c7cf8be5c6943f8b4d087ce15ab8192 : SUCCESS in 4m 06s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6c170ed7f2c240788928061d3361d870 : SUCCESS in 3m 39s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/e5b2b572a168453480841d582684abb6 : SUCCESS in 34m 04s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/7eba3ce22e1c4d40bc27e2a6ca79dc66 : SUCCESS in 27m 23s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/b720202689f645f1b81d33a57fc97775 : SUCCESS in 4m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/25ddc490781340e491d135cee4dddc04 : SUCCESS in 4m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/994be00fba854f05889de8f0581a9695 : SUCCESS in 5m 12s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4af8dc3e54a04ebca94371ec7b63cf22 : SUCCESS in 4m 26s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/f7a478ddca7e443b9b63e89646e9e50d : SUCCESS in 5m 21s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/7ecb5d50aa9540a7942af3de725f27d2 : SUCCESS in 1h 49m 18s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/7439055d2c93450fbee8935ae1f074e1 : SUCCESS in 19m 58s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/6f11e89ce50a4e53ae3acf8480319510 : SUCCESS in 33m 19s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/0fa57ffdfc81454b88d8587335fbf64a : SUCCESS in 34m 17s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/84127b6bd5dd43b2aed5304fd9e3b5b3 : SUCCESS in 38m 02s\n- dib-nodepool-functional-openstack-fedora-31-src https://zuul.opendev.org/t/openstack/build/a89e04fc62ab40b0a9f40dc272ac03c5 : SUCCESS in 43m 09s\n- dib-nodepool-functional-openstack-fedora-32-src https://zuul.opendev.org/t/openstack/build/ee8df06defe947da819581b415ba6b55 : SUCCESS in 39m 34s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/d4597d2a3b6545fbaa5253cf7b1fe88e : SUCCESS in 34m 31s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/7d59966d56ed435b8ab25544a3229014 : SUCCESS in 35m 19s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/6f8735fef57a4f9a8cc8846744994817 : SUCCESS in 36m 32s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/2b6ae7d6ba084bd0bf45f9a65dfd51ac : SUCCESS in 51m 54s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/76e9410deffd40e8a575688798a62966 : SUCCESS in 43m 50s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/335308cfa8194fc78afb188773561142 : SUCCESS in 30m 03s\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/aa5ef62be02b4ff4be38f06f98dbe6cb : SUCCESS in 34m 19s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/c8c0b139b0e14570a6cfb62751d81cd5 : SUCCESS in 45m 02s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/c73b306b7e6b443591912285b6f72e7f : SUCCESS in 6m 37s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/35c15693a882482a8d5f314c648d5ed0 : SUCCESS in 10m 39s\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/c9b276c6ea26429e8becf5e72e87023c : SUCCESS in 1h 40m 09s (non-voting)\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/436179612df14baeb0b3b4ae5fa608d4 : SUCCESS in 1h 30m 02s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"bc6c7519f1f0e526209faf18f64d47a563e18a41","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-08-27 12:27:13.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3-p9 dib-functests-bionic-python3-p9 : NODE_FAILURE in 0s","accounts_in_message":[],"_revision_number":1},{"id":"80da62bde0a682d8e1ac524e3edffd0bfec5cc3a","author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"date":"2020-08-28 06:20:29.000000000","message":"Patch Set 1:\n\nit seems like this is statically disabling that function, is the image to rely on the gropart element instead?","accounts_in_message":[],"_revision_number":1},{"id":"3eb6ff0b1efdbd1ddeac9def6ec17f92e874ec1f","author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"date":"2020-08-28 06:42:27.000000000","message":"Patch Set 1:\n\n\u003e it seems like this is statically disabling that function, is the\n \u003e image to rely on the gropart element instead?\n\nWell, in my case I\u0027m using this for images used by ironic, if you have a 1TB drive - ending up with ~1TB / partition is not nice.\nThere is the cloud-init-disable-resizefs element, but it only disables resize2fs, the partition is still growing to match 100% disk space.\n\nOther alternative is to use a custom partition layout, which I\u0027m doing right now - but I thought this makes sense :-)","accounts_in_message":[],"_revision_number":1},{"id":"35db7011c7982bc1e51e0487ced0a584e046304f","author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"date":"2020-08-28 06:49:53.000000000","message":"Patch Set 1:\n\nthe functionality itself makes sense, but I think the default use case makes sence to expand/resize.  I\u0027d personally prefer this to be locked behind a envvar (with updating the readme to let people know).","accounts_in_message":[],"_revision_number":1},{"id":"24e3de6f4127e61b64bf15289435b26706ef9635","author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"date":"2020-08-28 06:54:15.000000000","message":"Patch Set 1:\n\n\u003e the functionality itself makes sense, but I think the default use\n \u003e case makes sence to expand/resize.  I\u0027d personally prefer this to\n \u003e be locked behind a envvar (with updating the readme to let people\n \u003e know).\n\nWell then it makes sense to add this functionality to cloud-init-disable-resizefs element locked behind and envvar - with default disabled (to ensure current behaviour). I\u0027ll post an update later today.","accounts_in_message":[],"_revision_number":1},{"id":"676d77c1a61c6faa345235824dc9321cd1cd0bec","author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"date":"2020-08-28 06:59:26.000000000","message":"Patch Set 1: Code-Review+1\n\nman, I totally missed that this was not part of the main cloud-init element, lol","accounts_in_message":[],"_revision_number":1},{"id":"1f3edd4d09acd1972ef621603cb6d99caa0a234e","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-08-28 07:04:31.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"07c652d9e07d7bb2857c822f508e121082b6afd9","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-09-14 22:59:45.000000000","message":"Patch Set 1: Code-Review-1\n\nI think having this in the resizefs element is probably a better idea?\n\nWhat\u0027s the use case for wanting to grow the partition, but then not wanting to resize the file-system to fill it (i.e. use this element without resize2fs)?\n\nThe original changelog doesn\u0027t really talk about why it didn\u0027t disable growpart (Ic050c74aa71165b43c8908c4d6c7c0ea99ddafa3) but does say \"and users are likely better off creating new partitions in the empty space.\"  Maybe something has changed in the years since about cloud-init\u0027s growth model, and the extant code used to also disable growing the partition?\n\nI think it makes sense to just add this to resizefs, with a release note that it will now not grow the partition or resize the disk; which feels like totally reasonable default behaviour.  If anyone absolutely requires the opposite, we could add vars, but it\u0027s overall age and lack of references in [1] suggests to me that it\u0027s unlikely to be relied on.\n\n[1] http://codesearch.openstack.org/?q\u003dcloud-init-disable-resizefs\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","accounts_in_message":[],"_revision_number":1},{"id":"5e55e5048a9988984238f2b963cb0b96bfb8ea43","author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"date":"2020-10-06 12:03:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2c9f5e44b837c718579043cbfc79a75456646f98","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-06 12:17:28.000000000","message":"Patch Set 2:\n\nBuild failed (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/fcd382b6837a42c6a2d5fe030530c2e4 : FAILURE in 12m 43s","accounts_in_message":[],"_revision_number":2},{"id":"0b2f81040f661990af1361634d24cf118834e49d","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-10-06 12:55:27.000000000","message":"Patch Set 2:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3-p9 dib-functests-bionic-python3-p9 : NODE_FAILURE in 0s","accounts_in_message":[],"_revision_number":2},{"id":"c4cec4f89db4c2ee800f057443ab447c79c19630","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-10-06 14:07:33.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/95c39caed8a3483f81eb5743992c4ae7 : SUCCESS in 2h 02m 31s","accounts_in_message":[],"_revision_number":2},{"id":"040ef245834e934836b703232344ce1bf896cb65","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-06 14:22:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/88566d9db99b4b88991ca752214d1108 : SUCCESS in 7m 32s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7772fbd27e764945bddc4529b03a49dc : SUCCESS in 3m 55s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/45c8bc72c16041cfaecece721abf1e47 : SUCCESS in 6m 39s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b91ff4ff5c324c7b8453f9db9929d51b : SUCCESS in 3m 36s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/288f60e447e14dfa8b116c54e9c66cc3 : SUCCESS in 1h 07m 50s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/7ae3b59a3b014ac5bf12a3ee41056399 : SUCCESS in 34m 40s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/b3eb83e515964d99b5ad26197c129a9c : SUCCESS in 4m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/171f1aec26ab493ca881d900fc17b71e : SUCCESS in 4m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2c7bfed7ed364d38afc4a2bf323167f6 : SUCCESS in 6m 02s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d885f1ca4e45486f92077a035842a597 : SUCCESS in 4m 32s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/5a40966526064b179da6bfbe0705f3fa : SUCCESS in 4m 14s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/f547c36ad81349c0b6524925be070c01 : SUCCESS in 1h 57m 57s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/507eda8bf6b04b70a603082aabcd6bc8 : SUCCESS in 20m 26s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/1b3a0408b1fc445182c83c611049aa77 : SUCCESS in 31m 56s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/c6ae75a711374ecb8da3249f2b381e82 : SUCCESS in 35m 04s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/b24175cfb5bf4ebab0cf26af5d3d4a74 : SUCCESS in 33m 01s\n- dib-nodepool-functional-openstack-fedora-31-src https://zuul.opendev.org/t/openstack/build/161b85b96acb4ef0a97cae90a5712d30 : SUCCESS in 53m 58s\n- dib-nodepool-functional-openstack-fedora-32-src https://zuul.opendev.org/t/openstack/build/351142ea3b8a4c6a95402393d67d7082 : SUCCESS in 48m 58s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/1366be7a443d41ccb8ea6aefaa4f3028 : SUCCESS in 40m 11s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/0214b1312713495792be242f7f945c7b : SUCCESS in 31m 57s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/27fa11a71ad84c418dc5d0d0544938d9 : SUCCESS in 34m 00s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/b5645962df8149c9ba23b8f08ac11276 : SUCCESS in 40m 38s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/96be913544cb45ef99c98d4da6b05d1f : SUCCESS in 1h 07m 13s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/300f9a0ecfeb4d238167d49caa41c232 : SUCCESS in 35m 25s\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/c233f1ea3162432a8f2a876095512675 : FAILURE in 19m 59s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/fbbc704e656d4150b5dc2cf37829127d : SUCCESS in 48m 07s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/92f3c747e372421abce3b38a3a802c76 : SUCCESS in 9m 48s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/bd6b1e4767214f338ff7d5d95c4d4bf7 : SUCCESS in 12m 54s\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/8e83d04771ff4a8a822f070a3d0a3364 : SUCCESS in 1h 21m 24s (non-voting)\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/52ba284ccc7e4607a1e62a012eb04548 : SUCCESS in 1h 17m 27s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"df8c5322059aa529b9453c0871dbbf657e68ad22","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-10-07 02:42:29.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ca9b4e0d62a07a6354bf1c9f83d7c8529b70da79","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2020-10-07 06:45:47.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"d8b8312a8e0c94db173975d1be235745b0349ea8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-07 06:46:00.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"fb4dd35117b08118e95e624d93128137e640694c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-07 08:41:03.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b7978f2e4b854bc6847fe7bdf7f52859 : SUCCESS in 5m 29s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/903d52a93bb74fbfafdf7ed6cabc4a09 : SUCCESS in 4m 20s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/95089d9ad81b4c169eb0502f3fc6cc20 : SUCCESS in 3m 31s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/63904d1771a5447e8b9bad42aec1b4b5 : SUCCESS in 1h 02m 13s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/cc80328f8e1c4245b9f751af573361cc : SUCCESS in 33m 19s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/7de73cf09fb74581ab5975f457e723d0 : SUCCESS in 4m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/58bf32f12b46426c8d8bcd88f7d19848 : SUCCESS in 4m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c10c29e2ea664af2a903c54d5158237e : SUCCESS in 4m 03s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/242c0140278248ac9599e8799daa32dd : SUCCESS in 3m 58s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/709cd6518e8343d793d55496025eadf5 : SUCCESS in 3m 59s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/1f08b9f3652b44bcb15a31cb2ca71e3f : SUCCESS in 1h 53m 31s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/2245f32b519f4a149e5338d561ecd858 : SUCCESS in 16m 39s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/b619db5adc494f758f93a9db889f55a4 : SUCCESS in 33m 17s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/8aea6a9d4a39480daf67c025c3b58815 : SUCCESS in 58m 32s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/9ed18cb188d84a1a8109da7baeb92a5e : SUCCESS in 28m 03s\n- dib-nodepool-functional-openstack-fedora-31-src https://zuul.opendev.org/t/openstack/build/c5c3beb048a745e19663e8da2beb8b28 : SUCCESS in 32m 49s\n- dib-nodepool-functional-openstack-fedora-32-src https://zuul.opendev.org/t/openstack/build/806e00d7c0b145ed875325fc14544583 : SUCCESS in 1h 00m 34s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/08435407c14342a19d2b326a7ff8ef98 : SUCCESS in 27m 49s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/6648938f870642e2aac1b8c117669bea : SUCCESS in 59m 13s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/0dde5fe924c74961a6e9dd7d4e469d8f : SUCCESS in 1h 10m 48s\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/7da63b36f5b34a4591ae63f68a7c9123 : SUCCESS in 40m 56s\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/3a3b5d72c1fa4b0e9317c99999432bcb : SUCCESS in 11m 43s","accounts_in_message":[],"_revision_number":2},{"id":"42906292de5f2f8d17f22de53c394aeb0d2f9fae","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-07 08:41:03.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"a8b1ff474f7e041fa1469e3e58e3b15150f688ab","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-07 08:42:32.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5c1b7fda1bd34f52a16d1d302b8591ea : SUCCESS in 1m 02s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9177ebb12e8d49b6b21061f233f4c4c3 : SUCCESS in 1m 05s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"520e12ec2981352246e283a8ed37beefa5ccc2b2","revisions":{"fd083e22b7f13a69f8bd9c9020fea20186ca5b8e":{"kind":"REWORK","_number":1,"created":"2020-08-27 10:20:02.000000000","uploader":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"ref":"refs/changes/02/748402/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/02/748402/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/02/748402/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/02/748402/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/02/748402/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/02/748402/1"}}},"commit":{"parents":[{"commit":"d140cc239a247558153cd2073d69c602529f5e21","subject":"Merge \"Revert \"source-repositories: git is a build-only dependency\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/d140cc239a247558153cd2073d69c602529f5e21"}]}],"author":{"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","date":"2020-08-27 10:19:00.000000000","tz":120},"committer":{"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","date":"2020-08-27 10:19:59.000000000","tz":120},"subject":"Add cloud-init-disable-growpart","message":"Add cloud-init-disable-growpart\n\nThis allows to disable growpart module in cloud-init, not resizing / partition\nto maximum disk free size by default.\n\nChange-Id: I69984a9141fa8abb12dc5d51bd334f9280deca67\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/fd083e22b7f13a69f8bd9c9020fea20186ca5b8e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/fd083e22b7f13a69f8bd9c9020fea20186ca5b8e"}]},"branch":"refs/heads/master"},"520e12ec2981352246e283a8ed37beefa5ccc2b2":{"kind":"REWORK","_number":2,"created":"2020-10-06 12:03:59.000000000","uploader":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"ref":"refs/changes/02/748402/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/02/748402/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/02/748402/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/02/748402/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/02/748402/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/02/748402/2"}}},"commit":{"parents":[{"commit":"d140cc239a247558153cd2073d69c602529f5e21","subject":"Merge \"Revert \"source-repositories: git is a build-only dependency\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/d140cc239a247558153cd2073d69c602529f5e21"}]}],"author":{"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","date":"2020-08-27 10:19:00.000000000","tz":120},"committer":{"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","date":"2020-10-06 12:03:57.000000000","tz":120},"subject":"Disable growpart in cloud-init-disable-resizefs","message":"Disable growpart in cloud-init-disable-resizefs\n\nThis disables growpart module in cloud-init, not resizing / partition\nto maximum disk free size by default.\n\nChange-Id: I69984a9141fa8abb12dc5d51bd334f9280deca67\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/520e12ec2981352246e283a8ed37beefa5ccc2b2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/520e12ec2981352246e283a8ed37beefa5ccc2b2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}