)]}'
{"id":"openstack%2Fdiskimage-builder~756325","triplet_id":"openstack%2Fdiskimage-builder~master~Id590b00805d0fef00a2ddb1d7d78bad96016fbf9","project":"openstack/diskimage-builder","branch":"master","hashtags":[],"change_id":"Id590b00805d0fef00a2ddb1d7d78bad96016fbf9","subject":"Fix running in a venv","status":"ABANDONED","created":"2020-10-06 14:30:30.000000000","updated":"2020-11-12 14:41:53.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1beb60a2537ad741f91be7a8cc990111b35606cc","_number":756325,"virtual_id_number":756325,"owner":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2020-10-06 16:35:59.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-10-06 16:34:26.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"date":"2020-11-12 14:16:22.000000000","_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},{"date":"2020-10-06 14:31:25.000000000","_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-11-12 03:25:33.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-06 14:31:25.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-10-06 16:34:26.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-10-06 16:35:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-11-12 03:25:33.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"}],"messages":[{"id":"b5cfdea9aed13bd3459371ee1e6e238ec63efcdc","author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"date":"2020-10-06 14:30:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"458ed350a979df26f9a45dc24f3714ee840ddfac","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-10-06 14:31:25.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3-p9 dib-functests-bionic-python3-p9 : NODE_FAILURE in 0s","accounts_in_message":[],"_revision_number":1},{"id":"19ba7cb52fd3593d2d24eec6e97fd7a06acc1017","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-06 14:49:58.000000000","message":"Patch Set 1:\n\nBuild failed (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/4ac2140af3a74f5abd056a5a0c255fc3 : FAILURE in 10m 55s","accounts_in_message":[],"_revision_number":1},{"id":"d1baa447281d53f1572c1085c765b0a3de224d34","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-10-06 16:34:26.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/c71f5308629746e9ace1e488b5d4a127 : SUCCESS in 2h 03m 02s","accounts_in_message":[],"_revision_number":1},{"id":"3e648cad57d2e1b6babb79c6ed556ac7153dbe0e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-06 16:35:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5546a7fd585743f6a43b1e1650542c0e : SUCCESS in 4m 50s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4bb6f521e473464a97cfc5dd6380c5bf : SUCCESS in 3m 57s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/93eeaf62dd1b443b9cda5e8128f5beec : SUCCESS in 5m 00s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/4fd21e050914405280259ffc5820ced0 : SUCCESS in 47m 13s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/ea9c563286544d6d938784a3f682d053 : SUCCESS in 27m 05s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/fbd7b898e4924dd59073da1c641b8c14 : SUCCESS in 5m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/243d687f7de34d8f9632c0780cd34186 : SUCCESS in 4m 55s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f021d307bb40402baceb38aaed2294f1 : SUCCESS in 5m 47s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9a901183bffb4eb2a668f734ea36b00f : SUCCESS in 4m 49s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/6bc71faaf44548278ecfb36eb2dd093f : SUCCESS in 3m 56s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/7c80f7f6feca44efb2f091ac04213cfa : SUCCESS in 1h 29m 09s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/84c3c679ddad40b99bb60c62ab51937d : SUCCESS in 18m 18s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/330e1c7819424495880aead0e7d46449 : SUCCESS in 34m 58s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/16e261ff2bde440b8dd3c69d6df278d8 : SUCCESS in 32m 48s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/d15dd0be0c674305a058b97b94aa6e75 : SUCCESS in 32m 12s\n- dib-nodepool-functional-openstack-fedora-31-src https://zuul.opendev.org/t/openstack/build/2e1667b782724a6dabb3f2124f945c88 : SUCCESS in 36m 53s\n- dib-nodepool-functional-openstack-fedora-32-src https://zuul.opendev.org/t/openstack/build/309406dcbfd14984ba23f03f1622ecdc : SUCCESS in 35m 41s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/191a0018eca64ee081baa846be7f390c : SUCCESS in 30m 05s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/4fc94f4b50b04c8d9e8401e3c805cc2e : SUCCESS in 32m 27s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/98f8eaa2830b40469bb5a6dfebe4db5d : SUCCESS in 30m 54s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/6f64676e824a487a8e575a5af88e68a9 : SUCCESS in 43m 10s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/dc4316babf044593a3b6b64720e49091 : SUCCESS in 38m 58s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/52429662ecbf4b67a5f228c5d7877d94 : SUCCESS in 46m 13s\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/b2388495237e41cebde5f67b27229471 : FAILURE in 18m 08s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/4000ff737b55473a82be796bc8552e2f : SUCCESS in 43m 37s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/c2bd9bb1b2674b2bb79af2f05c4bf444 : SUCCESS in 7m 51s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/e652408f273343b4a09f5a7b3dab397a : SUCCESS in 12m 09s\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/c4097dd37d5b46039dfc4f5ea0fd1513 : SUCCESS in 1h 22m 59s (non-voting)\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/17cfd6e0e63740a09ddb56cbc178dce2 : SUCCESS in 1h 22m 12s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2f7574df1be572b6cc685c8b2e9b18eb93d24064","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-10-08 21:46:41.000000000","message":"Patch Set 1:\n\nThis is running in an *unactivated* vm right?  as in running ./bin/disk-image-create without first \". ./bin/activate\"?\n\nI have to admit, when we removed the non-working auto-activation I was pretty happy to say that running out of a non-activated venv wasn\u0027t supported.  \n\nAm I correct that this is the core problem?","accounts_in_message":[],"_revision_number":1},{"id":"6ae355631f7be45ae123f5f817e08d9ef58de02f","author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"date":"2020-10-13 19:09:04.000000000","message":"Patch Set 1:\n\n\u003e This is running in an *unactivated* vm right?  as in running\n \u003e ./bin/disk-image-create without first \". ./bin/activate\"?\n \u003e \n \u003e I have to admit, when we removed the non-working auto-activation I\n \u003e was pretty happy to say that running out of a non-activated venv\n \u003e wasn\u0027t supported.\n \u003e \n \u003e Am I correct that this is the core problem?\n\nYes, that\u0027s the core problem. However it worked before and within nodepool we cannot use pre-activation. We had to temporarily revert Ide4b617f419b57ca8be53bc36b1c506fd399d3e6 in our nodepool installation but this is only a temporary solution.\n\nI tried to keep this change as minimal as possible so we can keep the auto activation removal while still supporting to run dib in an unactivated venv just like any other python application.","accounts_in_message":[],"_revision_number":1},{"id":"0482d09d01319cf32b1b84f2ddc1c46e66e01815","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-11-09 11:21:08.000000000","message":"Patch Set 1:\n\nSorry I didn\u0027t get back to this, I felt like maybe we should reevaluate why this was necessary but got distracted.  I feel like we can just drop these as console scripts because they are not useful outside the context of disk-image-build and have proposed a couple of changes.  It looks like ci is having issues so I\u0027ll chase that tomorrow and we can evaluate","accounts_in_message":[],"_revision_number":1},{"id":"c8cc649e70abd89f58493cd1ac5011b348497f24","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-11-12 03:25:33.000000000","message":"Patch Set 1: Code-Review-1\n\n-1 for visibility to discuss this\n\nI think that having these tools as entry-points is wrong; there\u0027s nothing they can do outside the context of actually being run under disk-image-create.\n\nI have proposed\n\nhttps://review.opendev.org/#/c/761857/\nhttps://review.opendev.org/#/c/761858/\n\nthat moves it into /lib.  This is very similar to dib-run-parts, which we moved to an internal tool as well.\n\nDoes this work for you?","accounts_in_message":[],"_revision_number":1},{"id":"cd9d1f7611478a9c0b2038263700385ca0c394ca","author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"date":"2020-11-12 14:16:22.000000000","message":"Patch Set 1:\n\nThanks, I\u0027ll test those :)","accounts_in_message":[],"_revision_number":1},{"id":"1beb60a2537ad741f91be7a8cc990111b35606cc","author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"date":"2020-11-12 14:41:53.000000000","message":"Abandoned\n\nI tested your alternative changes and can confirm that they work. Thanks a lot!","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"601f198ecacd44a982226559fab21c742927e5ed","revisions":{"601f198ecacd44a982226559fab21c742927e5ed":{"kind":"REWORK","_number":1,"created":"2020-10-06 14:30:30.000000000","uploader":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"ref":"refs/changes/25/756325/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/25/756325/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/25/756325/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/25/756325/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/25/756325/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/25/756325/1"}}},"commit":{"parents":[{"commit":"8a8786a7369cc50c2ffc7f11c1ecfe0f78d1a8a3","subject":"Merge \"Test opensuse 15 builds with 15.2\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/8a8786a7369cc50c2ffc7f11c1ecfe0f78d1a8a3"}]}],"author":{"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","date":"2020-10-06 14:28:01.000000000","tz":120},"committer":{"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","date":"2020-10-06 14:28:01.000000000","tz":120},"subject":"Fix running in a venv","message":"Fix running in a venv\n\nChange Iede929ea2d278008220aac8b1d678ba41eba0d8a removed the\nvirtualenv activation to make diskimage-builder more compatible with\npython 3 and venv instead of virtualenv. This actually broke running\nin a venv since some scripts that are installed along\ndiskimage-builder are not found anymore. Fix this by exporting a new\nvariable DIB_BIN_DIR and call those tools using absolute paths.\n\nChange-Id: Id590b00805d0fef00a2ddb1d7d78bad96016fbf9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/601f198ecacd44a982226559fab21c742927e5ed"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/601f198ecacd44a982226559fab21c742927e5ed"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}