)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e740bb58b2fd1c75d4f8bae4bb5f329d7d1e2c89","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://lists.centos.org/pipermail/centos-devel/2020-September/056069.html"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: https://review.opendev.org/c/openstack/diskimage-builder/+/766447/"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ife139fcaff0c2d944098ea353259971d2d3f18b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"73ccb77d_82a09d25","line":14,"updated":"2020-12-11 08:10:24.000000000","message":"Given the depends-on is the same project as this change, you would have to rebase this patch on top. \"Depends-on\" are for cross-project dependencies.","commit_id":"7e8fb3dbe31f2ef307cbc0b9d4ff7150821676ff"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8bb159c2810270ebe211296ae3412563d6fbacf6","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://lists.centos.org/pipermail/centos-devel/2020-September/056069.html"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: https://review.opendev.org/c/openstack/diskimage-builder/+/766447/"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ife139fcaff0c2d944098ea353259971d2d3f18b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"54008a19_8d150ca5","line":14,"in_reply_to":"73ccb77d_82a09d25","updated":"2020-12-14 08:55:11.000000000","message":"+1","commit_id":"7e8fb3dbe31f2ef307cbc0b9d4ff7150821676ff"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"9ce7be4732923067658ca9b2631f0c5b2cae9fb4","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://lists.centos.org/pipermail/centos-devel/2020-September/056069.html"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: https://review.opendev.org/c/openstack/diskimage-builder/+/766447/"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Also Increase flake8 and pyflakes version in lower-constraints.txt as"},{"line_number":17,"context_line":"this was already broken."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"c60ee5cb_a80fd543","line":14,"updated":"2020-12-14 16:52:06.000000000","message":"This should no longer be included, right?","commit_id":"eaa268067b51d2e98280e10928a03286f2f4ea98"}],"diskimage_builder/elements/centos/pre-install.d/01-set-centos-mirror":[{"author":{"_account_id":10910,"name":"Stig Telfer","email":"stig.openstack@telfer.org","username":"stigtelfer"},"change_message_id":"42f5fbc8ffa4f98620f187da045d7fa4987f4010","unresolved":true,"context_lines":[{"line_number":15,"context_line":"if [[ ${DIB_RELEASE} \u003d\u003d \u00277\u0027 ]]; then"},{"line_number":16,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\(centos\\|altarch\\)/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":17,"context_line":"elif [[ ${DIB_RELEASE} \u003e \u00277\u0027 ]]; then"},{"line_number":18,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Linux-BaseOS.repo"},{"line_number":19,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Linux-AppStream.repo"},{"line_number":20,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Linux-Plus.repo"},{"line_number":21,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Linux-Extras.repo"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"99b198fc_c074f691","line":18,"updated":"2020-12-09 21:08:27.000000000","message":"This logic is not correct because CentOS 8.1 and CentOS 8.2 do not use this naming scheme.  Also, for a complete solution there are additional repos in 8.3, eg FastTrack, HighAvailability, etc.\n\nLook at https://review.opendev.org/c/openstack/diskimage-builder/+/766164/1/diskimage_builder/elements/centos/pre-install.d/01-set-centos-mirror for example.","commit_id":"dd0582c4eb2ff0136bc3253ca80391c3120c04c4"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"edbadc1ed4df76ea0e2b6292d181eceeb4b2d574","unresolved":true,"context_lines":[{"line_number":15,"context_line":"if [[ ${DIB_RELEASE} \u003d\u003d \u00277\u0027 ]]; then"},{"line_number":16,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\(centos\\|altarch\\)/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":17,"context_line":"elif [[ ${DIB_RELEASE} \u003e \u00277\u0027 ]]; then"},{"line_number":18,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Linux-BaseOS.repo"},{"line_number":19,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Linux-AppStream.repo"},{"line_number":20,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Linux-Plus.repo"},{"line_number":21,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Linux-Extras.repo"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ccdc7ab7_ea7572b9","line":18,"in_reply_to":"99b198fc_c074f691","updated":"2020-12-10 07:34:02.000000000","message":"like your patch.\nIn that case, I added Depends-On to yours patch in that commit.\nIt should be ok.","commit_id":"dd0582c4eb2ff0136bc3253ca80391c3120c04c4"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e740bb58b2fd1c75d4f8bae4bb5f329d7d1e2c89","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# The others aren\u0027t enabled and do not exist on all mirrors"},{"line_number":15,"context_line":"if [[ ${DIB_RELEASE} \u003d\u003d \u00277\u0027 ]]; then"},{"line_number":16,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\(centos\\|altarch\\)/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":17,"context_line":"else"},{"line_number":18,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Linux-BaseOS.repo"},{"line_number":19,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Linux-AppStream.repo"},{"line_number":20,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Linux-Plus.repo"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"659b4f32_5dac7a51","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":4},"updated":"2020-12-11 08:10:24.000000000","message":"Not sure I understand the reason for changing this line. I added the elif just in case someone tried to build a CentOS 6 image. Anyway...","commit_id":"7e8fb3dbe31f2ef307cbc0b9d4ff7150821676ff"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8bb159c2810270ebe211296ae3412563d6fbacf6","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# The others aren\u0027t enabled and do not exist on all mirrors"},{"line_number":15,"context_line":"if [[ ${DIB_RELEASE} \u003d\u003d \u00277\u0027 ]]; then"},{"line_number":16,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\(centos\\|altarch\\)/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":17,"context_line":"else"},{"line_number":18,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Linux-BaseOS.repo"},{"line_number":19,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Linux-AppStream.repo"},{"line_number":20,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Linux-Plus.repo"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"665576ea_33338521","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":4},"in_reply_to":"659b4f32_5dac7a51","updated":"2020-12-14 08:55:11.000000000","message":"+1 to this too I mean we may as well keep it explicit here... the if is for rhel7 and the elif is for \u003e7","commit_id":"7e8fb3dbe31f2ef307cbc0b9d4ff7150821676ff"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"2edd0cade47a19456928f018977b177970360f29","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# The others aren\u0027t enabled and do not exist on all mirrors"},{"line_number":15,"context_line":"if [[ ${DIB_RELEASE} \u003d\u003d \u00277\u0027 ]]; then"},{"line_number":16,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\(centos\\|altarch\\)/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":17,"context_line":"else"},{"line_number":18,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Linux-BaseOS.repo"},{"line_number":19,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Linux-AppStream.repo"},{"line_number":20,"context_line":"    sed -e \"s,^#baseurl\u003dhttp[s]*://mirror.centos.org/\\$contentdir/,baseurl\u003d$DIB_DISTRIBUTION_MIRROR/,;/^mirrorlist\u003d/d\" -i /etc/yum.repos.d/CentOS-Linux-Plus.repo"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"1c208fcd_92159733","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":4},"in_reply_to":"665576ea_33338521","updated":"2020-12-14 13:17:23.000000000","message":"+1, changing that condition seems unrelated.","commit_id":"7e8fb3dbe31f2ef307cbc0b9d4ff7150821676ff"}],"diskimage_builder/elements/yum-minimal/root.d/08-yum-chroot":[{"author":{"_account_id":11810,"name":"Nicolas Hicher","email":"nhicher@redhat.com","username":"atarakt"},"change_message_id":"a3db52441e66ebd648d372ba38e6a215b85f91bf","unresolved":true,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # CentOS 8.1 split repositories and GPG keys out into subpackages"},{"line_number":93,"context_line":"    if [[ ${DISTRO_NAME} \u003d centos \u0026\u0026 ${DIB_RELEASE} \u003e \"7\" ]]; then"},{"line_number":94,"context_line":"        packages+\u003d\"centos-gpg-keys \""},{"line_number":95,"context_line":"        if [[ \"$DIB_RELEASE\" \u003d~ (stream) ]]; then"},{"line_number":96,"context_line":"            packages+\u003d\"centos-stream-release centos-stream-repos \""},{"line_number":97,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"b636a879_c67a0202","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":36},"updated":"2020-12-08 17:00:25.000000000","message":"It doesn\u0027t work for me, I have to set:\npackages+\u003d\"centos-linux-release centos-linux-repos centos-gpg-keys \"\n\nTo be able to build image. Without centos-linux-repos no /etc/yum.repos.d/*repo are available","commit_id":"aae7d4ca262d7b36673c6e99b7297975de2461f5"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"9c5d16aca1528bb4505b041040b2278b653c6f82","unresolved":true,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # CentOS 8.1 split repositories and GPG keys out into subpackages"},{"line_number":93,"context_line":"    if [[ ${DISTRO_NAME} \u003d centos \u0026\u0026 ${DIB_RELEASE} \u003e \"7\" ]]; then"},{"line_number":94,"context_line":"        packages+\u003d\"centos-gpg-keys \""},{"line_number":95,"context_line":"        if [[ \"$DIB_RELEASE\" \u003d~ (stream) ]]; then"},{"line_number":96,"context_line":"            packages+\u003d\"centos-stream-release centos-stream-repos \""},{"line_number":97,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fdd3150_5f8dc4e8","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":36},"in_reply_to":"73c0e781_153e9b18","updated":"2020-12-09 07:15:17.000000000","message":"Ah, both are required. Sorry","commit_id":"aae7d4ca262d7b36673c6e99b7297975de2461f5"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"d8583b1adda33e404d34eeb19ca1ade90e4c08c8","unresolved":true,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # CentOS 8.1 split repositories and GPG keys out into subpackages"},{"line_number":93,"context_line":"    if [[ ${DISTRO_NAME} \u003d centos \u0026\u0026 ${DIB_RELEASE} \u003e \"7\" ]]; then"},{"line_number":94,"context_line":"        packages+\u003d\"centos-gpg-keys \""},{"line_number":95,"context_line":"        if [[ \"$DIB_RELEASE\" \u003d~ (stream) ]]; then"},{"line_number":96,"context_line":"            packages+\u003d\"centos-stream-release centos-stream-repos \""},{"line_number":97,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"73c0e781_153e9b18","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":36},"in_reply_to":"b636a879_c67a0202","updated":"2020-12-09 07:09:33.000000000","message":"The centos-linux-release is replacing centos-linux-repos.\nSee https://lists.centos.org/pipermail/centos-devel/2020-September/056069.html","commit_id":"aae7d4ca262d7b36673c6e99b7297975de2461f5"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"78b3b389ff7dfec7727d3572633451527190a7b6","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    if [[ ${DISTRO_NAME} \u003d centos \u0026\u0026 ${DIB_RELEASE} \u003e \"7\" ]]; then"},{"line_number":94,"context_line":"        packages+\u003d\"centos-linux-release centos-linux-repos centos-gpg-keys \""},{"line_number":95,"context_line":"        if [[ \"$DIB_RELEASE\" \u003d~ (stream) ]]; then"},{"line_number":96,"context_line":"            packages+\u003d\"centos-stream-release centos-stream-repos \""},{"line_number":97,"context_line":"        fi"},{"line_number":98,"context_line":"    fi"},{"line_number":99,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"215cf247_44b1fb61","line":96,"range":{"start_line":96,"start_character":23,"end_line":96,"end_character":64},"updated":"2020-12-10 13:06:14.000000000","message":"now it is: centos-release-stream","commit_id":"e6bc64f5323c9c6a2cc84c78cb752b486c425ce9"}]}