)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"220eef18edb23ac1b31dc6a3eb014c6f61761625","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-03-04 15:58:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix: IPA image buidling with OpenSuse."},{"line_number":8,"context_line":"This PR is also related to the following PR in Ironic-python-agent-builder:"},{"line_number":9,"context_line":"https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/778726"},{"line_number":10,"context_line":"Change-Id: Id2759be29bfcbf2ecf1ce67e171686924b506b1a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da27f409_a0911642","line":8,"updated":"2021-03-04 16:04:05.000000000","message":"Hi, could you add  blank lines between the subject, the very first line, and the rest of the message? This is so change reporting doesn\u0027t get confused and try to put everything on one line like it presently is represented.","commit_id":"c25382fd97659b988ae5df588e8e8c8bbd6b48a3"},{"author":{"_account_id":33185,"name":"Moshiur Rahman","email":"moshiur.rahman@est.tech","username":"smoshiur1237"},"change_message_id":"a66b618ae67c50503e6673c253de4a246baecb86","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-03-04 15:58:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix: IPA image buidling with OpenSuse."},{"line_number":8,"context_line":"This PR is also related to the following PR in Ironic-python-agent-builder:"},{"line_number":9,"context_line":"https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/778726"},{"line_number":10,"context_line":"Change-Id: Id2759be29bfcbf2ecf1ce67e171686924b506b1a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2d11f9ae_9546d823","line":8,"in_reply_to":"da27f409_a0911642","updated":"2021-03-05 07:23:10.000000000","message":"Done","commit_id":"c25382fd97659b988ae5df588e8e8c8bbd6b48a3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"220eef18edb23ac1b31dc6a3eb014c6f61761625","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix: IPA image buidling with OpenSuse."},{"line_number":8,"context_line":"This PR is also related to the following PR in Ironic-python-agent-builder:"},{"line_number":9,"context_line":"https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/778726"},{"line_number":10,"context_line":"Change-Id: Id2759be29bfcbf2ecf1ce67e171686924b506b1a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a1b6f17b_b666c19b","line":9,"updated":"2021-03-04 16:04:05.000000000","message":"Is either change dependent upon one another? If so one of them likely needs to have a Depends-On flag added.","commit_id":"c25382fd97659b988ae5df588e8e8c8bbd6b48a3"},{"author":{"_account_id":33185,"name":"Moshiur Rahman","email":"moshiur.rahman@est.tech","username":"smoshiur1237"},"change_message_id":"a66b618ae67c50503e6673c253de4a246baecb86","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix: IPA image buidling with OpenSuse."},{"line_number":8,"context_line":"This PR is also related to the following PR in Ironic-python-agent-builder:"},{"line_number":9,"context_line":"https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/778726"},{"line_number":10,"context_line":"Change-Id: Id2759be29bfcbf2ecf1ce67e171686924b506b1a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0087905f_dd6015b1","line":9,"in_reply_to":"a1b6f17b_b666c19b","updated":"2021-03-05 07:23:10.000000000","message":"I mean the other PR is also necessary to have openSuse build successfull.","commit_id":"c25382fd97659b988ae5df588e8e8c8bbd6b48a3"}],"diskimage_builder/elements/zypper/bin/install-packages":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"44f8090249e75495921f553f2ca619a5d87dc252","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"while true ; do"},{"line_number":49,"context_line":"    case \"$1\" in"},{"line_number":50,"context_line":"        -u) run_zypper dist-upgrade --no-recommends --force-resolution; exit 0;;"},{"line_number":51,"context_line":"        -e) ACTION\u003d\"remove\"; ACTION_ARGS\u003d\"--clean-deps\"; shift;;"},{"line_number":52,"context_line":"        -d) ACTION_ARGS\u003d\"${ACTION_ARGS} --download-only\"; shift;;"},{"line_number":53,"context_line":"        -m) MAP_ELEMENT\u003d$2; shift 2;;"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"c57c7a9e_a326b6c6","line":50,"range":{"start_line":50,"start_character":52,"end_line":50,"end_character":71},"updated":"2021-03-23 23:46:47.000000000","message":"You\u0027ve said the build fails, but haven\u0027t explained why this is needed?  This affects all suse builds so I think we need some clarity here","commit_id":"58d3798f558d38a2c0864f92d4c8fd51c7317827"},{"author":{"_account_id":33185,"name":"Moshiur Rahman","email":"moshiur.rahman@est.tech","username":"smoshiur1237"},"change_message_id":"000905c41817427ccd1807a4515483e19281e141","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"while true ; do"},{"line_number":49,"context_line":"    case \"$1\" in"},{"line_number":50,"context_line":"        -u) run_zypper dist-upgrade --no-recommends --force-resolution; exit 0;;"},{"line_number":51,"context_line":"        -e) ACTION\u003d\"remove\"; ACTION_ARGS\u003d\"--clean-deps\"; shift;;"},{"line_number":52,"context_line":"        -d) ACTION_ARGS\u003d\"${ACTION_ARGS} --download-only\"; shift;;"},{"line_number":53,"context_line":"        -m) MAP_ELEMENT\u003d$2; shift 2;;"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"3fa20466_4956bacc","line":50,"range":{"start_line":50,"start_character":52,"end_line":50,"end_character":71},"in_reply_to":"0011c57d_09bee7ed","updated":"2021-03-26 08:56:53.000000000","message":"The changes were given +2 already. This is broken for long time. This is the only solution I have at this moment. If you have any idea to solve it different way, please I need your guidance.","commit_id":"58d3798f558d38a2c0864f92d4c8fd51c7317827"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5ea3544f4eb277a3cd8307abdbd53664d2c00f91","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"while true ; do"},{"line_number":49,"context_line":"    case \"$1\" in"},{"line_number":50,"context_line":"        -u) run_zypper dist-upgrade --no-recommends --force-resolution; exit 0;;"},{"line_number":51,"context_line":"        -e) ACTION\u003d\"remove\"; ACTION_ARGS\u003d\"--clean-deps\"; shift;;"},{"line_number":52,"context_line":"        -d) ACTION_ARGS\u003d\"${ACTION_ARGS} --download-only\"; shift;;"},{"line_number":53,"context_line":"        -m) MAP_ELEMENT\u003d$2; shift 2;;"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"0011c57d_09bee7ed","line":50,"range":{"start_line":50,"start_character":52,"end_line":50,"end_character":71},"in_reply_to":"3d044fac_57f0e800","updated":"2021-03-26 03:31:03.000000000","message":"This seems odd to me and a sign something else is going on, but if it as at least explained in the changelog I guess it\u0027s ok if others agree.","commit_id":"58d3798f558d38a2c0864f92d4c8fd51c7317827"},{"author":{"_account_id":33185,"name":"Moshiur Rahman","email":"moshiur.rahman@est.tech","username":"smoshiur1237"},"change_message_id":"2ce50990e9274c23e2a380bb5f2310f3aff651c5","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"while true ; do"},{"line_number":49,"context_line":"    case \"$1\" in"},{"line_number":50,"context_line":"        -u) run_zypper dist-upgrade --no-recommends --force-resolution; exit 0;;"},{"line_number":51,"context_line":"        -e) ACTION\u003d\"remove\"; ACTION_ARGS\u003d\"--clean-deps\"; shift;;"},{"line_number":52,"context_line":"        -d) ACTION_ARGS\u003d\"${ACTION_ARGS} --download-only\"; shift;;"},{"line_number":53,"context_line":"        -m) MAP_ELEMENT\u003d$2; shift 2;;"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"dadb09fc_ec189f47","line":50,"range":{"start_line":50,"start_character":52,"end_line":50,"end_character":71},"in_reply_to":"3fa20466_4956bacc","updated":"2021-03-26 13:36:55.000000000","message":"Today I have tried locally again and it was working properly without --force-resolution and haven\u0027t seen error. I will remove this part.","commit_id":"58d3798f558d38a2c0864f92d4c8fd51c7317827"},{"author":{"_account_id":33185,"name":"Moshiur Rahman","email":"moshiur.rahman@est.tech","username":"smoshiur1237"},"change_message_id":"45a4a5756ae9b631fc609ca1935093e648b462fb","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"while true ; do"},{"line_number":49,"context_line":"    case \"$1\" in"},{"line_number":50,"context_line":"        -u) run_zypper dist-upgrade --no-recommends --force-resolution; exit 0;;"},{"line_number":51,"context_line":"        -e) ACTION\u003d\"remove\"; ACTION_ARGS\u003d\"--clean-deps\"; shift;;"},{"line_number":52,"context_line":"        -d) ACTION_ARGS\u003d\"${ACTION_ARGS} --download-only\"; shift;;"},{"line_number":53,"context_line":"        -m) MAP_ELEMENT\u003d$2; shift 2;;"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"3d044fac_57f0e800","line":50,"range":{"start_line":50,"start_character":52,"end_line":50,"end_character":71},"in_reply_to":"5483041e_4b20b43a","updated":"2021-03-25 09:04:34.000000000","message":"Can we please move forward with this PR? its hanging for long time. My other PR in ipa-builder is cannot be merged because of this PR. Could you please help?","commit_id":"58d3798f558d38a2c0864f92d4c8fd51c7317827"},{"author":{"_account_id":33185,"name":"Moshiur Rahman","email":"moshiur.rahman@est.tech","username":"smoshiur1237"},"change_message_id":"fd04c9af4dfc6be03f214baebe86ccc152b76d39","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"while true ; do"},{"line_number":49,"context_line":"    case \"$1\" in"},{"line_number":50,"context_line":"        -u) run_zypper dist-upgrade --no-recommends --force-resolution; exit 0;;"},{"line_number":51,"context_line":"        -e) ACTION\u003d\"remove\"; ACTION_ARGS\u003d\"--clean-deps\"; shift;;"},{"line_number":52,"context_line":"        -d) ACTION_ARGS\u003d\"${ACTION_ARGS} --download-only\"; shift;;"},{"line_number":53,"context_line":"        -m) MAP_ELEMENT\u003d$2; shift 2;;"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"5483041e_4b20b43a","line":50,"range":{"start_line":50,"start_character":52,"end_line":50,"end_character":71},"in_reply_to":"c57c7a9e_a326b6c6","updated":"2021-03-24 07:56:06.000000000","message":"Without the --force-resolution the build was failing. The logs during the run_zypper dist-upgrade says, upgrade was unable to proceed because there were few options available and without resolution, it cannot decide which options it would follow. So by adding --force-resolution, it would choose the default upgrade option. So this helps the upgrade process to move forward and build was successfull.","commit_id":"58d3798f558d38a2c0864f92d4c8fd51c7317827"}],"diskimage_builder/lib/img-functions":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"220eef18edb23ac1b31dc6a3eb014c6f61761625","unresolved":true,"context_lines":[{"line_number":210,"context_line":"            echo \"Using signed kernel $DIB_SIGNED_KERNEL_VERSION\""},{"line_number":211,"context_line":"            KERNEL\u003d$(basename $(ls -1rv $BOOTDIR/vmlinu*generic.efi.signed 2\u003e/dev/null))"},{"line_number":212,"context_line":"        fi"},{"line_number":213,"context_line":"    elif [ -f $TARGET_ROOT/etc/os-release ]; then"},{"line_number":214,"context_line":"        KERNEL\u003d$(basename $(readlink -e $BOOTDIR/vmlinuz))"},{"line_number":215,"context_line":"        RAMDISK\u003d$(basename $(readlink -e $BOOTDIR/initrd))"},{"line_number":216,"context_line":"    elif [[ -f \"${TARGET_ROOT}\"/etc/gentoo-release ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"16fd77cb_566c65a5","line":213,"updated":"2021-03-04 16:04:05.000000000","message":"nice! LSB compliance.","commit_id":"c25382fd97659b988ae5df588e8e8c8bbd6b48a3"},{"author":{"_account_id":33185,"name":"Moshiur Rahman","email":"moshiur.rahman@est.tech","username":"smoshiur1237"},"change_message_id":"d2823b583be7519de316cf92feb63b239329b943","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            echo \"Using signed kernel $DIB_SIGNED_KERNEL_VERSION\""},{"line_number":211,"context_line":"            KERNEL\u003d$(basename $(ls -1rv $BOOTDIR/vmlinu*generic.efi.signed 2\u003e/dev/null))"},{"line_number":212,"context_line":"        fi"},{"line_number":213,"context_line":"    elif [ -f $TARGET_ROOT/etc/os-release ]; then"},{"line_number":214,"context_line":"        KERNEL\u003d$(basename $(readlink -e $BOOTDIR/vmlinuz))"},{"line_number":215,"context_line":"        RAMDISK\u003d$(basename $(readlink -e $BOOTDIR/initrd))"},{"line_number":216,"context_line":"    elif [[ -f \"${TARGET_ROOT}\"/etc/gentoo-release ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7bb231ec_3a9a6bcc","line":213,"in_reply_to":"0eba93a9_8badb082","updated":"2021-03-12 13:54:00.000000000","message":"Hi, is it possible review and merge this changes? My other PR in ironic-python-agent-builder needs this changes to test.","commit_id":"c25382fd97659b988ae5df588e8e8c8bbd6b48a3"},{"author":{"_account_id":33185,"name":"Moshiur Rahman","email":"moshiur.rahman@est.tech","username":"smoshiur1237"},"change_message_id":"a66b618ae67c50503e6673c253de4a246baecb86","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            echo \"Using signed kernel $DIB_SIGNED_KERNEL_VERSION\""},{"line_number":211,"context_line":"            KERNEL\u003d$(basename $(ls -1rv $BOOTDIR/vmlinu*generic.efi.signed 2\u003e/dev/null))"},{"line_number":212,"context_line":"        fi"},{"line_number":213,"context_line":"    elif [ -f $TARGET_ROOT/etc/os-release ]; then"},{"line_number":214,"context_line":"        KERNEL\u003d$(basename $(readlink -e $BOOTDIR/vmlinuz))"},{"line_number":215,"context_line":"        RAMDISK\u003d$(basename $(readlink -e $BOOTDIR/initrd))"},{"line_number":216,"context_line":"    elif [[ -f \"${TARGET_ROOT}\"/etc/gentoo-release ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"0eba93a9_8badb082","line":213,"in_reply_to":"16fd77cb_566c65a5","updated":"2021-03-05 07:23:10.000000000","message":"Done","commit_id":"c25382fd97659b988ae5df588e8e8c8bbd6b48a3"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"44f8090249e75495921f553f2ca619a5d87dc252","unresolved":true,"context_lines":[{"line_number":210,"context_line":"            echo \"Using signed kernel $DIB_SIGNED_KERNEL_VERSION\""},{"line_number":211,"context_line":"            KERNEL\u003d$(basename $(ls -1rv $BOOTDIR/vmlinu*generic.efi.signed 2\u003e/dev/null))"},{"line_number":212,"context_line":"        fi"},{"line_number":213,"context_line":"    elif [ -f $TARGET_ROOT/etc/os-release ]; then"},{"line_number":214,"context_line":"        KERNEL\u003d$(basename $(readlink -e $BOOTDIR/vmlinuz))"},{"line_number":215,"context_line":"        RAMDISK\u003d$(basename $(readlink -e $BOOTDIR/initrd))"},{"line_number":216,"context_line":"    elif [[ -f \"${TARGET_ROOT}\"/etc/gentoo-release ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"fd48f6ec_aa9ac4e1","line":213,"updated":"2021-03-23 23:46:47.000000000","message":"this globally changes things from only matching on suse to matching on every platform with /etc/os-release.  should this be behind some other sort of check?\n\nI don\u0027t know the answer, but I\u0027d like to see it justified why it\u0027s correct to change it like this.","commit_id":"58d3798f558d38a2c0864f92d4c8fd51c7317827"},{"author":{"_account_id":33185,"name":"Moshiur Rahman","email":"moshiur.rahman@est.tech","username":"smoshiur1237"},"change_message_id":"f9fe6c245808903fdcfaf1288894dbebfdfb84ba","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            echo \"Using signed kernel $DIB_SIGNED_KERNEL_VERSION\""},{"line_number":211,"context_line":"            KERNEL\u003d$(basename $(ls -1rv $BOOTDIR/vmlinu*generic.efi.signed 2\u003e/dev/null))"},{"line_number":212,"context_line":"        fi"},{"line_number":213,"context_line":"    elif [ -f $TARGET_ROOT/etc/os-release ]; then"},{"line_number":214,"context_line":"        KERNEL\u003d$(basename $(readlink -e $BOOTDIR/vmlinuz))"},{"line_number":215,"context_line":"        RAMDISK\u003d$(basename $(readlink -e $BOOTDIR/initrd))"},{"line_number":216,"context_line":"    elif [[ -f \"${TARGET_ROOT}\"/etc/gentoo-release ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"ace677cb_5aaead3c","line":213,"in_reply_to":"0049476d_2efa127f","updated":"2021-04-06 07:09:07.000000000","message":"Please review.","commit_id":"58d3798f558d38a2c0864f92d4c8fd51c7317827"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5ea3544f4eb277a3cd8307abdbd53664d2c00f91","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            echo \"Using signed kernel $DIB_SIGNED_KERNEL_VERSION\""},{"line_number":211,"context_line":"            KERNEL\u003d$(basename $(ls -1rv $BOOTDIR/vmlinu*generic.efi.signed 2\u003e/dev/null))"},{"line_number":212,"context_line":"        fi"},{"line_number":213,"context_line":"    elif [ -f $TARGET_ROOT/etc/os-release ]; then"},{"line_number":214,"context_line":"        KERNEL\u003d$(basename $(readlink -e $BOOTDIR/vmlinuz))"},{"line_number":215,"context_line":"        RAMDISK\u003d$(basename $(readlink -e $BOOTDIR/initrd))"},{"line_number":216,"context_line":"    elif [[ -f \"${TARGET_ROOT}\"/etc/gentoo-release ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"ad685ec3_7896b9e3","line":213,"in_reply_to":"17bb8f0d_d6eea68b","updated":"2021-03-26 03:31:03.000000000","message":"What I mean is that this match used to exclusively match on suse systems, and now it seems to match on pretty much all systems.  I\u0027m pretty sure gentoo (below this) has /etc/os-release so this seems to effectively shortcut/break this?\n\nI\u0027m pretty sure this needs to limit itself to suse, or otherwise explain why this is right","commit_id":"58d3798f558d38a2c0864f92d4c8fd51c7317827"},{"author":{"_account_id":33185,"name":"Moshiur Rahman","email":"moshiur.rahman@est.tech","username":"smoshiur1237"},"change_message_id":"000905c41817427ccd1807a4515483e19281e141","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            echo \"Using signed kernel $DIB_SIGNED_KERNEL_VERSION\""},{"line_number":211,"context_line":"            KERNEL\u003d$(basename $(ls -1rv $BOOTDIR/vmlinu*generic.efi.signed 2\u003e/dev/null))"},{"line_number":212,"context_line":"        fi"},{"line_number":213,"context_line":"    elif [ -f $TARGET_ROOT/etc/os-release ]; then"},{"line_number":214,"context_line":"        KERNEL\u003d$(basename $(readlink -e $BOOTDIR/vmlinuz))"},{"line_number":215,"context_line":"        RAMDISK\u003d$(basename $(readlink -e $BOOTDIR/initrd))"},{"line_number":216,"context_line":"    elif [[ -f \"${TARGET_ROOT}\"/etc/gentoo-release ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"d3b3f877_7da0b5fd","line":213,"in_reply_to":"ad685ec3_7896b9e3","updated":"2021-03-26 08:56:53.000000000","message":"If I change the condition to \"\"elif [ $IPA_DISTRO_FAMILY \u003d \"suse\" ]; then\"\", does it solve your concern..","commit_id":"58d3798f558d38a2c0864f92d4c8fd51c7317827"},{"author":{"_account_id":33185,"name":"Moshiur Rahman","email":"moshiur.rahman@est.tech","username":"smoshiur1237"},"change_message_id":"50a44bd24195a7e78a0e8d1f7c9342a0f936d28c","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            echo \"Using signed kernel $DIB_SIGNED_KERNEL_VERSION\""},{"line_number":211,"context_line":"            KERNEL\u003d$(basename $(ls -1rv $BOOTDIR/vmlinu*generic.efi.signed 2\u003e/dev/null))"},{"line_number":212,"context_line":"        fi"},{"line_number":213,"context_line":"    elif [ -f $TARGET_ROOT/etc/os-release ]; then"},{"line_number":214,"context_line":"        KERNEL\u003d$(basename $(readlink -e $BOOTDIR/vmlinuz))"},{"line_number":215,"context_line":"        RAMDISK\u003d$(basename $(readlink -e $BOOTDIR/initrd))"},{"line_number":216,"context_line":"    elif [[ -f \"${TARGET_ROOT}\"/etc/gentoo-release ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"0049476d_2efa127f","line":213,"in_reply_to":"b6028d7e_ff347be3","updated":"2021-03-29 07:31:27.000000000","message":"I have tried with the following condition and its also working. So I have added the following condition for opensuse and updated the patch.\nif [[ $DISTRO_NAME \u003d opensuse ]]","commit_id":"58d3798f558d38a2c0864f92d4c8fd51c7317827"},{"author":{"_account_id":33185,"name":"Moshiur Rahman","email":"moshiur.rahman@est.tech","username":"smoshiur1237"},"change_message_id":"2ce50990e9274c23e2a380bb5f2310f3aff651c5","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            echo \"Using signed kernel $DIB_SIGNED_KERNEL_VERSION\""},{"line_number":211,"context_line":"            KERNEL\u003d$(basename $(ls -1rv $BOOTDIR/vmlinu*generic.efi.signed 2\u003e/dev/null))"},{"line_number":212,"context_line":"        fi"},{"line_number":213,"context_line":"    elif [ -f $TARGET_ROOT/etc/os-release ]; then"},{"line_number":214,"context_line":"        KERNEL\u003d$(basename $(readlink -e $BOOTDIR/vmlinuz))"},{"line_number":215,"context_line":"        RAMDISK\u003d$(basename $(readlink -e $BOOTDIR/initrd))"},{"line_number":216,"context_line":"    elif [[ -f \"${TARGET_ROOT}\"/etc/gentoo-release ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"fd743958_85d51cc5","line":213,"in_reply_to":"d3b3f877_7da0b5fd","updated":"2021-03-26 13:36:55.000000000","message":"I have tried locally with  $DISTRO_FAMILY \u003d \"opensuse\" and  $IPA_DISTRO_FAMILY \u003d \"suse\" . Both of them are failing. You have said earlier in your comment about gentoo and it has os-release. Here it seems that gentoo has /etc/gentoo.release. Which doesn\u0027t work for openSuse. only etc/os-release is supported by suse based distro.","commit_id":"58d3798f558d38a2c0864f92d4c8fd51c7317827"},{"author":{"_account_id":33185,"name":"Moshiur Rahman","email":"moshiur.rahman@est.tech","username":"smoshiur1237"},"change_message_id":"fd04c9af4dfc6be03f214baebe86ccc152b76d39","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            echo \"Using signed kernel $DIB_SIGNED_KERNEL_VERSION\""},{"line_number":211,"context_line":"            KERNEL\u003d$(basename $(ls -1rv $BOOTDIR/vmlinu*generic.efi.signed 2\u003e/dev/null))"},{"line_number":212,"context_line":"        fi"},{"line_number":213,"context_line":"    elif [ -f $TARGET_ROOT/etc/os-release ]; then"},{"line_number":214,"context_line":"        KERNEL\u003d$(basename $(readlink -e $BOOTDIR/vmlinuz))"},{"line_number":215,"context_line":"        RAMDISK\u003d$(basename $(readlink -e $BOOTDIR/initrd))"},{"line_number":216,"context_line":"    elif [[ -f \"${TARGET_ROOT}\"/etc/gentoo-release ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"17bb8f0d_d6eea68b","line":213,"in_reply_to":"fd48f6ec_aa9ac4e1","updated":"2021-03-24 07:56:06.000000000","message":"/etc/SuSE-release was already deprecated from openSuse 13 version and with new distribution it is renamed to /os-release for openSuse. As this change only necessary for openSuse, I don\u0027t think it needs some other checks. Locally my test was passing for openSuse.","commit_id":"58d3798f558d38a2c0864f92d4c8fd51c7317827"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e9e9306a4707ced9daae4eb6592571c594ed4d08","unresolved":true,"context_lines":[{"line_number":210,"context_line":"            echo \"Using signed kernel $DIB_SIGNED_KERNEL_VERSION\""},{"line_number":211,"context_line":"            KERNEL\u003d$(basename $(ls -1rv $BOOTDIR/vmlinu*generic.efi.signed 2\u003e/dev/null))"},{"line_number":212,"context_line":"        fi"},{"line_number":213,"context_line":"    elif [ -f $TARGET_ROOT/etc/os-release ]; then"},{"line_number":214,"context_line":"        KERNEL\u003d$(basename $(readlink -e $BOOTDIR/vmlinuz))"},{"line_number":215,"context_line":"        RAMDISK\u003d$(basename $(readlink -e $BOOTDIR/initrd))"},{"line_number":216,"context_line":"    elif [[ -f \"${TARGET_ROOT}\"/etc/gentoo-release ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"b6028d7e_ff347be3","line":213,"in_reply_to":"fd743958_85d51cc5","updated":"2021-03-29 06:23:19.000000000","message":"I don\u0027t think that\u0027s right.  os-release is FHS standard [1]; most distros will have this file.\n\nI think you want this check to be\n\n if [[ $DISTRO_NAME \u003d opensuse ]]\n\nwhich is in use in several other places and should be fine to keep it as suse only\n\n[1] https://www.freedesktop.org/software/systemd/man/os-release.html","commit_id":"58d3798f558d38a2c0864f92d4c8fd51c7317827"}]}