)]}'
{"id":"openstack%2Fdiskimage-builder~781126","triplet_id":"openstack%2Fdiskimage-builder~master~I42886a9e4b53a84a577c7ae6ea2eebb0b6043d86","project":"openstack/diskimage-builder","branch":"master","topic":"glean-source","hashtags":[],"change_id":"I42886a9e4b53a84a577c7ae6ea2eebb0b6043d86","subject":"Install glean from source-repository","status":"ABANDONED","created":"2021-03-17 16:44:36.000000000","updated":"2021-03-18 17:53:47.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"22cf27f3f0498eb5c200f17f12ba1f60f09ac1a7","_number":781126,"virtual_id_number":781126,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-03-17 18:23:40.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2021-03-18 00:48:20.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-17 17:21:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-03-17 18:23:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-18 00:48:20.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2021-03-18 01:44:06.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"0089e3a749f22467c13978a102caa1004be1e79a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-03-17 16:44:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bdf5edec75691c45d7546586acd8b2abfea31ddc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-03-17 16:55:45.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d615defd2279057023bb8bb4d6d5e4e486de6239","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-17 17:21:57.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/595030a8711c4c0abe241925187f903f : SUCCESS in 21m 15s","accounts_in_message":[],"_revision_number":2},{"id":"6afde6294b80f87a91fb9a9641052ba9e909a949","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-17 18:23:40.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c0f846c5f6304c53bc2373724fa0643b : SUCCESS in 6m 26s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7956c0e876924c08bdcfbf4cd1a97d18 : SUCCESS in 5m 52s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a55830d262bb4e3cbd5d93609f8a2d9f : SUCCESS in 5m 16s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/c2e082ff76714881bff223b28af562cc : SUCCESS in 55m 13s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/8433fc0d243b4c748475cfa8d5035445 : SUCCESS in 29m 57s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/14e7573eca724d0d9fa61c9632777f64 : SUCCESS in 6m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9cad4d56b7f741a8be0263355238417d : SUCCESS in 5m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6287a81d1ca34bc89ab194f23096c173 : SUCCESS in 5m 09s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c6549edd35e04d8f8a0e94cac8f291d9 : SUCCESS in 4m 43s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/7b51a6810cef4b32b0c325be5219f105 : SUCCESS in 5m 02s (non-voting)\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/a291d551e5b5421986339ffca4b855f8 : SUCCESS in 4m 24s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/74cf73e5d57140cdb7b7c3b1777b37f9 : SUCCESS in 1h 16m 05s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/026752e74ef44fc78fe4819c40617dea : SUCCESS in 19m 04s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/75240a04cefb45e3a076e0e91119bea0 : FAILURE in 35m 47s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/d4b3fa979a76437e90a99eac8e0ddad2 : FAILURE in 34m 20s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/2fda5f3003f246e28345fcf3db43ecce : FAILURE in 33m 39s\n- dib-nodepool-functional-openstack-fedora-32-src https://zuul.opendev.org/t/openstack/build/b6edcaed027d4b909ddbe27afec55319 : FAILURE in 37m 16s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/7354f08beeb349009b10e9de4cc2fdf2 : FAILURE in 32m 19s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/6484605cb176433f9c10e85777f119d8 : FAILURE in 31m 43s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/6e2ce343c61c4ff6b087b4adc7712168 : FAILURE in 33m 53s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/faff3c695e184e6e933c1564093dcdbe : FAILURE in 44m 59s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/69cde9e4351946f3a118dc183c215821 : FAILURE in 43m 39s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/22bae41f33d341918107ef3022f3a243 : SUCCESS in 33m 36s\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/3f844b014ea04b20b8f2142be02c4719 : FAILURE in 19m 48s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/d6664d44a2e94d6bb47ddb445324d7e9 : FAILURE in 24m 24s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/d56e3ad37f6e4357a094e610a5da233e : SUCCESS in 8m 13s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/04d923dbeeb54ff1b7ae6c15cb22cb8f : SUCCESS in 11m 43s\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/c7459ea0d8d74fb9ae0e5336bb3876ea : SUCCESS in 1h 23m 41s (non-voting)\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/cc6e211f881147e498eb77b26de77247 : SUCCESS in 1h 18m 35s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"55186f423822ea4be6eb56454d28c894144ea627","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2021-03-18 00:48:20.000000000","message":"Patch Set 2: Code-Review-1\n\nThis one made me think!  I was sure I had used the nodepool jobs to test glean changes with\n\nhttps://opendev.org/zuul/nodepool/src/branch/master/playbooks/nodepool-functional-container-openstack/templates/nodepool.yaml.j2#L79 where we do\n\n  DIB_INSTALLTYPE_simple_init: \u0027repo\u0027\n  DIB_REPOLOCATION_glean: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/opendev/glean\u0027].src_\n  DIB_REPOREF_glean: \"{{ zuul.projects[\u0027opendev.org/opendev/glean\u0027].checkout }}\"\n\nThis is actually two different things -- \"DIB_INSTALLTYPE_simple_init\u003drepo\" actually instructs the *install-types* element to use the scripts from the -repo-install directory in \n\nhttps://opendev.org/openstack/diskimage-builder/src/branch/master/diskimage_builder/elements/simple-init/install.d\n\nfor the \"simple-init\" element.  The DIB_REPO*_glean variables instruct source-repositories where to download the upstream source for \"glean\" from.\n\nSo I believe that the \"repo\" install is doing what it says -- simple-init is installing glean from an on-disk repository cloned from zuul.\n\nI would agree this is all quite confusing 😐","accounts_in_message":[],"_revision_number":2},{"id":"9fec740f3549697984a72cf38bab248b2a7eb2f0","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-03-18 01:44:06.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/26/781126/2/check-dib/dib-functests-bionic-python3/18e9f26/ : SUCCESS in 32m 39s","accounts_in_message":[],"_revision_number":2},{"id":"22cf27f3f0498eb5c200f17f12ba1f60f09ac1a7","tag":"autogenerated:gerrit:abandon","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-03-18 17:53:47.000000000","message":"Abandoned\n\nOh. Ooooooh. Thanks for explanation, the simple-init vs glean part is actually quite confusing.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d091463b7ee8f71ab73efd3f65ebcbde9a396438","revisions":{"7e85cd2e2c0daeb6a5e3d44d420c9544eef383b0":{"kind":"REWORK","_number":1,"created":"2021-03-17 16:44:36.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/26/781126/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/26/781126/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/26/781126/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/26/781126/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/26/781126/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/26/781126/1"}}},"commit":{"parents":[{"commit":"4aae99e64ee3ba5dd80246a8f1b9e0d6fe53a889","subject":"Merge \"Change paths for bootloader files in iso element\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/4aae99e64ee3ba5dd80246a8f1b9e0d6fe53a889"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-03-17 16:43:46.000000000","tz":60},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-03-17 16:43:46.000000000","tz":60},"subject":"Install glean from source-repository","message":"Install glean from source-repository\n\nThe simple-init element uses source-repositories but installs glean from\npip, rendering its useless.\n\nChange-Id: I42886a9e4b53a84a577c7ae6ea2eebb0b6043d86\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/7e85cd2e2c0daeb6a5e3d44d420c9544eef383b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/7e85cd2e2c0daeb6a5e3d44d420c9544eef383b0"}]},"branch":"refs/heads/master"},"d091463b7ee8f71ab73efd3f65ebcbde9a396438":{"kind":"REWORK","_number":2,"created":"2021-03-17 16:55:45.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/26/781126/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/26/781126/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/26/781126/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/26/781126/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/26/781126/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/26/781126/2"}}},"commit":{"parents":[{"commit":"4aae99e64ee3ba5dd80246a8f1b9e0d6fe53a889","subject":"Merge \"Change paths for bootloader files in iso element\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/4aae99e64ee3ba5dd80246a8f1b9e0d6fe53a889"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-03-17 16:43:46.000000000","tz":60},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-03-17 16:54:58.000000000","tz":60},"subject":"Install glean from source-repository","message":"Install glean from source-repository\n\nThe simple-init element uses source-repositories but installs glean from\npip, rendering its useless. Remove the non-standard \"repo\" install,\nsource-repositories does not recognize it as valid (it expects \"source\").\n\nChange-Id: I42886a9e4b53a84a577c7ae6ea2eebb0b6043d86\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/d091463b7ee8f71ab73efd3f65ebcbde9a396438"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/d091463b7ee8f71ab73efd3f65ebcbde9a396438"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
