)]}'
{"id":"openstack%2Fdiskimage-builder~784203","triplet_id":"openstack%2Fdiskimage-builder~master~Icd22dfa5faa540773d096810f1423257d0727c81","project":"openstack/diskimage-builder","branch":"master","topic":"grub-cfg-fix","hashtags":[],"change_id":"Icd22dfa5faa540773d096810f1423257d0727c81","subject":"Fix generate two grub.cfg files","status":"ABANDONED","created":"2021-04-01 07:38:59.000000000","updated":"2021-04-08 03:14:17.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3b8a638b2235018318c1018baeccdc7c2de4d43d","_number":784203,"virtual_id_number":784203,"owner":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-04-01 09:23:57.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"all":[{"value":-1,"date":"2021-04-07 05:32:03.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-01 08:01:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-04-01 08:19:36.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-04-01 09:23:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-01 10:19:49.000000000","updated_by":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2021-04-01 10:19:49.000000000","updated_by":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"reviewer":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"state":"REVIEWER"}],"messages":[{"id":"f4e1eb7a792b1447fa545652594a199a3993e0ee","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"date":"2021-04-01 07:38:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ae9a4bde0ed6af8a19cfe36d8e3601e2c3782867","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-01 08:01:36.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- dib-functests-arm64-bionic https://zuul.opendev.org/t/openstack/build/1dcc1b08cdaa4a028b41bc68c7b7b1e4 : SUCCESS in 18m 00s","accounts_in_message":[],"_revision_number":1},{"id":"a2ed0b547d1598b30140a2e973ef79cfd0b0ec4d","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-04-01 08:19:36.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- dib-functests-bionic-python3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/diskimage-builder/03/784203/1/check-dib/dib-functests-bionic-python3/73c7e09/ : SUCCESS in 36m 23s","accounts_in_message":[],"_revision_number":1},{"id":"bf128f76153241d924ca52e4c0316538e08a4d80","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-01 09:23:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2937789fa0334d6bb2975fed92286e17 : SUCCESS in 5m 26s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8cabbc69ad7d43e29165a3a4cc3a17d4 : SUCCESS in 5m 02s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2a454671a119417896a92db8e220aef5 : SUCCESS in 5m 19s\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/28ba76996ce54624bc6224726d2b3f52 : SUCCESS in 1h 00m 40s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/9dedad5661364892a318f0d0e5718310 : SUCCESS in 32m 03s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/8a568e39a666453797e4906fbb9d81ab : SUCCESS in 5m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/45662ef225e142dcae44fc4760cecb01 : SUCCESS in 4m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b159b8748afd45ddb52e97833962f3b2 : SUCCESS in 4m 03s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0b6435daf07949cd9e5af4007d5bc9d8 : SUCCESS in 3m 47s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/a51c0234e6754c2baf2bd2252172f754 : SUCCESS in 3m 57s (non-voting)\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/7705421ec1044b38964948d32f85aaab : SUCCESS in 3m 49s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/c8a7440b5ca24ba28ccb97ddef1f83b8 : SUCCESS in 1h 38m 18s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/f4124f83e1b143189edcbbbea57ca655 : SUCCESS in 23m 11s\n- dib-nodepool-functional-openstack-centos-7-src https://zuul.opendev.org/t/openstack/build/cf0f91aa60e4420c9521ae9c49a319b1 : SUCCESS in 33m 07s\n- dib-nodepool-functional-openstack-centos-8-src https://zuul.opendev.org/t/openstack/build/522ea1f078934221b84b78ec85d3f901 : SUCCESS in 35m 33s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/56d533ba307149a8ad6f31bb66e3e87a : SUCCESS in 32m 06s\n- dib-nodepool-functional-openstack-fedora-32-src https://zuul.opendev.org/t/openstack/build/9188b865f16f424382ff64bf20e0f90d : SUCCESS in 37m 14s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/5c7268a112664fbf9d91159e254693e3 : SUCCESS in 36m 51s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/bb0e1b5dc2154502b9738dd60824f1bb : SUCCESS in 33m 00s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/3779911cfc5148128e5aa11622e300c9 : SUCCESS in 34m 37s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/7c95ac58b06c4c7388f09f5fb0b18da0 : SUCCESS in 59m 37s (non-voting)\n- dib-nodepool-functional-openstack-opensuse-tumbleweed-src https://zuul.opendev.org/t/openstack/build/ca824b88c9614241b86739926a17406d : SUCCESS in 46m 42s (non-voting)\n- dib-functests-bionic-python3 https://zuul.opendev.org/t/openstack/build/88e0b93b0c934dc1b1610749237f649e : SUCCESS in 1h 29m 51s\n- dib-functests-bionic-python3-image https://zuul.opendev.org/t/openstack/build/72ea3fc3207f49eebe9769cb62d4ef04 : FAILURE in 19m 53s (non-voting)\n- dib-functests-bionic-python3-extras https://zuul.opendev.org/t/openstack/build/1912d50eccfe4601a962f5d96abd54c4 : SUCCESS in 32m 44s (non-voting)\n- dib-functests-bionic-python3-containers https://zuul.opendev.org/t/openstack/build/71749cf918b0412f83535108c3a0001c : SUCCESS in 9m 48s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/dea60c8ad9e04da4bd6b9b6dc8dd68ac : SUCCESS in 11m 43s\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/3e43015a924c42fcad3b33c310f25caa : SUCCESS in 1h 26m 47s (non-voting)\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/f898079d097847c1abf963f08cc3e464 : SUCCESS in 1h 22m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7453e39c6fe5a6711147def359ee2ee40a6e4f6d","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-04-07 05:32:03.000000000","message":"Patch Set 1: Code-Review-1\n\nThe two grub.cfg files are required, /boot/efi/$EFI_BOOT_DIR/grub.cfg is for UEFI boot and the other is for legacy BIOS boot.\n\nIf the issue is that the two grub.cfg files are different because one is modified after generation, this change should fix that.","accounts_in_message":[],"_revision_number":1},{"id":"8bacb7908a377637fa0255626dee14eed8a85053","author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"date":"2021-04-07 07:27:23.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e The two grub.cfg files are required, /boot/efi/$EFI_BOOT_DIR/grub.cfg is for UEFI boot and the other is for legacy BIOS boot.\n\u003e \n\u003e If the issue is that the two grub.cfg files are different because one is modified after generation, this change should fix that.\n\nYes, after generation one of them is modified.\nI don\u0027t know how to fix it. Can we just symbolic link one to the other to make only one existed? \nSay, ln -s /boot/efi/$EFI_BOOT_DIR/grub.cfg /boot/grub2/grub.cfg","accounts_in_message":[],"_revision_number":1},{"id":"9d9c448e95dca66deae8656d5e1e60a0d4d1a55d","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-04-07 21:07:15.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1: Code-Review-1\n\u003e \u003e \n\u003e \u003e The two grub.cfg files are required, /boot/efi/$EFI_BOOT_DIR/grub.cfg is for UEFI boot and the other is for legacy BIOS boot.\n\u003e \u003e \n\u003e \u003e If the issue is that the two grub.cfg files are different because one is modified after generation, this change should fix that.\n\u003e \n\u003e Yes, after generation one of them is modified.\n\u003e I don\u0027t know how to fix it. Can we just symbolic link one to the other to make only one existed? \n\u003e Say, ln -s /boot/efi/$EFI_BOOT_DIR/grub.cfg /boot/grub2/grub.cfg\n\nThey\u0027re on different partitions, and each boot method only mounts one partition, so linking won\u0027t work. Any post-generation modifications will need to be made to each file","accounts_in_message":[],"_revision_number":1},{"id":"7631a9e965fc04e38806b158935bbe5e7e2e50f0","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-04-07 21:26:14.000000000","message":"Patch Set 1:\n\nIt looks like this change will end up fixing this issue, lets focus reviews there.","accounts_in_message":[],"_revision_number":1},{"id":"314088784fc3caeb06da79a0d1a5f1f8ab55b82d","author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"date":"2021-04-08 00:56:40.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1:\n\u003e \u003e \n\u003e \u003e \u003e Patch Set 1: Code-Review-1\n\u003e \u003e \u003e \n\u003e \u003e \u003e The two grub.cfg files are required, /boot/efi/$EFI_BOOT_DIR/grub.cfg is for UEFI boot and the other is for legacy BIOS boot.\n\u003e \u003e \u003e \n\u003e \u003e \u003e If the issue is that the two grub.cfg files are different because one is modified after generation, this change should fix that.\n\u003e \u003e \n\u003e \u003e Yes, after generation one of them is modified.\n\u003e \u003e I don\u0027t know how to fix it. Can we just symbolic link one to the other to make only one existed? \n\u003e \u003e Say, ln -s /boot/efi/$EFI_BOOT_DIR/grub.cfg /boot/grub2/grub.cfg\n\u003e \n\u003e They\u0027re on different partitions, and each boot method only mounts one partition, so linking won\u0027t work. Any post-generation modifications will need to be made to each file\n\nUnderstand, will try to fix it like this way.","accounts_in_message":[],"_revision_number":1},{"id":"8f40f79e847a0ba0a9b856e1ffd4bdbcc0a95968","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-04-08 02:01:41.000000000","message":"Patch Set 1:\n\nI meant to say this change should be abandoned because another change has just landed which should improve the situation https://review.opendev.org/c/openstack/diskimage-builder/+/785247","accounts_in_message":[],"_revision_number":1},{"id":"3b8a638b2235018318c1018baeccdc7c2de4d43d","tag":"autogenerated:gerrit:abandon","author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"date":"2021-04-08 03:14:17.000000000","message":"Abandoned\n\nGo to new fix: https://review.opendev.org/c/openstack/diskimage-builder/+/785247","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a603fcf746b27216ef70e678cf544771065a01d5","revisions":{"a603fcf746b27216ef70e678cf544771065a01d5":{"kind":"REWORK","_number":1,"created":"2021-04-01 07:38:59.000000000","uploader":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"ref":"refs/changes/03/784203/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/03/784203/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/03/784203/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/03/784203/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/03/784203/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/03/784203/1"}}},"commit":{"parents":[{"commit":"b4f768117f8805487799829da84883266e5575f2","subject":"update gentoo keywords to support gcc-10","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/b4f768117f8805487799829da84883266e5575f2"}]}],"author":{"name":"Xinliang Liu","email":"xinliang.liu@linaro.org","date":"2021-04-01 04:21:14.000000000","tz":0},"committer":{"name":"Xinliang Liu","email":"xinliang.liu@linaro.org","date":"2021-04-01 07:38:03.000000000","tz":0},"subject":"Fix generate two grub.cfg files","message":"Fix generate two grub.cfg files\n\nWhen there is a directory \u0027/boot/efi/$EFI_BOOT_DIR\u0027 it will generate\ntwo grub.cfg files. One under this dir, the other under directory\n\u0027/boot/grub2/\u0027 or\u0027/boot/grub/\u0027.\n\nBut current bootloader element grub default overrides such as root\ndevice override and console parameters appending only happen in the\nlatter grub.cfg. This might cause grub default overrides not working.\nBecause only the former grub.cfg will be used to boot OS here.\n\nChange-Id: Icd22dfa5faa540773d096810f1423257d0727c81\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/a603fcf746b27216ef70e678cf544771065a01d5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/a603fcf746b27216ef70e678cf544771065a01d5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}