)]}'
{"diskimage_builder/elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ac0b79d4eaba5e383f2327f6e1c7b41f361d5ce0","unresolved":true,"context_lines":[{"line_number":169,"context_line":"                    GRUB_OPTS\u003d\"--target\u003dx86_64-efi\""},{"line_number":170,"context_line":"                    # This call installs grub for BIOS compatability"},{"line_number":171,"context_line":"                    # which makes portable EFI/BIOS images."},{"line_number":172,"context_line":"                    $GRUBNAME --modules\u003d\"$modules\" --target\u003di386-pc $BOOT_DEV"},{"line_number":173,"context_line":"                    ;;"},{"line_number":174,"context_line":"                # At this point, we don\u0027t need to override the target"},{"line_number":175,"context_line":"                # for any other architectures."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"c22eb80a_6134833c","line":172,"updated":"2021-04-07 21:25:21.000000000","message":"This installs grub to /boot/grub2, which allows EFI images to also boot in legacy bios mode, that is why 2 copies of grub.cfg are written, one to /boot/efi/$EFI_BOOT_DIR/grub.cfg (UEFI boot) and one to /boot/grub2/grub.cfg (legacy BIOS).\n\nLegacy bios boot only applies to amd64 though. How about at the end of this function after the GRUB_CFG modifications have been made, have a conditional using DIB_BLOCK_DEVICE and ARCH which copies /boot/efi/$EFI_BOOT_DIR/grub.cfg to /boot/grub[2]/grub.cfg?","commit_id":"c6b625dedff0541d1b4b294a498d7cb8c64f90a3"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"9d339dae87c76611f6dfabc58cd90f67204fa094","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    fi"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    # All GRUB_MKCONFIG calls need to happen after we configure"},{"line_number":229,"context_line":"    # /etc/default/grub above. Without this we can set in appropriate"},{"line_number":230,"context_line":"    # root device labels and then images don\u0027t boot."},{"line_number":231,"context_line":"    $GRUB_MKCONFIG -o $GRUB_CFG"},{"line_number":232,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"e23b306c_9fbfd974","line":229,"updated":"2021-04-07 19:23:02.000000000","message":"Nit: the space within \"in appropriate\" is inappropriate ;)","commit_id":"c6b625dedff0541d1b4b294a498d7cb8c64f90a3"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ac0b79d4eaba5e383f2327f6e1c7b41f361d5ce0","unresolved":true,"context_lines":[{"line_number":242,"context_line":"        sed -i \"s%search --no.*%%\" $GRUB_CFG"},{"line_number":243,"context_line":"        sed -i \"s%set root\u003d.*%set root\u003d(hd0,1)%\" $GRUB_CFG"},{"line_number":244,"context_line":"    fi"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    # Fix efi specific instructions in grub config file"},{"line_number":247,"context_line":"    if [ -d /sys/firmware/efi ]; then"},{"line_number":248,"context_line":"        sed -i \u0027s%\\(initrd\\|linux\\)efi /boot%\\1 /boot%g\u0027 $GRUB_CFG"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"27990c3f_3a2cd66f","line":245,"updated":"2021-04-07 21:25:21.000000000","message":"See my comment on #172, maybe here is where GRUB_CFG is copied to /boot/grub[2]/grub.cfg for legacy bios boot, since the changes below are EFI specific","commit_id":"c6b625dedff0541d1b4b294a498d7cb8c64f90a3"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6f17340dbd2a107542818875cc14c62b59cec4c4","unresolved":true,"context_lines":[{"line_number":260,"context_line":"    # linuxefi/initrdefi for the image to boot under efi"},{"line_number":261,"context_line":"    if [[ ${DIB_BLOCK_DEVICE} \u003d\u003d \"efi\" ]]; then"},{"line_number":262,"context_line":"        sed -i \u0027s%\\(linux\\|initrd\\)16 /boot%\\1efi /boot%g\u0027 $GRUB_CFG"},{"line_number":263,"context_line":"    fi"},{"line_number":264,"context_line":"}"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"DIB_EXTLINUX\u003d${DIB_EXTLINUX:-0}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"2bacafb3_3aba60e8","line":263,"updated":"2021-04-07 21:51:14.000000000","message":"The changes #244-#263 are only made to $GRUB_CFG, but they should probably also be made to /boot/efi/$EFI_BOOT_DIR/grub.cfg.\n\nMaybe copying $GRUB_CFG to /boot/efi/$EFI_BOOT_DIR/grub.cfg here would be safer than running $GRUB_MKCONFIG twice","commit_id":"61c7c7418853943dc2b901b0c584029d9f315ac4"}]}